Menu

#521 -keepdirectories for a recursive match

v4.11
closed-fixed
None
5
2014-08-19
2014-05-05
No

Currently, to keep a directory foo/bar one must specify:

-keepdirectories foo/bar

By comparison,

-keepdirectories foo/bar/

will not work because of the trailing slash. This means that if you want to keep foo/bar and subdirectories you must specify:

-keepdirectories foo/bar
-keepdirectories foo/bar/**

Is it possible to improve this syntax such that

-keepdirectories foo/bar/

and

-keepdirectories foo/bar/**

both match foo/bar? This way users can simply specify:

-keepdirectories foo/bar/**

to indicate that foo/bar and subdirectories should be match, all in one statement.

Discussion

  • Gili Tzabari

    Gili Tzabari - 2014-05-05

    If you decide against this new syntax, please update http://proguard.sourceforge.net/manual/usage.html#filefilters to indicate that a trailing slash will prevent a directory match.

     
  • Eric Lafortune

    Eric Lafortune - 2014-05-06

    It seems preferable to leave the distinction, so the user can specify subdirectories without the directory itself. The pattern matching is strictly based on the name strings, without interpreting the semantics of directories. I've clarified the documentation with an example, for the upcoming ProGuard 5.0 beta2.

     
  • Eric Lafortune

    Eric Lafortune - 2014-05-06
    • status: open --> open-fixed
    • assigned_to: Eric Lafortune
     
  • Gili Tzabari

    Gili Tzabari - 2014-05-07

    Okay, thank you. I will review the updated documentation when the website is updated.

     
  • Eric Lafortune

    Eric Lafortune - 2014-08-19
    • Status: open-fixed --> closed-fixed
     

Log in to post a comment.

Auth0 Logo