[Proftpd-devel] src/fs.c and NFS

[Vladimir K. <vl...@op...>]

hello,


When running proftpd-1.2.0 rc3 with NFS mounted user directories, I
exeprienced some problems related to NFS. 
Proftpd 'hangs' in random intervals, eating cpu time.

the top(1) output looked like:
75485 root     105   0  2228K  1508K RUN    621:03 95.70% 95.70% proftpd


Attaching to program: /usr/home/lada/ftp-demon/proftpd-1.2/./proftpd,
process 90482
0x8061403 in fs_creat (name=0x0, mode=2055, fd=0xbfbfc2b4) at fs.c:1252
1252      ret = f->creat(f,name,mode);
(gdb) where
#0  0x8061403 in fs_creat (name=0x0, mode=2055, fd=0xbfbfc2b4) at
fs.c:1252
#1  0x0 in ?? ()
(gdb) print name
$1 = 0x0
(gdb) printf "%s\n", name
Error accessing memory address 0x0: Bad address.


I tried to put additional condition in fs.c (patch below) which seems to
be working for this case. 
This is just a workaround, since creat/open should
return EFAULT in this case, but this seems to be somehow NFS specific.

Any ideas appreciated.


V. Kotal



@@ -1247,6 +1247,9 @@
 {
   fsdir_t *f;
   int ret;
+
+  if (!name)
+    return NULL;

   f = fs_lookup_file(name,NULL,FSOP_CREAT);
   ret = f->creat(f,name,mode);