From: TJ S. <tj...@ca...> - 2016-12-03 19:38:41
|
On Fri, Dec 2, 2016, at 04:11, Matus UHLAR - fantomas wrote: > I have applied this patch to proftpd-1.3.5 (a few rejects applied > manually), > but after runnind "mlsd" multiple times (luckily tnftp supports this > command) I still have the same problem. > > after further diggging (should have done this previously, just needed to > get user's pasword), seems that this bug appears when mod_facl is loaded. > Even turning "FaclEngine off" did not help. Ah, that's very helpful. Thank you! Based on that pointer, I've dug into the mod_facl code more closely, and indeed saw the memory leaks. I've created a pull request which fixes the issue: https://github.com/proftpd/proftpd/pull/357 And I've verified the fix using Valgrind. While there, I also fixed the handling of the FACLEngine directive to do what you'd want/expect here. I'll be merging this PR shortly, and backporting it to the 1.3.5 branch. Cheers, TJ |