Re: [Proftpd-user] Default sendfile support: on or off?

[Ed W. <ew...@ew...>]

On Tue, Jun 27, 2006 at 05:04:03PM -0700, TJ Saunders wrote:
> Hello, proftpd users.  In the 1.3.0 release, proftpd shipped with sendfile
> support being enabled by default, with the ability to disable use of
> sendfile() via the UseSendfile configuration directive.
> 
> There have been a few reports trickling in about mysterious and
> inexplicable data transfer errors on some platforms when sites upgraded to
> 1.3.0; in the end, disabling sendfile support made these mysterious errors
> go away.
> 
> Would you, as the general proftpd public, prefer to return to having
> sendfile support disabled by default?  Would it be better (or worse) to
> keep sendfile support enabled in the build by default, but disabled in the
> default proftpd.conf?

My opinion is that once you've changed the default, don't change it
back or you'll confuse users.  Keep it enabled in the build by default,
keep it enabled in the default proftpd.conf, but treat it similar to the
way that openssh does - add the defaults in the conf file but commented
out.  That way it's clear that UseSendfile is on and makes it easy for a
user to turn off.  If you want to be really clear, add an additional
comment that the parameter was added in 1.3.0.

Cheers,
        .../Ed

-- 
Ed Wilts, RHCE
Mounds View, MN, USA
mailto:ew...@ew...
Member #1, Red Hat Community Ambassador Program