Re: [pptp-devel] pppd: *** buffer overflow detected ***: /usr/sbin/pppd terminated

[James C. <qu...@la...>]

On Wed, Jun 21, 2017 at 09:16:12PM +0200, Christoph Biedl wrote:
> jaseywang wrote...
> 
> > pptpd & my mac client runs well for a long time, but today pptpd crash
> > several times, here is the server overflow info and client log info:
> 
> > Jun 20 22:53:09 ali-bj pptpd[88950]: CTRL: Client 117.73.146.179 control connection started
>                                ^^^^^
> So you're using process IDs outside the 16 bit range. Nothing illegal,
> but Debian has a patch that seems to be right about that issue:
> 
> https://sources.debian.net/patches/ppp/2.4.7-1%2B4/rc_mksid-no-buffer-overflow/

Good catch, thanks!  Matches the stack trace; rc_mksid+0x43.  I'm in
agreement with Rober Lynn on #782450 that the fix, while it will work,
is unclear; both pid 65535 and 0 map to "0000".

> Did your distribution include that?

Hope jaseywang will answer, but I've just checked and Fedora isn't
carrying that patch yet.

https://src.fedoraproject.org/cgit/rpms/ppp.git/

-- 
James Cameron
http://quozl.netrek.org/