Re: [ppa-qps-devel] Marine ed theme remplates

[Denis S. O. <den...@gm...>]

On 10/24/06, Vasiliy Maximov <mc...@ge...> wrote:
> And more about templates:
>   File "FOREIGN_DROP.edit.pyem", line 20, in ?
> NameError: name 'isNew' is not defined

Fixed in both FOREIGN_DROP and FOREIGN_MULTISELECT, please test.

> Ok. In QPS 2.6 code, file qEdit.py, I've found these lines:
>         # following 3 lines are here only for compatibility reasons
>         # after all field templates will be changed they will gone
>         namespace['edPrefix'] = self.edit.prefix
>         namespace['edUser'] = self.user
>         namespace['isNew'] = self.isNew
>
> And they really has gone in 2.7, but for example keyword 'isNew' can be
> found in field templates of all themes, including default one.
> So we have templates outdated in repository? Or that piece of code had gone
> too soon?

No, the templates are updated too slowly.

> Meanwile I suggest:
> +        namespace['edPrefix'] = self.edit.prefix
>  +        namespace['edUser'] = self.user
>  +        namespace['isNew'] = self.isNew

$ grep edPrefix QPS/themes/marine/templates/*.pyem
QPS/themes/marine/templates/fields/*.pyem
-> nothing
$ grep edUser QPS/themes/marine/templates/*.pyem
QPS/themes/marine/templates/fields/*.pyem
-> nothing

Suggestion declined ;)