[ppa-qps-devel] Re: [ppa-qps-checkins] QPS/qps/qDB qSQL.py,1.6,1.7 qMySQL.py,1.2,1.3

[Denis S. O. <od...@st...>]

On Tue, 20 Dec 2005 20:58:49 +0000
Alexey Melchakov wrote:

>      def close(self):
> -        self.dbConn._current_transaction.popLevel()
> -        self.opened = 0
> +        if self.opened:
> +            self.impl.popLevel()
> +            if not self.impl:
> +                self.dbConn._current_transaction = None
> +            self.opened = 0

The last line marks transaction as not opened on first .close()
invocation.  I believe it's not correct: the next time .popLevel() won't
be called, so transaction won't be committed if there are more than 1
level.

-- 
Denis S. Otkidach
http://www.python.ru/      [ru]