postgres-xc-developers

[Postgres-xc-developers] Minor Fixes

[Matt W. <MW...@XI...>]

Just a quick question about contributing fixes. I've had to make some minor changes to get XC compiled on Solaris x64.
What format would you like to see for the changes? Most are very minor, such as removing return statements inside void functions (which the Solaris compiler flags as incorrect since you can't return from a void function).
Matt

Re: [Postgres-xc-developers] Minor Fixes

[Michael P. <mic...@gm...>]

On Fri, Jun 21, 2013 at 5:45 AM, Matt Warner <MW...@xi...> wrote:
> Just a quick question about contributing fixes. I’ve had to make some minor
> changes to get XC compiled on Solaris x64.
>
> What format would you like to see for the changes? Most are very minor, such
> as removing return statements inside void functions (which the Solaris
> compiler flags as incorrect since you can’t return from a void function).
Please send patches generated by git that are based on the branch you
want to have the fix applied, generally master, such as fixes can be
easily backported to other maintenance branches. For the format of the
patches, I personally don't really mind, and I am sure that the others
will agree, if such patches are generated without context diff as long
as they are understandable.

Thanks,
--
Michael

Re: [Postgres-xc-developers] Minor Fixes

[Michael P. <mic...@gm...>]

On Fri, Jun 21, 2013 at 10:24 AM, Michael Paquier
<mic...@gm...> wrote:
> On Fri, Jun 21, 2013 at 5:45 AM, Matt Warner <MW...@xi...> wrote:
>> Just a quick question about contributing fixes. I’ve had to make some minor
>> changes to get XC compiled on Solaris x64.
>>
>> What format would you like to see for the changes? Most are very minor, such
>> as removing return statements inside void functions (which the Solaris
>> compiler flags as incorrect since you can’t return from a void function).
> Please send patches generated by git that are based on the branch you
> want to have the fix applied, generally master, such as fixes can be
> easily backported to other maintenance branches. For the format of the
> patches, I personally don't really mind, and I am sure that the others
> will agree, if such patches are generated without context diff as long
> as they are understandable.
Here are some more guidelines that postgres community follows, just be
sure to send the patches to the correct ML.
http://wiki.postgresql.org/wiki/Submitting_a_Patch
--
Michael

Re: [Postgres-xc-developers] Minor Fixes

[Koichi S. <koi...@gm...>]

Thanks a lot for the patch.   As Michael mentioned, you can send a patch to
developers mailing list.

BTW, core team tested current XC on 64bit Intel CentOS and others tested it
against RedHat.    Did you test XC on Solaris?

Regards;

----------
Koichi Suzuki


2013/6/21 Matt Warner <MW...@xi...>

> Just a quick question about contributing fixes. I’ve had to make some
> minor changes to get XC compiled on Solaris x64.****
>
> What format would you like to see for the changes? Most are very minor,
> such as removing return statements inside void functions (which the Solaris
> compiler flags as incorrect since you can’t return from a void function).*
> ***
>
> Matt****
>
> ** **
>
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Windows:
>
> Build for Windows Store.
>
> http://p.sf.net/sfu/windows-dev2dev
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
>

Re: [Postgres-xc-developers] Minor Fixes

[Matt W. <MW...@XI...>]

Yes, I’m running XC on Solaris x64.

From: Koichi Suzuki [mailto:koi...@gm...]
Sent: Thursday, June 20, 2013 6:34 PM
To: Matt Warner
Cc: pos...@li...
Subject: Re: [Postgres-xc-developers] Minor Fixes

Thanks a lot for the patch.   As Michael mentioned, you can send a patch to developers mailing list.

BTW, core team tested current XC on 64bit Intel CentOS and others tested it against RedHat.    Did you test XC on Solaris?

Regards;

----------
Koichi Suzuki

2013/6/21 Matt Warner <MW...@xi...<mailto:MW...@xi...>>
Just a quick question about contributing fixes. I’ve had to make some minor changes to get XC compiled on Solaris x64.
What format would you like to see for the changes? Most are very minor, such as removing return statements inside void functions (which the Solaris compiler flags as incorrect since you can’t return from a void function).
Matt


------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Postgres-xc-developers mailing list
Pos...@li...<mailto:Pos...@li...>
https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers

Re: [Postgres-xc-developers] Minor Fixes

[Matt W. <MW...@XI...>]

Regarding the other changes, they are specific to Solaris. For example, in src/backend/pgxc/pool/pgxcnode.c, Solaris requires we include sys/filio.h. I’ll be searching to see if I can find a macro already defined for Solaris that I can leverage to #ifdef those Solaris-specific items.

Matt

From: Matt Warner
Sent: Friday, June 21, 2013 9:21 AM
To: 'Koichi Suzuki'
Cc: 'pos...@li...'
Subject: RE: [Postgres-xc-developers] Minor Fixes

First patch.

From: Matt Warner
Sent: Friday, June 21, 2013 8:50 AM
To: 'Koichi Suzuki'
Cc: pos...@li...<mailto:pos...@li...>
Subject: RE: [Postgres-xc-developers] Minor Fixes

Yes, I’m running XC on Solaris x64.

From: Koichi Suzuki [mailto:koi...@gm...]
Sent: Thursday, June 20, 2013 6:34 PM
To: Matt Warner
Cc: pos...@li...<mailto:pos...@li...>
Subject: Re: [Postgres-xc-developers] Minor Fixes

Thanks a lot for the patch.   As Michael mentioned, you can send a patch to developers mailing list.

BTW, core team tested current XC on 64bit Intel CentOS and others tested it against RedHat.    Did you test XC on Solaris?

Regards;

----------
Koichi Suzuki

2013/6/21 Matt Warner <MW...@xi...<mailto:MW...@xi...>>
Just a quick question about contributing fixes. I’ve had to make some minor changes to get XC compiled on Solaris x64.
What format would you like to see for the changes? Most are very minor, such as removing return statements inside void functions (which the Solaris compiler flags as incorrect since you can’t return from a void function).
Matt


------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Postgres-xc-developers mailing list
Pos...@li...<mailto:Pos...@li...>
https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers

Re: [Postgres-xc-developers] Minor Fixes

[鈴木 幸市 <ko...@in...>]

The patch looks reasonable.   One comment: removing "return" for non-void function will cause Linux gcc warning.  For this case, we need #ifdef SOLARIS directive.

You sent two similar patch for proxy_main.c in separate e-mails.   The later one seems to resolve my comment above.   Although the core team cannot declare that XC runs on Solaris so far, I think the patch is reasonable to be included.

Any other comments?
---
Koichi Suzuki



On 2013/06/22, at 1:26, Matt Warner <MW...@XI...> wrote:

> Regarding the other changes, they are specific to Solaris. For example, in src/backend/pgxc/pool/pgxcnode.c, Solaris requires we include sys/filio.h. I’ll be searching to see if I can find a macro already defined for Solaris that I can leverage to #ifdef those Solaris-specific items.
>  
> Matt
>  
> From: Matt Warner 
> Sent: Friday, June 21, 2013 9:21 AM
> To: 'Koichi Suzuki'
> Cc: 'pos...@li...'
> Subject: RE: [Postgres-xc-developers] Minor Fixes
>  
> First patch.
>  
> From: Matt Warner 
> Sent: Friday, June 21, 2013 8:50 AM
> To: 'Koichi Suzuki'
> Cc: pos...@li...
> Subject: RE: [Postgres-xc-developers] Minor Fixes
>  
> Yes, I’m running XC on Solaris x64.
>  
> From: Koichi Suzuki [mailto:koi...@gm...] 
> Sent: Thursday, June 20, 2013 6:34 PM
> To: Matt Warner
> Cc: pos...@li...
> Subject: Re: [Postgres-xc-developers] Minor Fixes
>  
> Thanks a lot for the patch.   As Michael mentioned, you can send a patch to developers mailing list.
>  
> BTW, core team tested current XC on 64bit Intel CentOS and others tested it against RedHat.    Did you test XC on Solaris?
>  
> Regards;
> 
> ----------
> Koichi Suzuki
>  
> 
> 2013/6/21 Matt Warner <MW...@xi...>
> Just a quick question about contributing fixes. I’ve had to make some minor changes to get XC compiled on Solaris x64.
> What format would you like to see for the changes? Most are very minor, such as removing return statements inside void functions (which the Solaris compiler flags as incorrect since you can’t return from a void function).
> Matt
>  
> 
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Windows:
> 
> Build for Windows Store.
> 
> http://p.sf.net/sfu/windows-dev2dev
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
> 
>  
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Windows:
> 
> Build for Windows Store.
> 
> http://p.sf.net/sfu/windows-dev2dev_______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers

Re: [Postgres-xc-developers] Minor Fixes

[Ashutosh B. <ash...@en...>]

While we are in last run of beta and GA, I don't think, we should include
any patches which are not blocking bug-fixes or regression fixes. This is
esp applicable, if we are not declaring XC to be available on Solaris. Any
kind of porting needs to be a separate project, done before beta
test-cycles. I think it's a candidate for 1.2, for which development will
start by July mid or end.


On Mon, Jun 24, 2013 at 6:52 AM, 鈴木 幸市 <ko...@in...> wrote:

> The patch looks reasonable.   One comment: removing "return" for non-void
> function will cause Linux gcc warning.  For this case, we need #ifdef
> SOLARIS directive.
>
> You sent two similar patch for proxy_main.c in separate e-mails.   The
> later one seems to resolve my comment above.   Although the core team
> cannot declare that XC runs on Solaris so far, I think the patch is
> reasonable to be included.
>
> Any other comments?
> ---
> Koichi Suzuki
>
>
>
> On 2013/06/22, at 1:26, Matt Warner <MW...@XI...> wrote:
>
> Regarding the other changes, they are specific to Solaris. For example, in
> src/backend/pgxc/pool/pgxcnode.c, Solaris requires we include sys/filio.h.
> I’ll be searching to see if I can find a macro already defined for Solaris
> that I can leverage to #ifdef those Solaris-specific items.****
>
> Matt****
>
> *From:* Matt Warner
> *Sent:* Friday, June 21, 2013 9:21 AM
> *To:* 'Koichi Suzuki'
> *Cc:* 'pos...@li...'
> *Subject:* RE: [Postgres-xc-developers] Minor Fixes****
> ** **
> First patch.****
>
> *From:* Matt Warner
> *Sent:* Friday, June 21, 2013 8:50 AM
> *To:* 'Koichi Suzuki'
> *Cc:* pos...@li...
> *Subject:* RE: [Postgres-xc-developers] Minor Fixes****
> ** **
> Yes, I’m running XC on Solaris x64.****
>
> *From:* Koichi Suzuki [mailto:koi...@gm...<koi...@gm...>
> ]
> *Sent:* Thursday, June 20, 2013 6:34 PM
> *To:* Matt Warner
> *Cc:* pos...@li...
> *Subject:* Re: [Postgres-xc-developers] Minor Fixes****
> ** **
> Thanks a lot for the patch.   As Michael mentioned, you can send a patch
> to developers mailing list.****
> ** **
> BTW, core team tested current XC on 64bit Intel CentOS and others tested
> it against RedHat.    Did you test XC on Solaris?****
> ** **
> Regards;****
>
> ****
> ----------
> Koichi Suzuki****
>
> ** **
> 2013/6/21 Matt Warner <MW...@xi...>****
> Just a quick question about contributing fixes. I’ve had to make some
> minor changes to get XC compiled on Solaris x64.****
> What format would you like to see for the changes? Most are very minor,
> such as removing return statements inside void functions (which the Solaris
> compiler flags as incorrect since you can’t return from a void function).*
> ***
> Matt****
>  ****
>
>
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Windows:
>
> Build for Windows Store.
>
> http://p.sf.net/sfu/windows-dev2dev
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers****
> ** **
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Windows:
>
> Build for Windows Store.
>
>
> http://p.sf.net/sfu/windows-dev2dev_______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
>
>
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Windows:
>
> Build for Windows Store.
>
> http://p.sf.net/sfu/windows-dev2dev
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
>


-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Postgres Database Company

Re: [Postgres-xc-developers] Minor Fixes

[Matt W. <MW...@XI...>]

I'll double check but I thought I'd only removed return from functions declaring void as their return type.

?

Matt

On Jun 23, 2013, at 6:22 PM, "鈴木 幸市" <ko...@in...<mailto:ko...@in...>> wrote:

The patch looks reasonable.   One comment: removing "return" for non-void function will cause Linux gcc warning.  For this case, we need #ifdef SOLARIS directive.

You sent two similar patch for proxy_main.c in separate e-mails.   The later one seems to resolve my comment above.   Although the core team cannot declare that XC runs on Solaris so far, I think the patch is reasonable to be included.

Any other comments?
---
Koichi Suzuki



On 2013/06/22, at 1:26, Matt Warner <MW...@XI...<mailto:MW...@XI...>> wrote:

Regarding the other changes, they are specific to Solaris. For example, in src/backend/pgxc/pool/pgxcnode.c, Solaris requires we include sys/filio.h. I’ll be searching to see if I can find a macro already defined for Solaris that I can leverage to #ifdef those Solaris-specific items.

Matt

From: Matt Warner
Sent: Friday, June 21, 2013 9:21 AM
To: 'Koichi Suzuki'
Cc: 'pos...@li...<mailto:pos...@li...>'
Subject: RE: [Postgres-xc-developers] Minor Fixes

First patch.

From: Matt Warner
Sent: Friday, June 21, 2013 8:50 AM
To: 'Koichi Suzuki'
Cc: pos...@li...<mailto:pos...@li...>
Subject: RE: [Postgres-xc-developers] Minor Fixes

Yes, I’m running XC on Solaris x64.

From: Koichi Suzuki [mailto:koi...@gm...]
Sent: Thursday, June 20, 2013 6:34 PM
To: Matt Warner
Cc: pos...@li...<mailto:pos...@li...>
Subject: Re: [Postgres-xc-developers] Minor Fixes

Thanks a lot for the patch.   As Michael mentioned, you can send a patch to developers mailing list.

BTW, core team tested current XC on 64bit Intel CentOS and others tested it against RedHat.    Did you test XC on Solaris?

Regards;

----------
Koichi Suzuki

2013/6/21 Matt Warner <MW...@xi...<mailto:MW...@xi...>>
Just a quick question about contributing fixes. I’ve had to make some minor changes to get XC compiled on Solaris x64.
What format would you like to see for the changes? Most are very minor, such as removing return statements inside void functions (which the Solaris compiler flags as incorrect since you can’t return from a void function).
Matt


------------------------------------------------------------------------------
This SF.net<http://SF.net> email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Postgres-xc-developers mailing list
Pos...@li...<mailto:Pos...@li...>
https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers

------------------------------------------------------------------------------
This SF.net<http://SF.net> email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev_______________________________________________
Postgres-xc-developers mailing list
Pos...@li...<mailto:Pos...@li...>
https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers

[Postgres-xc-developers] Fwd: Minor Fixes

[Koichi S. <koi...@gm...>]

Year.   The code is not harmfull at all.    Removing "return" from void
functions could be a good refactoring.   Although Solaris is not supported
officieally yet, I think it's a good idea to have it in master.   I do hope
Matt continues to test XC so that we can tell XC runs on Solaris.

Any more inputs?

Regardsds;

----------
Koichi Suzuki


2013/6/25 Matt Warner <MW...@xi...>

> I'll double check but I thought I'd only removed return from functions
> declaring void as their return type.
>
> ?
>
> Matt
>
> On Jun 23, 2013, at 6:22 PM, "鈴木 幸市" <ko...@in...> wrote:
>
> The patch looks reasonable.   One comment: removing "return" for non-void
> function will cause Linux gcc warning.  For this case, we need #ifdef
> SOLARIS directive.
>
> You sent two similar patch for proxy_main.c in separate e-mails.   The
> later one seems to resolve my comment above.   Although the core team
> cannot declare that XC runs on Solaris so far, I think the patch is
> reasonable to be included.
>
> Any other comments?
> ---
> Koichi Suzuki
>
>
>
> On 2013/06/22, at 1:26, Matt Warner <MW...@XI...> wrote:
>
> Regarding the other changes, they are specific to Solaris. For example, in
> src/backend/pgxc/pool/pgxcnode.c, Solaris requires we include sys/filio.h.
> I’ll be searching to see if I can find a macro already defined for Solaris
> that I can leverage to #ifdef those Solaris-specific items.****
>
> Matt****
>
> *From:* Matt Warner
> *Sent:* Friday, June 21, 2013 9:21 AM
> *To:* 'Koichi Suzuki'
> *Cc:* 'pos...@li...'
> *Subject:* RE: [Postgres-xc-developers] Minor Fixes****
> ** **
> First patch.****
>
> *From:* Matt Warner
> *Sent:* Friday, June 21, 2013 8:50 AM
> *To:* 'Koichi Suzuki'
> *Cc:* pos...@li...
> *Subject:* RE: [Postgres-xc-developers] Minor Fixes****
> ** **
> Yes, I’m running XC on Solaris x64.****
>
> *From:* Koichi Suzuki [mailto:koi...@gm...<koi...@gm...>
> ]
> *Sent:* Thursday, June 20, 2013 6:34 PM
> *To:* Matt Warner
> *Cc:* pos...@li...
> *Subject:* Re: [Postgres-xc-developers] Minor Fixes****
> ** **
> Thanks a lot for the patch.   As Michael mentioned, you can send a patch
> to developers mailing list.****
> ** **
> BTW, core team tested current XC on 64bit Intel CentOS and others tested
> it against RedHat.    Did you test XC on Solaris?****
> ** **
> Regards;****
>
> ****
> ----------
> Koichi Suzuki****
>
> ** **
> 2013/6/21 Matt Warner <MW...@xi...>****
> Just a quick question about contributing fixes. I’ve had to make some
> minor changes to get XC compiled on Solaris x64.****
> What format would you like to see for the changes? Most are very minor,
> such as removing return statements inside void functions (which the Solaris
> compiler flags as incorrect since you can’t return from a void function).*
> ***
> Matt****
>  ****
>
>
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Windows:
>
> Build for Windows Store.
>
> http://p.sf.net/sfu/windows-dev2dev
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers****
> ** **
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Windows:
>
> Build for Windows Store.
>
>
> http://p.sf.net/sfu/windows-dev2dev_______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
>
>

Re: [Postgres-xc-developers] Minor Fixes

[Koichi S. <koi...@gm...>]

I meant that removing "return" statement which returns another function
return value will be a good refactoring.   Of course, simple return may not
be removed.


----------
Koichi Suzuki


2013/6/25 Koichi Suzuki <koi...@gm...>

> Year.   The code is not harmfull at all.    Removing "return" from void
> functions could be a good refactoring.   Although Solaris is not supported
> officieally yet, I think it's a good idea to have it in master.   I do hope
> Matt continues to test XC so that we can tell XC runs on Solaris.
>
> Any more inputs?
>
> Regardsds;
>
> ----------
> Koichi Suzuki
>
>
> 2013/6/25 Matt Warner <MW...@xi...>
>
>> I'll double check but I thought I'd only removed return from functions
>> declaring void as their return type.
>>
>> ?
>>
>> Matt
>>
>> On Jun 23, 2013, at 6:22 PM, "鈴木 幸市" <ko...@in...> wrote:
>>
>> The patch looks reasonable.   One comment: removing "return" for non-void
>> function will cause Linux gcc warning.  For this case, we need #ifdef
>> SOLARIS directive.
>>
>> You sent two similar patch for proxy_main.c in separate e-mails.   The
>> later one seems to resolve my comment above.   Although the core team
>> cannot declare that XC runs on Solaris so far, I think the patch is
>> reasonable to be included.
>>
>> Any other comments?
>>  ---
>> Koichi Suzuki
>>
>>
>>
>> On 2013/06/22, at 1:26, Matt Warner <MW...@XI...> wrote:
>>
>> Regarding the other changes, they are specific to Solaris. For example,
>> in src/backend/pgxc/pool/pgxcnode.c, Solaris requires we include
>> sys/filio.h. I’ll be searching to see if I can find a macro already defined
>> for Solaris that I can leverage to #ifdef those Solaris-specific items.**
>> **
>>
>> Matt****
>>
>> *From:* Matt Warner
>> *Sent:* Friday, June 21, 2013 9:21 AM
>> *To:* 'Koichi Suzuki'
>> *Cc:* 'pos...@li...'
>> *Subject:* RE: [Postgres-xc-developers] Minor Fixes****
>> ** **
>> First patch.****
>>
>> *From:* Matt Warner
>> *Sent:* Friday, June 21, 2013 8:50 AM
>> *To:* 'Koichi Suzuki'
>> *Cc:* pos...@li...
>> *Subject:* RE: [Postgres-xc-developers] Minor Fixes****
>> ** **
>> Yes, I’m running XC on Solaris x64.****
>>
>> *From:* Koichi Suzuki [mailto:koi...@gm...<koi...@gm...>
>> ]
>> *Sent:* Thursday, June 20, 2013 6:34 PM
>> *To:* Matt Warner
>> *Cc:* pos...@li...
>> *Subject:* Re: [Postgres-xc-developers] Minor Fixes****
>> ** **
>> Thanks a lot for the patch.   As Michael mentioned, you can send a patch
>> to developers mailing list.****
>> ** **
>> BTW, core team tested current XC on 64bit Intel CentOS and others tested
>> it against RedHat.    Did you test XC on Solaris?****
>> ** **
>> Regards;****
>>
>> ****
>> ----------
>> Koichi Suzuki****
>>
>> ** **
>> 2013/6/21 Matt Warner <MW...@xi...>****
>> Just a quick question about contributing fixes. I’ve had to make some
>> minor changes to get XC compiled on Solaris x64.****
>> What format would you like to see for the changes? Most are very minor,
>> such as removing return statements inside void functions (which the Solaris
>> compiler flags as incorrect since you can’t return from a void function).
>> ****
>> Matt****
>>  ****
>>
>>
>>
>> ------------------------------------------------------------------------------
>> This SF.net email is sponsored by Windows:
>>
>> Build for Windows Store.
>>
>> http://p.sf.net/sfu/windows-dev2dev
>> _______________________________________________
>> Postgres-xc-developers mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers****
>> ** **
>>
>> ------------------------------------------------------------------------------
>> This SF.net email is sponsored by Windows:
>>
>> Build for Windows Store.
>>
>>
>> http://p.sf.net/sfu/windows-dev2dev_______________________________________________
>> Postgres-xc-developers mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>
>>
>>
>

Re: [Postgres-xc-developers] Minor Fixes

[Koichi S. <koi...@gm...>]

Hi,

I reviewed this thread again.  It may be better to include Matt's patch to
the master after we build REL1_1_STABLE so that he can continue his
Solaris-related work on the master.   As Ashutosh suggested, it will be
less confusing not to include this in REL1_1_STABLE.

Because I'm about to build REL1_1_STABLE for beta work, please let me know
if anybody need Matt's patch in 1.1.

Matt, could you let me know your idea and if you can continue to test XC on
Solaris and declare that XC supports Solaris?

Best Regards;

----------
Koichi Suzuki


2013/6/25 Koichi Suzuki <koi...@gm...>

> I meant that removing "return" statement which returns another function
> return value will be a good refactoring.   Of course, simple return may not
> be removed.
>
>
> ----------
> Koichi Suzuki
>
>
> 2013/6/25 Koichi Suzuki <koi...@gm...>
>
>> Year.   The code is not harmfull at all.    Removing "return" from void
>> functions could be a good refactoring.   Although Solaris is not supported
>> officieally yet, I think it's a good idea to have it in master.   I do hope
>> Matt continues to test XC so that we can tell XC runs on Solaris.
>>
>> Any more inputs?
>>
>> Regardsds;
>>
>> ----------
>> Koichi Suzuki
>>
>>
>> 2013/6/25 Matt Warner <MW...@xi...>
>>
>>> I'll double check but I thought I'd only removed return from functions
>>> declaring void as their return type.
>>>
>>> ?
>>>
>>> Matt
>>>
>>> On Jun 23, 2013, at 6:22 PM, "鈴木 幸市" <ko...@in...> wrote:
>>>
>>> The patch looks reasonable.   One comment: removing "return" for
>>> non-void function will cause Linux gcc warning.  For this case, we need
>>> #ifdef SOLARIS directive.
>>>
>>> You sent two similar patch for proxy_main.c in separate e-mails.   The
>>> later one seems to resolve my comment above.   Although the core team
>>> cannot declare that XC runs on Solaris so far, I think the patch is
>>> reasonable to be included.
>>>
>>> Any other comments?
>>>  ---
>>> Koichi Suzuki
>>>
>>>
>>>
>>> On 2013/06/22, at 1:26, Matt Warner <MW...@XI...> wrote:
>>>
>>> Regarding the other changes, they are specific to Solaris. For example,
>>> in src/backend/pgxc/pool/pgxcnode.c, Solaris requires we include
>>> sys/filio.h. I’ll be searching to see if I can find a macro already defined
>>> for Solaris that I can leverage to #ifdef those Solaris-specific items.*
>>> ***
>>>
>>> Matt****
>>>
>>> *From:* Matt Warner
>>> *Sent:* Friday, June 21, 2013 9:21 AM
>>> *To:* 'Koichi Suzuki'
>>> *Cc:* 'pos...@li...'
>>> *Subject:* RE: [Postgres-xc-developers] Minor Fixes****
>>> ** **
>>> First patch.****
>>>
>>> *From:* Matt Warner
>>> *Sent:* Friday, June 21, 2013 8:50 AM
>>> *To:* 'Koichi Suzuki'
>>> *Cc:* pos...@li...
>>> *Subject:* RE: [Postgres-xc-developers] Minor Fixes****
>>> ** **
>>> Yes, I’m running XC on Solaris x64.****
>>>
>>> *From:* Koichi Suzuki [mailto:koi...@gm...<koi...@gm...>
>>> ]
>>> *Sent:* Thursday, June 20, 2013 6:34 PM
>>> *To:* Matt Warner
>>> *Cc:* pos...@li...
>>> *Subject:* Re: [Postgres-xc-developers] Minor Fixes****
>>> ** **
>>> Thanks a lot for the patch.   As Michael mentioned, you can send a patch
>>> to developers mailing list.****
>>> ** **
>>> BTW, core team tested current XC on 64bit Intel CentOS and others tested
>>> it against RedHat.    Did you test XC on Solaris?****
>>> ** **
>>> Regards;****
>>>
>>> ****
>>> ----------
>>> Koichi Suzuki****
>>>
>>> ** **
>>> 2013/6/21 Matt Warner <MW...@xi...>****
>>> Just a quick question about contributing fixes. I’ve had to make some
>>> minor changes to get XC compiled on Solaris x64.****
>>> What format would you like to see for the changes? Most are very minor,
>>> such as removing return statements inside void functions (which the Solaris
>>> compiler flags as incorrect since you can’t return from a void function).
>>> ****
>>> Matt****
>>>  ****
>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> This SF.net email is sponsored by Windows:
>>>
>>> Build for Windows Store.
>>>
>>> http://p.sf.net/sfu/windows-dev2dev
>>> _______________________________________________
>>> Postgres-xc-developers mailing list
>>> Pos...@li...
>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers****
>>> ** **
>>>
>>> ------------------------------------------------------------------------------
>>> This SF.net email is sponsored by Windows:
>>>
>>> Build for Windows Store.
>>>
>>>
>>> http://p.sf.net/sfu/windows-dev2dev_______________________________________________
>>> Postgres-xc-developers mailing list
>>> Pos...@li...
>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>
>>>
>>>
>>
>

Re: [Postgres-xc-developers] Minor Fixes

[Matt W. <MW...@XI...>]

I’d be happy to continue testing on Solaris.

From: Koichi Suzuki [mailto:koi...@gm...]
Sent: Wednesday, June 26, 2013 11:19 PM
To: Matt Warner; Postgres-XC Developers
Subject: Re: [Postgres-xc-developers] Minor Fixes

Hi,
I reviewed this thread again.  It may be better to include Matt's patch to the master after we build REL1_1_STABLE so that he can continue his Solaris-related work on the master.   As Ashutosh suggested, it will be less confusing not to include this in REL1_1_STABLE.
Because I'm about to build REL1_1_STABLE for beta work, please let me know if anybody need Matt's patch in 1.1.
Matt, could you let me know your idea and if you can continue to test XC on Solaris and declare that XC supports Solaris?
Best Regards;

----------
Koichi Suzuki

2013/6/25 Koichi Suzuki <koi...@gm...<mailto:koi...@gm...>>
I meant that removing "return" statement which returns another function return value will be a good refactoring.   Of course, simple return may not be removed.


----------
Koichi Suzuki

2013/6/25 Koichi Suzuki <koi...@gm...<mailto:koi...@gm...>>
Year.   The code is not harmfull at all.    Removing "return" from void functions could be a good refactoring.   Although Solaris is not supported officieally yet, I think it's a good idea to have it in master.   I do hope Matt continues to test XC so that we can tell XC runs on Solaris.
Any more inputs?
Regardsds;

----------
Koichi Suzuki

2013/6/25 Matt Warner <MW...@xi...<mailto:MW...@xi...>>
I'll double check but I thought I'd only removed return from functions declaring void as their return type.

?

Matt

On Jun 23, 2013, at 6:22 PM, "鈴木 幸市" <ko...@in...<mailto:ko...@in...>> wrote:
The patch looks reasonable.   One comment: removing "return" for non-void function will cause Linux gcc warning.  For this case, we need #ifdef SOLARIS directive.

You sent two similar patch for proxy_main.c in separate e-mails.   The later one seems to resolve my comment above.   Although the core team cannot declare that XC runs on Solaris so far, I think the patch is reasonable to be included.

Any other comments?
---
Koichi Suzuki



On 2013/06/22, at 1:26, Matt Warner <MW...@XI...<mailto:MW...@XI...>> wrote:


Regarding the other changes, they are specific to Solaris. For example, in src/backend/pgxc/pool/pgxcnode.c, Solaris requires we include sys/filio.h. I’ll be searching to see if I can find a macro already defined for Solaris that I can leverage to #ifdef those Solaris-specific items.

Matt

From: Matt Warner
Sent: Friday, June 21, 2013 9:21 AM
To: 'Koichi Suzuki'
Cc: 'pos...@li...<mailto:pos...@li...>'
Subject: RE: [Postgres-xc-developers] Minor Fixes

First patch.

From: Matt Warner
Sent: Friday, June 21, 2013 8:50 AM
To: 'Koichi Suzuki'
Cc: pos...@li...<mailto:pos...@li...>
Subject: RE: [Postgres-xc-developers] Minor Fixes

Yes, I’m running XC on Solaris x64.

From: Koichi Suzuki [mailto:koi...@gm...]
Sent: Thursday, June 20, 2013 6:34 PM
To: Matt Warner
Cc: pos...@li...<mailto:pos...@li...>
Subject: Re: [Postgres-xc-developers] Minor Fixes

Thanks a lot for the patch.   As Michael mentioned, you can send a patch to developers mailing list.

BTW, core team tested current XC on 64bit Intel CentOS and others tested it against RedHat.    Did you test XC on Solaris?

Regards;

----------
Koichi Suzuki

2013/6/21 Matt Warner <MW...@xi...<mailto:MW...@xi...>>
Just a quick question about contributing fixes. I’ve had to make some minor changes to get XC compiled on Solaris x64.
What format would you like to see for the changes? Most are very minor, such as removing return statements inside void functions (which the Solaris compiler flags as incorrect since you can’t return from a void function).
Matt


------------------------------------------------------------------------------
This SF.net<http://SF.net> email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Postgres-xc-developers mailing list
Pos...@li...<mailto:Pos...@li...>
https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers

------------------------------------------------------------------------------
This SF.net<http://SF.net> email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev_______________________________________________
Postgres-xc-developers mailing list
Pos...@li...<mailto:Pos...@li...>
https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers

Re: [Postgres-xc-developers] Minor Fixes

[Koichi S. <koi...@gm...>]

Thank you Matt.

Please wait a bit until branch for 1.1 is built.

Regards;

----------
Koichi Suzuki


2013/6/28 Matt Warner <MW...@xi...>

> I’d be happy to continue testing on Solaris.****
>
> ** **
>
> *From:* Koichi Suzuki [mailto:koi...@gm...]
> *Sent:* Wednesday, June 26, 2013 11:19 PM
> *To:* Matt Warner; Postgres-XC Developers
>
> *Subject:* Re: [Postgres-xc-developers] Minor Fixes****
>
> ** **
>
> Hi,****
>
> I reviewed this thread again.  It may be better to include Matt's patch to
> the master after we build REL1_1_STABLE so that he can continue his
> Solaris-related work on the master.   As Ashutosh suggested, it will be
> less confusing not to include this in REL1_1_STABLE.****
>
> Because I'm about to build REL1_1_STABLE for beta work, please let me know
> if anybody need Matt's patch in 1.1.****
>
> Matt, could you let me know your idea and if you can continue to test XC
> on Solaris and declare that XC supports Solaris?****
>
> Best Regards;****
>
>
> ****
>
> ----------
> Koichi Suzuki****
>
> ** **
>
> 2013/6/25 Koichi Suzuki <koi...@gm...>****
>
> I meant that removing "return" statement which returns another function
> return value will be a good refactoring.   Of course, simple return may not
> be removed.****
>
> ** **
>
>
> ****
>
> ----------
> Koichi Suzuki****
>
> ** **
>
> 2013/6/25 Koichi Suzuki <koi...@gm...>****
>
> Year.   The code is not harmfull at all.    Removing "return" from void
> functions could be a good refactoring.   Although Solaris is not supported
> officieally yet, I think it's a good idea to have it in master.   I do hope
> Matt continues to test XC so that we can tell XC runs on Solaris.****
>
> Any more inputs?****
>
> Regardsds;****
>
>
> ****
>
> ----------
> Koichi Suzuki****
>
> ** **
>
> 2013/6/25 Matt Warner <MW...@xi...>****
>
> I'll double check but I thought I'd only removed return from functions
> declaring void as their return type. ****
>
> ** **
>
> ?****
>
> ** **
>
> Matt****
>
>
> On Jun 23, 2013, at 6:22 PM, "鈴木 幸市" <ko...@in...> wrote:****
>
> The patch looks reasonable.   One comment: removing "return" for non-void
> function will cause Linux gcc warning.  For this case, we need #ifdef
> SOLARIS directive.****
>
> ** **
>
> You sent two similar patch for proxy_main.c in separate e-mails.   The
> later one seems to resolve my comment above.   Although the core team
> cannot declare that XC runs on Solaris so far, I think the patch is
> reasonable to be included.****
>
> ** **
>
> Any other comments?****
>
> ---****
>
> Koichi Suzuki****
>
> ** **
>
> ** **
>
> ** **
>
> On 2013/06/22, at 1:26, Matt Warner <MW...@XI...> wrote:****
>
>
>
> ****
>
> Regarding the other changes, they are specific to Solaris. For example, in
> src/backend/pgxc/pool/pgxcnode.c, Solaris requires we include sys/filio.h.
> I’ll be searching to see if I can find a macro already defined for Solaris
> that I can leverage to #ifdef those Solaris-specific items.****
>
>  ****
>
> Matt****
>
>  ****
>
> *From:* Matt Warner
> *Sent:* Friday, June 21, 2013 9:21 AM
> *To:* 'Koichi Suzuki'
> *Cc:* 'pos...@li...'
> *Subject:* RE: [Postgres-xc-developers] Minor Fixes****
>
>  ****
>
> First patch.****
>
>  ****
>
> *From:* Matt Warner
> *Sent:* Friday, June 21, 2013 8:50 AM
> *To:* 'Koichi Suzuki'
> *Cc:* pos...@li...
> *Subject:* RE: [Postgres-xc-developers] Minor Fixes****
>
>  ****
>
> Yes, I’m running XC on Solaris x64.****
>
>  ****
>
> *From:* Koichi Suzuki [mailto:koi...@gm...<koi...@gm...>
> ]
> *Sent:* Thursday, June 20, 2013 6:34 PM
> *To:* Matt Warner
> *Cc:* pos...@li...
> *Subject:* Re: [Postgres-xc-developers] Minor Fixes****
>
>  ****
>
> Thanks a lot for the patch.   As Michael mentioned, you can send a patch
> to developers mailing list.****
>
>  ****
>
> BTW, core team tested current XC on 64bit Intel CentOS and others tested
> it against RedHat.    Did you test XC on Solaris?****
>
>  ****
>
> Regards;****
>
>
> ****
>
> ----------
> Koichi Suzuki****
>
>  ****
>
> 2013/6/21 Matt Warner <MW...@xi...>****
>
> Just a quick question about contributing fixes. I’ve had to make some
> minor changes to get XC compiled on Solaris x64.****
>
> What format would you like to see for the changes? Most are very minor,
> such as removing return statements inside void functions (which the Solaris
> compiler flags as incorrect since you can’t return from a void function).*
> ***
>
> Matt****
>
>  ****
>
>
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Windows:
>
> Build for Windows Store.
>
> http://p.sf.net/sfu/windows-dev2dev
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers****
>
>  ****
>
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Windows:
>
> Build for Windows Store.
>
>
> http://p.sf.net/sfu/windows-dev2dev_______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers****
>
> ** **
>
> ** **
>
> ** **
>
> ** **
>

Re: [Postgres-xc-developers] Minor Fixes

[Matt W. <MW...@XI...>]

Good morning.

I just wanted to check in and see whether there’s still an interest in the patches I submitted that allow XC to compile and run under Solaris with the Sun compiler.

Regards,

Matt

From: Koichi Suzuki [mailto:koi...@gm...]
Sent: Thursday, June 27, 2013 9:27 AM
To: Matt Warner
Cc: Postgres-XC Developers
Subject: Re: [Postgres-xc-developers] Minor Fixes

Thank you Matt.
Please wait a bit until branch for 1.1 is built.
Regards;

----------
Koichi Suzuki

2013/6/28 Matt Warner <MW...@xi...<mailto:MW...@xi...>>
I’d be happy to continue testing on Solaris.

From: Koichi Suzuki [mailto:koi...@gm...<mailto:koi...@gm...>]
Sent: Wednesday, June 26, 2013 11:19 PM
To: Matt Warner; Postgres-XC Developers

Subject: Re: [Postgres-xc-developers] Minor Fixes

Hi,
I reviewed this thread again.  It may be better to include Matt's patch to the master after we build REL1_1_STABLE so that he can continue his Solaris-related work on the master.   As Ashutosh suggested, it will be less confusing not to include this in REL1_1_STABLE.
Because I'm about to build REL1_1_STABLE for beta work, please let me know if anybody need Matt's patch in 1.1.
Matt, could you let me know your idea and if you can continue to test XC on Solaris and declare that XC supports Solaris?
Best Regards;

----------
Koichi Suzuki

2013/6/25 Koichi Suzuki <koi...@gm...<mailto:koi...@gm...>>
I meant that removing "return" statement which returns another function return value will be a good refactoring.   Of course, simple return may not be removed.


----------
Koichi Suzuki

2013/6/25 Koichi Suzuki <koi...@gm...<mailto:koi...@gm...>>
Year.   The code is not harmfull at all.    Removing "return" from void functions could be a good refactoring.   Although Solaris is not supported officieally yet, I think it's a good idea to have it in master.   I do hope Matt continues to test XC so that we can tell XC runs on Solaris.
Any more inputs?
Regardsds;

----------
Koichi Suzuki

2013/6/25 Matt Warner <MW...@xi...<mailto:MW...@xi...>>
I'll double check but I thought I'd only removed return from functions declaring void as their return type.

?

Matt

On Jun 23, 2013, at 6:22 PM, "鈴木 幸市" <ko...@in...<mailto:ko...@in...>> wrote:
The patch looks reasonable.   One comment: removing "return" for non-void function will cause Linux gcc warning.  For this case, we need #ifdef SOLARIS directive.

You sent two similar patch for proxy_main.c in separate e-mails.   The later one seems to resolve my comment above.   Although the core team cannot declare that XC runs on Solaris so far, I think the patch is reasonable to be included.

Any other comments?
---
Koichi Suzuki



On 2013/06/22, at 1:26, Matt Warner <MW...@XI...<mailto:MW...@XI...>> wrote:

Regarding the other changes, they are specific to Solaris. For example, in src/backend/pgxc/pool/pgxcnode.c, Solaris requires we include sys/filio.h. I’ll be searching to see if I can find a macro already defined for Solaris that I can leverage to #ifdef those Solaris-specific items.

Matt

From: Matt Warner
Sent: Friday, June 21, 2013 9:21 AM
To: 'Koichi Suzuki'
Cc: 'pos...@li...<mailto:pos...@li...>'
Subject: RE: [Postgres-xc-developers] Minor Fixes

First patch.

From: Matt Warner
Sent: Friday, June 21, 2013 8:50 AM
To: 'Koichi Suzuki'
Cc: pos...@li...<mailto:pos...@li...>
Subject: RE: [Postgres-xc-developers] Minor Fixes

Yes, I’m running XC on Solaris x64.

From: Koichi Suzuki [mailto:koi...@gm...]
Sent: Thursday, June 20, 2013 6:34 PM
To: Matt Warner
Cc: pos...@li...<mailto:pos...@li...>
Subject: Re: [Postgres-xc-developers] Minor Fixes

Thanks a lot for the patch.   As Michael mentioned, you can send a patch to developers mailing list.

BTW, core team tested current XC on 64bit Intel CentOS and others tested it against RedHat.    Did you test XC on Solaris?

Regards;

----------
Koichi Suzuki

2013/6/21 Matt Warner <MW...@xi...<mailto:MW...@xi...>>
Just a quick question about contributing fixes. I’ve had to make some minor changes to get XC compiled on Solaris x64.
What format would you like to see for the changes? Most are very minor, such as removing return statements inside void functions (which the Solaris compiler flags as incorrect since you can’t return from a void function).
Matt


------------------------------------------------------------------------------
This SF.net<http://SF.net> email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Postgres-xc-developers mailing list
Pos...@li...<mailto:Pos...@li...>
https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers

------------------------------------------------------------------------------
This SF.net<http://SF.net> email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev_______________________________________________
Postgres-xc-developers mailing list
Pos...@li...<mailto:Pos...@li...>
https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers

Re: [Postgres-xc-developers] Minor Fixes

[鈴木 幸市 <ko...@in...>]

This depends on how serious the demand/usecase is and how works on it.  Yes, you can work on it and you must have demanding usecase.

I mean when 1.1GA is out, it's safer to concentrate on the master.   This is a better place to work for Solaris.

Regards;
---
Koichi Suzuki

On 2013/08/03, at 0:43, Matt Warner <MW...@XI...> wrote:

> Good morning.
>  
> I just wanted to check in and see whether there’s still an interest in the patches I submitted that allow XC to compile and run under Solaris with the Sun compiler.
>  
> Regards,
>  
> Matt
>  
> From: Koichi Suzuki [mailto:koi...@gm...] 
> Sent: Thursday, June 27, 2013 9:27 AM
> To: Matt Warner
> Cc: Postgres-XC Developers
> Subject: Re: [Postgres-xc-developers] Minor Fixes
>  
> Thank you Matt.
> 
> Please wait a bit until branch for 1.1 is built.
> 
> Regards;
> 
> ----------
> Koichi Suzuki
>  
> 
> 2013/6/28 Matt Warner <MW...@xi...>
> I’d be happy to continue testing on Solaris.
>  
> From: Koichi Suzuki [mailto:koi...@gm...] 
> Sent: Wednesday, June 26, 2013 11:19 PM
> To: Matt Warner; Postgres-XC Developers
> 
> Subject: Re: [Postgres-xc-developers] Minor Fixes
>  
> Hi,
> 
> I reviewed this thread again.  It may be better to include Matt's patch to the master after we build REL1_1_STABLE so that he can continue his Solaris-related work on the master.   As Ashutosh suggested, it will be less confusing not to include this in REL1_1_STABLE.
> 
> Because I'm about to build REL1_1_STABLE for beta work, please let me know if anybody need Matt's patch in 1.1.
> 
> Matt, could you let me know your idea and if you can continue to test XC on Solaris and declare that XC supports Solaris?
> 
> Best Regards;
> 
> ----------
> Koichi Suzuki
>  
> 
> 2013/6/25 Koichi Suzuki <koi...@gm...>
> I meant that removing "return" statement which returns another function return value will be a good refactoring.   Of course, simple return may not be removed.
>  
> 
> ----------
> Koichi Suzuki
>  
> 
> 2013/6/25 Koichi Suzuki <koi...@gm...>
> Year.   The code is not harmfull at all.    Removing "return" from void functions could be a good refactoring.   Although Solaris is not supported officieally yet, I think it's a good idea to have it in master.   I do hope Matt continues to test XC so that we can tell XC runs on Solaris.
> 
> Any more inputs?
> 
> Regardsds;
> 
> ----------
> Koichi Suzuki
>  
> 
> 2013/6/25 Matt Warner <MW...@xi...>
> I'll double check but I thought I'd only removed return from functions declaring void as their return type. 
>  
> ?
>  
> Matt
> 
> On Jun 23, 2013, at 6:22 PM, "鈴木 幸市" <ko...@in...> wrote:
> 
> The patch looks reasonable.   One comment: removing "return" for non-void function will cause Linux gcc warning.  For this case, we need #ifdef SOLARIS directive.
>  
> You sent two similar patch for proxy_main.c in separate e-mails.   The later one seems to resolve my comment above.   Although the core team cannot declare that XC runs on Solaris so far, I think the patch is reasonable to be included.
>  
> Any other comments?
> ---
> Koichi Suzuki
>  
>  
>  
> On 2013/06/22, at 1:26, Matt Warner <MW...@XI...> wrote:
>  
> 
> Regarding the other changes, they are specific to Solaris. For example, in src/backend/pgxc/pool/pgxcnode.c, Solaris requires we include sys/filio.h. I’ll be searching to see if I can find a macro already defined for Solaris that I can leverage to #ifdef those Solaris-specific items.
>  
> Matt
>  
> From: Matt Warner 
> Sent: Friday, June 21, 2013 9:21 AM
> To: 'Koichi Suzuki'
> Cc: 'pos...@li...'
> Subject: RE: [Postgres-xc-developers] Minor Fixes
>  
> First patch.
>  
> From: Matt Warner 
> Sent: Friday, June 21, 2013 8:50 AM
> To: 'Koichi Suzuki'
> Cc: pos...@li...
> Subject: RE: [Postgres-xc-developers] Minor Fixes
>  
> Yes, I’m running XC on Solaris x64.
>  
> From: Koichi Suzuki [mailto:koi...@gm...] 
> Sent: Thursday, June 20, 2013 6:34 PM
> To: Matt Warner
> Cc: pos...@li...
> Subject: Re: [Postgres-xc-developers] Minor Fixes
>  
> Thanks a lot for the patch.   As Michael mentioned, you can send a patch to developers mailing list.
>  
> BTW, core team tested current XC on 64bit Intel CentOS and others tested it against RedHat.    Did you test XC on Solaris?
>  
> Regards;
> 
> ----------
> Koichi Suzuki
>  
> 
> 2013/6/21 Matt Warner <MW...@xi...>
> Just a quick question about contributing fixes. I’ve had to make some minor changes to get XC compiled on Solaris x64.
> What format would you like to see for the changes? Most are very minor, such as removing return statements inside void functions (which the Solaris compiler flags as incorrect since you can’t return from a void function).
> Matt
>  
> 
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Windows:
> 
> Build for Windows Store.
> 
> http://p.sf.net/sfu/windows-dev2dev
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
> 
>  
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Windows:
> 
> Build for Windows Store.
> 
> http://p.sf.net/sfu/windows-dev2dev_______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>  
>  
>  
>  
>  
> ------------------------------------------------------------------------------
> Get your SQL database under version control now!
> Version control is standard for application code, but databases havent 
> caught up. So what steps can you take to put your SQL databases under 
> version control? Why should you start doing it? Read more to find out.
> http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk_______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers

Re: [Postgres-xc-developers] Minor Fixes

[Michael P. <mic...@gm...>]

On Mon, Aug 5, 2013 at 10:09 PM, 鈴木 幸市 <ko...@in...> wrote:

> This depends on how serious the demand/usecase is and how works on it.
>  Yes, you can work on it and you must have demanding usecase.
>
> I mean when 1.1GA is out, it's safer to concentrate on the master.   This
> is a better place to work for Solaris.
>
As 1.1 stable branch and master are already separated, what is the point of
not committing what Matt has sent before it is forgotten? It is perfectly
possible to continue the development work on master while improving the 1.1
beta state. IMO, I think that we should look at what Matt could send.
-- 
Michael

Re: [Postgres-xc-developers] Minor Fixes

[Matt W. <MW...@XI...>]

I noticed that changes allowing XC to compile on Mac OS have been committed, but it doesn’t appear that the patches I supplied for Solaris have made it in.

Is there something I’ve omitted that would make those patches more appealing?

Thanks!

Matt

From: Michael Paquier [mailto:mic...@gm...]
Sent: Monday, August 05, 2013 6:25 AM
To: 鈴木 幸市
Cc: Matt Warner; Postgres-XC Developers; Koichi Suzuki
Subject: Re: [Postgres-xc-developers] Minor Fixes



On Mon, Aug 5, 2013 at 10:09 PM, 鈴木 幸市 <ko...@in...<mailto:ko...@in...>> wrote:
This depends on how serious the demand/usecase is and how works on it.  Yes, you can work on it and you must have demanding usecase.

I mean when 1.1GA is out, it's safer to concentrate on the master.   This is a better place to work for Solaris.
As 1.1 stable branch and master are already separated, what is the point of not committing what Matt has sent before it is forgotten? It is perfectly possible to continue the development work on master while improving the 1.1 beta state. IMO, I think that we should look at what Matt could send.
--
Michael

Re: [Postgres-xc-developers] Minor Fixes

[Michael P. <mic...@gm...>]

On Wed, Oct 2, 2013 at 8:06 AM, Matt Warner <MW...@xi...> wrote:
> I noticed that changes allowing XC to compile on Mac OS have been committed,
> but it doesn’t appear that the patches I supplied for Solaris have made it
> in.
>
> Is there something I’ve omitted that would make those patches more
> appealing?
Sorry I couldn't find those patches in my archives :(. My fault...
Could you send them on this thread? I promise I'll have a look at them
even if I don't have a Solaris platform at my disposition yet. This
gives a reason to have VM using it though.
-- 
Michael

Re: [Postgres-xc-developers] Minor Fixes

[鈴木 幸市 <ko...@in...>]

All the patches looks reasonable and can be applied to REL1_1_STABLE, as well as master.

Any more inputs?
---
Koichi Suzuki

On 2013/10/02, at 8:58, Matt Warner <MW...@XI...>
 wrote:

> Attached.
> 
> Thanks!
> 
> Matt
> 
> -----Original Message-----
> From: Michael Paquier [mailto:mic...@gm...] 
> Sent: Tuesday, October 01, 2013 4:57 PM
> To: Matt Warner
> Cc: 鈴木 幸市; Postgres-XC Developers; Koichi Suzuki
> Subject: Re: [Postgres-xc-developers] Minor Fixes
> 
> On Wed, Oct 2, 2013 at 8:06 AM, Matt Warner <MW...@xi...> wrote:
>> I noticed that changes allowing XC to compile on Mac OS have been committed,
>> but it doesn’t appear that the patches I supplied for Solaris have made it
>> in.
>> 
>> Is there something I’ve omitted that would make those patches more
>> appealing?
> Sorry I couldn't find those patches in my archives :(. My fault...
> Could you send them on this thread? I promise I'll have a look at them
> even if I don't have a Solaris platform at my disposition yet. This
> gives a reason to have VM using it though.
> -- 
> Michael
> <solaris_makesgml-v1.patch><solaris_proxy_main-v2.patch><solaris_pgxcnode-v1.patch><solaris_sgml_Makefile-v1.patch><solaris_configure-v1.patch>

Re: [Postgres-xc-developers] Minor Fixes

[Matt W. <MW...@XI...>]

Attached.

Thanks!

Matt

-----Original Message-----
From: Michael Paquier [mailto:mic...@gm...] 
Sent: Tuesday, October 01, 2013 4:57 PM
To: Matt Warner
Cc: 鈴木 幸市; Postgres-XC Developers; Koichi Suzuki
Subject: Re: [Postgres-xc-developers] Minor Fixes

On Wed, Oct 2, 2013 at 8:06 AM, Matt Warner <MW...@xi...> wrote:
> I noticed that changes allowing XC to compile on Mac OS have been committed,
> but it doesn’t appear that the patches I supplied for Solaris have made it
> in.
>
> Is there something I’ve omitted that would make those patches more
> appealing?
Sorry I couldn't find those patches in my archives :(. My fault...
Could you send them on this thread? I promise I'll have a look at them
even if I don't have a Solaris platform at my disposition yet. This
gives a reason to have VM using it though.
-- 
Michael

Re: [Postgres-xc-developers] Minor Fixes

[Michael P. <mic...@gm...>]

On Wed, Oct 2, 2013 at 10:33 AM, 鈴木 幸市 <ko...@in...> wrote:
> All the patches looks reasonable and can be applied to REL1_1_STABLE, as well as master.
>
> Any more inputs?
Yep, I'd like to actually test them on a Solaris VM.
-- 
Michael

Re: [Postgres-xc-developers] Minor Fixes

[Koichi S. <koi...@gm...>]

Are you testing them before committed or after then?

BTW, koi...@gm... is obsolete (still alive though) and please
use koichi.dbms instead.

Regards;

---
Koichi Suzuki


2013/10/2 Michael Paquier <mic...@gm...>

> On Wed, Oct 2, 2013 at 10:33 AM, 鈴木 幸市 <ko...@in...> wrote:
> > All the patches looks reasonable and can be applied to REL1_1_STABLE, as
> well as master.
> >
> > Any more inputs?
> Yep, I'd like to actually test them on a Solaris VM.
> --
> Michael
>
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
> from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>

Re: [Postgres-xc-developers] Minor Fixes

[Michael P. <mic...@gm...>]

On Wed, Oct 2, 2013 at 3:11 PM, Koichi Suzuki <koi...@gm...> wrote:
> Are you testing them before committed or after then?
>
> BTW, koi...@gm... is obsolete (still alive though) and please
> use koichi.dbms instead.
I have always been told to test things before committing them, not after :)
-- 
Michael

Re: [Postgres-xc-developers] Minor Fixes

[Koichi S. <koi...@gm...>]

Okay, I will wait for your test result to commit it.

---
Koichi Suzuki


2013/10/2 Michael Paquier <mic...@gm...>

> On Wed, Oct 2, 2013 at 3:11 PM, Koichi Suzuki <koi...@gm...>
> wrote:
> > Are you testing them before committed or after then?
> >
> > BTW, koi...@gm... is obsolete (still alive though) and
> please
> > use koichi.dbms instead.
> I have always been told to test things before committing them, not after :)
> --
> Michael
>