Thread: Re: [Postgres-xc-developers] Minor Fixes (Page 2)

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

On Wed, Oct 2, 2013 at 3:45 PM, Koichi Suzuki <koi...@gm...> wrote:
> Okay, I will wait for your test result to commit it.
You shouldn't worry about that too...
-- 
Michael

Hi,

I have set up a Solaris 11 instance in my lab... So here is some
feedback about those patches:
1) makesgml patch: strndup is available in Solaris 11, not in Solaris
<= 10. IMO this patch is not necessary for 2 reasons:
- makesgml should not use strndup.
- Solaris 10 was out in 2005... That's getting old.
So we should patch makesgml and remove the calls to strndup inside it
instead of creating a fake version of it as you do.
2) configure patch. Not necessary, and -1 for adding a flag like that.
Isn't it possible to use something like __sparc__ or __SOLARIS__
instead? You need also to keep in mind that configure is generated
with autoconfigure, so you would actually need to patch configure.in.
3) Makefile patch, actually this is not only a bug of Solaris, so I
went ahead and committed it. That's a good catch.
4) pgxcnode patch. This is indeed necessary for the compilation on
Solaris, FIONREAD is declared in filio.h, but I don't like the use of
a CFLAGS as you did in configure.
5) GTM proxy patch. It looks like you spotted a couple of other bugs!
There is a strange mixture of things returned from functions where
they shouldn't, and this is not only a problem with Solaris. I'll
rework it a bit and commit it later after checking that it works in my
lab.

Thanks for the report and really sorry for the delay in responding!
Regards,
-- 
Michael

On Thu, Oct 3, 2013 at 9:04 AM, Matt Warner <MW...@xi...> wrote:
> Just to follow up, the change to configure.in is trivial to include "__SOLARIS__", but it looks to me like in the master branch that someone else is already hacking the configure file and not updating configure.in.
>
> Examples:
> Someone has set CFLAGS="-DPGXC $CFLAGS" in configure but not in configure.in
> PACKAGE_XC_VERSION, PGXC_MAJORVERSION, and PACKAGE_XC_VERSION are not defined in configure.in
> PACKAGE_BUGREPORT is set to pgs...@po... in configure.in
>
> Not trying to harp, just wondering how best to get this change incorporated?
Woah, I completely forgot about that... All those changes should be
incorporated in configure.in, definitely. That's one more thing to fix
on top of makesgml.
Regards,
-- 
Michael

I can spend some time cleaning up configure.in if it's not stepping on anyone's toes. 

> On Oct 2, 2013, at 5:07 PM, "Michael Paquier" <mic...@gm...> wrote:
> 
>> On Thu, Oct 3, 2013 at 9:04 AM, Matt Warner <MW...@xi...> wrote:
>> Just to follow up, the change to configure.in is trivial to include "__SOLARIS__", but it looks to me like in the master branch that someone else is already hacking the configure file and not updating configure.in.
>> 
>> Examples:
>> Someone has set CFLAGS="-DPGXC $CFLAGS" in configure but not in configure.in
>> PACKAGE_XC_VERSION, PGXC_MAJORVERSION, and PACKAGE_XC_VERSION are not defined in configure.in
>> PACKAGE_BUGREPORT is set to pgs...@po... in configure.in
>> 
>> Not trying to harp, just wondering how best to get this change incorporated?
> Woah, I completely forgot about that... All those changes should be
> incorporated in configure.in, definitely. That's one more thing to fix
> on top of makesgml.
> Regards,
> -- 
> Michael

On Thu, Oct 3, 2013 at 9:15 AM, Matt Warner <MW...@xi...> wrote:
> I can spend some time cleaning up configure.in if it's not stepping on anyone's toes.
Feel free. I will try to work on your patch for GTM proxy first and do
smth for makesgml then.
-- 
Michael

Thanks guys for your efforts to test XC on Solaris.   This is very valuable
work.   If either of you can keep working with Solaris, we may be able to
announce that XC supports Solaris.

Michael, I believe you're testing on Intel architecture.   Is either of you
going to test XC against SPARC?

I'm not familiar with Solaris threading.   GTM and GTM_Proxy depend upon
Posix thread and I hope it has no problem with Solaris.

Regards;
---
Koichi Suzuki

2013/10/3 Michael Paquier <mic...@gm...>

> On Thu, Oct 3, 2013 at 9:15 AM, Matt Warner <MW...@xi...> wrote:
> > I can spend some time cleaning up configure.in if it's not stepping on
> anyone's toes.
> Feel free. I will try to work on your patch for GTM proxy first and do
> smth for makesgml then.
> --
> Michael
>
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
> from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>

On Thu, Oct 3, 2013 at 10:10 AM, Koichi Suzuki <koi...@gm...> wrote:
> Thanks guys for your efforts to test XC on Solaris.   This is very valuable
> work.   If either of you can keep working with Solaris, we may be able to
> announce that XC supports Solaris.
>
> Michael, I believe you're testing on Intel architecture.   Is either of you
> going to test XC against SPARC?
Nope, just got some Intel machines in my OSS lab.
-- 
Michael

Hi,

First off, thank you for taking the time to review the patches!

Responses to the items you noted:

1. Solaris 10 is still a very active OS: Oracle shows it's end of support is not until January 2021. I think that means we should not necessarily expect everyone's build environment to be S11. If we can update maksgml to avoid strndup, then problem solved either way. Solaris has excellent backward binary compatibility, meaning what we compile on S9 or S10 will run on S11, but the reverse might or might not be true.

2. I actually did look at updating configure.in at one point in the past but when I ran autoconf, it produced a configure file that looked nothing like what was supplied with the version in the repository. I don't recall at this point which version I was looking at. I see from more recent builds that everything looks OK now, so I accept the -1 as my bad for not doing this the right way. I'm more than happy to update configure.in instead of configure. I can modify it to set something like "__SOLARIS_10__", although in your note 4 you indicated you didn't like the use of the CFLAG.

3. Glad to help!

4. I used the CFLAG because I was unsuccessful in writing a macro to do this. If you'd prefer a macro to the configure and CFLAG route, please let me know and I'll pursue it further. Otherwise, I'll plan to update configure.in

5. Thanks!

Matt

-----Original Message-----
From: Michael Paquier [mailto:mic...@gm...] 
Sent: Wednesday, October 02, 2013 6:45 AM
To: Matt Warner
Cc: 鈴木 幸市; Postgres-XC Developers; Koichi Suzuki
Subject: Re: [Postgres-xc-developers] Minor Fixes

Hi,

I have set up a Solaris 11 instance in my lab... So here is some
feedback about those patches:
1) makesgml patch: strndup is available in Solaris 11, not in Solaris
<= 10. IMO this patch is not necessary for 2 reasons:
- makesgml should not use strndup.
- Solaris 10 was out in 2005... That's getting old.
So we should patch makesgml and remove the calls to strndup inside it
instead of creating a fake version of it as you do.
2) configure patch. Not necessary, and -1 for adding a flag like that.
Isn't it possible to use something like __sparc__ or __SOLARIS__
instead? You need also to keep in mind that configure is generated
with autoconfigure, so you would actually need to patch configure.in.
3) Makefile patch, actually this is not only a bug of Solaris, so I
went ahead and committed it. That's a good catch.
4) pgxcnode patch. This is indeed necessary for the compilation on
Solaris, FIONREAD is declared in filio.h, but I don't like the use of
a CFLAGS as you did in configure.
5) GTM proxy patch. It looks like you spotted a couple of other bugs!
There is a strange mixture of things returned from functions where
they shouldn't, and this is not only a problem with Solaris. I'll
rework it a bit and commit it later after checking that it works in my
lab.

Thanks for the report and really sorry for the delay in responding!
Regards,
-- 
Michael

Just to follow up, the change to configure.in is trivial to include "__SOLARIS__", but it looks to me like in the master branch that someone else is already hacking the configure file and not updating configure.in.

Examples:
Someone has set CFLAGS="-DPGXC $CFLAGS" in configure but not in configure.in
PACKAGE_XC_VERSION, PGXC_MAJORVERSION, and PACKAGE_XC_VERSION are not defined in configure.in
PACKAGE_BUGREPORT is set to pgs...@po... in configure.in

Not trying to harp, just wondering how best to get this change incorporated.

?

Matt

-----Original Message-----
From: Matt Warner 
Sent: Wednesday, October 02, 2013 4:43 PM
To: 'Michael Paquier'
Cc: 鈴木 幸市; Postgres-XC Developers; Koichi Suzuki
Subject: RE: [Postgres-xc-developers] Minor Fixes

Hi,

First off, thank you for taking the time to review the patches!

Responses to the items you noted:

1. Solaris 10 is still a very active OS: Oracle shows it's end of support is not until January 2021. I think that means we should not necessarily expect everyone's build environment to be S11. If we can update maksgml to avoid strndup, then problem solved either way. Solaris has excellent backward binary compatibility, meaning what we compile on S9 or S10 will run on S11, but the reverse might or might not be true.

2. I actually did look at updating configure.in at one point in the past but when I ran autoconf, it produced a configure file that looked nothing like what was supplied with the version in the repository. I don't recall at this point which version I was looking at. I see from more recent builds that everything looks OK now, so I accept the -1 as my bad for not doing this the right way. I'm more than happy to update configure.in instead of configure. I can modify it to set something like "__SOLARIS_10__", although in your note 4 you indicated you didn't like the use of the CFLAG.

3. Glad to help!

4. I used the CFLAG because I was unsuccessful in writing a macro to do this. If you'd prefer a macro to the configure and CFLAG route, please let me know and I'll pursue it further. Otherwise, I'll plan to update configure.in

5. Thanks!

Matt

-----Original Message-----
From: Michael Paquier [mailto:mic...@gm...] 
Sent: Wednesday, October 02, 2013 6:45 AM
To: Matt Warner
Cc: 鈴木 幸市; Postgres-XC Developers; Koichi Suzuki
Subject: Re: [Postgres-xc-developers] Minor Fixes

Hi,

I have set up a Solaris 11 instance in my lab... So here is some
feedback about those patches:
1) makesgml patch: strndup is available in Solaris 11, not in Solaris
<= 10. IMO this patch is not necessary for 2 reasons:
- makesgml should not use strndup.
- Solaris 10 was out in 2005... That's getting old.
So we should patch makesgml and remove the calls to strndup inside it
instead of creating a fake version of it as you do.
2) configure patch. Not necessary, and -1 for adding a flag like that.
Isn't it possible to use something like __sparc__ or __SOLARIS__
instead? You need also to keep in mind that configure is generated
with autoconfigure, so you would actually need to patch configure.in.
3) Makefile patch, actually this is not only a bug of Solaris, so I
went ahead and committed it. That's a good catch.
4) pgxcnode patch. This is indeed necessary for the compilation on
Solaris, FIONREAD is declared in filio.h, but I don't like the use of
a CFLAGS as you did in configure.
5) GTM proxy patch. It looks like you spotted a couple of other bugs!
There is a strange mixture of things returned from functions where
they shouldn't, and this is not only a problem with Solaris. I'll
rework it a bit and commit it later after checking that it works in my
lab.

Thanks for the report and really sorry for the delay in responding!
Regards,
-- 
Michael

I'm compiling with the Solaris Studio compiler on Solaris Intel right now. If it compiles on Intel, it will compile on SPARC, the only exceptions being assembly code or code that has hard-coded dependencies on byte ordering (big- vs little-endian systems). I don't recall seeing any code like that in XC. That said, I have access to both Intel and SPARC Solaris, so I can perform builds and do some testing.

Solaris supports standard POSIX threads. I've been testing XC on Solaris and haven't seen issues around that, though I have seen what look like optimizer bugs (queries that don't complete when the amount of data changes as opposed to simply taking longer).

Matt

From: Koichi Suzuki [mailto:koi...@gm...]
Sent: Wednesday, October 02, 2013 6:11 PM
To: Michael Paquier
Cc: Matt Warner; Postgres-XC Developers
Subject: Re: [Postgres-xc-developers] Minor Fixes

Thanks guys for your efforts to test XC on Solaris.   This is very valuable work.   If either of you can keep working with Solaris, we may be able to announce that XC supports Solaris.

Michael, I believe you're testing on Intel architecture.   Is either of you going to test XC against SPARC?

I'm not familiar with Solaris threading.   GTM and GTM_Proxy depend upon Posix thread and I hope it has no problem with Solaris.

Regards;
---
Koichi Suzuki

2013/10/3 Michael Paquier <mic...@gm...<mailto:mic...@gm...>>
On Thu, Oct 3, 2013 at 9:15 AM, Matt Warner <MW...@xi...<mailto:MW...@xi...>> wrote:
> I can spend some time cleaning up configure.in<http://configure.in> if it's not stepping on anyone's toes.
Feel free. I will try to work on your patch for GTM proxy first and do
smth for makesgml then.
--
Michael

------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
_______________________________________________
Postgres-xc-developers mailing list
Pos...@li...<mailto:Pos...@li...>
https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers

Thanks Matt and Michael.   Please keep sharing your work on Solaris and
please share optimizer bug issue.   It will be nice to share table
definition, query and the plan.

Best;
---
Koichi Suzuki

2013/10/3 Matt Warner <MW...@xi...>

> I’m compiling with the Solaris Studio compiler on Solaris Intel right now.
> If it compiles on Intel, it will compile on SPARC, the only exceptions
> being assembly code or code that has hard-coded dependencies on byte
> ordering (big- vs little-endian systems). I don’t recall seeing any code
> like that in XC. That said, I have access to both Intel and SPARC Solaris,
> so I can perform builds and do some testing.****
>
> ** **
>
> Solaris supports standard POSIX threads. I’ve been testing XC on Solaris
> and haven’t seen issues around that, though I have seen what look like
> optimizer bugs (queries that don’t complete when the amount of data changes
> as opposed to simply taking longer).****
>
> ** **
>
> Matt****
>
> ** **
>
> *From:* Koichi Suzuki [mailto:koi...@gm...]
> *Sent:* Wednesday, October 02, 2013 6:11 PM
> *To:* Michael Paquier
> *Cc:* Matt Warner; Postgres-XC Developers
>
> *Subject:* Re: [Postgres-xc-developers] Minor Fixes****
>
> ** **
>
> Thanks guys for your efforts to test XC on Solaris.   This is very
> valuable work.   If either of you can keep working with Solaris, we may be
> able to announce that XC supports Solaris.****
>
> ** **
>
> Michael, I believe you're testing on Intel architecture.   Is either of
> you going to test XC against SPARC?****
>
> ** **
>
> I'm not familiar with Solaris threading.   GTM and GTM_Proxy depend upon
> Posix thread and I hope it has no problem with Solaris.****
>
> ** **
>
> Regards;****
>
> ---****
>
> Koichi Suzuki****
>
> ** **
>
> 2013/10/3 Michael Paquier <mic...@gm...>****
>
> On Thu, Oct 3, 2013 at 9:15 AM, Matt Warner <MW...@xi...> wrote:
> > I can spend some time cleaning up configure.in if it's not stepping on
> anyone's toes.
> Feel free. I will try to work on your patch for GTM proxy first and do
> smth for makesgml then.****
>
> --
> Michael
>
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
> from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers****
>
> ** **
>

I've shared table definitions, query, plan, and even scrubbed data to Abbas and Michael.

From: Koichi Suzuki [mailto:koi...@gm...]
Sent: Wednesday, October 02, 2013 6:36 PM
To: Matt Warner
Cc: Michael Paquier; Postgres-XC Developers
Subject: Re: [Postgres-xc-developers] Minor Fixes

Thanks Matt and Michael.   Please keep sharing your work on Solaris and please share optimizer bug issue.   It will be nice to share table definition, query and the plan.

Best;
---
Koichi Suzuki

2013/10/3 Matt Warner <MW...@xi...<mailto:MW...@xi...>>
I'm compiling with the Solaris Studio compiler on Solaris Intel right now. If it compiles on Intel, it will compile on SPARC, the only exceptions being assembly code or code that has hard-coded dependencies on byte ordering (big- vs little-endian systems). I don't recall seeing any code like that in XC. That said, I have access to both Intel and SPARC Solaris, so I can perform builds and do some testing.

Solaris supports standard POSIX threads. I've been testing XC on Solaris and haven't seen issues around that, though I have seen what look like optimizer bugs (queries that don't complete when the amount of data changes as opposed to simply taking longer).

Matt

From: Koichi Suzuki [mailto:koi...@gm...<mailto:koi...@gm...>]
Sent: Wednesday, October 02, 2013 6:11 PM
To: Michael Paquier
Cc: Matt Warner; Postgres-XC Developers

Subject: Re: [Postgres-xc-developers] Minor Fixes

Thanks guys for your efforts to test XC on Solaris.   This is very valuable work.   If either of you can keep working with Solaris, we may be able to announce that XC supports Solaris.

Michael, I believe you're testing on Intel architecture.   Is either of you going to test XC against SPARC?

I'm not familiar with Solaris threading.   GTM and GTM_Proxy depend upon Posix thread and I hope it has no problem with Solaris.

Regards;
---
Koichi Suzuki

2013/10/3 Michael Paquier <mic...@gm...<mailto:mic...@gm...>>
On Thu, Oct 3, 2013 at 9:15 AM, Matt Warner <MW...@xi...<mailto:MW...@xi...>> wrote:
> I can spend some time cleaning up configure.in<http://configure.in> if it's not stepping on anyone's toes.
Feel free. I will try to work on your patch for GTM proxy first and do
smth for makesgml then.
--
Michael

------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
_______________________________________________
Postgres-xc-developers mailing list
Pos...@li...<mailto:Pos...@li...>
https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers

I just finished working on the patch for GTM-Proxy and directly pushed
it as it was trivial. I also decided to backpatch it as there were
some incorrectness in the code.

The following things are still missing:
1 - Change configure.in and regenerate configure with autoconf
(addition of a flag for Solaris, don't like much this method but I
couldn't come up with smth better)
2 - Patch for pgxcnode.c
3 - Patch for makesgml

I'll work on the patch for makesgml next and post it here for review.
Regards,
-- 
Michael

On Tue, Oct 8, 2013 at 9:03 PM, Michael Paquier
<mic...@gm...> wrote:
> 3 - Patch for makesgml
I pushed 3 as it was a trivial change as well, remains 1 and 2. Matt,
are you able to get an environment with autoconf 2.63? I cannot recall
on the top of my head an environment that has it... Ubuntu or CentOS
maintain autoconf archives, no?
-- 
Michael

Yes, I have autoconf in place and have been putting in time here and there to update the configure.in.

I've also been looking at using autoconf to check for the presence of filio.h and go that route instead of specifying "__SOLARIS__". That would seem to be more portable.

Matt

-----Original Message-----
From: Michael Paquier [mailto:mic...@gm...] 
Sent: Tuesday, October 08, 2013 5:33 AM
To: Matt Warner
Cc: 鈴木 幸市; Postgres-XC Developers; Koichi Suzuki
Subject: Re: [Postgres-xc-developers] Minor Fixes

On Tue, Oct 8, 2013 at 9:03 PM, Michael Paquier
<mic...@gm...> wrote:
> 3 - Patch for makesgml
I pushed 3 as it was a trivial change as well, remains 1 and 2. Matt,
are you able to get an environment with autoconf 2.63? I cannot recall
on the top of my head an environment that has it... Ubuntu or CentOS
maintain autoconf archives, no?
-- 
Michael

I've taken configure.in and the M4 files from Postgres 9.3.0 and added in the XC-specific pieces. I hope to have not missed anything. I am testing to ensure I can perform a complete build with no issues before I send the updated files.

With respect to how to handle the include of filio.h and defining PGXC, I added in a pgxc_config.h.in file to handle both. This seems to be in line with how Postgres is handling these types of configs and only requires a simple ifdef for including filio.h.

So I owe you a different patch for proxy_main.c as well.

FYI,

Matt

-----Original Message-----
From: Matt Warner 
Sent: Tuesday, October 08, 2013 1:45 PM
To: 'Michael Paquier'
Cc: 鈴木 幸市; Postgres-XC Developers; Koichi Suzuki
Subject: RE: [Postgres-xc-developers] Minor Fixes

Yes, I have autoconf in place and have been putting in time here and there to update the configure.in.

I've also been looking at using autoconf to check for the presence of filio.h and go that route instead of specifying "__SOLARIS__". That would seem to be more portable.

Matt

-----Original Message-----
From: Michael Paquier [mailto:mic...@gm...] 
Sent: Tuesday, October 08, 2013 5:33 AM
To: Matt Warner
Cc: 鈴木 幸市; Postgres-XC Developers; Koichi Suzuki
Subject: Re: [Postgres-xc-developers] Minor Fixes

On Tue, Oct 8, 2013 at 9:03 PM, Michael Paquier
<mic...@gm...> wrote:
> 3 - Patch for makesgml
I pushed 3 as it was a trivial change as well, remains 1 and 2. Matt,
are you able to get an environment with autoconf 2.63? I cannot recall
on the top of my head an environment that has it... Ubuntu or CentOS
maintain autoconf archives, no?
-- 
Michael

On Wed, Oct 9, 2013 at 9:13 AM, Matt Warner <MW...@xi...> wrote:
> So I owe you a different patch for proxy_main.c as well.
Btw, I can see why it is needed for pgxcnode.h as we use FIONREAD
there, but why is it necessary to have an include to filio.h in
proxy_main.c? I couldn't figure out why so I simply removed that from
the patch committed.
-- 
Michael

I've checked out latest with git and as you point out, there's no need for filio.h in proxy_main.c.

There is a need for it in backend/pgxc/pgxcnode.c, so I've put in an "#ifdef HAVE_SYS_FILIO_H" to conditionally include filio.h.

As soon as I complete a successful compilation of the latest pull from git and do some testing, I'll send the changes.

Matt

-----Original Message-----
From: Michael Paquier [mailto:mic...@gm...] 
Sent: Tuesday, October 08, 2013 5:43 PM
To: Matt Warner
Cc: 鈴木 幸市; Postgres-XC Developers; Koichi Suzuki
Subject: Re: [Postgres-xc-developers] Minor Fixes

On Wed, Oct 9, 2013 at 9:13 AM, Matt Warner <MW...@xi...> wrote:
> So I owe you a different patch for proxy_main.c as well.
Btw, I can see why it is needed for pgxcnode.h as we use FIONREAD
there, but why is it necessary to have an include to filio.h in
proxy_main.c? I couldn't figure out why so I simply removed that from
the patch committed.
-- 
Michael

Below is a summary of the changes made against git pull from this morning.

I don't claim to be the best resource for this, so please do take the time to verify what I've sent. I also welcome comments and suggestions.

Please note that the entire config directory was replaced with the one from Postgres 9.3.0.

Likewise, I used configure.in from Postgres 9.3.0 as the starting point for the updates. autoconf successfully creates the configure file, which is also attached. I've tried to capture all the XC pieces that had been added manually to the previous configure file, but the new configure file should be checked and verified.

In particular, I moved the '-DPGXC' from configure to pgxc_config.h and updated postgres.h to include this new header.

The changes all compile successfully under Solaris 10 using the Solaris Studio compiler. Being that the Solaris compiler seems to be more demanding than gcc about syntax and "correctness", I believe this is a good sign. I also ran this with test data and saw no issues.

FYI,

Matt

% git status
# On branch master
# Changes to be committed:
#   (use "git reset HEAD <file>..." to unstage)
#
#	new file:   src/include/pgxc_config.h
#	new file:   src/include/pgxc_config.h.in
#	new file:   src/include/stamp-ext-h
#
# Changes not staged for commit:
#   (use "git add <file>..." to update what will be committed)
#   (use "git checkout -- <file>..." to discard changes in working directory)
#
#	modified:   config/c-compiler.m4
#	modified:   config/config.guess
#	modified:   config/config.sub
#	modified:   config/install-sh
#	modified:   config/perl.m4
#	modified:   config/programs.m4
#	modified:   config/python.m4
#	modified:   configure
#	modified:   configure.in
#	modified:   src/backend/pgxc/pool/pgxcnode.c
#	modified:   src/include/postgres.h
#

-----Original Message-----
From: Michael Paquier [mailto:mic...@gm...] 
Sent: Tuesday, October 08, 2013 5:43 PM
To: Matt Warner
Cc: 鈴木 幸市; Postgres-XC Developers; Koichi Suzuki
Subject: Re: [Postgres-xc-developers] Minor Fixes

On Wed, Oct 9, 2013 at 9:13 AM, Matt Warner <MW...@xi...> wrote:
> So I owe you a different patch for proxy_main.c as well.
Btw, I can see why it is needed for pgxcnode.h as we use FIONREAD
there, but why is it necessary to have an include to filio.h in
proxy_main.c? I couldn't figure out why so I simply removed that from
the patch committed.
-- 
Michael

Good morning. I didn't see any responses to this.

I know everyone is busy. Were the changes acceptable?

Matt

-----Original Message-----
From: Matt Warner [mailto:MW...@XI...] 
Sent: Wednesday, October 09, 2013 4:29 PM
To: 'Michael Paquier'
Cc: Postgres-XC Developers; Suzuki; Koichi
Subject: Re: [Postgres-xc-developers] Minor Fixes

Below is a summary of the changes made against git pull from this morning.

I don't claim to be the best resource for this, so please do take the time to verify what I've sent. I also welcome comments and suggestions.

Please note that the entire config directory was replaced with the one from Postgres 9.3.0.

Likewise, I used configure.in from Postgres 9.3.0 as the starting point for the updates. autoconf successfully creates the configure file, which is also attached. I've tried to capture all the XC pieces that had been added manually to the previous configure file, but the new configure file should be checked and verified.

In particular, I moved the '-DPGXC' from configure to pgxc_config.h and updated postgres.h to include this new header.

The changes all compile successfully under Solaris 10 using the Solaris Studio compiler. Being that the Solaris compiler seems to be more demanding than gcc about syntax and "correctness", I believe this is a good sign. I also ran this with test data and saw no issues.

FYI,

Matt

% git status
# On branch master
# Changes to be committed:
#   (use "git reset HEAD <file>..." to unstage)
#
#	new file:   src/include/pgxc_config.h
#	new file:   src/include/pgxc_config.h.in
#	new file:   src/include/stamp-ext-h
#
# Changes not staged for commit:
#   (use "git add <file>..." to update what will be committed)
#   (use "git checkout -- <file>..." to discard changes in working directory)
#
#	modified:   config/c-compiler.m4
#	modified:   config/config.guess
#	modified:   config/config.sub
#	modified:   config/install-sh
#	modified:   config/perl.m4
#	modified:   config/programs.m4
#	modified:   config/python.m4
#	modified:   configure
#	modified:   configure.in
#	modified:   src/backend/pgxc/pool/pgxcnode.c
#	modified:   src/include/postgres.h
#

-----Original Message-----
From: Michael Paquier [mailto:mic...@gm...] 
Sent: Tuesday, October 08, 2013 5:43 PM
To: Matt Warner
Cc: 鈴木 幸市; Postgres-XC Developers; Koichi Suzuki
Subject: Re: [Postgres-xc-developers] Minor Fixes

On Wed, Oct 9, 2013 at 9:13 AM, Matt Warner <MW...@xi...> wrote:
> So I owe you a different patch for proxy_main.c as well.
Btw, I can see why it is needed for pgxcnode.h as we use FIONREAD
there, but why is it necessary to have an include to filio.h in
proxy_main.c? I couldn't figure out why so I simply removed that from
the patch committed.
-- 
Michael

On Fri, Oct 25, 2013 at 1:14 AM, Matt Warner <MW...@xi...> wrote:
> Good morning. I didn't see any responses to this.
>
> I know everyone is busy. Were the changes acceptable?
Sorry, I'm quite busy the last couple of weeks, so I got no time to
look at your patches.
-- 
Michael

It's been several months since I submitted the changes that bring XC into line with the 9.3 release of Postgres, including bringing configure.in up to date.

I'm interested in having this work integrated. What can I do to assist?

-----Original Message-----
From: Michael Paquier [mailto:mic...@gm...] 
Sent: Thursday, October 24, 2013 3:59 PM
To: Matt Warner
Cc: Postgres-XC Developers; Suzuki; 鈴木 幸市 (ko...@in...)
Subject: Re: [Postgres-xc-developers] Minor Fixes

On Fri, Oct 25, 2013 at 1:14 AM, Matt Warner <MW...@xi...> wrote:
> Good morning. I didn't see any responses to this.
>
> I know everyone is busy. Were the changes acceptable?
Sorry, I'm quite busy the last couple of weeks, so I got no time to
look at your patches.
-- 
Michael

Sorry for taking long.    We're now working hard to merge and port
PostgreSQL 9.3 features and fixes into XC.   It is taking longer than
I first expected.   The first effort will be available as early as
next week and then I can include your improvement to our master (I
began this effort last October).

Good things on this work is that major new PostgreSQL feature will be
available with XC as well, including event triggers, updatable views,
LATERAL and material views.   This tool longer because considerable
changes in the planner internal affected existing XC planner as well.

Your patch will be included just after these are in XC's master branch.

I appreciate for your patience.

Regards;
---
Koichi Suzuki

2014/1/24 Matt Warner <MW...@xi...>:
> It's been several months since I submitted the changes that bring XC into line with the 9.3 release of Postgres, including bringing configure.in up to date.
>
> I'm interested in having this work integrated. What can I do to assist?
>
> -----Original Message-----
> From: Michael Paquier [mailto:mic...@gm...]
> Sent: Thursday, October 24, 2013 3:59 PM
> To: Matt Warner
> Cc: Postgres-XC Developers; Suzuki; 鈴木 幸市 (ko...@in...)
> Subject: Re: [Postgres-xc-developers] Minor Fixes
>
> On Fri, Oct 25, 2013 at 1:14 AM, Matt Warner <MW...@xi...> wrote:
>> Good morning. I didn't see any responses to this.
>>
>> I know everyone is busy. Were the changes acceptable?
> Sorry, I'm quite busy the last couple of weeks, so I got no time to
> look at your patches.
> --
> Michael
>
> ------------------------------------------------------------------------------
> CenturyLink Cloud: The Leader in Enterprise Cloud Services.
> Learn Why More Businesses Are Choosing CenturyLink Cloud For
> Critical Workloads, Development Environments & Everything In Between.
> Get a Quote or Start a Free Trial Today.
> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers