postfixadmin-tracker — Postfix Admin tracker notification - READ ONLY!

[ postfixadmin-Patches-3383236 ] preliminary code to merge vacation

[SourceForge.net <no...@so...>]

Patches item #3383236, was opened at 2011-07-31 14:38
Message generated for change (Settings changed) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: SVN (please specify revision!)
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: J.Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: preliminary code to merge  vacation

Initial Comment:
this patch i use to get code in to sync  toget later one template and one code voor edit-vacation and user-vacation

regarde Jan Kruis


----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-21 23:35

Message:
> What I found strange that you had trouble with the merge, because the
"svn
> diff" have taken on him for svn svn 1167 and 1168 have uploaded.

I also found it strange, but well, sh** happens ;-)

>> the "vacation already active" message would also be useful for admins,
>> but that probably needs a small text change
>
> I had the message already included in the update but I thought later,
> because the admin of the list-virutal.php already can see that the
vacation
> message is active. "Set Vacation" and "VACATION IS ON"

basically correct, but having it on the vacation page won't hurt ;-)

>> in admin mode, $fDomain should be read from $fUsername instead of
using
>> an url parameter

> [Code] ...

Yes, something like that, but completely different ;-) See r1172 if you
are interested what I did - (I included some additional changes and
cleanup)

> > in admin mode, there should be a check if $fUsername is valid

also part of r1172, at least as a basic check 

> Check for the $fUsername do you think of a check against the database
or
> to a syntax check. I see no benefit in a check against the database. to
> perform list because vacation.php come from virtual domain and user
name
> comes from the database.

General rule of thumb: never trust your users ;-)
The username is handed over as URL parameter, and an evil user could
always modify it.

> The adjustment in the code I will have for my account, I will leave the
> language, adapting to your.

I just added the obsolete markers to the language files (r1170). 

I still have to rename the remaining/used texts to something more useful -
but that's something that should be done for all texts, not only the
vacation-related texts. 

Nevertheless I'll close this tracker item as fixed :-)

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-21 19:30

Message:
Hi Christian,

I read your commit log message and I agree with the adjustment.
With the merge of the file i had no problems. I've removed the file from
my system and enter a "svn up".


What I found strange that you had trouble with the merge, because the "svn
diff" have taken on him for svn svn 1167 and 1168 have uploaded.

I will not add more variables to variables.inc.php

Just coming back to the comment:

>
> From my POV the merge is finished. The only things I noticed while
> proofreading your changes are:
> the "vacation already active" message would also be useful for admins,
> but that probably needs a small text change
>

I had the message already included in the update but I thought later,
because the admin of the list-virutal.php already can see that the vacation
message is active. "Set Vacation" and "VACATION IS ON"

>
> in admin mode, $fDomain should be read from $fUsername instead of using
an url parameter
>

[Code]
// only allow admins to change someone else's 'stuff'
if(authentication_has_role('admin')) {
   $Admin_role = 1 ;

   if (isset($_GET['username'])) $fUsername = escape_string
($_GET['username']);
   if (isset($_GET['domain'])) $fDomain = escape_string
($_GET['domain']);
   $Return_url = "list-virtual.php?domain=$fDomain";
}
else {
   $Admin_role = 0 ;
#   $Return_url = "users/main.php";
   $Return_url = "main.php";
   authentication_require_role('user');
   $fUsername = $SESSID_USERNAME;
   $fDomain = $USERID_DOMAIN;
}
[/Code]

exchange with 

[Code]
// only allow admins to change someone else's 'stuff'
if(authentication_has_role('admin')) {
   $Admin_role = 1 ;

   if (isset($_GET['username'])) $fUsername = escape_string
($_GET['username']);
//   if (isset($_GET['domain'])) $fDomain = escape_string
($_GET['domain']);
   $tmp = preg_split ('/@/', $fUsername);
   $fDomain = $tmp[1];
   $Return_url = "list-virtual.php?domain=$fDomain";
} 
else {
   $Admin_role = 0 ;
//   $Return_url = "users/main.php";
   $Return_url = "main.php";
   authentication_require_role('user');
   $fUsername = $SESSID_USERNAME;
//   $fDomain = $USERID_DOMAIN;
   $tmp = preg_split ('/@/', $fUsername);
   $fDomain = $tmp[1];
}
[/Code] 

>
>  in admin mode, there should be a check if $fUsername is valid
>

Check for the $fUsername do you think of a check against the database or
to a syntax check. I see no benefit in a check  against the database. to
perform list because vacation.php come from virtual domain and user name
comes from the database.

> (and of course I still have to check your comments in en.lang)

> Those are mostly unrelated to your patch. I won't complain if you fix
> them, but it's not a real problem for me to fix them myself. (That's
> especially true for the text change - I can update all language files
> (well, add a comment) with one script call.)


The adjustment in the code I will have for my account, I will leave the
language, adapting to your.


----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-15 01:25

Message:
> I ask myself if i used the right way to call vacation voor the users
> because i al sop saw a reference to url_user_vacation in
configs/menu.conf
> and in templates/users_menu.tpl
> or are these obsolete ?

They are not obsolete, but they are not used everywhere :-(

Besides that, things aren't as easy as "change a link" because that makes
the other links in the users menu link to the wrong place. Instead, I
commited a dummy users/vacation.php that only does a
require('../vacation.php'). That avoids the link hell ;-)

> I pleaced some remark in the en.lang file .these are the data which we
can
> to put together and could rename. If this will not give any problems
with
> the translations.

I've postponed this part of your patch.

> I uploaded vacation-6.patch.

I integrated it in svn trunk (with some trouble - looks like you didn't
create the patch against latest svn, but it finally worked) and commited it
to SVN r1169. 

Please see the commit log message for some details about the differences
between your patch and what I commited. (I hope you don't get too many
merge conflicts on your next "svn up" run ;-)

Oh, BTW: Please do not add more variables to variables.inc.php - it's
a(nother) leftover I want to get rid of (by initializing the variables in
the/each script that requires them).

From my POV the merge is finished. The only things I noticed while
proofreading your changes are:
- the "vacation already active" message would also be useful for admins,
but that probably needs a small text change
- in admin mode, $fDomain should be read from $fUsername instead of using
an url parameter
- in admin mode, there should be a check if $fUsername is valid
- (and of course I still have to check your comments in en.lang)

Those are mostly unrelated to your patch. I won't complain if you fix
them, but it's not a real problem for me to fix them myself. (That's
especially true for the text change - I can update all language files
(well, add a comment) with one script call.)

If you provide a patch for the above things, please make sure to use the
latest svn revision before running "svn diff".

All that said: thanks for working on this patch!

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-08 01:40

Message:
Hi Christian,

I think I'm done fairly.

modules in the patch are not longer used this way can

edit-vacation.php and users/vacation.php will  be replaced by vacation.php
.

templates/edit-vacation.tpl and templates/user-vacatio.tpl wil be replaced
by templates/vacation.tpl .


I ask myself if i used the right way to call vacation voor the users
because i al sop saw a reference to url_user_vacation in configs/menu.conf 
and in templates/users_menu.tpl
or are these obsolete ?

I pleaced some remark in the en.lang file .these are the data which we can
to put together and could rename. If this will not give any problems with
the translations.

BTW
I saw in the nl.lang file a few times  the same text wand it was not
marked as ​obsulte like other text .
These are among the text of *_password_text_error.

I uploaded vacation-6.patch.

Please let me know what you think and want shoud be changed

Regrades Jan
 

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-07 01:31

Message:
Q1: Renaming $PALANG texts is not a real problem - language-update.sh can
do that (no translations lost). The more interesting question is how to
name the variables - IMHO they don't need to have "vacation" in their name.
For example, pUsersVacation_subject (text: "Subject") could just be
$PALANG[subject] and could also be used in broadcast-message.php (instead
of pBroadcast_subject).

I can do the renaming if you tell me which variables you want to rename
and which name you'd like to have.

Q2: fetchmail.php contains an example:
flash_info(sprintf($PALANG['pDelete_delete_success'],$account));

Q3
> $ return_url = 'list-virtual.php? fDomain $ domain =';

This should probably be $return_url = 'list-virtual.php?domain=' .
$fDomain; (Note: I didn't check the parameter and variable names)

> I like the following line ... insert vaction.php they do not work. I get
a blank screen.

That's means you should check your error_log ;-) - it usually contains an
error message in this case.

> header ("Location:". "return_url $ '.)

Shouldn't that be header("Location: $Return_url");  ?

> $Return_url = 'list-virtual.php?domain=$fDomain';

You should use "..." quotes instead of '...' (your version won't replace
$fDomain with the variable content).

BTW: You have probably noticed that the SF tracker is not the perfect
place for pasting code. Feel free to upload it as attachment or switch to
another communication channel, for example the postfixadmin-devel
mailinglist.

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-06 23:17

Message:
Hi Christian,

I used your vacation.tpl adjustment.


Q1
I wonder whether it is advisable to rename the languages ​​of
[pUsersVacation] change to [pVacation]
It clearness would clearly benefit, but I think it will generate lot of
translation work . I like to hear your opinion.


Q2
Flash_Message I wanted to use the email user to be added to the flash_info
/ flash_error () I try it now via% s see question below.

Another question relates to sprintf () and% s $ PALANG text?
where can I find an example of the use of it. I found something in
footer.php but did not it dn't call the function with flash or flash error
information. when i try it it dn't repleace the %s but show it.

The adjustment that I will make in the long file *. I will make in the NL
and EN version.

Q3
I run into another problem.

Depending on the role (admin or user) I set the variable

$ return_url = 'list-virtual.php? fDomain $ domain =';
or
$ return_url = 'main.php';

I like the following line ... insert vaction.php they do not work. I get a
blank screen.

header ("Location:". "return_url $ '.)

question:
How do I header () returns the location if I want to define as a variable.
This is the code I currently use.


[code]
// only allow admins to change someone else's 'stuff'
if(authentication_has_role('admin')) {
   $Admin_Role = 1 ;
   $Return_url = 'list-virtual.php?domain=$fDomain';

   if (isset($_GET['username'])) $fUsername = escape_string
($_GET['username']);
   if (isset($_GET['domain'])) $fDomain = escape_string ($_GET['domain']);
}
else {
   $Admin_Role = 0 ;
   $Return_url = 'main.php';
//   authentication_require_role('user');
   $fUsername = $SESSID_USERNAME;
   $fDomain = $USERID_DOMAIN;
}

// is vacation support enabled in $CONF ?
if($CONF['vacation'] == 'NO') {
  if ($Admin_Role == 1) {
    header ("Location: list-virtual.php?domain=$fDomain");
  }
  else {
    header ("Location: main.php");
  }
  exit(0);
}
[/code]

Regards,
Jan Kruis


----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-05 22:18

Message:
Some small notes on vacation-3.patch:

edit.vacation.php + users/vacation.php: 
- The fChange and fBack POST variables are only used with empty() - that
means escape_string() is superfluous (but doesn't hurt)
- I don't see a real need for using $Flash_Message - you can use
flash_info()/flash_error() with a $PALANG text directly

vacation.tpl: 
- displaying the mail address in users/ is superfluous IMHO - I'd propose
to wrap this table row in {if !$authentication_has_role.user} ... {/if}

I nevertheless commited your patch to SVN r1163 (without changes to avoid
merge conflicts for you).

About your TODO list:
> - remove entry in the language with are not used any more.

Just tell me which $PALANG texts are no longer needed, I will handle the
changes in *.lang

> - add useremail to flash-message sure for admin if coming back to
> list-virtual.php.

Sounds like a good idea. You can use sprintf() and '%s' in the $PALANG
text to make the text a valid sentense. Feel free to modify the existing
text in the languages you understand. For the others, we can just append
'(%s)' to the text and add a comment to the translators that they should
make the translation nicer. Again, I can help with updating *.lang if you
want - doing this with language-update.sh might be faster than manual
editing.

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-04 13:38

Message:
Translation update commited to SVN r1162.

I'll review the vacation-related parts of your patch tonight.

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 22:02

Message:
Hi Christian,

I have upload new patch.

In this one i replaced eidt-vaction.tpl and user_vacation.tpl with a new
template vacation.tpl
as a frist step to merge the two module into one.

what a like to do is put the of the email for with the vacation is change
into header somethink link

auto response for : us...@do...

as well user setting as for the admin setting.

as you can see i also make a patch voor the languages/nl.lang


If you like the patch sofar  you may commit vacatiion-3.patch

thing i have todo.

- remove entry in the language with are not used any more.
- merge edit-vacation.php and user/vaction.php into one file.
- add useremail to flash-message sure for admin if coming back to
list-virtual.php.

BTW
I had a look a the $smarty->assign remark, and  you were right. It is
change in vacation-3.patch.

if you have any comments or recommendations please let me know

Regards Jan Kruis



----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 22:02

Message:
Hi Christian,

I have upload new patch.

In this one i replaced eidt-vaction.tpl and user_vacation.tpl with a new
template vacation.tpl
as a frist step to merge the two module into one.

what a like to do is put the of the email for with the vacation is change
into header somethink link

auto response for : us...@do...

as well user setting as for the admin setting.

as you can see i also make a patch voor the languages/nl.lang


If you like the patch sofar  you may commit vacatiion-3.patch

thing i have todo.

- remove entry in the language with are not used any more.
- merge edit-vacation.php and user/vaction.php into one file.
- add useremail to flash-message sure for admin if coming back to
list-virtual.php.

BTW
I had a look a the $smarty->assign remark, and  you were right. It is
change in vacation-3.patch.

if you have any comments or recommendations please let me know

Regards Jan Kruis



----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 10:51

Message:
Christian,

In my attempt to merge edit-vacation and user-vacation vacation together
into one file
(meaning to get the preliminary code and  templates as much in sync as
possible to obtain unambiguous)
I noticed something strange.

In the template edit vacation.tpl I particularly "control" and "name"
changed from activeform to fActiveForm.

I open edit-vacation.php through the edit-list-virtual.php window;
everything works well, now I open a second window and open user-vacation
everything this still works well, until I reload window 1 (edit vacation).
Now change the window in the window of user-vacation but call the right
url in the browser, that of  edit-vacation.php (with the right name and
domain).

Could this be the result of my changes of that review, and particularly
name?


Regards, Jan Kruis

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 10:44

Message:
Hi Christian,

dont commit the patch it nown
i upload a second patch with handel the return and removed some unused
code in templates
please have a look and i see up to remarks

i have a look at the $smarty->assign remark

reards jan

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-01 02:23

Message:
I just had a quick look at your patch - looks good :-) - but as usual, I
found "a hair in the soup" (as we germans say) ;-)

In edit-vacation.php, you use (for $tSubject and $tBody)
    $smarty->assign ('tSubject', htmlentities ($tSubject, ENT_QUOTES,
'UTF-8'), false);
You can most probably use this instead:
    $smarty->assign ('tSubject', $tSubject);
(without the "false" as third parameter, $smarty->assign does the
htmlentities() call itsself - see assign() and sanitize() in
smarty.inc.php)
Or did I overlook something?

What's your preferred way to continue? Shall I commit your preliminary
patch to SVN now or should I wait until you provide a non-preliminary
patch? (I'd prefer to commit now, but it's your choice.)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

[ postfixadmin-Patches-3383236 ] preliminary code to merge vacation

[SourceForge.net <no...@so...>]

Patches item #3383236, was opened at 2011-07-31 14:38
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: SVN (please specify revision!)
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: J.Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: preliminary code to merge  vacation

Initial Comment:
this patch i use to get code in to sync  toget later one template and one code voor edit-vacation and user-vacation

regarde Jan Kruis


----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-21 23:35

Message:
> What I found strange that you had trouble with the merge, because the
"svn
> diff" have taken on him for svn svn 1167 and 1168 have uploaded.

I also found it strange, but well, sh** happens ;-)

>> the "vacation already active" message would also be useful for admins,
>> but that probably needs a small text change
>
> I had the message already included in the update but I thought later,
> because the admin of the list-virutal.php already can see that the
vacation
> message is active. "Set Vacation" and "VACATION IS ON"

basically correct, but having it on the vacation page won't hurt ;-)

>> in admin mode, $fDomain should be read from $fUsername instead of
using
>> an url parameter

> [Code] ...

Yes, something like that, but completely different ;-) See r1172 if you
are interested what I did - (I included some additional changes and
cleanup)

> > in admin mode, there should be a check if $fUsername is valid

also part of r1172, at least as a basic check 

> Check for the $fUsername do you think of a check against the database
or
> to a syntax check. I see no benefit in a check against the database. to
> perform list because vacation.php come from virtual domain and user
name
> comes from the database.

General rule of thumb: never trust your users ;-)
The username is handed over as URL parameter, and an evil user could
always modify it.

> The adjustment in the code I will have for my account, I will leave the
> language, adapting to your.

I just added the obsolete markers to the language files (r1170). 

I still have to rename the remaining/used texts to something more useful -
but that's something that should be done for all texts, not only the
vacation-related texts. 

Nevertheless I'll close this tracker item as fixed :-)

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-21 19:30

Message:
Hi Christian,

I read your commit log message and I agree with the adjustment.
With the merge of the file i had no problems. I've removed the file from
my system and enter a "svn up".


What I found strange that you had trouble with the merge, because the "svn
diff" have taken on him for svn svn 1167 and 1168 have uploaded.

I will not add more variables to variables.inc.php

Just coming back to the comment:

>
> From my POV the merge is finished. The only things I noticed while
> proofreading your changes are:
> the "vacation already active" message would also be useful for admins,
> but that probably needs a small text change
>

I had the message already included in the update but I thought later,
because the admin of the list-virutal.php already can see that the vacation
message is active. "Set Vacation" and "VACATION IS ON"

>
> in admin mode, $fDomain should be read from $fUsername instead of using
an url parameter
>

[Code]
// only allow admins to change someone else's 'stuff'
if(authentication_has_role('admin')) {
   $Admin_role = 1 ;

   if (isset($_GET['username'])) $fUsername = escape_string
($_GET['username']);
   if (isset($_GET['domain'])) $fDomain = escape_string
($_GET['domain']);
   $Return_url = "list-virtual.php?domain=$fDomain";
}
else {
   $Admin_role = 0 ;
#   $Return_url = "users/main.php";
   $Return_url = "main.php";
   authentication_require_role('user');
   $fUsername = $SESSID_USERNAME;
   $fDomain = $USERID_DOMAIN;
}
[/Code]

exchange with 

[Code]
// only allow admins to change someone else's 'stuff'
if(authentication_has_role('admin')) {
   $Admin_role = 1 ;

   if (isset($_GET['username'])) $fUsername = escape_string
($_GET['username']);
//   if (isset($_GET['domain'])) $fDomain = escape_string
($_GET['domain']);
   $tmp = preg_split ('/@/', $fUsername);
   $fDomain = $tmp[1];
   $Return_url = "list-virtual.php?domain=$fDomain";
} 
else {
   $Admin_role = 0 ;
//   $Return_url = "users/main.php";
   $Return_url = "main.php";
   authentication_require_role('user');
   $fUsername = $SESSID_USERNAME;
//   $fDomain = $USERID_DOMAIN;
   $tmp = preg_split ('/@/', $fUsername);
   $fDomain = $tmp[1];
}
[/Code] 

>
>  in admin mode, there should be a check if $fUsername is valid
>

Check for the $fUsername do you think of a check against the database or
to a syntax check. I see no benefit in a check  against the database. to
perform list because vacation.php come from virtual domain and user name
comes from the database.

> (and of course I still have to check your comments in en.lang)

> Those are mostly unrelated to your patch. I won't complain if you fix
> them, but it's not a real problem for me to fix them myself. (That's
> especially true for the text change - I can update all language files
> (well, add a comment) with one script call.)


The adjustment in the code I will have for my account, I will leave the
language, adapting to your.


----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-15 01:25

Message:
> I ask myself if i used the right way to call vacation voor the users
> because i al sop saw a reference to url_user_vacation in
configs/menu.conf
> and in templates/users_menu.tpl
> or are these obsolete ?

They are not obsolete, but they are not used everywhere :-(

Besides that, things aren't as easy as "change a link" because that makes
the other links in the users menu link to the wrong place. Instead, I
commited a dummy users/vacation.php that only does a
require('../vacation.php'). That avoids the link hell ;-)

> I pleaced some remark in the en.lang file .these are the data which we
can
> to put together and could rename. If this will not give any problems
with
> the translations.

I've postponed this part of your patch.

> I uploaded vacation-6.patch.

I integrated it in svn trunk (with some trouble - looks like you didn't
create the patch against latest svn, but it finally worked) and commited it
to SVN r1169. 

Please see the commit log message for some details about the differences
between your patch and what I commited. (I hope you don't get too many
merge conflicts on your next "svn up" run ;-)

Oh, BTW: Please do not add more variables to variables.inc.php - it's
a(nother) leftover I want to get rid of (by initializing the variables in
the/each script that requires them).

From my POV the merge is finished. The only things I noticed while
proofreading your changes are:
- the "vacation already active" message would also be useful for admins,
but that probably needs a small text change
- in admin mode, $fDomain should be read from $fUsername instead of using
an url parameter
- in admin mode, there should be a check if $fUsername is valid
- (and of course I still have to check your comments in en.lang)

Those are mostly unrelated to your patch. I won't complain if you fix
them, but it's not a real problem for me to fix them myself. (That's
especially true for the text change - I can update all language files
(well, add a comment) with one script call.)

If you provide a patch for the above things, please make sure to use the
latest svn revision before running "svn diff".

All that said: thanks for working on this patch!

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-08 01:40

Message:
Hi Christian,

I think I'm done fairly.

modules in the patch are not longer used this way can

edit-vacation.php and users/vacation.php will  be replaced by vacation.php
.

templates/edit-vacation.tpl and templates/user-vacatio.tpl wil be replaced
by templates/vacation.tpl .


I ask myself if i used the right way to call vacation voor the users
because i al sop saw a reference to url_user_vacation in configs/menu.conf 
and in templates/users_menu.tpl
or are these obsolete ?

I pleaced some remark in the en.lang file .these are the data which we can
to put together and could rename. If this will not give any problems with
the translations.

BTW
I saw in the nl.lang file a few times  the same text wand it was not
marked as ​obsulte like other text .
These are among the text of *_password_text_error.

I uploaded vacation-6.patch.

Please let me know what you think and want shoud be changed

Regrades Jan
 

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-07 01:31

Message:
Q1: Renaming $PALANG texts is not a real problem - language-update.sh can
do that (no translations lost). The more interesting question is how to
name the variables - IMHO they don't need to have "vacation" in their name.
For example, pUsersVacation_subject (text: "Subject") could just be
$PALANG[subject] and could also be used in broadcast-message.php (instead
of pBroadcast_subject).

I can do the renaming if you tell me which variables you want to rename
and which name you'd like to have.

Q2: fetchmail.php contains an example:
flash_info(sprintf($PALANG['pDelete_delete_success'],$account));

Q3
> $ return_url = 'list-virtual.php? fDomain $ domain =';

This should probably be $return_url = 'list-virtual.php?domain=' .
$fDomain; (Note: I didn't check the parameter and variable names)

> I like the following line ... insert vaction.php they do not work. I get
a blank screen.

That's means you should check your error_log ;-) - it usually contains an
error message in this case.

> header ("Location:". "return_url $ '.)

Shouldn't that be header("Location: $Return_url");  ?

> $Return_url = 'list-virtual.php?domain=$fDomain';

You should use "..." quotes instead of '...' (your version won't replace
$fDomain with the variable content).

BTW: You have probably noticed that the SF tracker is not the perfect
place for pasting code. Feel free to upload it as attachment or switch to
another communication channel, for example the postfixadmin-devel
mailinglist.

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-06 23:17

Message:
Hi Christian,

I used your vacation.tpl adjustment.


Q1
I wonder whether it is advisable to rename the languages ​​of
[pUsersVacation] change to [pVacation]
It clearness would clearly benefit, but I think it will generate lot of
translation work . I like to hear your opinion.


Q2
Flash_Message I wanted to use the email user to be added to the flash_info
/ flash_error () I try it now via% s see question below.

Another question relates to sprintf () and% s $ PALANG text?
where can I find an example of the use of it. I found something in
footer.php but did not it dn't call the function with flash or flash error
information. when i try it it dn't repleace the %s but show it.

The adjustment that I will make in the long file *. I will make in the NL
and EN version.

Q3
I run into another problem.

Depending on the role (admin or user) I set the variable

$ return_url = 'list-virtual.php? fDomain $ domain =';
or
$ return_url = 'main.php';

I like the following line ... insert vaction.php they do not work. I get a
blank screen.

header ("Location:". "return_url $ '.)

question:
How do I header () returns the location if I want to define as a variable.
This is the code I currently use.


[code]
// only allow admins to change someone else's 'stuff'
if(authentication_has_role('admin')) {
   $Admin_Role = 1 ;
   $Return_url = 'list-virtual.php?domain=$fDomain';

   if (isset($_GET['username'])) $fUsername = escape_string
($_GET['username']);
   if (isset($_GET['domain'])) $fDomain = escape_string ($_GET['domain']);
}
else {
   $Admin_Role = 0 ;
   $Return_url = 'main.php';
//   authentication_require_role('user');
   $fUsername = $SESSID_USERNAME;
   $fDomain = $USERID_DOMAIN;
}

// is vacation support enabled in $CONF ?
if($CONF['vacation'] == 'NO') {
  if ($Admin_Role == 1) {
    header ("Location: list-virtual.php?domain=$fDomain");
  }
  else {
    header ("Location: main.php");
  }
  exit(0);
}
[/code]

Regards,
Jan Kruis


----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-05 22:18

Message:
Some small notes on vacation-3.patch:

edit.vacation.php + users/vacation.php: 
- The fChange and fBack POST variables are only used with empty() - that
means escape_string() is superfluous (but doesn't hurt)
- I don't see a real need for using $Flash_Message - you can use
flash_info()/flash_error() with a $PALANG text directly

vacation.tpl: 
- displaying the mail address in users/ is superfluous IMHO - I'd propose
to wrap this table row in {if !$authentication_has_role.user} ... {/if}

I nevertheless commited your patch to SVN r1163 (without changes to avoid
merge conflicts for you).

About your TODO list:
> - remove entry in the language with are not used any more.

Just tell me which $PALANG texts are no longer needed, I will handle the
changes in *.lang

> - add useremail to flash-message sure for admin if coming back to
> list-virtual.php.

Sounds like a good idea. You can use sprintf() and '%s' in the $PALANG
text to make the text a valid sentense. Feel free to modify the existing
text in the languages you understand. For the others, we can just append
'(%s)' to the text and add a comment to the translators that they should
make the translation nicer. Again, I can help with updating *.lang if you
want - doing this with language-update.sh might be faster than manual
editing.

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-04 13:38

Message:
Translation update commited to SVN r1162.

I'll review the vacation-related parts of your patch tonight.

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 22:02

Message:
Hi Christian,

I have upload new patch.

In this one i replaced eidt-vaction.tpl and user_vacation.tpl with a new
template vacation.tpl
as a frist step to merge the two module into one.

what a like to do is put the of the email for with the vacation is change
into header somethink link

auto response for : us...@do...

as well user setting as for the admin setting.

as you can see i also make a patch voor the languages/nl.lang


If you like the patch sofar  you may commit vacatiion-3.patch

thing i have todo.

- remove entry in the language with are not used any more.
- merge edit-vacation.php and user/vaction.php into one file.
- add useremail to flash-message sure for admin if coming back to
list-virtual.php.

BTW
I had a look a the $smarty->assign remark, and  you were right. It is
change in vacation-3.patch.

if you have any comments or recommendations please let me know

Regards Jan Kruis



----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 22:02

Message:
Hi Christian,

I have upload new patch.

In this one i replaced eidt-vaction.tpl and user_vacation.tpl with a new
template vacation.tpl
as a frist step to merge the two module into one.

what a like to do is put the of the email for with the vacation is change
into header somethink link

auto response for : us...@do...

as well user setting as for the admin setting.

as you can see i also make a patch voor the languages/nl.lang


If you like the patch sofar  you may commit vacatiion-3.patch

thing i have todo.

- remove entry in the language with are not used any more.
- merge edit-vacation.php and user/vaction.php into one file.
- add useremail to flash-message sure for admin if coming back to
list-virtual.php.

BTW
I had a look a the $smarty->assign remark, and  you were right. It is
change in vacation-3.patch.

if you have any comments or recommendations please let me know

Regards Jan Kruis



----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 10:51

Message:
Christian,

In my attempt to merge edit-vacation and user-vacation vacation together
into one file
(meaning to get the preliminary code and  templates as much in sync as
possible to obtain unambiguous)
I noticed something strange.

In the template edit vacation.tpl I particularly "control" and "name"
changed from activeform to fActiveForm.

I open edit-vacation.php through the edit-list-virtual.php window;
everything works well, now I open a second window and open user-vacation
everything this still works well, until I reload window 1 (edit vacation).
Now change the window in the window of user-vacation but call the right
url in the browser, that of  edit-vacation.php (with the right name and
domain).

Could this be the result of my changes of that review, and particularly
name?


Regards, Jan Kruis

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 10:44

Message:
Hi Christian,

dont commit the patch it nown
i upload a second patch with handel the return and removed some unused
code in templates
please have a look and i see up to remarks

i have a look at the $smarty->assign remark

reards jan

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-01 02:23

Message:
I just had a quick look at your patch - looks good :-) - but as usual, I
found "a hair in the soup" (as we germans say) ;-)

In edit-vacation.php, you use (for $tSubject and $tBody)
    $smarty->assign ('tSubject', htmlentities ($tSubject, ENT_QUOTES,
'UTF-8'), false);
You can most probably use this instead:
    $smarty->assign ('tSubject', $tSubject);
(without the "false" as third parameter, $smarty->assign does the
htmlentities() call itsself - see assign() and sanitize() in
smarty.inc.php)
Or did I overlook something?

What's your preferred way to continue? Shall I commit your preliminary
patch to SVN now or should I wait until you provide a non-preliminary
patch? (I'd prefer to commit now, but it's your choice.)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

[ postfixadmin-Patches-3383236 ] preliminary code to merge vacation

[SourceForge.net <no...@so...>]

Patches item #3383236, was opened at 2011-07-31 14:38
Message generated for change (Comment added) made by jan-kruis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: SVN (please specify revision!)
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: J.Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: preliminary code to merge  vacation

Initial Comment:
this patch i use to get code in to sync  toget later one template and one code voor edit-vacation and user-vacation

regarde Jan Kruis


----------------------------------------------------------------------

>Comment By: J.Kruis (jan-kruis)
Date: 2011-08-21 19:30

Message:
Hi Christian,

I read your commit log message and I agree with the adjustment.
With the merge of the file i had no problems. I've removed the file from
my system and enter a "svn up".


What I found strange that you had trouble with the merge, because the "svn
diff" have taken on him for svn svn 1167 and 1168 have uploaded.

I will not add more variables to variables.inc.php

Just coming back to the comment:

>
> From my POV the merge is finished. The only things I noticed while
> proofreading your changes are:
> the "vacation already active" message would also be useful for admins,
> but that probably needs a small text change
>

I had the message already included in the update but I thought later,
because the admin of the list-virutal.php already can see that the vacation
message is active. "Set Vacation" and "VACATION IS ON"

>
> in admin mode, $fDomain should be read from $fUsername instead of using
an url parameter
>

[Code]
// only allow admins to change someone else's 'stuff'
if(authentication_has_role('admin')) {
   $Admin_role = 1 ;

   if (isset($_GET['username'])) $fUsername = escape_string
($_GET['username']);
   if (isset($_GET['domain'])) $fDomain = escape_string
($_GET['domain']);
   $Return_url = "list-virtual.php?domain=$fDomain";
}
else {
   $Admin_role = 0 ;
#   $Return_url = "users/main.php";
   $Return_url = "main.php";
   authentication_require_role('user');
   $fUsername = $SESSID_USERNAME;
   $fDomain = $USERID_DOMAIN;
}
[/Code]

exchange with 

[Code]
// only allow admins to change someone else's 'stuff'
if(authentication_has_role('admin')) {
   $Admin_role = 1 ;

   if (isset($_GET['username'])) $fUsername = escape_string
($_GET['username']);
//   if (isset($_GET['domain'])) $fDomain = escape_string
($_GET['domain']);
   $tmp = preg_split ('/@/', $fUsername);
   $fDomain = $tmp[1];
   $Return_url = "list-virtual.php?domain=$fDomain";
} 
else {
   $Admin_role = 0 ;
//   $Return_url = "users/main.php";
   $Return_url = "main.php";
   authentication_require_role('user');
   $fUsername = $SESSID_USERNAME;
//   $fDomain = $USERID_DOMAIN;
   $tmp = preg_split ('/@/', $fUsername);
   $fDomain = $tmp[1];
}
[/Code] 

>
>  in admin mode, there should be a check if $fUsername is valid
>

Check for the $fUsername do you think of a check against the database or
to a syntax check. I see no benefit in a check  against the database. to
perform list because vacation.php come from virtual domain and user name
comes from the database.

> (and of course I still have to check your comments in en.lang)

> Those are mostly unrelated to your patch. I won't complain if you fix
> them, but it's not a real problem for me to fix them myself. (That's
> especially true for the text change - I can update all language files
> (well, add a comment) with one script call.)


The adjustment in the code I will have for my account, I will leave the
language, adapting to your.


----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-15 01:25

Message:
> I ask myself if i used the right way to call vacation voor the users
> because i al sop saw a reference to url_user_vacation in
configs/menu.conf
> and in templates/users_menu.tpl
> or are these obsolete ?

They are not obsolete, but they are not used everywhere :-(

Besides that, things aren't as easy as "change a link" because that makes
the other links in the users menu link to the wrong place. Instead, I
commited a dummy users/vacation.php that only does a
require('../vacation.php'). That avoids the link hell ;-)

> I pleaced some remark in the en.lang file .these are the data which we
can
> to put together and could rename. If this will not give any problems
with
> the translations.

I've postponed this part of your patch.

> I uploaded vacation-6.patch.

I integrated it in svn trunk (with some trouble - looks like you didn't
create the patch against latest svn, but it finally worked) and commited it
to SVN r1169. 

Please see the commit log message for some details about the differences
between your patch and what I commited. (I hope you don't get too many
merge conflicts on your next "svn up" run ;-)

Oh, BTW: Please do not add more variables to variables.inc.php - it's
a(nother) leftover I want to get rid of (by initializing the variables in
the/each script that requires them).

From my POV the merge is finished. The only things I noticed while
proofreading your changes are:
- the "vacation already active" message would also be useful for admins,
but that probably needs a small text change
- in admin mode, $fDomain should be read from $fUsername instead of using
an url parameter
- in admin mode, there should be a check if $fUsername is valid
- (and of course I still have to check your comments in en.lang)

Those are mostly unrelated to your patch. I won't complain if you fix
them, but it's not a real problem for me to fix them myself. (That's
especially true for the text change - I can update all language files
(well, add a comment) with one script call.)

If you provide a patch for the above things, please make sure to use the
latest svn revision before running "svn diff".

All that said: thanks for working on this patch!

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-08 01:40

Message:
Hi Christian,

I think I'm done fairly.

modules in the patch are not longer used this way can

edit-vacation.php and users/vacation.php will  be replaced by vacation.php
.

templates/edit-vacation.tpl and templates/user-vacatio.tpl wil be replaced
by templates/vacation.tpl .


I ask myself if i used the right way to call vacation voor the users
because i al sop saw a reference to url_user_vacation in configs/menu.conf 
and in templates/users_menu.tpl
or are these obsolete ?

I pleaced some remark in the en.lang file .these are the data which we can
to put together and could rename. If this will not give any problems with
the translations.

BTW
I saw in the nl.lang file a few times  the same text wand it was not
marked as ​obsulte like other text .
These are among the text of *_password_text_error.

I uploaded vacation-6.patch.

Please let me know what you think and want shoud be changed

Regrades Jan
 

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-07 01:31

Message:
Q1: Renaming $PALANG texts is not a real problem - language-update.sh can
do that (no translations lost). The more interesting question is how to
name the variables - IMHO they don't need to have "vacation" in their name.
For example, pUsersVacation_subject (text: "Subject") could just be
$PALANG[subject] and could also be used in broadcast-message.php (instead
of pBroadcast_subject).

I can do the renaming if you tell me which variables you want to rename
and which name you'd like to have.

Q2: fetchmail.php contains an example:
flash_info(sprintf($PALANG['pDelete_delete_success'],$account));

Q3
> $ return_url = 'list-virtual.php? fDomain $ domain =';

This should probably be $return_url = 'list-virtual.php?domain=' .
$fDomain; (Note: I didn't check the parameter and variable names)

> I like the following line ... insert vaction.php they do not work. I get
a blank screen.

That's means you should check your error_log ;-) - it usually contains an
error message in this case.

> header ("Location:". "return_url $ '.)

Shouldn't that be header("Location: $Return_url");  ?

> $Return_url = 'list-virtual.php?domain=$fDomain';

You should use "..." quotes instead of '...' (your version won't replace
$fDomain with the variable content).

BTW: You have probably noticed that the SF tracker is not the perfect
place for pasting code. Feel free to upload it as attachment or switch to
another communication channel, for example the postfixadmin-devel
mailinglist.

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-06 23:17

Message:
Hi Christian,

I used your vacation.tpl adjustment.


Q1
I wonder whether it is advisable to rename the languages ​​of
[pUsersVacation] change to [pVacation]
It clearness would clearly benefit, but I think it will generate lot of
translation work . I like to hear your opinion.


Q2
Flash_Message I wanted to use the email user to be added to the flash_info
/ flash_error () I try it now via% s see question below.

Another question relates to sprintf () and% s $ PALANG text?
where can I find an example of the use of it. I found something in
footer.php but did not it dn't call the function with flash or flash error
information. when i try it it dn't repleace the %s but show it.

The adjustment that I will make in the long file *. I will make in the NL
and EN version.

Q3
I run into another problem.

Depending on the role (admin or user) I set the variable

$ return_url = 'list-virtual.php? fDomain $ domain =';
or
$ return_url = 'main.php';

I like the following line ... insert vaction.php they do not work. I get a
blank screen.

header ("Location:". "return_url $ '.)

question:
How do I header () returns the location if I want to define as a variable.
This is the code I currently use.


[code]
// only allow admins to change someone else's 'stuff'
if(authentication_has_role('admin')) {
   $Admin_Role = 1 ;
   $Return_url = 'list-virtual.php?domain=$fDomain';

   if (isset($_GET['username'])) $fUsername = escape_string
($_GET['username']);
   if (isset($_GET['domain'])) $fDomain = escape_string ($_GET['domain']);
}
else {
   $Admin_Role = 0 ;
   $Return_url = 'main.php';
//   authentication_require_role('user');
   $fUsername = $SESSID_USERNAME;
   $fDomain = $USERID_DOMAIN;
}

// is vacation support enabled in $CONF ?
if($CONF['vacation'] == 'NO') {
  if ($Admin_Role == 1) {
    header ("Location: list-virtual.php?domain=$fDomain");
  }
  else {
    header ("Location: main.php");
  }
  exit(0);
}
[/code]

Regards,
Jan Kruis


----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-05 22:18

Message:
Some small notes on vacation-3.patch:

edit.vacation.php + users/vacation.php: 
- The fChange and fBack POST variables are only used with empty() - that
means escape_string() is superfluous (but doesn't hurt)
- I don't see a real need for using $Flash_Message - you can use
flash_info()/flash_error() with a $PALANG text directly

vacation.tpl: 
- displaying the mail address in users/ is superfluous IMHO - I'd propose
to wrap this table row in {if !$authentication_has_role.user} ... {/if}

I nevertheless commited your patch to SVN r1163 (without changes to avoid
merge conflicts for you).

About your TODO list:
> - remove entry in the language with are not used any more.

Just tell me which $PALANG texts are no longer needed, I will handle the
changes in *.lang

> - add useremail to flash-message sure for admin if coming back to
> list-virtual.php.

Sounds like a good idea. You can use sprintf() and '%s' in the $PALANG
text to make the text a valid sentense. Feel free to modify the existing
text in the languages you understand. For the others, we can just append
'(%s)' to the text and add a comment to the translators that they should
make the translation nicer. Again, I can help with updating *.lang if you
want - doing this with language-update.sh might be faster than manual
editing.

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-04 13:38

Message:
Translation update commited to SVN r1162.

I'll review the vacation-related parts of your patch tonight.

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 22:02

Message:
Hi Christian,

I have upload new patch.

In this one i replaced eidt-vaction.tpl and user_vacation.tpl with a new
template vacation.tpl
as a frist step to merge the two module into one.

what a like to do is put the of the email for with the vacation is change
into header somethink link

auto response for : us...@do...

as well user setting as for the admin setting.

as you can see i also make a patch voor the languages/nl.lang


If you like the patch sofar  you may commit vacatiion-3.patch

thing i have todo.

- remove entry in the language with are not used any more.
- merge edit-vacation.php and user/vaction.php into one file.
- add useremail to flash-message sure for admin if coming back to
list-virtual.php.

BTW
I had a look a the $smarty->assign remark, and  you were right. It is
change in vacation-3.patch.

if you have any comments or recommendations please let me know

Regards Jan Kruis



----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 22:02

Message:
Hi Christian,

I have upload new patch.

In this one i replaced eidt-vaction.tpl and user_vacation.tpl with a new
template vacation.tpl
as a frist step to merge the two module into one.

what a like to do is put the of the email for with the vacation is change
into header somethink link

auto response for : us...@do...

as well user setting as for the admin setting.

as you can see i also make a patch voor the languages/nl.lang


If you like the patch sofar  you may commit vacatiion-3.patch

thing i have todo.

- remove entry in the language with are not used any more.
- merge edit-vacation.php and user/vaction.php into one file.
- add useremail to flash-message sure for admin if coming back to
list-virtual.php.

BTW
I had a look a the $smarty->assign remark, and  you were right. It is
change in vacation-3.patch.

if you have any comments or recommendations please let me know

Regards Jan Kruis



----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 10:51

Message:
Christian,

In my attempt to merge edit-vacation and user-vacation vacation together
into one file
(meaning to get the preliminary code and  templates as much in sync as
possible to obtain unambiguous)
I noticed something strange.

In the template edit vacation.tpl I particularly "control" and "name"
changed from activeform to fActiveForm.

I open edit-vacation.php through the edit-list-virtual.php window;
everything works well, now I open a second window and open user-vacation
everything this still works well, until I reload window 1 (edit vacation).
Now change the window in the window of user-vacation but call the right
url in the browser, that of  edit-vacation.php (with the right name and
domain).

Could this be the result of my changes of that review, and particularly
name?


Regards, Jan Kruis

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 10:44

Message:
Hi Christian,

dont commit the patch it nown
i upload a second patch with handel the return and removed some unused
code in templates
please have a look and i see up to remarks

i have a look at the $smarty->assign remark

reards jan

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-01 02:23

Message:
I just had a quick look at your patch - looks good :-) - but as usual, I
found "a hair in the soup" (as we germans say) ;-)

In edit-vacation.php, you use (for $tSubject and $tBody)
    $smarty->assign ('tSubject', htmlentities ($tSubject, ENT_QUOTES,
'UTF-8'), false);
You can most probably use this instead:
    $smarty->assign ('tSubject', $tSubject);
(without the "false" as third parameter, $smarty->assign does the
htmlentities() call itsself - see assign() and sanitize() in
smarty.inc.php)
Or did I overlook something?

What's your preferred way to continue? Shall I commit your preliminary
patch to SVN now or should I wait until you provide a non-preliminary
patch? (I'd prefer to commit now, but it's your choice.)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

[ postfixadmin-Bugs-3393643 ] squirrelmail plugin login error

[SourceForge.net <no...@so...>]

Bugs item #3393643, was opened at 2011-08-18 10:47
Message generated for change (Comment added) made by mralone
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3393643&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: v2.3.3
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Juri Gurjanov (mralone)
Assigned to: Nobody/Anonymous (nobody)
Summary: squirrelmail plugin login error

Initial Comment:
Hello.

Found a problem with squirrelmail plugin and postfixadmin - if I made changes in "Forwarding", "Auto Response" or "Change Password", then click "Sigh Out" and login again, I can't access "Forwarding", "Auto Response" or "Change Password" anymore due to "ERROR You must be logged in to access this page." 

I can reproduce this problem on Squrrelmail 1.4.21 and 1.4.22 with Postfixadmin 2.3.3 but can't reproduce on Squirrelmail 1.4.15

----------------------------------------------------------------------

>Comment By: Juri Gurjanov (mralone)
Date: 2011-08-18 10:49

Message:
Forgot to say, that if I close browser window, and login again, I can
access plugin parts, until some changes were made.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3393643&group_id=191583

[ postfixadmin-Bugs-3393643 ] squirrelmail plugin login error

[SourceForge.net <no...@so...>]

Bugs item #3393643, was opened at 2011-08-18 10:47
Message generated for change (Tracker Item Submitted) made by mralone
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3393643&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: v2.3.3
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Juri Gurjanov (mralone)
Assigned to: Nobody/Anonymous (nobody)
Summary: squirrelmail plugin login error

Initial Comment:
Hello.

Found a problem with squirrelmail plugin and postfixadmin - if I made changes in "Forwarding", "Auto Response" or "Change Password", then click "Sigh Out" and login again, I can't access "Forwarding", "Auto Response" or "Change Password" anymore due to "ERROR You must be logged in to access this page." 

I can reproduce this problem on Squrrelmail 1.4.21 and 1.4.22 with Postfixadmin 2.3.3 but can't reproduce on Squirrelmail 1.4.15

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3393643&group_id=191583

[ postfixadmin-Patches-3383236 ] preliminary code to merge vacation

[SourceForge.net <no...@so...>]

Patches item #3383236, was opened at 2011-07-31 14:38
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: SVN (please specify revision!)
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: J.Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: preliminary code to merge  vacation

Initial Comment:
this patch i use to get code in to sync  toget later one template and one code voor edit-vacation and user-vacation

regarde Jan Kruis


----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-15 01:25

Message:
> I ask myself if i used the right way to call vacation voor the users
> because i al sop saw a reference to url_user_vacation in
configs/menu.conf
> and in templates/users_menu.tpl
> or are these obsolete ?

They are not obsolete, but they are not used everywhere :-(

Besides that, things aren't as easy as "change a link" because that makes
the other links in the users menu link to the wrong place. Instead, I
commited a dummy users/vacation.php that only does a
require('../vacation.php'). That avoids the link hell ;-)

> I pleaced some remark in the en.lang file .these are the data which we
can
> to put together and could rename. If this will not give any problems
with
> the translations.

I've postponed this part of your patch.

> I uploaded vacation-6.patch.

I integrated it in svn trunk (with some trouble - looks like you didn't
create the patch against latest svn, but it finally worked) and commited it
to SVN r1169. 

Please see the commit log message for some details about the differences
between your patch and what I commited. (I hope you don't get too many
merge conflicts on your next "svn up" run ;-)

Oh, BTW: Please do not add more variables to variables.inc.php - it's
a(nother) leftover I want to get rid of (by initializing the variables in
the/each script that requires them).

From my POV the merge is finished. The only things I noticed while
proofreading your changes are:
- the "vacation already active" message would also be useful for admins,
but that probably needs a small text change
- in admin mode, $fDomain should be read from $fUsername instead of using
an url parameter
- in admin mode, there should be a check if $fUsername is valid
- (and of course I still have to check your comments in en.lang)

Those are mostly unrelated to your patch. I won't complain if you fix
them, but it's not a real problem for me to fix them myself. (That's
especially true for the text change - I can update all language files
(well, add a comment) with one script call.)

If you provide a patch for the above things, please make sure to use the
latest svn revision before running "svn diff".

All that said: thanks for working on this patch!

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-08 01:40

Message:
Hi Christian,

I think I'm done fairly.

modules in the patch are not longer used this way can

edit-vacation.php and users/vacation.php will  be replaced by vacation.php
.

templates/edit-vacation.tpl and templates/user-vacatio.tpl wil be replaced
by templates/vacation.tpl .


I ask myself if i used the right way to call vacation voor the users
because i al sop saw a reference to url_user_vacation in configs/menu.conf 
and in templates/users_menu.tpl
or are these obsolete ?

I pleaced some remark in the en.lang file .these are the data which we can
to put together and could rename. If this will not give any problems with
the translations.

BTW
I saw in the nl.lang file a few times  the same text wand it was not
marked as ​obsulte like other text .
These are among the text of *_password_text_error.

I uploaded vacation-6.patch.

Please let me know what you think and want shoud be changed

Regrades Jan
 

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-07 01:31

Message:
Q1: Renaming $PALANG texts is not a real problem - language-update.sh can
do that (no translations lost). The more interesting question is how to
name the variables - IMHO they don't need to have "vacation" in their name.
For example, pUsersVacation_subject (text: "Subject") could just be
$PALANG[subject] and could also be used in broadcast-message.php (instead
of pBroadcast_subject).

I can do the renaming if you tell me which variables you want to rename
and which name you'd like to have.

Q2: fetchmail.php contains an example:
flash_info(sprintf($PALANG['pDelete_delete_success'],$account));

Q3
> $ return_url = 'list-virtual.php? fDomain $ domain =';

This should probably be $return_url = 'list-virtual.php?domain=' .
$fDomain; (Note: I didn't check the parameter and variable names)

> I like the following line ... insert vaction.php they do not work. I get
a blank screen.

That's means you should check your error_log ;-) - it usually contains an
error message in this case.

> header ("Location:". "return_url $ '.)

Shouldn't that be header("Location: $Return_url");  ?

> $Return_url = 'list-virtual.php?domain=$fDomain';

You should use "..." quotes instead of '...' (your version won't replace
$fDomain with the variable content).

BTW: You have probably noticed that the SF tracker is not the perfect
place for pasting code. Feel free to upload it as attachment or switch to
another communication channel, for example the postfixadmin-devel
mailinglist.

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-06 23:17

Message:
Hi Christian,

I used your vacation.tpl adjustment.


Q1
I wonder whether it is advisable to rename the languages ​​of
[pUsersVacation] change to [pVacation]
It clearness would clearly benefit, but I think it will generate lot of
translation work . I like to hear your opinion.


Q2
Flash_Message I wanted to use the email user to be added to the flash_info
/ flash_error () I try it now via% s see question below.

Another question relates to sprintf () and% s $ PALANG text?
where can I find an example of the use of it. I found something in
footer.php but did not it dn't call the function with flash or flash error
information. when i try it it dn't repleace the %s but show it.

The adjustment that I will make in the long file *. I will make in the NL
and EN version.

Q3
I run into another problem.

Depending on the role (admin or user) I set the variable

$ return_url = 'list-virtual.php? fDomain $ domain =';
or
$ return_url = 'main.php';

I like the following line ... insert vaction.php they do not work. I get a
blank screen.

header ("Location:". "return_url $ '.)

question:
How do I header () returns the location if I want to define as a variable.
This is the code I currently use.


[code]
// only allow admins to change someone else's 'stuff'
if(authentication_has_role('admin')) {
   $Admin_Role = 1 ;
   $Return_url = 'list-virtual.php?domain=$fDomain';

   if (isset($_GET['username'])) $fUsername = escape_string
($_GET['username']);
   if (isset($_GET['domain'])) $fDomain = escape_string ($_GET['domain']);
}
else {
   $Admin_Role = 0 ;
   $Return_url = 'main.php';
//   authentication_require_role('user');
   $fUsername = $SESSID_USERNAME;
   $fDomain = $USERID_DOMAIN;
}

// is vacation support enabled in $CONF ?
if($CONF['vacation'] == 'NO') {
  if ($Admin_Role == 1) {
    header ("Location: list-virtual.php?domain=$fDomain");
  }
  else {
    header ("Location: main.php");
  }
  exit(0);
}
[/code]

Regards,
Jan Kruis


----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-05 22:18

Message:
Some small notes on vacation-3.patch:

edit.vacation.php + users/vacation.php: 
- The fChange and fBack POST variables are only used with empty() - that
means escape_string() is superfluous (but doesn't hurt)
- I don't see a real need for using $Flash_Message - you can use
flash_info()/flash_error() with a $PALANG text directly

vacation.tpl: 
- displaying the mail address in users/ is superfluous IMHO - I'd propose
to wrap this table row in {if !$authentication_has_role.user} ... {/if}

I nevertheless commited your patch to SVN r1163 (without changes to avoid
merge conflicts for you).

About your TODO list:
> - remove entry in the language with are not used any more.

Just tell me which $PALANG texts are no longer needed, I will handle the
changes in *.lang

> - add useremail to flash-message sure for admin if coming back to
> list-virtual.php.

Sounds like a good idea. You can use sprintf() and '%s' in the $PALANG
text to make the text a valid sentense. Feel free to modify the existing
text in the languages you understand. For the others, we can just append
'(%s)' to the text and add a comment to the translators that they should
make the translation nicer. Again, I can help with updating *.lang if you
want - doing this with language-update.sh might be faster than manual
editing.

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-04 13:38

Message:
Translation update commited to SVN r1162.

I'll review the vacation-related parts of your patch tonight.

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 22:02

Message:
Hi Christian,

I have upload new patch.

In this one i replaced eidt-vaction.tpl and user_vacation.tpl with a new
template vacation.tpl
as a frist step to merge the two module into one.

what a like to do is put the of the email for with the vacation is change
into header somethink link

auto response for : us...@do...

as well user setting as for the admin setting.

as you can see i also make a patch voor the languages/nl.lang


If you like the patch sofar  you may commit vacatiion-3.patch

thing i have todo.

- remove entry in the language with are not used any more.
- merge edit-vacation.php and user/vaction.php into one file.
- add useremail to flash-message sure for admin if coming back to
list-virtual.php.

BTW
I had a look a the $smarty->assign remark, and  you were right. It is
change in vacation-3.patch.

if you have any comments or recommendations please let me know

Regards Jan Kruis



----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 22:02

Message:
Hi Christian,

I have upload new patch.

In this one i replaced eidt-vaction.tpl and user_vacation.tpl with a new
template vacation.tpl
as a frist step to merge the two module into one.

what a like to do is put the of the email for with the vacation is change
into header somethink link

auto response for : us...@do...

as well user setting as for the admin setting.

as you can see i also make a patch voor the languages/nl.lang


If you like the patch sofar  you may commit vacatiion-3.patch

thing i have todo.

- remove entry in the language with are not used any more.
- merge edit-vacation.php and user/vaction.php into one file.
- add useremail to flash-message sure for admin if coming back to
list-virtual.php.

BTW
I had a look a the $smarty->assign remark, and  you were right. It is
change in vacation-3.patch.

if you have any comments or recommendations please let me know

Regards Jan Kruis



----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 10:51

Message:
Christian,

In my attempt to merge edit-vacation and user-vacation vacation together
into one file
(meaning to get the preliminary code and  templates as much in sync as
possible to obtain unambiguous)
I noticed something strange.

In the template edit vacation.tpl I particularly "control" and "name"
changed from activeform to fActiveForm.

I open edit-vacation.php through the edit-list-virtual.php window;
everything works well, now I open a second window and open user-vacation
everything this still works well, until I reload window 1 (edit vacation).
Now change the window in the window of user-vacation but call the right
url in the browser, that of  edit-vacation.php (with the right name and
domain).

Could this be the result of my changes of that review, and particularly
name?


Regards, Jan Kruis

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 10:44

Message:
Hi Christian,

dont commit the patch it nown
i upload a second patch with handel the return and removed some unused
code in templates
please have a look and i see up to remarks

i have a look at the $smarty->assign remark

reards jan

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-01 02:23

Message:
I just had a quick look at your patch - looks good :-) - but as usual, I
found "a hair in the soup" (as we germans say) ;-)

In edit-vacation.php, you use (for $tSubject and $tBody)
    $smarty->assign ('tSubject', htmlentities ($tSubject, ENT_QUOTES,
'UTF-8'), false);
You can most probably use this instead:
    $smarty->assign ('tSubject', $tSubject);
(without the "false" as third parameter, $smarty->assign does the
htmlentities() call itsself - see assign() and sanitize() in
smarty.inc.php)
Or did I overlook something?

What's your preferred way to continue? Shall I commit your preliminary
patch to SVN now or should I wait until you provide a non-preliminary
patch? (I'd prefer to commit now, but it's your choice.)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

[ postfixadmin-Patches-3383236 ] preliminary code to merge vacation

[SourceForge.net <no...@so...>]

Patches item #3383236, was opened at 2011-07-31 14:38
Message generated for change (Comment added) made by jan-kruis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: SVN (please specify revision!)
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: J.Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: preliminary code to merge  vacation

Initial Comment:
this patch i use to get code in to sync  toget later one template and one code voor edit-vacation and user-vacation

regarde Jan Kruis


----------------------------------------------------------------------

>Comment By: J.Kruis (jan-kruis)
Date: 2011-08-08 01:40

Message:
Hi Christian,

I think I'm done fairly.

modules in the patch are not longer used this way can

edit-vacation.php and users/vacation.php will  be replaced by vacation.php
.

templates/edit-vacation.tpl and templates/user-vacatio.tpl wil be replaced
by templates/vacation.tpl .


I ask myself if i used the right way to call vacation voor the users
because i al sop saw a reference to url_user_vacation in configs/menu.conf 
and in templates/users_menu.tpl
or are these obsolete ?

I pleaced some remark in the en.lang file .these are the data which we can
to put together and could rename. If this will not give any problems with
the translations.

BTW
I saw in the nl.lang file a few times  the same text wand it was not
marked as ​obsulte like other text .
These are among the text of *_password_text_error.

I uploaded vacation-6.patch.

Please let me know what you think and want shoud be changed

Regrades Jan
 

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-07 01:31

Message:
Q1: Renaming $PALANG texts is not a real problem - language-update.sh can
do that (no translations lost). The more interesting question is how to
name the variables - IMHO they don't need to have "vacation" in their name.
For example, pUsersVacation_subject (text: "Subject") could just be
$PALANG[subject] and could also be used in broadcast-message.php (instead
of pBroadcast_subject).

I can do the renaming if you tell me which variables you want to rename
and which name you'd like to have.

Q2: fetchmail.php contains an example:
flash_info(sprintf($PALANG['pDelete_delete_success'],$account));

Q3
> $ return_url = 'list-virtual.php? fDomain $ domain =';

This should probably be $return_url = 'list-virtual.php?domain=' .
$fDomain; (Note: I didn't check the parameter and variable names)

> I like the following line ... insert vaction.php they do not work. I get
a blank screen.

That's means you should check your error_log ;-) - it usually contains an
error message in this case.

> header ("Location:". "return_url $ '.)

Shouldn't that be header("Location: $Return_url");  ?

> $Return_url = 'list-virtual.php?domain=$fDomain';

You should use "..." quotes instead of '...' (your version won't replace
$fDomain with the variable content).

BTW: You have probably noticed that the SF tracker is not the perfect
place for pasting code. Feel free to upload it as attachment or switch to
another communication channel, for example the postfixadmin-devel
mailinglist.

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-06 23:17

Message:
Hi Christian,

I used your vacation.tpl adjustment.


Q1
I wonder whether it is advisable to rename the languages ​​of
[pUsersVacation] change to [pVacation]
It clearness would clearly benefit, but I think it will generate lot of
translation work . I like to hear your opinion.


Q2
Flash_Message I wanted to use the email user to be added to the flash_info
/ flash_error () I try it now via% s see question below.

Another question relates to sprintf () and% s $ PALANG text?
where can I find an example of the use of it. I found something in
footer.php but did not it dn't call the function with flash or flash error
information. when i try it it dn't repleace the %s but show it.

The adjustment that I will make in the long file *. I will make in the NL
and EN version.

Q3
I run into another problem.

Depending on the role (admin or user) I set the variable

$ return_url = 'list-virtual.php? fDomain $ domain =';
or
$ return_url = 'main.php';

I like the following line ... insert vaction.php they do not work. I get a
blank screen.

header ("Location:". "return_url $ '.)

question:
How do I header () returns the location if I want to define as a variable.
This is the code I currently use.


[code]
// only allow admins to change someone else's 'stuff'
if(authentication_has_role('admin')) {
   $Admin_Role = 1 ;
   $Return_url = 'list-virtual.php?domain=$fDomain';

   if (isset($_GET['username'])) $fUsername = escape_string
($_GET['username']);
   if (isset($_GET['domain'])) $fDomain = escape_string ($_GET['domain']);
}
else {
   $Admin_Role = 0 ;
   $Return_url = 'main.php';
//   authentication_require_role('user');
   $fUsername = $SESSID_USERNAME;
   $fDomain = $USERID_DOMAIN;
}

// is vacation support enabled in $CONF ?
if($CONF['vacation'] == 'NO') {
  if ($Admin_Role == 1) {
    header ("Location: list-virtual.php?domain=$fDomain");
  }
  else {
    header ("Location: main.php");
  }
  exit(0);
}
[/code]

Regards,
Jan Kruis


----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-05 22:18

Message:
Some small notes on vacation-3.patch:

edit.vacation.php + users/vacation.php: 
- The fChange and fBack POST variables are only used with empty() - that
means escape_string() is superfluous (but doesn't hurt)
- I don't see a real need for using $Flash_Message - you can use
flash_info()/flash_error() with a $PALANG text directly

vacation.tpl: 
- displaying the mail address in users/ is superfluous IMHO - I'd propose
to wrap this table row in {if !$authentication_has_role.user} ... {/if}

I nevertheless commited your patch to SVN r1163 (without changes to avoid
merge conflicts for you).

About your TODO list:
> - remove entry in the language with are not used any more.

Just tell me which $PALANG texts are no longer needed, I will handle the
changes in *.lang

> - add useremail to flash-message sure for admin if coming back to
> list-virtual.php.

Sounds like a good idea. You can use sprintf() and '%s' in the $PALANG
text to make the text a valid sentense. Feel free to modify the existing
text in the languages you understand. For the others, we can just append
'(%s)' to the text and add a comment to the translators that they should
make the translation nicer. Again, I can help with updating *.lang if you
want - doing this with language-update.sh might be faster than manual
editing.

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-04 13:38

Message:
Translation update commited to SVN r1162.

I'll review the vacation-related parts of your patch tonight.

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 22:02

Message:
Hi Christian,

I have upload new patch.

In this one i replaced eidt-vaction.tpl and user_vacation.tpl with a new
template vacation.tpl
as a frist step to merge the two module into one.

what a like to do is put the of the email for with the vacation is change
into header somethink link

auto response for : us...@do...

as well user setting as for the admin setting.

as you can see i also make a patch voor the languages/nl.lang


If you like the patch sofar  you may commit vacatiion-3.patch

thing i have todo.

- remove entry in the language with are not used any more.
- merge edit-vacation.php and user/vaction.php into one file.
- add useremail to flash-message sure for admin if coming back to
list-virtual.php.

BTW
I had a look a the $smarty->assign remark, and  you were right. It is
change in vacation-3.patch.

if you have any comments or recommendations please let me know

Regards Jan Kruis



----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 22:02

Message:
Hi Christian,

I have upload new patch.

In this one i replaced eidt-vaction.tpl and user_vacation.tpl with a new
template vacation.tpl
as a frist step to merge the two module into one.

what a like to do is put the of the email for with the vacation is change
into header somethink link

auto response for : us...@do...

as well user setting as for the admin setting.

as you can see i also make a patch voor the languages/nl.lang


If you like the patch sofar  you may commit vacatiion-3.patch

thing i have todo.

- remove entry in the language with are not used any more.
- merge edit-vacation.php and user/vaction.php into one file.
- add useremail to flash-message sure for admin if coming back to
list-virtual.php.

BTW
I had a look a the $smarty->assign remark, and  you were right. It is
change in vacation-3.patch.

if you have any comments or recommendations please let me know

Regards Jan Kruis



----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 10:51

Message:
Christian,

In my attempt to merge edit-vacation and user-vacation vacation together
into one file
(meaning to get the preliminary code and  templates as much in sync as
possible to obtain unambiguous)
I noticed something strange.

In the template edit vacation.tpl I particularly "control" and "name"
changed from activeform to fActiveForm.

I open edit-vacation.php through the edit-list-virtual.php window;
everything works well, now I open a second window and open user-vacation
everything this still works well, until I reload window 1 (edit vacation).
Now change the window in the window of user-vacation but call the right
url in the browser, that of  edit-vacation.php (with the right name and
domain).

Could this be the result of my changes of that review, and particularly
name?


Regards, Jan Kruis

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 10:44

Message:
Hi Christian,

dont commit the patch it nown
i upload a second patch with handel the return and removed some unused
code in templates
please have a look and i see up to remarks

i have a look at the $smarty->assign remark

reards jan

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-01 02:23

Message:
I just had a quick look at your patch - looks good :-) - but as usual, I
found "a hair in the soup" (as we germans say) ;-)

In edit-vacation.php, you use (for $tSubject and $tBody)
    $smarty->assign ('tSubject', htmlentities ($tSubject, ENT_QUOTES,
'UTF-8'), false);
You can most probably use this instead:
    $smarty->assign ('tSubject', $tSubject);
(without the "false" as third parameter, $smarty->assign does the
htmlentities() call itsself - see assign() and sanitize() in
smarty.inc.php)
Or did I overlook something?

What's your preferred way to continue? Shall I commit your preliminary
patch to SVN now or should I wait until you provide a non-preliminary
patch? (I'd prefer to commit now, but it's your choice.)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

[ postfixadmin-Feature Requests-3260737 ] Notofication of quota issue when adding new user

[SourceForge.net <no...@so...>]

Feature Requests item #3260737, was opened at 2011-03-30 19:20
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=3260737&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Interface Improvements (example)
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Darek M (fafaforza)
Assigned to: Nobody/Anonymous (nobody)
Summary: Notofication of quota issue when adding new user

Initial Comment:
I've been bitten a second time by quota differences.  DB value maxquota was at 10, and I was adding a user with 100.

Pressed submit, and the page stayed on the create-mailbox.php screen and no mailbox was added.  Spent a decent amount of time checking over logs, enabling logging in php.ini, etc, only to remember this issue from the past.

It would be very helpful to have a notification message produced in the form of "user quota exceeds domain quota" or similar to tip someone off.

----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-07 19:02

Message:
SVN trunk has this for edit-mailbox. We still need to add it for
create-mailbox (which means merging the code for edit and create).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=3260737&group_id=191583

[ postfixadmin-Feature Requests-3184684 ] Log configuration - option to NOT log the IP address

[SourceForge.net <no...@so...>]

Feature Requests item #3184684, was opened at 2011-02-17 10:51
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=3184684&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: None
>Status: Pending
Resolution: None
>Priority: 4
Private: No
Submitted By: https://www.google.com/accounts ()
Assigned to: Nobody/Anonymous (nobody)
>Summary: Log configuration - option to NOT log the IP address

Initial Comment:
currently logging in PFA can only be enabled or disabled. For privacy reasons it would be useful if the logging of IP addresses could be switched on/off in the config file. The IP address is currently stored in the logs together with the username.


----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-07 18:52

Message:
There's one thing I don't understand in your request: What is the advantage
of not logging the IP address?

I'd understand the request for an anonymous service (which we obviously
can't have for mailserver configuration) - but since we log the username
(which allows to identify an user), I see no privacy advantage in not
logging the IP.

Therefore I tend to reject this request - unless you tell me what I
overlooked ;-)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=3184684&group_id=191583

[ postfixadmin-Patches-3387375 ] create alias as admin

[SourceForge.net <no...@so...>]

Patches item #3387375, was opened at 2011-08-06 21:17
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3387375&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: SVN (please specify revision!)
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: J.Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: create alias as admin

Initial Comment:
hi,

If I input an incorrect email alias I get a error which references to an error in the goto feild in the flash error.

Attached a patch that fixes the problem.

----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-07 01:40

Message:
Good catch!

Commited to SVN trunk r1167. Thanks for the patch!

For the records: the 2.3 branch is not affected by this problem.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3387375&group_id=191583

[ postfixadmin-Patches-3383236 ] preliminary code to merge vacation

[SourceForge.net <no...@so...>]

Patches item #3383236, was opened at 2011-07-31 14:38
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: SVN (please specify revision!)
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: J.Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: preliminary code to merge  vacation

Initial Comment:
this patch i use to get code in to sync  toget later one template and one code voor edit-vacation and user-vacation

regarde Jan Kruis


----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-07 01:31

Message:
Q1: Renaming $PALANG texts is not a real problem - language-update.sh can
do that (no translations lost). The more interesting question is how to
name the variables - IMHO they don't need to have "vacation" in their name.
For example, pUsersVacation_subject (text: "Subject") could just be
$PALANG[subject] and could also be used in broadcast-message.php (instead
of pBroadcast_subject).

I can do the renaming if you tell me which variables you want to rename
and which name you'd like to have.

Q2: fetchmail.php contains an example:
flash_info(sprintf($PALANG['pDelete_delete_success'],$account));

Q3
> $ return_url = 'list-virtual.php? fDomain $ domain =';

This should probably be $return_url = 'list-virtual.php?domain=' .
$fDomain; (Note: I didn't check the parameter and variable names)

> I like the following line ... insert vaction.php they do not work. I get
a blank screen.

That's means you should check your error_log ;-) - it usually contains an
error message in this case.

> header ("Location:". "return_url $ '.)

Shouldn't that be header("Location: $Return_url");  ?

> $Return_url = 'list-virtual.php?domain=$fDomain';

You should use "..." quotes instead of '...' (your version won't replace
$fDomain with the variable content).

BTW: You have probably noticed that the SF tracker is not the perfect
place for pasting code. Feel free to upload it as attachment or switch to
another communication channel, for example the postfixadmin-devel
mailinglist.

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-06 23:17

Message:
Hi Christian,

I used your vacation.tpl adjustment.


Q1
I wonder whether it is advisable to rename the languages ​​of
[pUsersVacation] change to [pVacation]
It clearness would clearly benefit, but I think it will generate lot of
translation work . I like to hear your opinion.


Q2
Flash_Message I wanted to use the email user to be added to the flash_info
/ flash_error () I try it now via% s see question below.

Another question relates to sprintf () and% s $ PALANG text?
where can I find an example of the use of it. I found something in
footer.php but did not it dn't call the function with flash or flash error
information. when i try it it dn't repleace the %s but show it.

The adjustment that I will make in the long file *. I will make in the NL
and EN version.

Q3
I run into another problem.

Depending on the role (admin or user) I set the variable

$ return_url = 'list-virtual.php? fDomain $ domain =';
or
$ return_url = 'main.php';

I like the following line ... insert vaction.php they do not work. I get a
blank screen.

header ("Location:". "return_url $ '.)

question:
How do I header () returns the location if I want to define as a variable.
This is the code I currently use.


[code]
// only allow admins to change someone else's 'stuff'
if(authentication_has_role('admin')) {
   $Admin_Role = 1 ;
   $Return_url = 'list-virtual.php?domain=$fDomain';

   if (isset($_GET['username'])) $fUsername = escape_string
($_GET['username']);
   if (isset($_GET['domain'])) $fDomain = escape_string ($_GET['domain']);
}
else {
   $Admin_Role = 0 ;
   $Return_url = 'main.php';
//   authentication_require_role('user');
   $fUsername = $SESSID_USERNAME;
   $fDomain = $USERID_DOMAIN;
}

// is vacation support enabled in $CONF ?
if($CONF['vacation'] == 'NO') {
  if ($Admin_Role == 1) {
    header ("Location: list-virtual.php?domain=$fDomain");
  }
  else {
    header ("Location: main.php");
  }
  exit(0);
}
[/code]

Regards,
Jan Kruis


----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-05 22:18

Message:
Some small notes on vacation-3.patch:

edit.vacation.php + users/vacation.php: 
- The fChange and fBack POST variables are only used with empty() - that
means escape_string() is superfluous (but doesn't hurt)
- I don't see a real need for using $Flash_Message - you can use
flash_info()/flash_error() with a $PALANG text directly

vacation.tpl: 
- displaying the mail address in users/ is superfluous IMHO - I'd propose
to wrap this table row in {if !$authentication_has_role.user} ... {/if}

I nevertheless commited your patch to SVN r1163 (without changes to avoid
merge conflicts for you).

About your TODO list:
> - remove entry in the language with are not used any more.

Just tell me which $PALANG texts are no longer needed, I will handle the
changes in *.lang

> - add useremail to flash-message sure for admin if coming back to
> list-virtual.php.

Sounds like a good idea. You can use sprintf() and '%s' in the $PALANG
text to make the text a valid sentense. Feel free to modify the existing
text in the languages you understand. For the others, we can just append
'(%s)' to the text and add a comment to the translators that they should
make the translation nicer. Again, I can help with updating *.lang if you
want - doing this with language-update.sh might be faster than manual
editing.

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-04 13:38

Message:
Translation update commited to SVN r1162.

I'll review the vacation-related parts of your patch tonight.

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 22:02

Message:
Hi Christian,

I have upload new patch.

In this one i replaced eidt-vaction.tpl and user_vacation.tpl with a new
template vacation.tpl
as a frist step to merge the two module into one.

what a like to do is put the of the email for with the vacation is change
into header somethink link

auto response for : us...@do...

as well user setting as for the admin setting.

as you can see i also make a patch voor the languages/nl.lang


If you like the patch sofar  you may commit vacatiion-3.patch

thing i have todo.

- remove entry in the language with are not used any more.
- merge edit-vacation.php and user/vaction.php into one file.
- add useremail to flash-message sure for admin if coming back to
list-virtual.php.

BTW
I had a look a the $smarty->assign remark, and  you were right. It is
change in vacation-3.patch.

if you have any comments or recommendations please let me know

Regards Jan Kruis



----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 22:02

Message:
Hi Christian,

I have upload new patch.

In this one i replaced eidt-vaction.tpl and user_vacation.tpl with a new
template vacation.tpl
as a frist step to merge the two module into one.

what a like to do is put the of the email for with the vacation is change
into header somethink link

auto response for : us...@do...

as well user setting as for the admin setting.

as you can see i also make a patch voor the languages/nl.lang


If you like the patch sofar  you may commit vacatiion-3.patch

thing i have todo.

- remove entry in the language with are not used any more.
- merge edit-vacation.php and user/vaction.php into one file.
- add useremail to flash-message sure for admin if coming back to
list-virtual.php.

BTW
I had a look a the $smarty->assign remark, and  you were right. It is
change in vacation-3.patch.

if you have any comments or recommendations please let me know

Regards Jan Kruis



----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 10:51

Message:
Christian,

In my attempt to merge edit-vacation and user-vacation vacation together
into one file
(meaning to get the preliminary code and  templates as much in sync as
possible to obtain unambiguous)
I noticed something strange.

In the template edit vacation.tpl I particularly "control" and "name"
changed from activeform to fActiveForm.

I open edit-vacation.php through the edit-list-virtual.php window;
everything works well, now I open a second window and open user-vacation
everything this still works well, until I reload window 1 (edit vacation).
Now change the window in the window of user-vacation but call the right
url in the browser, that of  edit-vacation.php (with the right name and
domain).

Could this be the result of my changes of that review, and particularly
name?


Regards, Jan Kruis

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 10:44

Message:
Hi Christian,

dont commit the patch it nown
i upload a second patch with handel the return and removed some unused
code in templates
please have a look and i see up to remarks

i have a look at the $smarty->assign remark

reards jan

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-01 02:23

Message:
I just had a quick look at your patch - looks good :-) - but as usual, I
found "a hair in the soup" (as we germans say) ;-)

In edit-vacation.php, you use (for $tSubject and $tBody)
    $smarty->assign ('tSubject', htmlentities ($tSubject, ENT_QUOTES,
'UTF-8'), false);
You can most probably use this instead:
    $smarty->assign ('tSubject', $tSubject);
(without the "false" as third parameter, $smarty->assign does the
htmlentities() call itsself - see assign() and sanitize() in
smarty.inc.php)
Or did I overlook something?

What's your preferred way to continue? Shall I commit your preliminary
patch to SVN now or should I wait until you provide a non-preliminary
patch? (I'd prefer to commit now, but it's your choice.)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

[ postfixadmin-Patches-3383236 ] preliminary code to merge vacation

[SourceForge.net <no...@so...>]

Patches item #3383236, was opened at 2011-07-31 14:38
Message generated for change (Comment added) made by jan-kruis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: SVN (please specify revision!)
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: J.Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: preliminary code to merge  vacation

Initial Comment:
this patch i use to get code in to sync  toget later one template and one code voor edit-vacation and user-vacation

regarde Jan Kruis


----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-06 23:17

Message:
Hi Christian,

I used your vacation.tpl adjustment.


Q1
I wonder whether it is advisable to rename the languages ​​of
[pUsersVacation] change to [pVacation]
It clearness would clearly benefit, but I think it will generate lot of
translation work . I like to hear your opinion.


Q2
Flash_Message I wanted to use the email user to be added to the flash_info
/ flash_error () I try it now via% s see question below.

Another question relates to sprintf () and% s $ PALANG text?
where can I find an example of the use of it. I found something in
footer.php but did not it dn't call the function with flash or flash error
information. when i try it it dn't repleace the %s but show it.

The adjustment that I will make in the long file *. I will make in the NL
and EN version.

Q3
I run into another problem.

Depending on the role (admin or user) I set the variable

$ return_url = 'list-virtual.php? fDomain $ domain =';
or
$ return_url = 'main.php';

I like the following line ... insert vaction.php they do not work. I get a
blank screen.

header ("Location:". "return_url $ '.)

question:
How do I header () returns the location if I want to define as a variable.
This is the code I currently use.


[code]
// only allow admins to change someone else's 'stuff'
if(authentication_has_role('admin')) {
   $Admin_Role = 1 ;
   $Return_url = 'list-virtual.php?domain=$fDomain';

   if (isset($_GET['username'])) $fUsername = escape_string
($_GET['username']);
   if (isset($_GET['domain'])) $fDomain = escape_string ($_GET['domain']);
}
else {
   $Admin_Role = 0 ;
   $Return_url = 'main.php';
//   authentication_require_role('user');
   $fUsername = $SESSID_USERNAME;
   $fDomain = $USERID_DOMAIN;
}

// is vacation support enabled in $CONF ?
if($CONF['vacation'] == 'NO') {
  if ($Admin_Role == 1) {
    header ("Location: list-virtual.php?domain=$fDomain");
  }
  else {
    header ("Location: main.php");
  }
  exit(0);
}
[/code]

Regards,
Jan Kruis


----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-05 22:18

Message:
Some small notes on vacation-3.patch:

edit.vacation.php + users/vacation.php: 
- The fChange and fBack POST variables are only used with empty() - that
means escape_string() is superfluous (but doesn't hurt)
- I don't see a real need for using $Flash_Message - you can use
flash_info()/flash_error() with a $PALANG text directly

vacation.tpl: 
- displaying the mail address in users/ is superfluous IMHO - I'd propose
to wrap this table row in {if !$authentication_has_role.user} ... {/if}

I nevertheless commited your patch to SVN r1163 (without changes to avoid
merge conflicts for you).

About your TODO list:
> - remove entry in the language with are not used any more.

Just tell me which $PALANG texts are no longer needed, I will handle the
changes in *.lang

> - add useremail to flash-message sure for admin if coming back to
> list-virtual.php.

Sounds like a good idea. You can use sprintf() and '%s' in the $PALANG
text to make the text a valid sentense. Feel free to modify the existing
text in the languages you understand. For the others, we can just append
'(%s)' to the text and add a comment to the translators that they should
make the translation nicer. Again, I can help with updating *.lang if you
want - doing this with language-update.sh might be faster than manual
editing.

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-04 13:38

Message:
Translation update commited to SVN r1162.

I'll review the vacation-related parts of your patch tonight.

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 22:02

Message:
Hi Christian,

I have upload new patch.

In this one i replaced eidt-vaction.tpl and user_vacation.tpl with a new
template vacation.tpl
as a frist step to merge the two module into one.

what a like to do is put the of the email for with the vacation is change
into header somethink link

auto response for : us...@do...

as well user setting as for the admin setting.

as you can see i also make a patch voor the languages/nl.lang


If you like the patch sofar  you may commit vacatiion-3.patch

thing i have todo.

- remove entry in the language with are not used any more.
- merge edit-vacation.php and user/vaction.php into one file.
- add useremail to flash-message sure for admin if coming back to
list-virtual.php.

BTW
I had a look a the $smarty->assign remark, and  you were right. It is
change in vacation-3.patch.

if you have any comments or recommendations please let me know

Regards Jan Kruis



----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 22:02

Message:
Hi Christian,

I have upload new patch.

In this one i replaced eidt-vaction.tpl and user_vacation.tpl with a new
template vacation.tpl
as a frist step to merge the two module into one.

what a like to do is put the of the email for with the vacation is change
into header somethink link

auto response for : us...@do...

as well user setting as for the admin setting.

as you can see i also make a patch voor the languages/nl.lang


If you like the patch sofar  you may commit vacatiion-3.patch

thing i have todo.

- remove entry in the language with are not used any more.
- merge edit-vacation.php and user/vaction.php into one file.
- add useremail to flash-message sure for admin if coming back to
list-virtual.php.

BTW
I had a look a the $smarty->assign remark, and  you were right. It is
change in vacation-3.patch.

if you have any comments or recommendations please let me know

Regards Jan Kruis



----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 10:51

Message:
Christian,

In my attempt to merge edit-vacation and user-vacation vacation together
into one file
(meaning to get the preliminary code and  templates as much in sync as
possible to obtain unambiguous)
I noticed something strange.

In the template edit vacation.tpl I particularly "control" and "name"
changed from activeform to fActiveForm.

I open edit-vacation.php through the edit-list-virtual.php window;
everything works well, now I open a second window and open user-vacation
everything this still works well, until I reload window 1 (edit vacation).
Now change the window in the window of user-vacation but call the right
url in the browser, that of  edit-vacation.php (with the right name and
domain).

Could this be the result of my changes of that review, and particularly
name?


Regards, Jan Kruis

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 10:44

Message:
Hi Christian,

dont commit the patch it nown
i upload a second patch with handel the return and removed some unused
code in templates
please have a look and i see up to remarks

i have a look at the $smarty->assign remark

reards jan

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-01 02:23

Message:
I just had a quick look at your patch - looks good :-) - but as usual, I
found "a hair in the soup" (as we germans say) ;-)

In edit-vacation.php, you use (for $tSubject and $tBody)
    $smarty->assign ('tSubject', htmlentities ($tSubject, ENT_QUOTES,
'UTF-8'), false);
You can most probably use this instead:
    $smarty->assign ('tSubject', $tSubject);
(without the "false" as third parameter, $smarty->assign does the
htmlentities() call itsself - see assign() and sanitize() in
smarty.inc.php)
Or did I overlook something?

What's your preferred way to continue? Shall I commit your preliminary
patch to SVN now or should I wait until you provide a non-preliminary
patch? (I'd prefer to commit now, but it's your choice.)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

[ postfixadmin-Patches-3387375 ] create alias as admin

[SourceForge.net <no...@so...>]

Patches item #3387375, was opened at 2011-08-06 21:17
Message generated for change (Tracker Item Submitted) made by jan-kruis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3387375&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: SVN (please specify revision!)
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: J.Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: create alias as admin

Initial Comment:
hi,

If I input an incorrect email alias I get a error which references to an error in the goto feild in the flash error.

Attached a patch that fixes the problem.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3387375&group_id=191583

[ postfixadmin-Bugs-3387020 ] fetchmail edit form: PHP instead of smarty template

[SourceForge.net <no...@so...>]

Bugs item #3387020, was opened at 2011-08-05 23:33
Message generated for change (Tracker Item Submitted) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3387020&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Christian Boltz (christian_boltz)
Assigned to: Nobody/Anonymous (nobody)
Summary: fetchmail edit form: PHP instead of smarty template

Initial Comment:
The whole form to edit a fetchmail entry is produced by fetchmail_edit_row() and  handed over to smarty in a single variable.

On the positive side, the form is produced based on the $fm_struct array.
It should be converted to a generic "edit form" smarty template.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3387020&group_id=191583

[ postfixadmin-Patches-3383236 ] preliminary code to merge vacation

[SourceForge.net <no...@so...>]

Patches item #3383236, was opened at 2011-07-31 14:38
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: SVN (please specify revision!)
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: J.Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: preliminary code to merge  vacation

Initial Comment:
this patch i use to get code in to sync  toget later one template and one code voor edit-vacation and user-vacation

regarde Jan Kruis


----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-05 22:18

Message:
Some small notes on vacation-3.patch:

edit.vacation.php + users/vacation.php: 
- The fChange and fBack POST variables are only used with empty() - that
means escape_string() is superfluous (but doesn't hurt)
- I don't see a real need for using $Flash_Message - you can use
flash_info()/flash_error() with a $PALANG text directly

vacation.tpl: 
- displaying the mail address in users/ is superfluous IMHO - I'd propose
to wrap this table row in {if !$authentication_has_role.user} ... {/if}

I nevertheless commited your patch to SVN r1163 (without changes to avoid
merge conflicts for you).

About your TODO list:
> - remove entry in the language with are not used any more.

Just tell me which $PALANG texts are no longer needed, I will handle the
changes in *.lang

> - add useremail to flash-message sure for admin if coming back to
> list-virtual.php.

Sounds like a good idea. You can use sprintf() and '%s' in the $PALANG
text to make the text a valid sentense. Feel free to modify the existing
text in the languages you understand. For the others, we can just append
'(%s)' to the text and add a comment to the translators that they should
make the translation nicer. Again, I can help with updating *.lang if you
want - doing this with language-update.sh might be faster than manual
editing.

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-04 13:38

Message:
Translation update commited to SVN r1162.

I'll review the vacation-related parts of your patch tonight.

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 22:02

Message:
Hi Christian,

I have upload new patch.

In this one i replaced eidt-vaction.tpl and user_vacation.tpl with a new
template vacation.tpl
as a frist step to merge the two module into one.

what a like to do is put the of the email for with the vacation is change
into header somethink link

auto response for : us...@do...

as well user setting as for the admin setting.

as you can see i also make a patch voor the languages/nl.lang


If you like the patch sofar  you may commit vacatiion-3.patch

thing i have todo.

- remove entry in the language with are not used any more.
- merge edit-vacation.php and user/vaction.php into one file.
- add useremail to flash-message sure for admin if coming back to
list-virtual.php.

BTW
I had a look a the $smarty->assign remark, and  you were right. It is
change in vacation-3.patch.

if you have any comments or recommendations please let me know

Regards Jan Kruis



----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 22:02

Message:
Hi Christian,

I have upload new patch.

In this one i replaced eidt-vaction.tpl and user_vacation.tpl with a new
template vacation.tpl
as a frist step to merge the two module into one.

what a like to do is put the of the email for with the vacation is change
into header somethink link

auto response for : us...@do...

as well user setting as for the admin setting.

as you can see i also make a patch voor the languages/nl.lang


If you like the patch sofar  you may commit vacatiion-3.patch

thing i have todo.

- remove entry in the language with are not used any more.
- merge edit-vacation.php and user/vaction.php into one file.
- add useremail to flash-message sure for admin if coming back to
list-virtual.php.

BTW
I had a look a the $smarty->assign remark, and  you were right. It is
change in vacation-3.patch.

if you have any comments or recommendations please let me know

Regards Jan Kruis



----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 10:51

Message:
Christian,

In my attempt to merge edit-vacation and user-vacation vacation together
into one file
(meaning to get the preliminary code and  templates as much in sync as
possible to obtain unambiguous)
I noticed something strange.

In the template edit vacation.tpl I particularly "control" and "name"
changed from activeform to fActiveForm.

I open edit-vacation.php through the edit-list-virtual.php window;
everything works well, now I open a second window and open user-vacation
everything this still works well, until I reload window 1 (edit vacation).
Now change the window in the window of user-vacation but call the right
url in the browser, that of  edit-vacation.php (with the right name and
domain).

Could this be the result of my changes of that review, and particularly
name?


Regards, Jan Kruis

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 10:44

Message:
Hi Christian,

dont commit the patch it nown
i upload a second patch with handel the return and removed some unused
code in templates
please have a look and i see up to remarks

i have a look at the $smarty->assign remark

reards jan

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-01 02:23

Message:
I just had a quick look at your patch - looks good :-) - but as usual, I
found "a hair in the soup" (as we germans say) ;-)

In edit-vacation.php, you use (for $tSubject and $tBody)
    $smarty->assign ('tSubject', htmlentities ($tSubject, ENT_QUOTES,
'UTF-8'), false);
You can most probably use this instead:
    $smarty->assign ('tSubject', $tSubject);
(without the "false" as third parameter, $smarty->assign does the
htmlentities() call itsself - see assign() and sanitize() in
smarty.inc.php)
Or did I overlook something?

What's your preferred way to continue? Shall I commit your preliminary
patch to SVN now or should I wait until you provide a non-preliminary
patch? (I'd prefer to commit now, but it's your choice.)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

[ postfixadmin-Patches-3383236 ] preliminary code to merge vacation

[SourceForge.net <no...@so...>]

Patches item #3383236, was opened at 2011-07-31 14:38
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: SVN (please specify revision!)
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: J.Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: preliminary code to merge  vacation

Initial Comment:
this patch i use to get code in to sync  toget later one template and one code voor edit-vacation and user-vacation

regarde Jan Kruis


----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-04 13:38

Message:
Translation update commited to SVN r1162.

I'll review the vacation-related parts of your patch tonight.

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 22:02

Message:
Hi Christian,

I have upload new patch.

In this one i replaced eidt-vaction.tpl and user_vacation.tpl with a new
template vacation.tpl
as a frist step to merge the two module into one.

what a like to do is put the of the email for with the vacation is change
into header somethink link

auto response for : us...@do...

as well user setting as for the admin setting.

as you can see i also make a patch voor the languages/nl.lang


If you like the patch sofar  you may commit vacatiion-3.patch

thing i have todo.

- remove entry in the language with are not used any more.
- merge edit-vacation.php and user/vaction.php into one file.
- add useremail to flash-message sure for admin if coming back to
list-virtual.php.

BTW
I had a look a the $smarty->assign remark, and  you were right. It is
change in vacation-3.patch.

if you have any comments or recommendations please let me know

Regards Jan Kruis



----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 22:02

Message:
Hi Christian,

I have upload new patch.

In this one i replaced eidt-vaction.tpl and user_vacation.tpl with a new
template vacation.tpl
as a frist step to merge the two module into one.

what a like to do is put the of the email for with the vacation is change
into header somethink link

auto response for : us...@do...

as well user setting as for the admin setting.

as you can see i also make a patch voor the languages/nl.lang


If you like the patch sofar  you may commit vacatiion-3.patch

thing i have todo.

- remove entry in the language with are not used any more.
- merge edit-vacation.php and user/vaction.php into one file.
- add useremail to flash-message sure for admin if coming back to
list-virtual.php.

BTW
I had a look a the $smarty->assign remark, and  you were right. It is
change in vacation-3.patch.

if you have any comments or recommendations please let me know

Regards Jan Kruis



----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 10:51

Message:
Christian,

In my attempt to merge edit-vacation and user-vacation vacation together
into one file
(meaning to get the preliminary code and  templates as much in sync as
possible to obtain unambiguous)
I noticed something strange.

In the template edit vacation.tpl I particularly "control" and "name"
changed from activeform to fActiveForm.

I open edit-vacation.php through the edit-list-virtual.php window;
everything works well, now I open a second window and open user-vacation
everything this still works well, until I reload window 1 (edit vacation).
Now change the window in the window of user-vacation but call the right
url in the browser, that of  edit-vacation.php (with the right name and
domain).

Could this be the result of my changes of that review, and particularly
name?


Regards, Jan Kruis

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 10:44

Message:
Hi Christian,

dont commit the patch it nown
i upload a second patch with handel the return and removed some unused
code in templates
please have a look and i see up to remarks

i have a look at the $smarty->assign remark

reards jan

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-01 02:23

Message:
I just had a quick look at your patch - looks good :-) - but as usual, I
found "a hair in the soup" (as we germans say) ;-)

In edit-vacation.php, you use (for $tSubject and $tBody)
    $smarty->assign ('tSubject', htmlentities ($tSubject, ENT_QUOTES,
'UTF-8'), false);
You can most probably use this instead:
    $smarty->assign ('tSubject', $tSubject);
(without the "false" as third parameter, $smarty->assign does the
htmlentities() call itsself - see assign() and sanitize() in
smarty.inc.php)
Or did I overlook something?

What's your preferred way to continue? Shall I commit your preliminary
patch to SVN now or should I wait until you provide a non-preliminary
patch? (I'd prefer to commit now, but it's your choice.)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

[ postfixadmin-Bugs-3385499 ] update-check fails - 2.3rc7 is "newer" than 2.3.3

[SourceForge.net <no...@so...>]

Bugs item #3385499, was opened at 2011-08-03 12:34
Message generated for change (Tracker Item Submitted) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3385499&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: SVN (please specify revision!)
Status: Open
Resolution: None
Priority: 7
Private: No
Submitted By: Christian Boltz (christian_boltz)
Assigned to: Nobody/Anonymous (nobody)
Summary: update-check fails - 2.3rc7 is "newer" than 2.3.3

Initial Comment:
reported by simonhobson in http://sourceforge.net/projects/postfixadmin/forums/forum/676076/topic/4635474

However, it looks like the version check is broken.
http://postfixadmin.sourceforge.net/update-check.php?version=2.3%2520rc7 says
"Congratulations - you're running the latest version of PostfixAdmin". It seems
that to the checker, "2.3rc7" and "2.3 rc7" are both >= 2.3.3

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3385499&group_id=191583

[ postfixadmin-Feature Requests-3384953 ] Spam / Sieve Script User Control

[SourceForge.net <no...@so...>]

Feature Requests item #3384953, was opened at 2011-08-02 20:29
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=3384953&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
>Priority: 4
Private: No
Submitted By: Drew (nerddtvg)
Assigned to: Nobody/Anonymous (nobody)
Summary: Spam / Sieve Script User Control

Initial Comment:
I needed the ability to turn on and off a global sieve script depending on a user's option for spam sorting. I have attached the files diffed against release 2.3.3 since the trunk was too different from my live version.

The following was added to the SQL script in Dovecot for the user_query:
IF(spam=1, '/var/vmail/sieve/spam.sieve','') as sieve \

And the following was altered on the table mailbox:
alter table mailbox add column spam tinyint(1) not null default 1 after quota;

The original intent was to have the sieve script name changeable or at least selected from the database (stored per user or in a different table joined in) but I was against the clock and didn't get that join code in place.

This just places a check box on the mailbox create and modify pages enabling and disabling according to their preference. Global option to allow this is in the configuration file, and the default user option to pre-fill forms is as well.

----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-02 22:48

Message:
as I said in #postfixadmin: at the moment I'm not going to implement
additional fields, and plan to change trunk in a way that makes adding
fields very easy. Therefore I'm lowering the priority a bit for now.

Nevertheless: thanks for the patch.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=3384953&group_id=191583

[ postfixadmin-Feature Requests-3384953 ] Spam / Sieve Script User Control

[SourceForge.net <no...@so...>]

Feature Requests item #3384953, was opened at 2011-08-02 13:29
Message generated for change (Tracker Item Submitted) made by nerddtvg
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=3384953&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Drew (nerddtvg)
Assigned to: Nobody/Anonymous (nobody)
Summary: Spam / Sieve Script User Control

Initial Comment:
I needed the ability to turn on and off a global sieve script depending on a user's option for spam sorting. I have attached the files diffed against release 2.3.3 since the trunk was too different from my live version.

The following was added to the SQL script in Dovecot for the user_query:
IF(spam=1, '/var/vmail/sieve/spam.sieve','') as sieve \

And the following was altered on the table mailbox:
alter table mailbox add column spam tinyint(1) not null default 1 after quota;

The original intent was to have the sieve script name changeable or at least selected from the database (stored per user or in a different table joined in) but I was against the clock and didn't get that join code in place.

This just places a check box on the mailbox create and modify pages enabling and disabling according to their preference. Global option to allow this is in the configuration file, and the default user option to pre-fill forms is as well.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=3384953&group_id=191583

[ postfixadmin-Patches-3383236 ] preliminary code to merge vacation

[SourceForge.net <no...@so...>]

Patches item #3383236, was opened at 2011-07-31 14:38
Message generated for change (Comment added) made by jan-kruis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: SVN (please specify revision!)
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: J.Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: preliminary code to merge  vacation

Initial Comment:
this patch i use to get code in to sync  toget later one template and one code voor edit-vacation and user-vacation

regarde Jan Kruis


----------------------------------------------------------------------

>Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 22:02

Message:
Hi Christian,

I have upload new patch.

In this one i replaced eidt-vaction.tpl and user_vacation.tpl with a new
template vacation.tpl
as a frist step to merge the two module into one.

what a like to do is put the of the email for with the vacation is change
into header somethink link

auto response for : us...@do...

as well user setting as for the admin setting.

as you can see i also make a patch voor the languages/nl.lang


If you like the patch sofar  you may commit vacatiion-3.patch

thing i have todo.

- remove entry in the language with are not used any more.
- merge edit-vacation.php and user/vaction.php into one file.
- add useremail to flash-message sure for admin if coming back to
list-virtual.php.

BTW
I had a look a the $smarty->assign remark, and  you were right. It is
change in vacation-3.patch.

if you have any comments or recommendations please let me know

Regards Jan Kruis



----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 22:02

Message:
Hi Christian,

I have upload new patch.

In this one i replaced eidt-vaction.tpl and user_vacation.tpl with a new
template vacation.tpl
as a frist step to merge the two module into one.

what a like to do is put the of the email for with the vacation is change
into header somethink link

auto response for : us...@do...

as well user setting as for the admin setting.

as you can see i also make a patch voor the languages/nl.lang


If you like the patch sofar  you may commit vacatiion-3.patch

thing i have todo.

- remove entry in the language with are not used any more.
- merge edit-vacation.php and user/vaction.php into one file.
- add useremail to flash-message sure for admin if coming back to
list-virtual.php.

BTW
I had a look a the $smarty->assign remark, and  you were right. It is
change in vacation-3.patch.

if you have any comments or recommendations please let me know

Regards Jan Kruis



----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 10:51

Message:
Christian,

In my attempt to merge edit-vacation and user-vacation vacation together
into one file
(meaning to get the preliminary code and  templates as much in sync as
possible to obtain unambiguous)
I noticed something strange.

In the template edit vacation.tpl I particularly "control" and "name"
changed from activeform to fActiveForm.

I open edit-vacation.php through the edit-list-virtual.php window;
everything works well, now I open a second window and open user-vacation
everything this still works well, until I reload window 1 (edit vacation).
Now change the window in the window of user-vacation but call the right
url in the browser, that of  edit-vacation.php (with the right name and
domain).

Could this be the result of my changes of that review, and particularly
name?


Regards, Jan Kruis

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 10:44

Message:
Hi Christian,

dont commit the patch it nown
i upload a second patch with handel the return and removed some unused
code in templates
please have a look and i see up to remarks

i have a look at the $smarty->assign remark

reards jan

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-01 02:23

Message:
I just had a quick look at your patch - looks good :-) - but as usual, I
found "a hair in the soup" (as we germans say) ;-)

In edit-vacation.php, you use (for $tSubject and $tBody)
    $smarty->assign ('tSubject', htmlentities ($tSubject, ENT_QUOTES,
'UTF-8'), false);
You can most probably use this instead:
    $smarty->assign ('tSubject', $tSubject);
(without the "false" as third parameter, $smarty->assign does the
htmlentities() call itsself - see assign() and sanitize() in
smarty.inc.php)
Or did I overlook something?

What's your preferred way to continue? Shall I commit your preliminary
patch to SVN now or should I wait until you provide a non-preliminary
patch? (I'd prefer to commit now, but it's your choice.)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

[ postfixadmin-Patches-3383236 ] preliminary code to merge vacation

[SourceForge.net <no...@so...>]

Patches item #3383236, was opened at 2011-07-31 14:38
Message generated for change (Comment added) made by jan-kruis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: SVN (please specify revision!)
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: J.Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: preliminary code to merge  vacation

Initial Comment:
this patch i use to get code in to sync  toget later one template and one code voor edit-vacation and user-vacation

regarde Jan Kruis


----------------------------------------------------------------------

>Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 22:02

Message:
Hi Christian,

I have upload new patch.

In this one i replaced eidt-vaction.tpl and user_vacation.tpl with a new
template vacation.tpl
as a frist step to merge the two module into one.

what a like to do is put the of the email for with the vacation is change
into header somethink link

auto response for : us...@do...

as well user setting as for the admin setting.

as you can see i also make a patch voor the languages/nl.lang


If you like the patch sofar  you may commit vacatiion-3.patch

thing i have todo.

- remove entry in the language with are not used any more.
- merge edit-vacation.php and user/vaction.php into one file.
- add useremail to flash-message sure for admin if coming back to
list-virtual.php.

BTW
I had a look a the $smarty->assign remark, and  you were right. It is
change in vacation-3.patch.

if you have any comments or recommendations please let me know

Regards Jan Kruis



----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 10:51

Message:
Christian,

In my attempt to merge edit-vacation and user-vacation vacation together
into one file
(meaning to get the preliminary code and  templates as much in sync as
possible to obtain unambiguous)
I noticed something strange.

In the template edit vacation.tpl I particularly "control" and "name"
changed from activeform to fActiveForm.

I open edit-vacation.php through the edit-list-virtual.php window;
everything works well, now I open a second window and open user-vacation
everything this still works well, until I reload window 1 (edit vacation).
Now change the window in the window of user-vacation but call the right
url in the browser, that of  edit-vacation.php (with the right name and
domain).

Could this be the result of my changes of that review, and particularly
name?


Regards, Jan Kruis

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 10:44

Message:
Hi Christian,

dont commit the patch it nown
i upload a second patch with handel the return and removed some unused
code in templates
please have a look and i see up to remarks

i have a look at the $smarty->assign remark

reards jan

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-01 02:23

Message:
I just had a quick look at your patch - looks good :-) - but as usual, I
found "a hair in the soup" (as we germans say) ;-)

In edit-vacation.php, you use (for $tSubject and $tBody)
    $smarty->assign ('tSubject', htmlentities ($tSubject, ENT_QUOTES,
'UTF-8'), false);
You can most probably use this instead:
    $smarty->assign ('tSubject', $tSubject);
(without the "false" as third parameter, $smarty->assign does the
htmlentities() call itsself - see assign() and sanitize() in
smarty.inc.php)
Or did I overlook something?

What's your preferred way to continue? Shall I commit your preliminary
patch to SVN now or should I wait until you provide a non-preliminary
patch? (I'd prefer to commit now, but it's your choice.)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

[ postfixadmin-Patches-3383236 ] preliminary code to merge vacation

[SourceForge.net <no...@so...>]

Patches item #3383236, was opened at 2011-07-31 14:38
Message generated for change (Comment added) made by jan-kruis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: SVN (please specify revision!)
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: J.Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: preliminary code to merge  vacation

Initial Comment:
this patch i use to get code in to sync  toget later one template and one code voor edit-vacation and user-vacation

regarde Jan Kruis


----------------------------------------------------------------------

>Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 10:51

Message:
Christian,

In my attempt to merge edit-vacation and user-vacation vacation together
into one file
(meaning to get the preliminary code and  templates as much in sync as
possible to obtain unambiguous)
I noticed something strange.

In the template edit vacation.tpl I particularly "control" and "name"
changed from activeform to fActiveForm.

I open edit-vacation.php through the edit-list-virtual.php window;
everything works well, now I open a second window and open user-vacation
everything this still works well, until I reload window 1 (edit vacation).
Now change the window in the window of user-vacation but call the right
url in the browser, that of  edit-vacation.php (with the right name and
domain).

Could this be the result of my changes of that review, and particularly
name?


Regards, Jan Kruis

----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 10:44

Message:
Hi Christian,

dont commit the patch it nown
i upload a second patch with handel the return and removed some unused
code in templates
please have a look and i see up to remarks

i have a look at the $smarty->assign remark

reards jan

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-01 02:23

Message:
I just had a quick look at your patch - looks good :-) - but as usual, I
found "a hair in the soup" (as we germans say) ;-)

In edit-vacation.php, you use (for $tSubject and $tBody)
    $smarty->assign ('tSubject', htmlentities ($tSubject, ENT_QUOTES,
'UTF-8'), false);
You can most probably use this instead:
    $smarty->assign ('tSubject', $tSubject);
(without the "false" as third parameter, $smarty->assign does the
htmlentities() call itsself - see assign() and sanitize() in
smarty.inc.php)
Or did I overlook something?

What's your preferred way to continue? Shall I commit your preliminary
patch to SVN now or should I wait until you provide a non-preliminary
patch? (I'd prefer to commit now, but it's your choice.)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

[ postfixadmin-Patches-3383236 ] preliminary code to merge vacation

[SourceForge.net <no...@so...>]

Patches item #3383236, was opened at 2011-07-31 14:38
Message generated for change (Comment added) made by jan-kruis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: SVN (please specify revision!)
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: J.Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: preliminary code to merge  vacation

Initial Comment:
this patch i use to get code in to sync  toget later one template and one code voor edit-vacation and user-vacation

regarde Jan Kruis


----------------------------------------------------------------------

>Comment By: J.Kruis (jan-kruis)
Date: 2011-08-01 10:44

Message:
Hi Christian,

dont commit the patch it nown
i upload a second patch with handel the return and removed some unused
code in templates
please have a look and i see up to remarks

i have a look at the $smarty->assign remark

reards jan

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-01 02:23

Message:
I just had a quick look at your patch - looks good :-) - but as usual, I
found "a hair in the soup" (as we germans say) ;-)

In edit-vacation.php, you use (for $tSubject and $tBody)
    $smarty->assign ('tSubject', htmlentities ($tSubject, ENT_QUOTES,
'UTF-8'), false);
You can most probably use this instead:
    $smarty->assign ('tSubject', $tSubject);
(without the "false" as third parameter, $smarty->assign does the
htmlentities() call itsself - see assign() and sanitize() in
smarty.inc.php)
Or did I overlook something?

What's your preferred way to continue? Shall I commit your preliminary
patch to SVN now or should I wait until you provide a non-preliminary
patch? (I'd prefer to commit now, but it's your choice.)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

[ postfixadmin-Patches-3383236 ] preliminary code to merge vacation

[SourceForge.net <no...@so...>]

Patches item #3383236, was opened at 2011-07-31 14:38
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: SVN (please specify revision!)
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: J.Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: preliminary code to merge  vacation

Initial Comment:
this patch i use to get code in to sync  toget later one template and one code voor edit-vacation and user-vacation

regarde Jan Kruis


----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2011-08-01 02:23

Message:
I just had a quick look at your patch - looks good :-) - but as usual, I
found "a hair in the soup" (as we germans say) ;-)

In edit-vacation.php, you use (for $tSubject and $tBody)
    $smarty->assign ('tSubject', htmlentities ($tSubject, ENT_QUOTES,
'UTF-8'), false);
You can most probably use this instead:
    $smarty->assign ('tSubject', $tSubject);
(without the "false" as third parameter, $smarty->assign does the
htmlentities() call itsself - see assign() and sanitize() in
smarty.inc.php)
Or did I overlook something?

What's your preferred way to continue? Shall I commit your preliminary
patch to SVN now or should I wait until you provide a non-preliminary
patch? (I'd prefer to commit now, but it's your choice.)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583

[ postfixadmin-Patches-2856577 ] Add domain quota in addition to max mailbox size

[SourceForge.net <no...@so...>]

Patches item #2856577, was opened at 2009-09-11 03:11
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2856577&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: None
Status: Closed
Resolution: Duplicate
Priority: 5
Private: No
Submitted By: wvolz (wvolz)
Assigned to: Nobody/Anonymous (nobody)
Summary: Add domain quota in addition to max mailbox size

Initial Comment:
This patch changes the behavior of the domain quota from per mailbox to per domain. Users are shown how much they have to allocate between mailboxes when editing and creating new mailboxes. The only change needed is a flag to enable this behavior.

----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2011-07-31 22:37

Message:
I just implemented a function allowed_quota() in SVN trunk r1156 based on
your changes for edit-mailbox.php, but with some simplifications and fixes.

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-04-19 22:52

Message:
You might be surprised about the resolution "duplicte", but there was
indeed another patch that implements the same functionality - see
https://sourceforge.net/tracker/index.php?func=detail&aid=2974928&group_id=191583&atid=937966

Domain quota support is available in the latest SVN trunk (r1045).

The only small detail that is still missing is displaying the remaining
available quota (similar to what you do in edit-mailbox). I have that on my
TODO list.

----------------------------------------------------------------------

Comment By: wvolz (wvolz)
Date: 2009-10-18 09:28

Message:
New patch. This version of the previous patch adds the ability to set a
maximum mailbox size and/or a domain quota. You can also have combinations
of the two.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2856577&group_id=191583