postfixadmin-tracker — Postfix Admin tracker notification - READ ONLY!

[ postfixadmin-Bugs-2778592 ] Invalid query when sending broadcast message

[SourceForge.net <no...@so...>]

Bugs item #2778592, was opened at 2009-04-22 13:09
Message generated for change (Comment added) made by gingerdog
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2778592&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: v 2.3
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: ryanklein (ryanklein)
Assigned to: Nobody/Anonymous (nobody)
Summary: Invalid query when sending broadcast message

Initial Comment:
I ran into a bug when trying out the broadcast message. The debug information was: 

Invalid query: Table 'postfix2.mailbox' doesn't exist

It appears as if the table name is hard coded and not using the variable name, which I changed. I am using version 2.3rc4.

----------------------------------------------------------------------

>Comment By: GingerDog (gingerdog)
Date: 2009-04-22 14:59

Message:
fixed in changeset 643; thanks for reporting this.

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2009-04-22 14:59

Message:
Thanks for the bug report; we believe this has been fixed in subversion.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2778592&group_id=191583

[ postfixadmin-Bugs-2778592 ] Invalid query when sending broadcast message

[SourceForge.net <no...@so...>]

Bugs item #2778592, was opened at 2009-04-22 08:09
Message generated for change (Tracker Item Submitted) made by ryanklein
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2778592&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: v 2.3
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: ryanklein (ryanklein)
Assigned to: Nobody/Anonymous (nobody)
Summary: Invalid query when sending broadcast message

Initial Comment:
I ran into a bug when trying out the broadcast message. The debug information was: 

Invalid query: Table 'postfix2.mailbox' doesn't exist

It appears as if the table name is hard coded and not using the variable name, which I changed. I am using version 2.3rc4.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2778592&group_id=191583

[ postfixadmin-Patches-2721439 ] use vacation.pl for multiple choice of reply

[SourceForge.net <no...@so...>]

Patches item #2721439, was opened at 2009-03-30 01:07
Message generated for change (Comment added) made by jan-kruis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2721439&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jan Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: use vacation.pl for multiple  choice of reply

Initial Comment:
adding choice of reply 
-type of reply is store in table vacation  in new record type
-delay between reply is store in table vacation in new record delay

choice of reply
 -once
 -autoreply
 - interval reply

Choice can be set by admin or user ( only by pfa not by squirrelmail)
option is controle by config.inc.php



 

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-20 19:34

Message:
Hi Guys,

Oops !
There was a bug in the pfa-diff-090419 file.
hereby a new pathfle pfa-diff-090420

Jan Kruis 

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-20 01:30

Message:
Hi David,

I have uploaded two files 

- pfa-diff-090419.php  
- postfix_mysql_dump

the first file is the patch file
the seconfd file is mine database postfixadmin  (mysql style)

BTW saw you note to late about $Id
please also check my engilsh if you could

regardes
Jan Kruis

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2009-04-19 00:10

Message:
For the database changes, you have two options:

a) perfect:
add an upgrade function to upgrade.php that does the needed ALTER TABLE
queries (upgrade.php has enough examples ;-)  (you can use any function
number you want - I'll set it to the correct value on commit)

b) easy:
describe what database changes are needed, for example:
# additional fields for vacation table:
#       `vacation_interval` int(10) NOT NULL default '0',
You can take these lines from a sql dump. GingerDog or I can then write
the needed function in upgrade.php.

If you add fields containing text, please choose the charset carefully:
- latin1 (aka iso-8859-1) if the field is guaranteed to contain ascii
chars only (like mail adresses)
- utf-8 if the field can contain any text (like user comments, vacation
message etc.)

BTW: please don't modify the lines containing $Id manually. They are
automatically maintained by svn.

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-18 09:34

Message:
Hi David

Thx for the info.

But how abaut the records i add to the table in the database

Jan

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2009-04-18 09:04

Message:
Hi Jan,

Yes - you can edit diff/patch files - just try and make sure it remains
valid.
Your diff file _should_ contain the new files as well - if it doesn't, try
doing 'svn add file.php' and try and re-create the diff then.

Thanks for the hard work :)
David.

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-18 02:06

Message:
Hi guys,

I think it ready. I will test it for two more days.

A question.

I have given the command svn diff  > diff_file  to generate a path file
but can I edit this file, to leave out my config.inc.php stuff out.
and who must i send the new 2 php to your which i added to this project.
(just a patchs)
which are edit-userscontrol-domain.php and templates/vacation.php

also what kind of file do you need for de modifaction in the database
table.


my svn version is 629 at this moment.

Regrads Jan Kruis





----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-13 21:33

Message:
I will try to implement this request



----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-04-13 13:03

Message:
> Making the reply-interval configurable per user is a good feature and
will
> be merged after the 2.3 release.

Will there be an Admin option to disallow Users from setting/changing this
interval if desired?

Many sites (mine for one) will want to set this policy site-wide...

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2009-04-13 12:08

Message:
I only had a very quick look on your changes. Some notes:

Making the reply-interval configurable per user is a good feature and will
be merged after the 2.3 release.

Merging the vacation template for users and admins into one file is also a
good idea.

Vacation start and stop date is indeed a different feature. I'd say it
should be implemented after merging your changes (to avoid merge
conflicts).

We once used *.tpl for the template files and switched to *.php to make
the PHP code inaccessible from the outside. (*.tpl can usually be
downloaded as plain text.)

Finally a question: Which version (or SVN revision) of postfixadmin did
you use as base for your changes? 
Knowing this would make merging easier - however if you don't remember, I
can reconstruct it from the $Id lines in the files. (It would be even
better if you can provide a patch instead of the changed files. If you did
your changes against a SVN checkout, just run "svn diff".)

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-07 22:08

Message:
hi,

I have a question ? Because in your earlier replay you have told

	I'll see if I can find the discussion(s), and create a formal enhancement
	request to track it.
 

What happens with this modification ?

Will it be used or ... ?


These are actually two modifications:

modification 1

 To reduce the two templates for setting the vacation edit-vacation.php
and user-vacation.php to only one vacation.php which checks from which
module ( admin or user) it is called. Because the two older templates did
use a lot of same code.


modification 2

Adding the option to make a choice of reply.
If the choice is once it act as vacation normale should work.
If the choice is autoreply there is a value in config.inc.php which set
the delay time between two emails from one sender to prevent the
vacation.pl from replaying from a possible autoreplay email. 

The admin as well as the user can make the choice of replay. Depending on
the settings in the config file. 

in the table vacation i add two records type and delay and in the table
vacation-notification i add the record notified_at.


In the config.inc.php file you can set these options

allow or not the multiple-choice or reply
allow or not the multiple-choice or reply for users










----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-03-30 23:50

Message:
Hi Guys,

Hmmm... I'm confused too


I know I recall discussion a while back about some new functionality, that
would not only allow the user to set the frequency, but would allow the
Admin from PREVENTING users from doing this, if the Site had a certain
policy they wanted to enforce site-wide.   ===> See  function vacation &
use of config.inc.php

Did this get lost?

Also, I think in the same discussion, we talked about the possibility of
setting Start/Stop dates, so you could actually schedule your vacation
message ahead of time and have it auto-start/end at the desired times.


what has this to do with this patch


the vacation.php template file can by used by edit-vacation and
user-vacation so only have to modifed one file.
In the config.inc.php file i added some value which give contole over
vacation.php if a user can change type of replay and the time delay.


Regards Jan



----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-03-30 16:14

Message:
Ok, thanks, good to know I'm not going senile! ;)

I'll see if I can find the discussion(s), and create a formal enhancement
request to track it.

Thanks!

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2009-03-30 14:32

Message:
libertytrek - yes, I vaguely remember such conversations; I'm happy to
merge such features once 2.3 is out.

(Speaking of which it's probably time for another rc release)

----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-03-30 12:43

Message:
Hmmm... I'm confused.

I know I recall discussion a while back about some new functionality, that
would not only allow the user to set the frequency, but would allow the
Admin from PREVENTING users from doing this, if the Site had a certain
policy they wanted to enforce site-wide.

Did this get lost?

Also, I think in the same discussion, we talked about the possibility of
setting Start/Stop dates, so you could actually schedule your vacation
message ahead of time and have it auto-start/end at the desired times.

Or am I just crazy?

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-03-30 01:19

Message:
edit-vacation.php and user/vacation.php use the new template/vacation.php

BTW
is it a idea to change the extensie to tpl for the template file ( we noe
have two vacation.php file ??)

regrades Jan Kruis

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2721439&group_id=191583

[ postfixadmin-Patches-2721439 ] use vacation.pl for multiple choice of reply

[SourceForge.net <no...@so...>]

Patches item #2721439, was opened at 2009-03-30 01:07
Message generated for change (Comment added) made by jan-kruis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2721439&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jan Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: use vacation.pl for multiple  choice of reply

Initial Comment:
adding choice of reply 
-type of reply is store in table vacation  in new record type
-delay between reply is store in table vacation in new record delay

choice of reply
 -once
 -autoreply
 - interval reply

Choice can be set by admin or user ( only by pfa not by squirrelmail)
option is controle by config.inc.php



 

----------------------------------------------------------------------

>Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-20 01:30

Message:
Hi David,

I have uploaded two files 

- pfa-diff-090419.php  
- postfix_mysql_dump

the first file is the patch file
the seconfd file is mine database postfixadmin  (mysql style)

BTW saw you note to late about $Id
please also check my engilsh if you could

regardes
Jan Kruis

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2009-04-19 00:10

Message:
For the database changes, you have two options:

a) perfect:
add an upgrade function to upgrade.php that does the needed ALTER TABLE
queries (upgrade.php has enough examples ;-)  (you can use any function
number you want - I'll set it to the correct value on commit)

b) easy:
describe what database changes are needed, for example:
# additional fields for vacation table:
#       `vacation_interval` int(10) NOT NULL default '0',
You can take these lines from a sql dump. GingerDog or I can then write
the needed function in upgrade.php.

If you add fields containing text, please choose the charset carefully:
- latin1 (aka iso-8859-1) if the field is guaranteed to contain ascii
chars only (like mail adresses)
- utf-8 if the field can contain any text (like user comments, vacation
message etc.)

BTW: please don't modify the lines containing $Id manually. They are
automatically maintained by svn.

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-18 09:34

Message:
Hi David

Thx for the info.

But how abaut the records i add to the table in the database

Jan

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2009-04-18 09:04

Message:
Hi Jan,

Yes - you can edit diff/patch files - just try and make sure it remains
valid.
Your diff file _should_ contain the new files as well - if it doesn't, try
doing 'svn add file.php' and try and re-create the diff then.

Thanks for the hard work :)
David.

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-18 02:06

Message:
Hi guys,

I think it ready. I will test it for two more days.

A question.

I have given the command svn diff  > diff_file  to generate a path file
but can I edit this file, to leave out my config.inc.php stuff out.
and who must i send the new 2 php to your which i added to this project.
(just a patchs)
which are edit-userscontrol-domain.php and templates/vacation.php

also what kind of file do you need for de modifaction in the database
table.


my svn version is 629 at this moment.

Regrads Jan Kruis





----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-13 21:33

Message:
I will try to implement this request



----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-04-13 13:03

Message:
> Making the reply-interval configurable per user is a good feature and
will
> be merged after the 2.3 release.

Will there be an Admin option to disallow Users from setting/changing this
interval if desired?

Many sites (mine for one) will want to set this policy site-wide...

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2009-04-13 12:08

Message:
I only had a very quick look on your changes. Some notes:

Making the reply-interval configurable per user is a good feature and will
be merged after the 2.3 release.

Merging the vacation template for users and admins into one file is also a
good idea.

Vacation start and stop date is indeed a different feature. I'd say it
should be implemented after merging your changes (to avoid merge
conflicts).

We once used *.tpl for the template files and switched to *.php to make
the PHP code inaccessible from the outside. (*.tpl can usually be
downloaded as plain text.)

Finally a question: Which version (or SVN revision) of postfixadmin did
you use as base for your changes? 
Knowing this would make merging easier - however if you don't remember, I
can reconstruct it from the $Id lines in the files. (It would be even
better if you can provide a patch instead of the changed files. If you did
your changes against a SVN checkout, just run "svn diff".)

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-07 22:08

Message:
hi,

I have a question ? Because in your earlier replay you have told

	I'll see if I can find the discussion(s), and create a formal enhancement
	request to track it.
 

What happens with this modification ?

Will it be used or ... ?


These are actually two modifications:

modification 1

 To reduce the two templates for setting the vacation edit-vacation.php
and user-vacation.php to only one vacation.php which checks from which
module ( admin or user) it is called. Because the two older templates did
use a lot of same code.


modification 2

Adding the option to make a choice of reply.
If the choice is once it act as vacation normale should work.
If the choice is autoreply there is a value in config.inc.php which set
the delay time between two emails from one sender to prevent the
vacation.pl from replaying from a possible autoreplay email. 

The admin as well as the user can make the choice of replay. Depending on
the settings in the config file. 

in the table vacation i add two records type and delay and in the table
vacation-notification i add the record notified_at.


In the config.inc.php file you can set these options

allow or not the multiple-choice or reply
allow or not the multiple-choice or reply for users










----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-03-30 23:50

Message:
Hi Guys,

Hmmm... I'm confused too


I know I recall discussion a while back about some new functionality, that
would not only allow the user to set the frequency, but would allow the
Admin from PREVENTING users from doing this, if the Site had a certain
policy they wanted to enforce site-wide.   ===> See  function vacation &
use of config.inc.php

Did this get lost?

Also, I think in the same discussion, we talked about the possibility of
setting Start/Stop dates, so you could actually schedule your vacation
message ahead of time and have it auto-start/end at the desired times.


what has this to do with this patch


the vacation.php template file can by used by edit-vacation and
user-vacation so only have to modifed one file.
In the config.inc.php file i added some value which give contole over
vacation.php if a user can change type of replay and the time delay.


Regards Jan



----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-03-30 16:14

Message:
Ok, thanks, good to know I'm not going senile! ;)

I'll see if I can find the discussion(s), and create a formal enhancement
request to track it.

Thanks!

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2009-03-30 14:32

Message:
libertytrek - yes, I vaguely remember such conversations; I'm happy to
merge such features once 2.3 is out.

(Speaking of which it's probably time for another rc release)

----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-03-30 12:43

Message:
Hmmm... I'm confused.

I know I recall discussion a while back about some new functionality, that
would not only allow the user to set the frequency, but would allow the
Admin from PREVENTING users from doing this, if the Site had a certain
policy they wanted to enforce site-wide.

Did this get lost?

Also, I think in the same discussion, we talked about the possibility of
setting Start/Stop dates, so you could actually schedule your vacation
message ahead of time and have it auto-start/end at the desired times.

Or am I just crazy?

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-03-30 01:19

Message:
edit-vacation.php and user/vacation.php use the new template/vacation.php

BTW
is it a idea to change the extensie to tpl for the template file ( we noe
have two vacation.php file ??)

regrades Jan Kruis

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2721439&group_id=191583

[ postfixadmin-Patches-2773238 ] Updated nb.lang

[SourceForge.net <no...@so...>]

Patches item #2773238, was opened at 2009-04-19 00:32
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2773238&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Languages
Group: SVN (please specify revision!)
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Odd Henriksen (oddhenriksen)
Assigned to: Nobody/Anonymous (nobody)
Summary: Updated nb.lang

Initial Comment:
Updated nb.lang with improvements and new strings. This patch is a diff against the current nb.lang in trunk (revision 634).

----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2009-04-19 13:44

Message:
Thanks!

Submitted to SVN r636.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2773238&group_id=191583

[ postfixadmin-Patches-2773238 ] Updated nb.lang

[SourceForge.net <no...@so...>]

Patches item #2773238, was opened at 2009-04-19 00:32
Message generated for change (Tracker Item Submitted) made by oddhenriksen
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2773238&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Languages
Group: SVN (please specify revision!)
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Odd Henriksen (oddhenriksen)
Assigned to: Nobody/Anonymous (nobody)
Summary: Updated nb.lang

Initial Comment:
Updated nb.lang with improvements and new strings. This patch is a diff against the current nb.lang in trunk (revision 634).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2773238&group_id=191583

[ postfixadmin-Patches-2721439 ] use vacation.pl for multiple choice of reply

[SourceForge.net <no...@so...>]

Patches item #2721439, was opened at 2009-03-30 01:07
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2721439&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jan Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: use vacation.pl for multiple  choice of reply

Initial Comment:
adding choice of reply 
-type of reply is store in table vacation  in new record type
-delay between reply is store in table vacation in new record delay

choice of reply
 -once
 -autoreply
 - interval reply

Choice can be set by admin or user ( only by pfa not by squirrelmail)
option is controle by config.inc.php



 

----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2009-04-19 00:10

Message:
For the database changes, you have two options:

a) perfect:
add an upgrade function to upgrade.php that does the needed ALTER TABLE
queries (upgrade.php has enough examples ;-)  (you can use any function
number you want - I'll set it to the correct value on commit)

b) easy:
describe what database changes are needed, for example:
# additional fields for vacation table:
#       `vacation_interval` int(10) NOT NULL default '0',
You can take these lines from a sql dump. GingerDog or I can then write
the needed function in upgrade.php.

If you add fields containing text, please choose the charset carefully:
- latin1 (aka iso-8859-1) if the field is guaranteed to contain ascii
chars only (like mail adresses)
- utf-8 if the field can contain any text (like user comments, vacation
message etc.)

BTW: please don't modify the lines containing $Id manually. They are
automatically maintained by svn.

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-18 09:34

Message:
Hi David

Thx for the info.

But how abaut the records i add to the table in the database

Jan

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2009-04-18 09:04

Message:
Hi Jan,

Yes - you can edit diff/patch files - just try and make sure it remains
valid.
Your diff file _should_ contain the new files as well - if it doesn't, try
doing 'svn add file.php' and try and re-create the diff then.

Thanks for the hard work :)
David.

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-18 02:06

Message:
Hi guys,

I think it ready. I will test it for two more days.

A question.

I have given the command svn diff  > diff_file  to generate a path file
but can I edit this file, to leave out my config.inc.php stuff out.
and who must i send the new 2 php to your which i added to this project.
(just a patchs)
which are edit-userscontrol-domain.php and templates/vacation.php

also what kind of file do you need for de modifaction in the database
table.


my svn version is 629 at this moment.

Regrads Jan Kruis





----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-13 21:33

Message:
I will try to implement this request



----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-04-13 13:03

Message:
> Making the reply-interval configurable per user is a good feature and
will
> be merged after the 2.3 release.

Will there be an Admin option to disallow Users from setting/changing this
interval if desired?

Many sites (mine for one) will want to set this policy site-wide...

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2009-04-13 12:08

Message:
I only had a very quick look on your changes. Some notes:

Making the reply-interval configurable per user is a good feature and will
be merged after the 2.3 release.

Merging the vacation template for users and admins into one file is also a
good idea.

Vacation start and stop date is indeed a different feature. I'd say it
should be implemented after merging your changes (to avoid merge
conflicts).

We once used *.tpl for the template files and switched to *.php to make
the PHP code inaccessible from the outside. (*.tpl can usually be
downloaded as plain text.)

Finally a question: Which version (or SVN revision) of postfixadmin did
you use as base for your changes? 
Knowing this would make merging easier - however if you don't remember, I
can reconstruct it from the $Id lines in the files. (It would be even
better if you can provide a patch instead of the changed files. If you did
your changes against a SVN checkout, just run "svn diff".)

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-07 22:08

Message:
hi,

I have a question ? Because in your earlier replay you have told

	I'll see if I can find the discussion(s), and create a formal enhancement
	request to track it.
 

What happens with this modification ?

Will it be used or ... ?


These are actually two modifications:

modification 1

 To reduce the two templates for setting the vacation edit-vacation.php
and user-vacation.php to only one vacation.php which checks from which
module ( admin or user) it is called. Because the two older templates did
use a lot of same code.


modification 2

Adding the option to make a choice of reply.
If the choice is once it act as vacation normale should work.
If the choice is autoreply there is a value in config.inc.php which set
the delay time between two emails from one sender to prevent the
vacation.pl from replaying from a possible autoreplay email. 

The admin as well as the user can make the choice of replay. Depending on
the settings in the config file. 

in the table vacation i add two records type and delay and in the table
vacation-notification i add the record notified_at.


In the config.inc.php file you can set these options

allow or not the multiple-choice or reply
allow or not the multiple-choice or reply for users










----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-03-30 23:50

Message:
Hi Guys,

Hmmm... I'm confused too


I know I recall discussion a while back about some new functionality, that
would not only allow the user to set the frequency, but would allow the
Admin from PREVENTING users from doing this, if the Site had a certain
policy they wanted to enforce site-wide.   ===> See  function vacation &
use of config.inc.php

Did this get lost?

Also, I think in the same discussion, we talked about the possibility of
setting Start/Stop dates, so you could actually schedule your vacation
message ahead of time and have it auto-start/end at the desired times.


what has this to do with this patch


the vacation.php template file can by used by edit-vacation and
user-vacation so only have to modifed one file.
In the config.inc.php file i added some value which give contole over
vacation.php if a user can change type of replay and the time delay.


Regards Jan



----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-03-30 16:14

Message:
Ok, thanks, good to know I'm not going senile! ;)

I'll see if I can find the discussion(s), and create a formal enhancement
request to track it.

Thanks!

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2009-03-30 14:32

Message:
libertytrek - yes, I vaguely remember such conversations; I'm happy to
merge such features once 2.3 is out.

(Speaking of which it's probably time for another rc release)

----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-03-30 12:43

Message:
Hmmm... I'm confused.

I know I recall discussion a while back about some new functionality, that
would not only allow the user to set the frequency, but would allow the
Admin from PREVENTING users from doing this, if the Site had a certain
policy they wanted to enforce site-wide.

Did this get lost?

Also, I think in the same discussion, we talked about the possibility of
setting Start/Stop dates, so you could actually schedule your vacation
message ahead of time and have it auto-start/end at the desired times.

Or am I just crazy?

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-03-30 01:19

Message:
edit-vacation.php and user/vacation.php use the new template/vacation.php

BTW
is it a idea to change the extensie to tpl for the template file ( we noe
have two vacation.php file ??)

regrades Jan Kruis

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2721439&group_id=191583

[ postfixadmin-Feature Requests-2765721 ] Add 'create_mailbox_flat'

[SourceForge.net <no...@so...>]

Feature Requests item #2765721, was opened at 2009-04-15 17:21
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=2765721&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: None
>Status: Pending
>Resolution: Out of Date
Priority: 5
Private: No
Submitted By: Stephan (stephan_r)
Assigned to: Nobody/Anonymous (nobody)
Summary: Add 'create_mailbox_flat'

Initial Comment:
Some people don't like subdirs created under INBOX but would like to have them created on the same level (flat).

Line 1922 in functions.inc.php creates subdirs INBOX/$dir like this:
   $f='{'.$s_host.'}INBOX.'.$f;

There should be an option, so this is done instead:
   if (isset($CONF['create_mailbox_flat']) 
   {
      $f='{'.$s_host.'}'.$f;
   ...

Thanks,
Stephan

----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2009-04-18 23:54

Message:
I guess you use an old(er) version of postfixadmin ;-)

The feature you want is already available in the latest version (since
r446, 2008-08-15) in a more flexible way (by allowing a prefix, which might
be empty in your case). The config parameter for this is
$CONF['create_mailbox_subdirs_prefix'].

Please upgrade to the latest version of postfixadmin. If
$CONF['create_mailbox_subdirs_prefix'] does not solve your problem, please
report back here.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=2765721&group_id=191583

[ postfixadmin-Patches-2721439 ] use vacation.pl for multiple choice of reply

[SourceForge.net <no...@so...>]

Patches item #2721439, was opened at 2009-03-30 01:07
Message generated for change (Comment added) made by jan-kruis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2721439&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jan Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: use vacation.pl for multiple  choice of reply

Initial Comment:
adding choice of reply 
-type of reply is store in table vacation  in new record type
-delay between reply is store in table vacation in new record delay

choice of reply
 -once
 -autoreply
 - interval reply

Choice can be set by admin or user ( only by pfa not by squirrelmail)
option is controle by config.inc.php



 

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-18 09:34

Message:
Hi David

Thx for the info.

But how abaut the records i add to the table in the database

Jan

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2009-04-18 09:04

Message:
Hi Jan,

Yes - you can edit diff/patch files - just try and make sure it remains
valid.
Your diff file _should_ contain the new files as well - if it doesn't, try
doing 'svn add file.php' and try and re-create the diff then.

Thanks for the hard work :)
David.

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-18 02:06

Message:
Hi guys,

I think it ready. I will test it for two more days.

A question.

I have given the command svn diff  > diff_file  to generate a path file
but can I edit this file, to leave out my config.inc.php stuff out.
and who must i send the new 2 php to your which i added to this project.
(just a patchs)
which are edit-userscontrol-domain.php and templates/vacation.php

also what kind of file do you need for de modifaction in the database
table.


my svn version is 629 at this moment.

Regrads Jan Kruis





----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-13 21:33

Message:
I will try to implement this request



----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-04-13 13:03

Message:
> Making the reply-interval configurable per user is a good feature and
will
> be merged after the 2.3 release.

Will there be an Admin option to disallow Users from setting/changing this
interval if desired?

Many sites (mine for one) will want to set this policy site-wide...

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2009-04-13 12:08

Message:
I only had a very quick look on your changes. Some notes:

Making the reply-interval configurable per user is a good feature and will
be merged after the 2.3 release.

Merging the vacation template for users and admins into one file is also a
good idea.

Vacation start and stop date is indeed a different feature. I'd say it
should be implemented after merging your changes (to avoid merge
conflicts).

We once used *.tpl for the template files and switched to *.php to make
the PHP code inaccessible from the outside. (*.tpl can usually be
downloaded as plain text.)

Finally a question: Which version (or SVN revision) of postfixadmin did
you use as base for your changes? 
Knowing this would make merging easier - however if you don't remember, I
can reconstruct it from the $Id lines in the files. (It would be even
better if you can provide a patch instead of the changed files. If you did
your changes against a SVN checkout, just run "svn diff".)

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-07 22:08

Message:
hi,

I have a question ? Because in your earlier replay you have told

	I'll see if I can find the discussion(s), and create a formal enhancement
	request to track it.
 

What happens with this modification ?

Will it be used or ... ?


These are actually two modifications:

modification 1

 To reduce the two templates for setting the vacation edit-vacation.php
and user-vacation.php to only one vacation.php which checks from which
module ( admin or user) it is called. Because the two older templates did
use a lot of same code.


modification 2

Adding the option to make a choice of reply.
If the choice is once it act as vacation normale should work.
If the choice is autoreply there is a value in config.inc.php which set
the delay time between two emails from one sender to prevent the
vacation.pl from replaying from a possible autoreplay email. 

The admin as well as the user can make the choice of replay. Depending on
the settings in the config file. 

in the table vacation i add two records type and delay and in the table
vacation-notification i add the record notified_at.


In the config.inc.php file you can set these options

allow or not the multiple-choice or reply
allow or not the multiple-choice or reply for users










----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-03-30 23:50

Message:
Hi Guys,

Hmmm... I'm confused too


I know I recall discussion a while back about some new functionality, that
would not only allow the user to set the frequency, but would allow the
Admin from PREVENTING users from doing this, if the Site had a certain
policy they wanted to enforce site-wide.   ===> See  function vacation &
use of config.inc.php

Did this get lost?

Also, I think in the same discussion, we talked about the possibility of
setting Start/Stop dates, so you could actually schedule your vacation
message ahead of time and have it auto-start/end at the desired times.


what has this to do with this patch


the vacation.php template file can by used by edit-vacation and
user-vacation so only have to modifed one file.
In the config.inc.php file i added some value which give contole over
vacation.php if a user can change type of replay and the time delay.


Regards Jan



----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-03-30 16:14

Message:
Ok, thanks, good to know I'm not going senile! ;)

I'll see if I can find the discussion(s), and create a formal enhancement
request to track it.

Thanks!

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2009-03-30 14:32

Message:
libertytrek - yes, I vaguely remember such conversations; I'm happy to
merge such features once 2.3 is out.

(Speaking of which it's probably time for another rc release)

----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-03-30 12:43

Message:
Hmmm... I'm confused.

I know I recall discussion a while back about some new functionality, that
would not only allow the user to set the frequency, but would allow the
Admin from PREVENTING users from doing this, if the Site had a certain
policy they wanted to enforce site-wide.

Did this get lost?

Also, I think in the same discussion, we talked about the possibility of
setting Start/Stop dates, so you could actually schedule your vacation
message ahead of time and have it auto-start/end at the desired times.

Or am I just crazy?

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-03-30 01:19

Message:
edit-vacation.php and user/vacation.php use the new template/vacation.php

BTW
is it a idea to change the extensie to tpl for the template file ( we noe
have two vacation.php file ??)

regrades Jan Kruis

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2721439&group_id=191583

[ postfixadmin-Patches-2721439 ] use vacation.pl for multiple choice of reply

[SourceForge.net <no...@so...>]

Patches item #2721439, was opened at 2009-03-29 23:07
Message generated for change (Comment added) made by gingerdog
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2721439&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jan Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: use vacation.pl for multiple  choice of reply

Initial Comment:
adding choice of reply 
-type of reply is store in table vacation  in new record type
-delay between reply is store in table vacation in new record delay

choice of reply
 -once
 -autoreply
 - interval reply

Choice can be set by admin or user ( only by pfa not by squirrelmail)
option is controle by config.inc.php



 

----------------------------------------------------------------------

>Comment By: GingerDog (gingerdog)
Date: 2009-04-18 07:04

Message:
Hi Jan,

Yes - you can edit diff/patch files - just try and make sure it remains
valid.
Your diff file _should_ contain the new files as well - if it doesn't, try
doing 'svn add file.php' and try and re-create the diff then.

Thanks for the hard work :)
David.

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-18 00:06

Message:
Hi guys,

I think it ready. I will test it for two more days.

A question.

I have given the command svn diff  > diff_file  to generate a path file
but can I edit this file, to leave out my config.inc.php stuff out.
and who must i send the new 2 php to your which i added to this project.
(just a patchs)
which are edit-userscontrol-domain.php and templates/vacation.php

also what kind of file do you need for de modifaction in the database
table.


my svn version is 629 at this moment.

Regrads Jan Kruis





----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-13 19:33

Message:
I will try to implement this request



----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-04-13 11:03

Message:
> Making the reply-interval configurable per user is a good feature and
will
> be merged after the 2.3 release.

Will there be an Admin option to disallow Users from setting/changing this
interval if desired?

Many sites (mine for one) will want to set this policy site-wide...

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2009-04-13 10:08

Message:
I only had a very quick look on your changes. Some notes:

Making the reply-interval configurable per user is a good feature and will
be merged after the 2.3 release.

Merging the vacation template for users and admins into one file is also a
good idea.

Vacation start and stop date is indeed a different feature. I'd say it
should be implemented after merging your changes (to avoid merge
conflicts).

We once used *.tpl for the template files and switched to *.php to make
the PHP code inaccessible from the outside. (*.tpl can usually be
downloaded as plain text.)

Finally a question: Which version (or SVN revision) of postfixadmin did
you use as base for your changes? 
Knowing this would make merging easier - however if you don't remember, I
can reconstruct it from the $Id lines in the files. (It would be even
better if you can provide a patch instead of the changed files. If you did
your changes against a SVN checkout, just run "svn diff".)

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-07 20:08

Message:
hi,

I have a question ? Because in your earlier replay you have told

	I'll see if I can find the discussion(s), and create a formal enhancement
	request to track it.
 

What happens with this modification ?

Will it be used or ... ?


These are actually two modifications:

modification 1

 To reduce the two templates for setting the vacation edit-vacation.php
and user-vacation.php to only one vacation.php which checks from which
module ( admin or user) it is called. Because the two older templates did
use a lot of same code.


modification 2

Adding the option to make a choice of reply.
If the choice is once it act as vacation normale should work.
If the choice is autoreply there is a value in config.inc.php which set
the delay time between two emails from one sender to prevent the
vacation.pl from replaying from a possible autoreplay email. 

The admin as well as the user can make the choice of replay. Depending on
the settings in the config file. 

in the table vacation i add two records type and delay and in the table
vacation-notification i add the record notified_at.


In the config.inc.php file you can set these options

allow or not the multiple-choice or reply
allow or not the multiple-choice or reply for users










----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-03-30 21:50

Message:
Hi Guys,

Hmmm... I'm confused too


I know I recall discussion a while back about some new functionality, that
would not only allow the user to set the frequency, but would allow the
Admin from PREVENTING users from doing this, if the Site had a certain
policy they wanted to enforce site-wide.   ===> See  function vacation &
use of config.inc.php

Did this get lost?

Also, I think in the same discussion, we talked about the possibility of
setting Start/Stop dates, so you could actually schedule your vacation
message ahead of time and have it auto-start/end at the desired times.


what has this to do with this patch


the vacation.php template file can by used by edit-vacation and
user-vacation so only have to modifed one file.
In the config.inc.php file i added some value which give contole over
vacation.php if a user can change type of replay and the time delay.


Regards Jan



----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-03-30 14:14

Message:
Ok, thanks, good to know I'm not going senile! ;)

I'll see if I can find the discussion(s), and create a formal enhancement
request to track it.

Thanks!

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2009-03-30 12:32

Message:
libertytrek - yes, I vaguely remember such conversations; I'm happy to
merge such features once 2.3 is out.

(Speaking of which it's probably time for another rc release)

----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-03-30 10:43

Message:
Hmmm... I'm confused.

I know I recall discussion a while back about some new functionality, that
would not only allow the user to set the frequency, but would allow the
Admin from PREVENTING users from doing this, if the Site had a certain
policy they wanted to enforce site-wide.

Did this get lost?

Also, I think in the same discussion, we talked about the possibility of
setting Start/Stop dates, so you could actually schedule your vacation
message ahead of time and have it auto-start/end at the desired times.

Or am I just crazy?

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-03-29 23:19

Message:
edit-vacation.php and user/vacation.php use the new template/vacation.php

BTW
is it a idea to change the extensie to tpl for the template file ( we noe
have two vacation.php file ??)

regrades Jan Kruis

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2721439&group_id=191583

[ postfixadmin-Patches-2711868 ] add smarty capability to Postfixadmin

[SourceForge.net <no...@so...>]

Patches item #2711868, was opened at 2009-03-25 13:54
Message generated for change (Comment added) made by gingerdog
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2711868&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: SVN (please specify revision!)
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Sebastian (sebastian2009)
Assigned to: Nobody/Anonymous (nobody)
Summary: add smarty capability to Postfixadmin

Initial Comment:
This patch introduces the smarty template engine for Postfixadmin. First revision only changes templates for admin functionality, users will follow.

This first revision tries to be as close to the logic as before, therefore the templates are still ugly, but working.

Just apply diff against Postfixadmin 2.3rc2. Patch includes all smarty libraries, so no need to get them separately.

Gunzip and apply in main Postfixadmin directory: "patch -p1 < smarty_patch_rev1.diff"

----------------------------------------------------------------------

>Comment By: GingerDog (gingerdog)
Date: 2009-04-18 07:03

Message:
There is a postfixadmin-smarty branch which contains this patch.

----------------------------------------------------------------------

Comment By: Sebastian (sebastian2009)
Date: 2009-03-25 16:07

Message:
Ok,

here's the patch for all pages including users. Code was indented.

----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-03-25 15:09

Message:
Oh... wait, missed the '+' in Davids comment... whew...

I'm really looking forward to 2.3... lots of good stuff in it...

Thanks guys!

----------------------------------------------------------------------

Comment By: Sebastian (sebastian2009)
Date: 2009-03-25 15:03

Message:
noproblem, it is'nt ready yet. Some additional revs will follow today.

Maybe we can add a branch for this one, as it eases up the merging for
2.3+?

----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-03-25 14:38

Message:
Please don't merge it now... RC stage is NOT the time for stuff like
this...

:)

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2009-03-25 14:27

Message:
Hi,

I'll look into possibly merging this in 2.3+.... If I merge it now, any
2.3 release will be pushed back by at least a month.

I haven't yet had the chance to review the contents of the patch in
detail.... 

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2711868&group_id=191583

[ postfixadmin-Feature Requests-2752992 ] Cracklib support for strong passwords

[SourceForge.net <no...@so...>]

Feature Requests item #2752992, was opened at 2009-04-11 13:24
Message generated for change (Comment added) made by gingerdog
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=2752992&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Charles (libertytrek)
Assigned to: Nobody/Anonymous (nobody)
Summary: Cracklib support for strong passwords

Initial Comment:
I'd love to see support for the use of cracklib, where the Admin can define the password criteria on a per-domain basis, in a simple screen...

Min Length:
Duration:
# of Upper Case characters:
# of Lower Case characters:
# of Number characters:
# of Non-AlphaNumeric characters:
Illegal characters:

Hmmm... duration would also require Cron support I guess... and also the ability to send email notifications (similar to Quota notifications) so the user knows when they need to change it - maybe even with a link to a secure change password page so if they let it expire, they can still go change it without having to call support...

----------------------------------------------------------------------

>Comment By: GingerDog (gingerdog)
Date: 2009-04-18 06:59

Message:
Is there anything else you'd like adding ? :-)

It seems a good idea - and there is http://pecl.php.net/package/crack
which would help somewhat.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=2752992&group_id=191583

[ postfixadmin-Patches-2721439 ] use vacation.pl for multiple choice of reply

[SourceForge.net <no...@so...>]

Patches item #2721439, was opened at 2009-03-30 01:07
Message generated for change (Comment added) made by jan-kruis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2721439&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jan Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: use vacation.pl for multiple  choice of reply

Initial Comment:
adding choice of reply 
-type of reply is store in table vacation  in new record type
-delay between reply is store in table vacation in new record delay

choice of reply
 -once
 -autoreply
 - interval reply

Choice can be set by admin or user ( only by pfa not by squirrelmail)
option is controle by config.inc.php



 

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-18 02:06

Message:
Hi guys,

I think it ready. I will test it for two more days.

A question.

I have given the command svn diff  > diff_file  to generate a path file
but can I edit this file, to leave out my config.inc.php stuff out.
and who must i send the new 2 php to your which i added to this project.
(just a patchs)
which are edit-userscontrol-domain.php and templates/vacation.php

also what kind of file do you need for de modifaction in the database
table.


my svn version is 629 at this moment.

Regrads Jan Kruis





----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-13 21:33

Message:
I will try to implement this request



----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-04-13 13:03

Message:
> Making the reply-interval configurable per user is a good feature and
will
> be merged after the 2.3 release.

Will there be an Admin option to disallow Users from setting/changing this
interval if desired?

Many sites (mine for one) will want to set this policy site-wide...

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2009-04-13 12:08

Message:
I only had a very quick look on your changes. Some notes:

Making the reply-interval configurable per user is a good feature and will
be merged after the 2.3 release.

Merging the vacation template for users and admins into one file is also a
good idea.

Vacation start and stop date is indeed a different feature. I'd say it
should be implemented after merging your changes (to avoid merge
conflicts).

We once used *.tpl for the template files and switched to *.php to make
the PHP code inaccessible from the outside. (*.tpl can usually be
downloaded as plain text.)

Finally a question: Which version (or SVN revision) of postfixadmin did
you use as base for your changes? 
Knowing this would make merging easier - however if you don't remember, I
can reconstruct it from the $Id lines in the files. (It would be even
better if you can provide a patch instead of the changed files. If you did
your changes against a SVN checkout, just run "svn diff".)

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-07 22:08

Message:
hi,

I have a question ? Because in your earlier replay you have told

	I'll see if I can find the discussion(s), and create a formal enhancement
	request to track it.
 

What happens with this modification ?

Will it be used or ... ?


These are actually two modifications:

modification 1

 To reduce the two templates for setting the vacation edit-vacation.php
and user-vacation.php to only one vacation.php which checks from which
module ( admin or user) it is called. Because the two older templates did
use a lot of same code.


modification 2

Adding the option to make a choice of reply.
If the choice is once it act as vacation normale should work.
If the choice is autoreply there is a value in config.inc.php which set
the delay time between two emails from one sender to prevent the
vacation.pl from replaying from a possible autoreplay email. 

The admin as well as the user can make the choice of replay. Depending on
the settings in the config file. 

in the table vacation i add two records type and delay and in the table
vacation-notification i add the record notified_at.


In the config.inc.php file you can set these options

allow or not the multiple-choice or reply
allow or not the multiple-choice or reply for users










----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-03-30 23:50

Message:
Hi Guys,

Hmmm... I'm confused too


I know I recall discussion a while back about some new functionality, that
would not only allow the user to set the frequency, but would allow the
Admin from PREVENTING users from doing this, if the Site had a certain
policy they wanted to enforce site-wide.   ===> See  function vacation &
use of config.inc.php

Did this get lost?

Also, I think in the same discussion, we talked about the possibility of
setting Start/Stop dates, so you could actually schedule your vacation
message ahead of time and have it auto-start/end at the desired times.


what has this to do with this patch


the vacation.php template file can by used by edit-vacation and
user-vacation so only have to modifed one file.
In the config.inc.php file i added some value which give contole over
vacation.php if a user can change type of replay and the time delay.


Regards Jan



----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-03-30 16:14

Message:
Ok, thanks, good to know I'm not going senile! ;)

I'll see if I can find the discussion(s), and create a formal enhancement
request to track it.

Thanks!

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2009-03-30 14:32

Message:
libertytrek - yes, I vaguely remember such conversations; I'm happy to
merge such features once 2.3 is out.

(Speaking of which it's probably time for another rc release)

----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-03-30 12:43

Message:
Hmmm... I'm confused.

I know I recall discussion a while back about some new functionality, that
would not only allow the user to set the frequency, but would allow the
Admin from PREVENTING users from doing this, if the Site had a certain
policy they wanted to enforce site-wide.

Did this get lost?

Also, I think in the same discussion, we talked about the possibility of
setting Start/Stop dates, so you could actually schedule your vacation
message ahead of time and have it auto-start/end at the desired times.

Or am I just crazy?

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-03-30 01:19

Message:
edit-vacation.php and user/vacation.php use the new template/vacation.php

BTW
is it a idea to change the extensie to tpl for the template file ( we noe
have two vacation.php file ??)

regrades Jan Kruis

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2721439&group_id=191583

[ postfixadmin-Feature Requests-2765721 ] Add 'create_mailbox_flat'

[SourceForge.net <no...@so...>]

Feature Requests item #2765721, was opened at 2009-04-15 17:21
Message generated for change (Tracker Item Submitted) made by stephan_r
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=2765721&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Stephan (stephan_r)
Assigned to: Nobody/Anonymous (nobody)
Summary: Add 'create_mailbox_flat'

Initial Comment:
Some people don't like subdirs created under INBOX but would like to have them created on the same level (flat).

Line 1922 in functions.inc.php creates subdirs INBOX/$dir like this:
   $f='{'.$s_host.'}INBOX.'.$f;

There should be an option, so this is done instead:
   if (isset($CONF['create_mailbox_flat']) 
   {
      $f='{'.$s_host.'}'.$f;
   ...

Thanks,
Stephan

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=2765721&group_id=191583

[ postfixadmin-Patches-2721439 ] use vacation.pl for multiple choice of reply

[SourceForge.net <no...@so...>]

Patches item #2721439, was opened at 2009-03-30 01:07
Message generated for change (Comment added) made by jan-kruis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2721439&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jan Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: use vacation.pl for multiple  choice of reply

Initial Comment:
adding choice of reply 
-type of reply is store in table vacation  in new record type
-delay between reply is store in table vacation in new record delay

choice of reply
 -once
 -autoreply
 - interval reply

Choice can be set by admin or user ( only by pfa not by squirrelmail)
option is controle by config.inc.php



 

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-13 21:33

Message:
I will try to implement this request



----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-04-13 13:03

Message:
> Making the reply-interval configurable per user is a good feature and
will
> be merged after the 2.3 release.

Will there be an Admin option to disallow Users from setting/changing this
interval if desired?

Many sites (mine for one) will want to set this policy site-wide...

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2009-04-13 12:08

Message:
I only had a very quick look on your changes. Some notes:

Making the reply-interval configurable per user is a good feature and will
be merged after the 2.3 release.

Merging the vacation template for users and admins into one file is also a
good idea.

Vacation start and stop date is indeed a different feature. I'd say it
should be implemented after merging your changes (to avoid merge
conflicts).

We once used *.tpl for the template files and switched to *.php to make
the PHP code inaccessible from the outside. (*.tpl can usually be
downloaded as plain text.)

Finally a question: Which version (or SVN revision) of postfixadmin did
you use as base for your changes? 
Knowing this would make merging easier - however if you don't remember, I
can reconstruct it from the $Id lines in the files. (It would be even
better if you can provide a patch instead of the changed files. If you did
your changes against a SVN checkout, just run "svn diff".)

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-07 22:08

Message:
hi,

I have a question ? Because in your earlier replay you have told

	I'll see if I can find the discussion(s), and create a formal enhancement
	request to track it.
 

What happens with this modification ?

Will it be used or ... ?


These are actually two modifications:

modification 1

 To reduce the two templates for setting the vacation edit-vacation.php
and user-vacation.php to only one vacation.php which checks from which
module ( admin or user) it is called. Because the two older templates did
use a lot of same code.


modification 2

Adding the option to make a choice of reply.
If the choice is once it act as vacation normale should work.
If the choice is autoreply there is a value in config.inc.php which set
the delay time between two emails from one sender to prevent the
vacation.pl from replaying from a possible autoreplay email. 

The admin as well as the user can make the choice of replay. Depending on
the settings in the config file. 

in the table vacation i add two records type and delay and in the table
vacation-notification i add the record notified_at.


In the config.inc.php file you can set these options

allow or not the multiple-choice or reply
allow or not the multiple-choice or reply for users










----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-03-30 23:50

Message:
Hi Guys,

Hmmm... I'm confused too


I know I recall discussion a while back about some new functionality, that
would not only allow the user to set the frequency, but would allow the
Admin from PREVENTING users from doing this, if the Site had a certain
policy they wanted to enforce site-wide.   ===> See  function vacation &
use of config.inc.php

Did this get lost?

Also, I think in the same discussion, we talked about the possibility of
setting Start/Stop dates, so you could actually schedule your vacation
message ahead of time and have it auto-start/end at the desired times.


what has this to do with this patch


the vacation.php template file can by used by edit-vacation and
user-vacation so only have to modifed one file.
In the config.inc.php file i added some value which give contole over
vacation.php if a user can change type of replay and the time delay.


Regards Jan



----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-03-30 16:14

Message:
Ok, thanks, good to know I'm not going senile! ;)

I'll see if I can find the discussion(s), and create a formal enhancement
request to track it.

Thanks!

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2009-03-30 14:32

Message:
libertytrek - yes, I vaguely remember such conversations; I'm happy to
merge such features once 2.3 is out.

(Speaking of which it's probably time for another rc release)

----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-03-30 12:43

Message:
Hmmm... I'm confused.

I know I recall discussion a while back about some new functionality, that
would not only allow the user to set the frequency, but would allow the
Admin from PREVENTING users from doing this, if the Site had a certain
policy they wanted to enforce site-wide.

Did this get lost?

Also, I think in the same discussion, we talked about the possibility of
setting Start/Stop dates, so you could actually schedule your vacation
message ahead of time and have it auto-start/end at the desired times.

Or am I just crazy?

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-03-30 01:19

Message:
edit-vacation.php and user/vacation.php use the new template/vacation.php

BTW
is it a idea to change the extensie to tpl for the template file ( we noe
have two vacation.php file ??)

regrades Jan Kruis

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2721439&group_id=191583

[ postfixadmin-Bugs-2759134 ] Vacation will not send a reply for aliased mailbox

[SourceForge.net <no...@so...>]

Bugs item #2759134, was opened at 2009-04-13 15:08
Message generated for change (Comment added) made by bazerka
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2759134&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: v 2.3
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jase Thew (bazerka)
Assigned to: Nobody/Anonymous (nobody)
Summary: Vacation will not send a reply for aliased mailbox

Initial Comment:
Vacation.pl - revision 535 with Postfixadmin 2.3-rc3

If you have a mailbox (eg, ma...@do...) which has an alias configured to deliver to it (eg, al...@do... -> ma...@do...) and you then enable vacation for the mailbox, if you send mail to the alias, a reply is not generated and the following is produced in the vacation logfile :

2009/04/13 13:44:38 DEBUG> /var/spool/vacation/vacation.pl:479 main:: - Script argument SMTP recipient is : 'mailbox#dom...@au...' and smtp_sender : 'ro...@ja...'
2009/04/13 13:44:38 DEBUG> /var/spool/vacation/vacation.pl:505 main:: - Converted autoreply mailbox back to normal style - from mailbox#dom...@au... to ma...@do...
2009/04/13 13:44:38 DEBUG> /var/spool/vacation/vacation.pl:516 main:: - Email headers have to: 'al...@do...' and From: 'ro...@ja... (Charlie Root)'
2009/04/13 13:44:38 DEBUG> /var/spool/vacation/vacation.pl:543 main:: - smtp envelope recipient ma...@do... not found in the header recipients (al...@do... & ) (therefore they were bcc'ed, so won't send vacation message)

I believe this to be a bug as a reply should be sent to the sender.


----------------------------------------------------------------------

Comment By: Jase Thew (bazerka)
Date: 2009-04-13 17:43

Message:
Firstly, alias expansion is not the same as BCC - the warning produced in
the log is of the result of a bad BCC check (at least, imo) that also
happens to catch alias expansions. 

Secondly, the previous version of vacation in this scenario would send the
auto response using the mailbox address as sender. So the fact that it
won't reply at all in this scenario with the current version is definitely
a regression.

Finally, sure, I can see the benefit in having alias (as opposed to
mailbox) addresses used for responses as an optional setting, so I don't
disagree with that.

----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-04-13 15:51

Message:
Not replying to senders when the recipient is BCCd is highly desirable...

I can see a Feature Request for allowing vacation message processing to
include aliases, but imo, this is not a bug...

Also, I think it should be optional... I wouldn't want my aliases to
respond with vacation messages...

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2759134&group_id=191583

[ postfixadmin-Bugs-2759134 ] Vacation will not send a reply for aliased mailbox

[SourceForge.net <no...@so...>]

Bugs item #2759134, was opened at 2009-04-13 11:08
Message generated for change (Comment added) made by libertytrek
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2759134&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: v 2.3
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jase Thew (bazerka)
Assigned to: Nobody/Anonymous (nobody)
Summary: Vacation will not send a reply for aliased mailbox

Initial Comment:
Vacation.pl - revision 535 with Postfixadmin 2.3-rc3

If you have a mailbox (eg, ma...@do...) which has an alias configured to deliver to it (eg, al...@do... -> ma...@do...) and you then enable vacation for the mailbox, if you send mail to the alias, a reply is not generated and the following is produced in the vacation logfile :

2009/04/13 13:44:38 DEBUG> /var/spool/vacation/vacation.pl:479 main:: - Script argument SMTP recipient is : 'mailbox#dom...@au...' and smtp_sender : 'ro...@ja...'
2009/04/13 13:44:38 DEBUG> /var/spool/vacation/vacation.pl:505 main:: - Converted autoreply mailbox back to normal style - from mailbox#dom...@au... to ma...@do...
2009/04/13 13:44:38 DEBUG> /var/spool/vacation/vacation.pl:516 main:: - Email headers have to: 'al...@do...' and From: 'ro...@ja... (Charlie Root)'
2009/04/13 13:44:38 DEBUG> /var/spool/vacation/vacation.pl:543 main:: - smtp envelope recipient ma...@do... not found in the header recipients (al...@do... & ) (therefore they were bcc'ed, so won't send vacation message)

I believe this to be a bug as a reply should be sent to the sender.


----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-04-13 11:51

Message:
Not replying to senders when the recipient is BCCd is highly desirable...

I can see a Feature Request for allowing vacation message processing to
include aliases, but imo, this is not a bug...

Also, I think it should be optional... I wouldn't want my aliases to
respond with vacation messages...

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2759134&group_id=191583

[ postfixadmin-Bugs-2759134 ] Vacation will not send a reply for aliased mailbox

[SourceForge.net <no...@so...>]

Bugs item #2759134, was opened at 2009-04-13 15:08
Message generated for change (Tracker Item Submitted) made by bazerka
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2759134&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: v 2.3
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jase Thew (bazerka)
Assigned to: Nobody/Anonymous (nobody)
Summary: Vacation will not send a reply for aliased mailbox

Initial Comment:
Vacation.pl - revision 535 with Postfixadmin 2.3-rc3

If you have a mailbox (eg, ma...@do...) which has an alias configured to deliver to it (eg, al...@do... -> ma...@do...) and you then enable vacation for the mailbox, if you send mail to the alias, a reply is not generated and the following is produced in the vacation logfile :

2009/04/13 13:44:38 DEBUG> /var/spool/vacation/vacation.pl:479 main:: - Script argument SMTP recipient is : 'mailbox#dom...@au...' and smtp_sender : 'ro...@ja...'
2009/04/13 13:44:38 DEBUG> /var/spool/vacation/vacation.pl:505 main:: - Converted autoreply mailbox back to normal style - from mailbox#dom...@au... to ma...@do...
2009/04/13 13:44:38 DEBUG> /var/spool/vacation/vacation.pl:516 main:: - Email headers have to: 'al...@do...' and From: 'ro...@ja... (Charlie Root)'
2009/04/13 13:44:38 DEBUG> /var/spool/vacation/vacation.pl:543 main:: - smtp envelope recipient ma...@do... not found in the header recipients (al...@do... & ) (therefore they were bcc'ed, so won't send vacation message)

I believe this to be a bug as a reply should be sent to the sender.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2759134&group_id=191583

[ postfixadmin-Patches-2721439 ] use vacation.pl for multiple choice of reply

[SourceForge.net <no...@so...>]

Patches item #2721439, was opened at 2009-03-29 19:07
Message generated for change (Comment added) made by libertytrek
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2721439&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jan Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: use vacation.pl for multiple  choice of reply

Initial Comment:
adding choice of reply 
-type of reply is store in table vacation  in new record type
-delay between reply is store in table vacation in new record delay

choice of reply
 -once
 -autoreply
 - interval reply

Choice can be set by admin or user ( only by pfa not by squirrelmail)
option is controle by config.inc.php



 

----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-04-13 07:03

Message:
> Making the reply-interval configurable per user is a good feature and
will
> be merged after the 2.3 release.

Will there be an Admin option to disallow Users from setting/changing this
interval if desired?

Many sites (mine for one) will want to set this policy site-wide...

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2009-04-13 06:08

Message:
I only had a very quick look on your changes. Some notes:

Making the reply-interval configurable per user is a good feature and will
be merged after the 2.3 release.

Merging the vacation template for users and admins into one file is also a
good idea.

Vacation start and stop date is indeed a different feature. I'd say it
should be implemented after merging your changes (to avoid merge
conflicts).

We once used *.tpl for the template files and switched to *.php to make
the PHP code inaccessible from the outside. (*.tpl can usually be
downloaded as plain text.)

Finally a question: Which version (or SVN revision) of postfixadmin did
you use as base for your changes? 
Knowing this would make merging easier - however if you don't remember, I
can reconstruct it from the $Id lines in the files. (It would be even
better if you can provide a patch instead of the changed files. If you did
your changes against a SVN checkout, just run "svn diff".)

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-07 16:08

Message:
hi,

I have a question ? Because in your earlier replay you have told

	I'll see if I can find the discussion(s), and create a formal enhancement
	request to track it.
 

What happens with this modification ?

Will it be used or ... ?


These are actually two modifications:

modification 1

 To reduce the two templates for setting the vacation edit-vacation.php
and user-vacation.php to only one vacation.php which checks from which
module ( admin or user) it is called. Because the two older templates did
use a lot of same code.


modification 2

Adding the option to make a choice of reply.
If the choice is once it act as vacation normale should work.
If the choice is autoreply there is a value in config.inc.php which set
the delay time between two emails from one sender to prevent the
vacation.pl from replaying from a possible autoreplay email. 

The admin as well as the user can make the choice of replay. Depending on
the settings in the config file. 

in the table vacation i add two records type and delay and in the table
vacation-notification i add the record notified_at.


In the config.inc.php file you can set these options

allow or not the multiple-choice or reply
allow or not the multiple-choice or reply for users










----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-03-30 17:50

Message:
Hi Guys,

Hmmm... I'm confused too


I know I recall discussion a while back about some new functionality, that
would not only allow the user to set the frequency, but would allow the
Admin from PREVENTING users from doing this, if the Site had a certain
policy they wanted to enforce site-wide.   ===> See  function vacation &
use of config.inc.php

Did this get lost?

Also, I think in the same discussion, we talked about the possibility of
setting Start/Stop dates, so you could actually schedule your vacation
message ahead of time and have it auto-start/end at the desired times.


what has this to do with this patch


the vacation.php template file can by used by edit-vacation and
user-vacation so only have to modifed one file.
In the config.inc.php file i added some value which give contole over
vacation.php if a user can change type of replay and the time delay.


Regards Jan



----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-03-30 10:14

Message:
Ok, thanks, good to know I'm not going senile! ;)

I'll see if I can find the discussion(s), and create a formal enhancement
request to track it.

Thanks!

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2009-03-30 08:32

Message:
libertytrek - yes, I vaguely remember such conversations; I'm happy to
merge such features once 2.3 is out.

(Speaking of which it's probably time for another rc release)

----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-03-30 06:43

Message:
Hmmm... I'm confused.

I know I recall discussion a while back about some new functionality, that
would not only allow the user to set the frequency, but would allow the
Admin from PREVENTING users from doing this, if the Site had a certain
policy they wanted to enforce site-wide.

Did this get lost?

Also, I think in the same discussion, we talked about the possibility of
setting Start/Stop dates, so you could actually schedule your vacation
message ahead of time and have it auto-start/end at the desired times.

Or am I just crazy?

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-03-29 19:19

Message:
edit-vacation.php and user/vacation.php use the new template/vacation.php

BTW
is it a idea to change the extensie to tpl for the template file ( we noe
have two vacation.php file ??)

regrades Jan Kruis

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2721439&group_id=191583

[ postfixadmin-Patches-2721439 ] use vacation.pl for multiple choice of reply

[SourceForge.net <no...@so...>]

Patches item #2721439, was opened at 2009-03-30 01:07
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2721439&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jan Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: use vacation.pl for multiple  choice of reply

Initial Comment:
adding choice of reply 
-type of reply is store in table vacation  in new record type
-delay between reply is store in table vacation in new record delay

choice of reply
 -once
 -autoreply
 - interval reply

Choice can be set by admin or user ( only by pfa not by squirrelmail)
option is controle by config.inc.php



 

----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2009-04-13 12:08

Message:
I only had a very quick look on your changes. Some notes:

Making the reply-interval configurable per user is a good feature and will
be merged after the 2.3 release.

Merging the vacation template for users and admins into one file is also a
good idea.

Vacation start and stop date is indeed a different feature. I'd say it
should be implemented after merging your changes (to avoid merge
conflicts).

We once used *.tpl for the template files and switched to *.php to make
the PHP code inaccessible from the outside. (*.tpl can usually be
downloaded as plain text.)

Finally a question: Which version (or SVN revision) of postfixadmin did
you use as base for your changes? 
Knowing this would make merging easier - however if you don't remember, I
can reconstruct it from the $Id lines in the files. (It would be even
better if you can provide a patch instead of the changed files. If you did
your changes against a SVN checkout, just run "svn diff".)

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-04-07 22:08

Message:
hi,

I have a question ? Because in your earlier replay you have told

	I'll see if I can find the discussion(s), and create a formal enhancement
	request to track it.
 

What happens with this modification ?

Will it be used or ... ?


These are actually two modifications:

modification 1

 To reduce the two templates for setting the vacation edit-vacation.php
and user-vacation.php to only one vacation.php which checks from which
module ( admin or user) it is called. Because the two older templates did
use a lot of same code.


modification 2

Adding the option to make a choice of reply.
If the choice is once it act as vacation normale should work.
If the choice is autoreply there is a value in config.inc.php which set
the delay time between two emails from one sender to prevent the
vacation.pl from replaying from a possible autoreplay email. 

The admin as well as the user can make the choice of replay. Depending on
the settings in the config file. 

in the table vacation i add two records type and delay and in the table
vacation-notification i add the record notified_at.


In the config.inc.php file you can set these options

allow or not the multiple-choice or reply
allow or not the multiple-choice or reply for users










----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-03-30 23:50

Message:
Hi Guys,

Hmmm... I'm confused too


I know I recall discussion a while back about some new functionality, that
would not only allow the user to set the frequency, but would allow the
Admin from PREVENTING users from doing this, if the Site had a certain
policy they wanted to enforce site-wide.   ===> See  function vacation &
use of config.inc.php

Did this get lost?

Also, I think in the same discussion, we talked about the possibility of
setting Start/Stop dates, so you could actually schedule your vacation
message ahead of time and have it auto-start/end at the desired times.


what has this to do with this patch


the vacation.php template file can by used by edit-vacation and
user-vacation so only have to modifed one file.
In the config.inc.php file i added some value which give contole over
vacation.php if a user can change type of replay and the time delay.


Regards Jan



----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-03-30 16:14

Message:
Ok, thanks, good to know I'm not going senile! ;)

I'll see if I can find the discussion(s), and create a formal enhancement
request to track it.

Thanks!

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2009-03-30 14:32

Message:
libertytrek - yes, I vaguely remember such conversations; I'm happy to
merge such features once 2.3 is out.

(Speaking of which it's probably time for another rc release)

----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-03-30 12:43

Message:
Hmmm... I'm confused.

I know I recall discussion a while back about some new functionality, that
would not only allow the user to set the frequency, but would allow the
Admin from PREVENTING users from doing this, if the Site had a certain
policy they wanted to enforce site-wide.

Did this get lost?

Also, I think in the same discussion, we talked about the possibility of
setting Start/Stop dates, so you could actually schedule your vacation
message ahead of time and have it auto-start/end at the desired times.

Or am I just crazy?

----------------------------------------------------------------------

Comment By: Jan Kruis (jan-kruis)
Date: 2009-03-30 01:19

Message:
edit-vacation.php and user/vacation.php use the new template/vacation.php

BTW
is it a idea to change the extensie to tpl for the template file ( we noe
have two vacation.php file ??)

regrades Jan Kruis

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2721439&group_id=191583

[ postfixadmin-Feature Requests-2752992 ] Cracklib support for strong passwords

[SourceForge.net <no...@so...>]

Feature Requests item #2752992, was opened at 2009-04-11 09:24
Message generated for change (Tracker Item Submitted) made by libertytrek
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=2752992&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Charles (libertytrek)
Assigned to: Nobody/Anonymous (nobody)
Summary: Cracklib support for strong passwords

Initial Comment:
I'd love to see support for the use of cracklib, where the Admin can define the password criteria on a per-domain basis, in a simple screen...

Min Length:
Duration:
# of Upper Case characters:
# of Lower Case characters:
# of Number characters:
# of Non-AlphaNumeric characters:
Illegal characters:

Hmmm... duration would also require Cron support I guess... and also the ability to send email notifications (similar to Quota notifications) so the user knows when they need to change it - maybe even with a link to a secure change password page so if they let it expire, they can still go change it without having to call support...

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=2752992&group_id=191583

[ postfixadmin-Feature Requests-2752945 ] Add Cron support

[SourceForge.net <no...@so...>]

Feature Requests item #2752945, was opened at 2009-04-11 09:07
Message generated for change (Tracker Item Submitted) made by libertytrek
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=2752945&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Charles (libertytrek)
Assigned to: Nobody/Anonymous (nobody)
Summary: Add Cron support

Initial Comment:
Adding cron support to postfixadmin opens up a lot of possibilities that would otherwise be either very difficult (for non-programmers) or impossible...

Two examples come to mind...

1. Add Start and Stop times to vacation messages, as discussed in this thread:

https://sourceforge.net/forum/message.php?msg_id=4927836

and

2. Add 'Active' time periods for certain aliases, as described here:

https://sourceforge.net/forum/message.php?msg_id=5224199

Of course, to prevent misuse, there should be some kind of hard limit on how often the cron jobs will need to run - like, say, maybe once every half hour...

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=2752945&group_id=191583

[ postfixadmin-Feature Requests-1957803 ] Automatic vacation end date

[SourceForge.net <no...@so...>]

Feature Requests item #1957803, was opened at 2008-05-05 04:10
Message generated for change (Comment added) made by libertytrek
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=1957803&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Mantas Bantas (mantoze)
Assigned to: Nobody/Anonymous (nobody)
Summary: Automatic vacation end date

Initial Comment:
How about automatic vacation end date?

----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-04-11 08:45

Message:
I like this idea, but since some kind of cron job will be necessary for
this, why not extend it a bit to include both a Start *and* End date?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=1957803&group_id=191583

[ postfixadmin-Bugs-2661366 ] add parameter to disable alias magic

[SourceForge.net <no...@so...>]

Bugs item #2661366, was opened at 2009-03-04 15:12
Message generated for change (Comment added) made by olfway
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2661366&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 4
Private: No
Submitted By: Pavel Volkovitskiy (olfway)
Assigned to: Nobody/Anonymous (nobody)
Summary: add parameter to disable alias magic

Initial Comment:
not everyone needs to have alias for every mailbox, so there should be a way to disable automagically alias creating


----------------------------------------------------------------------

>Comment By: Pavel Volkovitskiy (olfway)
Date: 2009-04-10 16:59

Message:
any chances of getting rid of such aliases after 2.3 release?

----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-04-10 16:03

Message:
Hopefully we can all agree that, since this will add more complexity, it
should most *definitely* *not* be added until after 2.3 is released...

:)

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2009-04-10 11:20

Message:
I'm not (yet) in favour of this - my money is on leaving it as it is.

----------------------------------------------------------------------

Comment By: Pavel Volkovitskiy (olfway)
Date: 2009-04-10 02:10

Message:
select username from mailbox where domain = 'domain.tld' union select
address from alias where domain = 'domain.tld';

that's tricky?

----------------------------------------------------------------------

Comment By: Pavel Volkovitskiy (olfway)
Date: 2009-04-10 02:01

Message:
you can use sql 'union' to merge selects from mailbox and alias table
select a from t1 union select a from t2 (can be wrong in details, but it's
easy and not tricky at all)

one simple selects union vs magic "if removing alias, also removing
mailbox, real_alias, force_delete" - union clearly wins imho

real word problem:
i had to restore mailbox once, after i removed alias and postfixadmin
removes mailbox just in case

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2009-04-10 01:52

Message:
IIRC, Postfix first checks the alias maps and, if it doesn't find a match,
the mailbox maps. This means that you'll never reach a mailbox if your
domain has a catchall address. There might be some very tricky SQL query to
solve this, but having an alias for every mailbox is the easiest (and easy
to understand) solution.

Yes, if you delete a mailbox or mailbox alias, postfixadmin removes both
the mailbox and its alias. (This is basically a feature because the alias
would loop to itsself without the mailbox.)

Yes, these aliases add some complexity to the code - but they allow to
have a much simpler SQL query in postfix. So it's worth it IMHO.

Having an option to disable these aliases would add more complexity ("if
$maintain_magic_aliases then run_existing_code"), and until now I'm not
sure if there is any benefit. 
My question remains - did you hit any real-world problem with this?

----------------------------------------------------------------------

Comment By: Pavel Volkovitskiy (olfway)
Date: 2009-04-10 01:10

Message:
catchall alias can be configured without such alias-for-every-mailbox
scheme, at least it works with exim here and i'm sure it can be configured
with postfix too

magic is bad, with one of previous snapshot it removes mailbox then i
removed alias for it
also you have to remember about that if you doing some sql updates,
especially if they hidden in web gui
i think that these aliases just adds unneeded complexity to code by itself
(looks in delete.php, for ex delete_alias)
it seems it will remove fo...@do... alias if i remove fo...@do...
mailbox?


----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2009-04-10 00:26

Message:
I know that the aliases for every mailbox is not always needed (but you'll
need it if you use a catchall alias). OTOH, I'm not aware that it hurts in
any situation. The worst thing I'm aware of are some wasted bytes in the
alias table ;-)

What is the reason for your request? Is there a usecase where the mailbox
aliases cause any problems?

If these aliases don't cause real-world problems, I'm not in favour of
allowing to disable them. There might be some side effects (maybe in
postfixadmin, maybe in the postfix configuration) and it adds some unneeded
complexity to the code.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2661366&group_id=191583

[ postfixadmin-Bugs-2661366 ] add parameter to disable alias magic

[SourceForge.net <no...@so...>]

Bugs item #2661366, was opened at 2009-03-04 07:12
Message generated for change (Comment added) made by libertytrek
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2661366&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 4
Private: No
Submitted By: Pavel Volkovitskiy (olfway)
Assigned to: Nobody/Anonymous (nobody)
Summary: add parameter to disable alias magic

Initial Comment:
not everyone needs to have alias for every mailbox, so there should be a way to disable automagically alias creating


----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2009-04-10 08:03

Message:
Hopefully we can all agree that, since this will add more complexity, it
should most *definitely* *not* be added until after 2.3 is released...

:)

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2009-04-10 03:20

Message:
I'm not (yet) in favour of this - my money is on leaving it as it is.

----------------------------------------------------------------------

Comment By: Pavel Volkovitskiy (olfway)
Date: 2009-04-09 18:10

Message:
select username from mailbox where domain = 'domain.tld' union select
address from alias where domain = 'domain.tld';

that's tricky?

----------------------------------------------------------------------

Comment By: Pavel Volkovitskiy (olfway)
Date: 2009-04-09 18:01

Message:
you can use sql 'union' to merge selects from mailbox and alias table
select a from t1 union select a from t2 (can be wrong in details, but it's
easy and not tricky at all)

one simple selects union vs magic "if removing alias, also removing
mailbox, real_alias, force_delete" - union clearly wins imho

real word problem:
i had to restore mailbox once, after i removed alias and postfixadmin
removes mailbox just in case

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2009-04-09 17:52

Message:
IIRC, Postfix first checks the alias maps and, if it doesn't find a match,
the mailbox maps. This means that you'll never reach a mailbox if your
domain has a catchall address. There might be some very tricky SQL query to
solve this, but having an alias for every mailbox is the easiest (and easy
to understand) solution.

Yes, if you delete a mailbox or mailbox alias, postfixadmin removes both
the mailbox and its alias. (This is basically a feature because the alias
would loop to itsself without the mailbox.)

Yes, these aliases add some complexity to the code - but they allow to
have a much simpler SQL query in postfix. So it's worth it IMHO.

Having an option to disable these aliases would add more complexity ("if
$maintain_magic_aliases then run_existing_code"), and until now I'm not
sure if there is any benefit. 
My question remains - did you hit any real-world problem with this?

----------------------------------------------------------------------

Comment By: Pavel Volkovitskiy (olfway)
Date: 2009-04-09 17:10

Message:
catchall alias can be configured without such alias-for-every-mailbox
scheme, at least it works with exim here and i'm sure it can be configured
with postfix too

magic is bad, with one of previous snapshot it removes mailbox then i
removed alias for it
also you have to remember about that if you doing some sql updates,
especially if they hidden in web gui
i think that these aliases just adds unneeded complexity to code by itself
(looks in delete.php, for ex delete_alias)
it seems it will remove fo...@do... alias if i remove fo...@do...
mailbox?


----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2009-04-09 16:26

Message:
I know that the aliases for every mailbox is not always needed (but you'll
need it if you use a catchall alias). OTOH, I'm not aware that it hurts in
any situation. The worst thing I'm aware of are some wasted bytes in the
alias table ;-)

What is the reason for your request? Is there a usecase where the mailbox
aliases cause any problems?

If these aliases don't cause real-world problems, I'm not in favour of
allowing to disable them. There might be some side effects (maybe in
postfixadmin, maybe in the postfix configuration) and it adds some unneeded
complexity to the code.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2661366&group_id=191583