postfixadmin-tracker — Postfix Admin tracker notification - READ ONLY!

[ postfixadmin-Bugs-2987852 ] min_password_length ignored if current password check fails

[SourceForge.net <no...@so...>]

Bugs item #2987852, was opened at 2010-04-15 13:46
Message generated for change (Tracker Item Submitted) made by jonner
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2987852&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: SVN (please specify revision!)
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jonathan Rogers (jonner)
Assigned to: Nobody/Anonymous (nobody)
Summary: min_password_length ignored if current password check fails

Initial Comment:
In the user's change password form, if the current password field doesn't match the current password and the new password fields are shorter than min_password_length, the "Password is too short - requires 5 characters" message is displayed, but the password is changed anyway, so both checks are circumvented. I discovered that this is due to a bug in the way errors are counted. A patch to fix it is attached.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2987852&group_id=191583

[ postfixadmin-Bugs-2986880 ] Quta's stored as integers, should be bigint.

[SourceForge.net <no...@so...>]

Bugs item #2986880, was opened at 2010-04-14 01:21
Message generated for change (Tracker Item Submitted) made by n0d3
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2986880&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Database
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: oliver (n0d3)
Assigned to: Nobody/Anonymous (nobody)
Summary: Quta's stored as integers, should be bigint.

Initial Comment:
Quta's in the database may become to small soon. Currently quota's can be stored as any integer, and be multiplied externally. Thus having a quota of '10' could mean anything from 10 bytes, to 10GB depending on what multiplication factor is used in postfixadmin's config.inc.php.

Postfix itself talks to the table via a select statement, that's just how it does that, and currently, with postfix the following query would be sent to postfix;
postfix=> select quota from mailbox;                   
 quota                                                                          
-------                                                                         
    10                                                                          
(1 row)  

Doing the same external multiplication trick works, as long as it stays under 2^32, the maximum size for an integer; 
So for example:
postfix=> select (quota *1024 *1024) from mailbox;      
 ?column?                                                                       
----------                                                                      
 10485760                                                                       
(1 row)    
Doesn't cause any issue really, so where is the problem?

Well let's say this user is allowed to have some absurd quota, say 10GB. (Remember, Google already offers 1GB quotas and 2GB quotas exist for webmail providers. Having certain users with 10GB shouldn't be all that awkward.
Trying a 10GB quota however fails horribly.
postfix=> select (quota *1024 *1024 *1024) from mailbox;
                                                                                
ERROR:  integer out of range

Changing the quota per user field from an Integer to a bigint solves the issue;
ALTER TABLE mailbox ALTER quota TYPE bigint;
postfix=> select (quota *1024 *1024 *1024) from mailbox;
  ?column?                                                                      
-------------
 10737418240
(1 row)

In conclusion, this means quota's would have never worked if they where bigger then the type of the table, so using external multipliers would have only worked for anything not dependent on the SQL query (which postfix is). Actually, having an external multiplier is useless, though it allows for pretty printing. There could be many reasons actually been thought of to store the quota in bytes actually. Changing the type to bigint actually allows for absurd high quota's 9223372036854774784 or 8Exabyte on a per user level is maybe to high (even in a million years from now, I don't see anybody using 8Exabyte mailboxes) but could pose a problem, far far in the future for quota for domains or maxquota for all domains combined?

So I would recommend, drop external multipliers, store quota's in bytes, pretty print them where needed and convert integers to bigints where needed (e.g. quota for per user, domain etc).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2986880&group_id=191583

[ postfixadmin-Patches-2984781 ] Catchall Alias Control

[SourceForge.net <no...@so...>]

Patches item #2984781, was opened at 2010-04-09 22:14
Message generated for change (Tracker Item Submitted) made by 
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2984781&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: W. Rossmann ()
Assigned to: Nobody/Anonymous (nobody)
Summary: Catchall Alias Control

Initial Comment:
Catchalls can be potentially dangerous for a server's reputation, particularly in the case where a user sets a catchall account that forwards mail to an external account. To the receiving servers this looks like you are the source of the spam, and has gotten our older servers blacklisted more than once. It generally does not become an issue until you have a few domains doing it [about 10 or more seems to do the trick] to a mail provider like Yahoo that maintain their own lists.

This patch allows you to select what level of administrative privileges are required in order to create a catchall account, as well as disable them entirely. Changes made to the following files:
- config.inc.php
- create-alias.php
- templates/create-alias.php

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2984781&group_id=191583

[ postfixadmin-Patches-2925620 ] password column name in configuration

[SourceForge.net <no...@so...>]

Patches item #2925620, was opened at 2010-01-04 13:10
Message generated for change (Comment added) made by sf-robot
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2925620&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Database
Group: None
>Status: Closed
Resolution: Rejected
Priority: 1
Private: No
Submitted By: Gabriel Serme (eirmag)
Assigned to: Nobody/Anonymous (nobody)
Summary: password column name in configuration

Initial Comment:
Sometimes you may want to have multiple columns in your database to store your password, or simply have a different name than "password". The problem is that the column name is hard written in source code.

This patch gives you the possibility to change the database password column name for USERS ONLY from the configuration file. Postfixadmin's column password remains "password".

The new config name is : "database_password_column_name", and impacted files are config.inc.php and model/UserHandler.php

Greetings for this new year, 
Gabriel

----------------------------------------------------------------------

>Comment By: SourceForge Robot (sf-robot)
Date: 2010-04-08 02:20

Message:
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2010-03-24 12:50

Message:
I can see your reasoning for wanting to do this - but I'm a bit wary about
merging this patch as it's use is to allow postfixadmin to work with
another database schema - if this were the case, then obviously you've got
issues with respect to other fields changing (e.g. username).... 

So I'm not sure it should be accepted. Sorry.

----------------------------------------------------------------------

Comment By: Gabriel Serme (eirmag)
Date: 2010-01-05 20:15

Message:
No problem, I understand your point and solutions you give are enough to
motivate not applying the patch.

thanks for both create-mailbox and edit-mailbox. I'll fix it on my
version.


----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2010-01-05 20:03

Message:
Well, my solution would be to ignore the historical reasons and just use
the 'password' column ;-)

That said: If you are fine with having the same content in the 'password'
and 'passcyrpt' column, you can add triggers in your database that update
the 'passcrypt' column whenever 'password' is changed. Both MySQL and
PostgreSQL support this. Or you can add a view that renames the column at
access time (SELECT username, password as passcrypt, ...).

BTW: Your patch is incomplete - you'll also have to modify
create-mailbox.php and edit-mailbox.php that are used in admin mode...

----------------------------------------------------------------------

Comment By: Gabriel Serme (eirmag)
Date: 2010-01-05 15:37

Message:
Hi,

when I created this patch, it was more for information than for mergin
request ;)

In fact, I wrote it because I was unable to change the database password
column name in postfixadmin. And I made change recently to my
postfix/courier configuration from passwords stored in column named
"password" to column named "passcrypt". 

Doing this, I break compatibility with postfixadmin, and for historical
reasons I want to keep my column "password". So, to make converge all my
authentication in a same place, I modify postfixadmin.

Also, modifying postfixadmin files directly wasn't a good optoin for me,
so I added the property "database_password_column_name".

If you have another solution, let me know. And thx for your reply.

Gabriel

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2010-01-05 12:19

Message:
Can you please describe _why_ the additional or renamed password column is
useful? At the moment I don't see the advantage. OTOH your patch would make
upgrades harder because database changes would be applied to the wrong
column etc.

I'm not totally against merging this patch, but I'd like to know your
usecase and reason first. (Maybe we find another solution for your problem,
which would be the better way IMHO.)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2925620&group_id=191583

[ postfixadmin-Feature Requests-2965578 ] Support pipe througput by adding user defined transport

[SourceForge.net <no...@so...>]

Feature Requests item #2965578, was opened at 2010-03-08 19:05
Message generated for change (Comment added) made by valkum
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=2965578&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Valkum (valkum)
Assigned to: Nobody/Anonymous (nobody)
Summary: Support pipe througput by adding user defined transport

Initial Comment:
By adding user defined transport anyone can add postfix' pipe by simply add scriptname in master.cnf.

----------------------------------------------------------------------

>Comment By: Valkum (valkum)
Date: 2010-04-08 00:40

Message:
Later i found out that i can config this for one domain but i think its
very cute for each mailbox.

other way is set up aliases to subdomains.

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2010-04-08 00:24

Message:
Yes, and postfixadmin should already support this. You can change the
transport on domain level ($CONF['transport']), and you can also add your
own transports to the selection list ($CONF['transport_options']).
Does this fulfill your needs?

Note: The config in DOCUMENTS/POSTFIX_CONF.TXT ignores the transport
setting, you'll have to change this part of the postfix config. For some
hints see
http://sourceforge.net/projects/postfixadmin/forums/forum/676076/topic/3564960

I'll happily add the transport handling to the documentation if you tell
me what you needed to change in the postfix config ;-)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=2965578&group_id=191583

[ postfixadmin-Feature Requests-2965578 ] Support pipe througput by adding user defined transport

[SourceForge.net <no...@so...>]

Feature Requests item #2965578, was opened at 2010-03-08 19:05
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=2965578&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Valkum (valkum)
Assigned to: Nobody/Anonymous (nobody)
Summary: Support pipe througput by adding user defined transport

Initial Comment:
By adding user defined transport anyone can add postfix' pipe by simply add scriptname in master.cnf.

----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2010-04-08 00:24

Message:
Yes, and postfixadmin should already support this. You can change the
transport on domain level ($CONF['transport']), and you can also add your
own transports to the selection list ($CONF['transport_options']).
Does this fulfill your needs?

Note: The config in DOCUMENTS/POSTFIX_CONF.TXT ignores the transport
setting, you'll have to change this part of the postfix config. For some
hints see
http://sourceforge.net/projects/postfixadmin/forums/forum/676076/topic/3564960

I'll happily add the transport handling to the documentation if you tell
me what you needed to change in the postfix config ;-)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=2965578&group_id=191583

[ postfixadmin-Bugs-2983354 ] dovecotpw with php

[SourceForge.net <no...@so...>]

Bugs item #2983354, was opened at 2010-04-07 19:38
Message generated for change (Tracker Item Submitted) made by valkum
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2983354&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Valkum (valkum)
Assigned to: Nobody/Anonymous (nobody)
Summary: dovecotpw with php

Initial Comment:
in association with my  cli i have found something bad in my logs of an 2.3 Installation.

In logfiles from Apache, not in log files from vhost, i found this:

Enter new password: Retype new password: 

this is the stdout from dovecotpw. we have to fix it in any way.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2983354&group_id=191583

[ postfixadmin-Patches-2981966 ] CLI for Postfixadmin

[SourceForge.net <no...@so...>]

Patches item #2981966, was opened at 2010-04-05 04:00
Message generated for change (Comment added) made by valkum
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2981966&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Widget (example)
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Valkum (valkum)
Assigned to: Nobody/Anonymous (nobody)
Summary: CLI for Postfixadmin

Initial Comment:
Today i've spend a lot of time to make a simple CLI widget for Postfixadmin. So you can add a tons of mailboxes or aliases at once by one script execution.

The requirements are:

php-cli


Simply put the scripts folder in your main root of postfixadmin or somewhere else. You can add path to postfixadmin by -webroot /path/to/pfadmin

At the moment only user view and user password works
Version 0.2 comes tomorrow. eventually.

//btw: popen with dovecotpw doesn't work on cli. Need bugfix here.  <------ IMPORTANT (functions.inc.php - function pacrypt(..) )
Every time I got 'Enter new password:' on STDOUT from dovecotpw


Copyright to many tons of code goes to CakePHP great work.
CakePHP's dispatcher with own Shell.

Report Bugs in this ticket please.


----------------------------------------------------------------------

>Comment By: Valkum (valkum)
Date: 2010-04-07 19:18

Message:
Oh one thing i have forgotten. 
The language phrases, should not include html tags or something similar.

----------------------------------------------------------------------

Comment By: Valkum (valkum)
Date: 2010-04-07 18:55

Message:
I think to write own OOP DB Models is much better than use somethin based
on third party. 
The only reason to use cakePHP CLi was the nice getParams and dispatcher
function. :)
But when we use such a big project like PHPDoctrine we have to use alway
te up to date version of this. So we have more work if something changes in
PHPDoctrine.

So i Think so:

Todo:
First::
*Use of db_update etc.
(pgsql things have to handled in this functions to)

Second:
*Port this functions to OOP.


If anyone have more time then me, he can Write the alias shell based on my
user shell and create-alias.php, edit-alias.php and delete-alias.php
But then directly with db_delete, db_insert etc.

About db_select. I thing we have to watch over drupals db function.
There you can transfer params so that you can build complex queries.

btw: what the spoken language in pfa-devel maillist ?

----------------------------------------------------------------------

Comment By: Sebastian (sebastian2009)
Date: 2010-04-07 11:23

Message:
Hi guys,

actually, I hadn't any time to develop further, but I can see light on the
other end of the tunnel... ;)

I started looking at PHPDoctrine as OOP-model. PHPDoctrine evolved very
good over the last few months. I think I'll start an approach to convert
things towards PHPDoctrine.

Are there any other good solutions out there that would be worth looking
at?

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2010-04-06 22:38

Message:
Thanks for your scripts. The commandline client is an often requested
feature ;-)
I also like the model/ files - OOP (and IMHO more important: one central
place for the code, instead of 3 slightly different versions) is always a
good thing[tm]. Now we "only" have to change the current code to actually
use this classes...

Some small notes:

> Some things in functions.inc.php are very sad for CLI.
> In line 1742 i changed $REMOTE_ADDR = $_SERVER['REMOTE_ADDR'];
> to:
> $REMOTE_ADDR = 'localhost';  [...]

That's the db_log() function, aka logging.
Maybe something like 'CLI' would be a better choice so that it's clear it
was a commandline action.
An even better idea would be to include the username of the user currently
logged in. For shell users, this means something like:

$processUser = posix_getpwuid(posix_getuid()); 
$REMOTE_ADDR = $processUser['name'] . ' @ CLI';

The posix functions are not available on windows, and maybe not even on
all linux installations (hint: php packages that are split by module) ->
The posix_* calls need to be wrapped with function_exists().


BTW: On which version/svn revision of postfixadmin are your changes based?
I'm asking to avoid merge conflicts. 
For me it looks like you used the 2.3 release as base since the
model/AliasHandler.php and model/VacationHandler.php are exactly the same.
SVN trunk has some changes in VacationHandler.php (added support for
vacation start and end dates) - therefore you should use this version if
you have to change anything in it ;-) AliasHandler.php also has some
changes (mostly whitespace) in SVN trunk.

Regarding your comments on the global vars for table names: yes, they are
ugly. The long-term solution (at least from my point of view) is to use the
db_insert, db_update, db_delete functions (see functions.inc.php) instead
of writing the INSERT, UPDATE and DELETE statements "by hand". Some new
queries already use these functions, however several "old" ones need to be
migrated.

Yes, we'll also need a similar function for SELECT. This might be harder
than the above ones because some SELECT queries postfixadmin uses are quite
complex. We'll have the choice between nearly no abstraction and a
non-understandable db_select function ;-) - I hope there can be something
between those extremes.

And a final question: What about joining the postfixadmin-devel
mailinglist? Communicating using a textarea that displays max. 5 lines (=
this ticket ;-) isn't the best option IMHO. But it's your decision of
course since you provide(d) the code ;-)

----------------------------------------------------------------------

Comment By: Valkum (valkum)
Date: 2010-04-06 03:10

Message:
Hope for Fully OOP Recoded Version of PFA in Version 3.0

----------------------------------------------------------------------

Comment By: Valkum (valkum)
Date: 2010-04-06 03:00

Message:
So Version 0.2 is up.
Changes:

'user add' added.
'user delete' added.

changed way of output.
model uses vars $return and $errormsg as transport.
return 0 or 1.

Some things in functions.inc.php are very sad for CLI.

In line 1348 i changed  $_SERVER["SERVER_NAME"]; to php_uname("n");
because this works and i think that it is silly to run pfa twice from the
same server.

In line 1742 i changed  $REMOTE_ADDR = $_SERVER['REMOTE_ADDR'];
to:
$REMOTE_ADDR = 'localhost';
if (isset($_SERVER['REMOTE_ADDR'])) 
  $REMOTE_ADDR = $_SERVER['REMOTE_ADDR'];
Because $_SERVER is not available in CLI.

Please find a fix for the dovecotpw problem. See Details above.

----------------------------------------------------------------------

Comment By: Valkum (valkum)
Date: 2010-04-05 20:54

Message:
Sry yesterday i've forgot to put in my actual  user model.
Now i start to implement the rest of user methods. Then i upload my model.

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2010-04-05 08:54

Message:
cool; i'll try and merge this son; nice idea.

----------------------------------------------------------------------

Comment By: Valkum (valkum)
Date: 2010-04-05 04:20

Message:
Moved to v0.1b:
*Added some Copyright text
*Added postfixadmin-cli (bashscript)
*Changed text in console help function

Bugs fixed:
*Got "Class 'Info' not found when calling postfixadmin-cli without args -
fixed

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2981966&group_id=191583

[ postfixadmin-Patches-2981966 ] CLI for Postfixadmin

[SourceForge.net <no...@so...>]

Patches item #2981966, was opened at 2010-04-05 04:00
Message generated for change (Comment added) made by valkum
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2981966&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Widget (example)
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Valkum (valkum)
Assigned to: Nobody/Anonymous (nobody)
Summary: CLI for Postfixadmin

Initial Comment:
Today i've spend a lot of time to make a simple CLI widget for Postfixadmin. So you can add a tons of mailboxes or aliases at once by one script execution.

The requirements are:

php-cli


Simply put the scripts folder in your main root of postfixadmin or somewhere else. You can add path to postfixadmin by -webroot /path/to/pfadmin

At the moment only user view and user password works
Version 0.2 comes tomorrow. eventually.

//btw: popen with dovecotpw doesn't work on cli. Need bugfix here.  <------ IMPORTANT (functions.inc.php - function pacrypt(..) )
Every time I got 'Enter new password:' on STDOUT from dovecotpw


Copyright to many tons of code goes to CakePHP great work.
CakePHP's dispatcher with own Shell.

Report Bugs in this ticket please.


----------------------------------------------------------------------

>Comment By: Valkum (valkum)
Date: 2010-04-07 18:55

Message:
I think to write own OOP DB Models is much better than use somethin based
on third party. 
The only reason to use cakePHP CLi was the nice getParams and dispatcher
function. :)
But when we use such a big project like PHPDoctrine we have to use alway
te up to date version of this. So we have more work if something changes in
PHPDoctrine.

So i Think so:

Todo:
First::
*Use of db_update etc.
(pgsql things have to handled in this functions to)

Second:
*Port this functions to OOP.


If anyone have more time then me, he can Write the alias shell based on my
user shell and create-alias.php, edit-alias.php and delete-alias.php
But then directly with db_delete, db_insert etc.

About db_select. I thing we have to watch over drupals db function.
There you can transfer params so that you can build complex queries.

btw: what the spoken language in pfa-devel maillist ?

----------------------------------------------------------------------

Comment By: Sebastian (sebastian2009)
Date: 2010-04-07 11:23

Message:
Hi guys,

actually, I hadn't any time to develop further, but I can see light on the
other end of the tunnel... ;)

I started looking at PHPDoctrine as OOP-model. PHPDoctrine evolved very
good over the last few months. I think I'll start an approach to convert
things towards PHPDoctrine.

Are there any other good solutions out there that would be worth looking
at?

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2010-04-06 22:38

Message:
Thanks for your scripts. The commandline client is an often requested
feature ;-)
I also like the model/ files - OOP (and IMHO more important: one central
place for the code, instead of 3 slightly different versions) is always a
good thing[tm]. Now we "only" have to change the current code to actually
use this classes...

Some small notes:

> Some things in functions.inc.php are very sad for CLI.
> In line 1742 i changed $REMOTE_ADDR = $_SERVER['REMOTE_ADDR'];
> to:
> $REMOTE_ADDR = 'localhost';  [...]

That's the db_log() function, aka logging.
Maybe something like 'CLI' would be a better choice so that it's clear it
was a commandline action.
An even better idea would be to include the username of the user currently
logged in. For shell users, this means something like:

$processUser = posix_getpwuid(posix_getuid()); 
$REMOTE_ADDR = $processUser['name'] . ' @ CLI';

The posix functions are not available on windows, and maybe not even on
all linux installations (hint: php packages that are split by module) ->
The posix_* calls need to be wrapped with function_exists().


BTW: On which version/svn revision of postfixadmin are your changes based?
I'm asking to avoid merge conflicts. 
For me it looks like you used the 2.3 release as base since the
model/AliasHandler.php and model/VacationHandler.php are exactly the same.
SVN trunk has some changes in VacationHandler.php (added support for
vacation start and end dates) - therefore you should use this version if
you have to change anything in it ;-) AliasHandler.php also has some
changes (mostly whitespace) in SVN trunk.

Regarding your comments on the global vars for table names: yes, they are
ugly. The long-term solution (at least from my point of view) is to use the
db_insert, db_update, db_delete functions (see functions.inc.php) instead
of writing the INSERT, UPDATE and DELETE statements "by hand". Some new
queries already use these functions, however several "old" ones need to be
migrated.

Yes, we'll also need a similar function for SELECT. This might be harder
than the above ones because some SELECT queries postfixadmin uses are quite
complex. We'll have the choice between nearly no abstraction and a
non-understandable db_select function ;-) - I hope there can be something
between those extremes.

And a final question: What about joining the postfixadmin-devel
mailinglist? Communicating using a textarea that displays max. 5 lines (=
this ticket ;-) isn't the best option IMHO. But it's your decision of
course since you provide(d) the code ;-)

----------------------------------------------------------------------

Comment By: Valkum (valkum)
Date: 2010-04-06 03:10

Message:
Hope for Fully OOP Recoded Version of PFA in Version 3.0

----------------------------------------------------------------------

Comment By: Valkum (valkum)
Date: 2010-04-06 03:00

Message:
So Version 0.2 is up.
Changes:

'user add' added.
'user delete' added.

changed way of output.
model uses vars $return and $errormsg as transport.
return 0 or 1.

Some things in functions.inc.php are very sad for CLI.

In line 1348 i changed  $_SERVER["SERVER_NAME"]; to php_uname("n");
because this works and i think that it is silly to run pfa twice from the
same server.

In line 1742 i changed  $REMOTE_ADDR = $_SERVER['REMOTE_ADDR'];
to:
$REMOTE_ADDR = 'localhost';
if (isset($_SERVER['REMOTE_ADDR'])) 
  $REMOTE_ADDR = $_SERVER['REMOTE_ADDR'];
Because $_SERVER is not available in CLI.

Please find a fix for the dovecotpw problem. See Details above.

----------------------------------------------------------------------

Comment By: Valkum (valkum)
Date: 2010-04-05 20:54

Message:
Sry yesterday i've forgot to put in my actual  user model.
Now i start to implement the rest of user methods. Then i upload my model.

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2010-04-05 08:54

Message:
cool; i'll try and merge this son; nice idea.

----------------------------------------------------------------------

Comment By: Valkum (valkum)
Date: 2010-04-05 04:20

Message:
Moved to v0.1b:
*Added some Copyright text
*Added postfixadmin-cli (bashscript)
*Changed text in console help function

Bugs fixed:
*Got "Class 'Info' not found when calling postfixadmin-cli without args -
fixed

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2981966&group_id=191583

[ postfixadmin-Patches-2981966 ] CLI for Postfixadmin

[SourceForge.net <no...@so...>]

Patches item #2981966, was opened at 2010-04-05 04:00
Message generated for change (Comment added) made by sebastian2009
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2981966&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Widget (example)
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Valkum ()
Assigned to: Nobody/Anonymous (nobody)
Summary: CLI for Postfixadmin

Initial Comment:
Today i've spend a lot of time to make a simple CLI widget for Postfixadmin. So you can add a tons of mailboxes or aliases at once by one script execution.

The requirements are:

php-cli


Simply put the scripts folder in your main root of postfixadmin or somewhere else. You can add path to postfixadmin by -webroot /path/to/pfadmin

At the moment only user view and user password works
Version 0.2 comes tomorrow. eventually.

//btw: popen with dovecotpw doesn't work on cli. Need bugfix here.  <------ IMPORTANT (functions.inc.php - function pacrypt(..) )
Every time I got 'Enter new password:' on STDOUT from dovecotpw


Copyright to many tons of code goes to CakePHP great work.
CakePHP's dispatcher with own Shell.

Report Bugs in this ticket please.


----------------------------------------------------------------------

>Comment By: Sebastian (sebastian2009)
Date: 2010-04-07 11:23

Message:
Hi guys,

actually, I hadn't any time to develop further, but I can see light on the
other end of the tunnel... ;)

I started looking at PHPDoctrine as OOP-model. PHPDoctrine evolved very
good over the last few months. I think I'll start an approach to convert
things towards PHPDoctrine.

Are there any other good solutions out there that would be worth looking
at?

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2010-04-06 22:38

Message:
Thanks for your scripts. The commandline client is an often requested
feature ;-)
I also like the model/ files - OOP (and IMHO more important: one central
place for the code, instead of 3 slightly different versions) is always a
good thing[tm]. Now we "only" have to change the current code to actually
use this classes...

Some small notes:

> Some things in functions.inc.php are very sad for CLI.
> In line 1742 i changed $REMOTE_ADDR = $_SERVER['REMOTE_ADDR'];
> to:
> $REMOTE_ADDR = 'localhost';  [...]

That's the db_log() function, aka logging.
Maybe something like 'CLI' would be a better choice so that it's clear it
was a commandline action.
An even better idea would be to include the username of the user currently
logged in. For shell users, this means something like:

$processUser = posix_getpwuid(posix_getuid()); 
$REMOTE_ADDR = $processUser['name'] . ' @ CLI';

The posix functions are not available on windows, and maybe not even on
all linux installations (hint: php packages that are split by module) ->
The posix_* calls need to be wrapped with function_exists().


BTW: On which version/svn revision of postfixadmin are your changes based?
I'm asking to avoid merge conflicts. 
For me it looks like you used the 2.3 release as base since the
model/AliasHandler.php and model/VacationHandler.php are exactly the same.
SVN trunk has some changes in VacationHandler.php (added support for
vacation start and end dates) - therefore you should use this version if
you have to change anything in it ;-) AliasHandler.php also has some
changes (mostly whitespace) in SVN trunk.

Regarding your comments on the global vars for table names: yes, they are
ugly. The long-term solution (at least from my point of view) is to use the
db_insert, db_update, db_delete functions (see functions.inc.php) instead
of writing the INSERT, UPDATE and DELETE statements "by hand". Some new
queries already use these functions, however several "old" ones need to be
migrated.

Yes, we'll also need a similar function for SELECT. This might be harder
than the above ones because some SELECT queries postfixadmin uses are quite
complex. We'll have the choice between nearly no abstraction and a
non-understandable db_select function ;-) - I hope there can be something
between those extremes.

And a final question: What about joining the postfixadmin-devel
mailinglist? Communicating using a textarea that displays max. 5 lines (=
this ticket ;-) isn't the best option IMHO. But it's your decision of
course since you provide(d) the code ;-)

----------------------------------------------------------------------

Comment By: Valkum ()
Date: 2010-04-06 03:10

Message:
Hope for Fully OOP Recoded Version of PFA in Version 3.0

----------------------------------------------------------------------

Comment By: Valkum ()
Date: 2010-04-06 03:00

Message:
So Version 0.2 is up.
Changes:

'user add' added.
'user delete' added.

changed way of output.
model uses vars $return and $errormsg as transport.
return 0 or 1.

Some things in functions.inc.php are very sad for CLI.

In line 1348 i changed  $_SERVER["SERVER_NAME"]; to php_uname("n");
because this works and i think that it is silly to run pfa twice from the
same server.

In line 1742 i changed  $REMOTE_ADDR = $_SERVER['REMOTE_ADDR'];
to:
$REMOTE_ADDR = 'localhost';
if (isset($_SERVER['REMOTE_ADDR'])) 
  $REMOTE_ADDR = $_SERVER['REMOTE_ADDR'];
Because $_SERVER is not available in CLI.

Please find a fix for the dovecotpw problem. See Details above.

----------------------------------------------------------------------

Comment By: Valkum ()
Date: 2010-04-05 20:54

Message:
Sry yesterday i've forgot to put in my actual  user model.
Now i start to implement the rest of user methods. Then i upload my model.

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2010-04-05 08:54

Message:
cool; i'll try and merge this son; nice idea.

----------------------------------------------------------------------

Comment By: Valkum ()
Date: 2010-04-05 04:20

Message:
Moved to v0.1b:
*Added some Copyright text
*Added postfixadmin-cli (bashscript)
*Changed text in console help function

Bugs fixed:
*Got "Class 'Info' not found when calling postfixadmin-cli without args -
fixed

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2981966&group_id=191583

[ postfixadmin-Patches-2981966 ] CLI for Postfixadmin

[SourceForge.net <no...@so...>]

Patches item #2981966, was opened at 2010-04-05 04:00
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2981966&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Widget (example)
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Valkum ()
Assigned to: Nobody/Anonymous (nobody)
Summary: CLI for Postfixadmin

Initial Comment:
Today i've spend a lot of time to make a simple CLI widget for Postfixadmin. So you can add a tons of mailboxes or aliases at once by one script execution.

The requirements are:

php-cli


Simply put the scripts folder in your main root of postfixadmin or somewhere else. You can add path to postfixadmin by -webroot /path/to/pfadmin

At the moment only user view and user password works
Version 0.2 comes tomorrow. eventually.

//btw: popen with dovecotpw doesn't work on cli. Need bugfix here.  <------ IMPORTANT (functions.inc.php - function pacrypt(..) )
Every time I got 'Enter new password:' on STDOUT from dovecotpw


Copyright to many tons of code goes to CakePHP great work.
CakePHP's dispatcher with own Shell.

Report Bugs in this ticket please.


----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2010-04-06 22:38

Message:
Thanks for your scripts. The commandline client is an often requested
feature ;-)
I also like the model/ files - OOP (and IMHO more important: one central
place for the code, instead of 3 slightly different versions) is always a
good thing[tm]. Now we "only" have to change the current code to actually
use this classes...

Some small notes:

> Some things in functions.inc.php are very sad for CLI.
> In line 1742 i changed $REMOTE_ADDR = $_SERVER['REMOTE_ADDR'];
> to:
> $REMOTE_ADDR = 'localhost';  [...]

That's the db_log() function, aka logging.
Maybe something like 'CLI' would be a better choice so that it's clear it
was a commandline action.
An even better idea would be to include the username of the user currently
logged in. For shell users, this means something like:

$processUser = posix_getpwuid(posix_getuid()); 
$REMOTE_ADDR = $processUser['name'] . ' @ CLI';

The posix functions are not available on windows, and maybe not even on
all linux installations (hint: php packages that are split by module) ->
The posix_* calls need to be wrapped with function_exists().


BTW: On which version/svn revision of postfixadmin are your changes based?
I'm asking to avoid merge conflicts. 
For me it looks like you used the 2.3 release as base since the
model/AliasHandler.php and model/VacationHandler.php are exactly the same.
SVN trunk has some changes in VacationHandler.php (added support for
vacation start and end dates) - therefore you should use this version if
you have to change anything in it ;-) AliasHandler.php also has some
changes (mostly whitespace) in SVN trunk.

Regarding your comments on the global vars for table names: yes, they are
ugly. The long-term solution (at least from my point of view) is to use the
db_insert, db_update, db_delete functions (see functions.inc.php) instead
of writing the INSERT, UPDATE and DELETE statements "by hand". Some new
queries already use these functions, however several "old" ones need to be
migrated.

Yes, we'll also need a similar function for SELECT. This might be harder
than the above ones because some SELECT queries postfixadmin uses are quite
complex. We'll have the choice between nearly no abstraction and a
non-understandable db_select function ;-) - I hope there can be something
between those extremes.

And a final question: What about joining the postfixadmin-devel
mailinglist? Communicating using a textarea that displays max. 5 lines (=
this ticket ;-) isn't the best option IMHO. But it's your decision of
course since you provide(d) the code ;-)

----------------------------------------------------------------------

Comment By: Valkum ()
Date: 2010-04-06 03:10

Message:
Hope for Fully OOP Recoded Version of PFA in Version 3.0

----------------------------------------------------------------------

Comment By: Valkum ()
Date: 2010-04-06 03:00

Message:
So Version 0.2 is up.
Changes:

'user add' added.
'user delete' added.

changed way of output.
model uses vars $return and $errormsg as transport.
return 0 or 1.

Some things in functions.inc.php are very sad for CLI.

In line 1348 i changed  $_SERVER["SERVER_NAME"]; to php_uname("n");
because this works and i think that it is silly to run pfa twice from the
same server.

In line 1742 i changed  $REMOTE_ADDR = $_SERVER['REMOTE_ADDR'];
to:
$REMOTE_ADDR = 'localhost';
if (isset($_SERVER['REMOTE_ADDR'])) 
  $REMOTE_ADDR = $_SERVER['REMOTE_ADDR'];
Because $_SERVER is not available in CLI.

Please find a fix for the dovecotpw problem. See Details above.

----------------------------------------------------------------------

Comment By: Valkum ()
Date: 2010-04-05 20:54

Message:
Sry yesterday i've forgot to put in my actual  user model.
Now i start to implement the rest of user methods. Then i upload my model.

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2010-04-05 08:54

Message:
cool; i'll try and merge this son; nice idea.

----------------------------------------------------------------------

Comment By: Valkum ()
Date: 2010-04-05 04:20

Message:
Moved to v0.1b:
*Added some Copyright text
*Added postfixadmin-cli (bashscript)
*Changed text in console help function

Bugs fixed:
*Got "Class 'Info' not found when calling postfixadmin-cli without args -
fixed

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2981966&group_id=191583

[ postfixadmin-Patches-2981966 ] CLI for Postfixadmin

[SourceForge.net <no...@so...>]

Patches item #2981966, was opened at 2010-04-05 04:00
Message generated for change (Comment added) made by 
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2981966&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Widget (example)
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Valkum ()
Assigned to: Nobody/Anonymous (nobody)
Summary: CLI for Postfixadmin

Initial Comment:
Today i've spend a lot of time to make a simple CLI widget for Postfixadmin. So you can add a tons of mailboxes or aliases at once by one script execution.

The requirements are:

php-cli


Simply put the scripts folder in your main root of postfixadmin or somewhere else. You can add path to postfixadmin by -webroot /path/to/pfadmin

At the moment only user view and user password works
Version 0.2 comes tomorrow. eventually.

//btw: popen with dovecotpw doesn't work on cli. Need bugfix here.  <------ IMPORTANT (functions.inc.php - function pacrypt(..) )
Every time I got 'Enter new password:' on STDOUT from dovecotpw


Copyright to many tons of code goes to CakePHP great work.
CakePHP's dispatcher with own Shell.

Report Bugs in this ticket please.


----------------------------------------------------------------------

>Comment By: Valkum ()
Date: 2010-04-06 03:10

Message:
Hope for Fully OOP Recoded Version of PFA in Version 3.0

----------------------------------------------------------------------

Comment By: Valkum ()
Date: 2010-04-06 03:00

Message:
So Version 0.2 is up.
Changes:

'user add' added.
'user delete' added.

changed way of output.
model uses vars $return and $errormsg as transport.
return 0 or 1.

Some things in functions.inc.php are very sad for CLI.

In line 1348 i changed  $_SERVER["SERVER_NAME"]; to php_uname("n");
because this works and i think that it is silly to run pfa twice from the
same server.

In line 1742 i changed  $REMOTE_ADDR = $_SERVER['REMOTE_ADDR'];
to:
$REMOTE_ADDR = 'localhost';
if (isset($_SERVER['REMOTE_ADDR'])) 
  $REMOTE_ADDR = $_SERVER['REMOTE_ADDR'];
Because $_SERVER is not available in CLI.

Please find a fix for the dovecotpw problem. See Details above.

----------------------------------------------------------------------

Comment By: Valkum ()
Date: 2010-04-05 20:54

Message:
Sry yesterday i've forgot to put in my actual  user model.
Now i start to implement the rest of user methods. Then i upload my model.

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2010-04-05 08:54

Message:
cool; i'll try and merge this son; nice idea.

----------------------------------------------------------------------

Comment By: Valkum ()
Date: 2010-04-05 04:20

Message:
Moved to v0.1b:
*Added some Copyright text
*Added postfixadmin-cli (bashscript)
*Changed text in console help function

Bugs fixed:
*Got "Class 'Info' not found when calling postfixadmin-cli without args -
fixed

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2981966&group_id=191583

[ postfixadmin-Patches-2981966 ] CLI for Postfixadmin

[SourceForge.net <no...@so...>]

Patches item #2981966, was opened at 2010-04-05 04:00
Message generated for change (Comment added) made by 
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2981966&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Widget (example)
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Valkum ()
Assigned to: Nobody/Anonymous (nobody)
Summary: CLI for Postfixadmin

Initial Comment:
Today i've spend a lot of time to make a simple CLI widget for Postfixadmin. So you can add a tons of mailboxes or aliases at once by one script execution.

The requirements are:

php-cli


Simply put the scripts folder in your main root of postfixadmin or somewhere else. You can add path to postfixadmin by -webroot /path/to/pfadmin

At the moment only user view and user password works
Version 0.2 comes tomorrow. eventually.

//btw: popen with dovecotpw doesn't work on cli. Need bugfix here.  <------ IMPORTANT (functions.inc.php - function pacrypt(..) )
Every time I got 'Enter new password:' on STDOUT from dovecotpw


Copyright to many tons of code goes to CakePHP great work.
CakePHP's dispatcher with own Shell.

Report Bugs in this ticket please.


----------------------------------------------------------------------

>Comment By: Valkum ()
Date: 2010-04-06 03:00

Message:
So Version 0.2 is up.
Changes:

'user add' added.
'user delete' added.

changed way of output.
model uses vars $return and $errormsg as transport.
return 0 or 1.

Some things in functions.inc.php are very sad for CLI.

In line 1348 i changed  $_SERVER["SERVER_NAME"]; to php_uname("n");
because this works and i think that it is silly to run pfa twice from the
same server.

In line 1742 i changed  $REMOTE_ADDR = $_SERVER['REMOTE_ADDR'];
to:
$REMOTE_ADDR = 'localhost';
if (isset($_SERVER['REMOTE_ADDR'])) 
  $REMOTE_ADDR = $_SERVER['REMOTE_ADDR'];
Because $_SERVER is not available in CLI.

Please find a fix for the dovecotpw problem. See Details above.

----------------------------------------------------------------------

Comment By: Valkum ()
Date: 2010-04-05 20:54

Message:
Sry yesterday i've forgot to put in my actual  user model.
Now i start to implement the rest of user methods. Then i upload my model.

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2010-04-05 08:54

Message:
cool; i'll try and merge this son; nice idea.

----------------------------------------------------------------------

Comment By: Valkum ()
Date: 2010-04-05 04:20

Message:
Moved to v0.1b:
*Added some Copyright text
*Added postfixadmin-cli (bashscript)
*Changed text in console help function

Bugs fixed:
*Got "Class 'Info' not found when calling postfixadmin-cli without args -
fixed

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2981966&group_id=191583

[ postfixadmin-Patches-2981966 ] CLI for Postfixadmin

[SourceForge.net <no...@so...>]

Patches item #2981966, was opened at 2010-04-05 04:00
Message generated for change (Comment added) made by 
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2981966&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Widget (example)
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Valkum ()
Assigned to: Nobody/Anonymous (nobody)
Summary: CLI for Postfixadmin

Initial Comment:
Today i've spend a lot of time to make a simple CLI widget for Postfixadmin. So you can add a tons of mailboxes or aliases at once by one script execution.

The requirements are:

php-cli


Simply put the scripts folder in your main root of postfixadmin or somewhere else. You can add path to postfixadmin by -webroot /path/to/pfadmin

At the moment only user view and user password works
Version 0.2 comes tomorrow. eventually.

//btw: popen with dovecotpw doesn't work on cli. Need bugfix here.  <------ IMPORTANT (functions.inc.php - function pacrypt(..) )
Every time I got 'Enter new password:' on STDOUT from dovecotpw


Copyright to many tons of code goes to CakePHP great work.
CakePHP's dispatcher with own Shell.

Report Bugs in this ticket please.


----------------------------------------------------------------------

Comment By: Valkum ()
Date: 2010-04-05 20:54

Message:
Sry yesterday i've forgot to put in my actual  user model.
Now i start to implement the rest of user methods. Then i upload my model.

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2010-04-05 08:54

Message:
cool; i'll try and merge this son; nice idea.

----------------------------------------------------------------------

Comment By: Valkum ()
Date: 2010-04-05 04:20

Message:
Moved to v0.1b:
*Added some Copyright text
*Added postfixadmin-cli (bashscript)
*Changed text in console help function

Bugs fixed:
*Got "Class 'Info' not found when calling postfixadmin-cli without args -
fixed

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2981966&group_id=191583

[ postfixadmin-Patches-2981966 ] CLI for Postfixadmin

[SourceForge.net <no...@so...>]

Patches item #2981966, was opened at 2010-04-05 02:00
Message generated for change (Comment added) made by gingerdog
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2981966&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Widget (example)
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Valkum ()
Assigned to: Nobody/Anonymous (nobody)
Summary: CLI for Postfixadmin

Initial Comment:
Today i've spend a lot of time to make a simple CLI widget for Postfixadmin. So you can add a tons of mailboxes or aliases at once by one script execution.

The requirements are:

php-cli


Simply put the scripts folder in your main root of postfixadmin or somewhere else. You can add path to postfixadmin by -webroot /path/to/pfadmin

At the moment only user view and user password works
Version 0.2 comes tomorrow. eventually.

//btw: popen with dovecotpw doesn't work on cli. Need bugfix here.  <------ IMPORTANT (functions.inc.php - function pacrypt(..) )
Every time I got 'Enter new password:' on STDOUT from dovecotpw


Copyright to many tons of code goes to CakePHP great work.
CakePHP's dispatcher with own Shell.

Report Bugs in this ticket please.


----------------------------------------------------------------------

>Comment By: GingerDog (gingerdog)
Date: 2010-04-05 06:54

Message:
cool; i'll try and merge this son; nice idea.

----------------------------------------------------------------------

Comment By: Valkum ()
Date: 2010-04-05 02:20

Message:
Moved to v0.1b:
*Added some Copyright text
*Added postfixadmin-cli (bashscript)
*Changed text in console help function

Bugs fixed:
*Got "Class 'Info' not found when calling postfixadmin-cli without args -
fixed

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2981966&group_id=191583

[ postfixadmin-Patches-2981966 ] CLI for Postfixadmin

[SourceForge.net <no...@so...>]

Patches item #2981966, was opened at 2010-04-05 04:00
Message generated for change (Comment added) made by 
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2981966&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Widget (example)
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Valkum ()
Assigned to: Nobody/Anonymous (nobody)
Summary: CLI for Postfixadmin

Initial Comment:
Today i've spend a lot of time to make a simple CLI widget for Postfixadmin. So you can add a tons of mailboxes or aliases at once by one script execution.

The requirements are:

php-cli


Simply put the scripts folder in your main root of postfixadmin or somewhere else. You can add path to postfixadmin by -webroot /path/to/pfadmin

At the moment only user view and user password works
Version 0.2 comes tomorrow. eventually.

//btw: popen with dovecotpw doesn't work on cli. Need bugfix here.  <------ IMPORTANT (functions.inc.php - function pacrypt(..) )
Every time I got 'Enter new password:' on STDOUT from dovecotpw


Copyright to many tons of code goes to CakePHP great work.
CakePHP's dispatcher with own Shell.

Report Bugs in this ticket please.


----------------------------------------------------------------------

>Comment By: Valkum ()
Date: 2010-04-05 04:20

Message:
Moved to v0.1b:
*Added some Copyright text
*Added postfixadmin-cli (bashscript)
*Changed text in console help function

Bugs fixed:
*Got "Class 'Info' not found when calling postfixadmin-cli without args -
fixed

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2981966&group_id=191583

[ postfixadmin-Patches-2981966 ] CLI for Postfixadmin

[SourceForge.net <no...@so...>]

Patches item #2981966, was opened at 2010-04-05 04:00
Message generated for change (Tracker Item Submitted) made by 
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2981966&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Widget (example)
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Valkum ()
Assigned to: Nobody/Anonymous (nobody)
Summary: CLI for Postfixadmin

Initial Comment:
Today i've spend a lot of time to make a simple CLI widget for Postfixadmin. So you can add a tons of mailboxes or aliases at once by one script execution.

The requirements are:

php-cli


Simply put the scripts folder in your main root of postfixadmin or somewhere else. You can add path to postfixadmin by -webroot /path/to/pfadmin

At the moment only user view and user password works
Version 0.2 comes tomorrow. eventually.

//btw: popen with dovecotpw doesn't work on cli. Need bugfix here.  <------ IMPORTANT (functions.inc.php - function pacrypt(..) )
Every time I got 'Enter new password:' on STDOUT from dovecotpw


Copyright to many tons of code goes to CakePHP great work.
CakePHP's dispatcher with own Shell.

Report Bugs in this ticket please.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2981966&group_id=191583

[ postfixadmin-Feature Requests-2979998 ] Enable users to reset their passwords

[SourceForge.net <no...@so...>]

Feature Requests item #2979998, was opened at 2010-03-31 15:10
Message generated for change (Tracker Item Submitted) made by mnaumann
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=2979998&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Moritz Naumann (mnaumann)
Assigned to: Nobody/Anonymous (nobody)
Summary: Enable users to reset their passwords

Initial Comment:

Imagine this: You have postfixadmin setup for example.ORG which manages email forwarding only, no mailboxes. Postfixadmin manages the example.ORG virtual mail domain. You have us...@ex... who has - long time ago - setup or received a password to manage his mail forwarding service via postfixadmin, and has postfixadmin configured to forward mail to us...@ex..., where he can still receive email. 

Now user1 wants to change the email address his mail is forwarded to from us...@ex... to us...@ex..., but he forgot his postfixadmin password. Now would it not be nice if user1 was able to receive an email to his email address on file (us...@ex...), thus forwarded to us...@ex..., allowing him to confirm that he is in fact the 'owner' of this forwarder and therefore allowing him to regain access to postfixadmin so that he can change the address  us...@ex... forwards to?

This is a common use case for our setup where we have email aliases only and many users who need to configure them. Currently, if you (being a non privileged user) forgot your password, and try to login with an incorrect one, all you get to see is "Your email address or password are not correct." There is no way to regain access for the user. As such, right now, we need to spend lots of support time on resetting passwords for users. This could, however, be automated, and a user self-help functionality for password resets would be appreciated.

Suggested implementation:
Below the login form for users, display a 'reset password' link. Once clicked, display an informative page explaining the password reset process to the user.
Send a confirmation email to the user's email address on file. This email should contain a URL which refers to a (new) script of the postfixadmin installation. The URL contains a unique identifier which allows the user to confirm that he has had access to this confirmation request email. When clicking the URL, the user is forwarded to a web page where, if the unique ID matches, the user can then set a new password by himself. If the unique ID doesn't match, an error page is displayed.

Unique ID:
The unique ID can either be randomly generated and stored on the database (preferred security-wise) in relation to the email address it was generated for, or, more easily implementable, can be a hash of email address, date (in format YYYYmmdd) and a secret key (which is shared sitewide and stored in config.inc.php). This hash can later be generated by the application and checked against the UID which was passed via the URL. 

Further improvement:
The password reset function should be rate limited per email address: when a given number over a given time of reset requests has been triggered (such as three password reset request per day and email address), further requests within this time frame are refused.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=2979998&group_id=191583

[ postfixadmin-Bugs-2978579 ] slow with lots of users

[SourceForge.net <no...@so...>]

Bugs item #2978579, was opened at 2010-03-29 13:20
Message generated for change (Comment added) made by gingerdog
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2978579&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Database
Group: v 2.3
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Han Boetes (hboetes)
Assigned to: Nobody/Anonymous (nobody)
Summary: slow with lots of users

Initial Comment:
postfixadmin is pretty fast for our smaller domains, but one domain has 1500+ boxes and it's very slow allas. I can see with top that mysql is being consulted while I'm waiting. I suspect it's because it's generating the "ka-ka ka-ke ke-ke ke-ki ki-ki ki-ki ki-ko ko-kr kr-la la-la la-la la-le li-li li-li li-li" overview lines.

For that domain it's not really usefull. The admins simply search.

How can I disable the overview line? Would it be an idea to make this configurable?

----------------------------------------------------------------------

>Comment By: GingerDog (gingerdog)
Date: 2010-03-29 13:33

Message:
Hi,
Yes, it would be best if it was somehow a configurable property..



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2978579&group_id=191583

[ postfixadmin-Bugs-2978579 ] slow with lots of users

[SourceForge.net <no...@so...>]

Bugs item #2978579, was opened at 2010-03-29 13:20
Message generated for change (Tracker Item Submitted) made by hboetes
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2978579&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Database
Group: v 2.3
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Han Boetes (hboetes)
Assigned to: Nobody/Anonymous (nobody)
Summary: slow with lots of users

Initial Comment:
postfixadmin is pretty fast for our smaller domains, but one domain has 1500+ boxes and it's very slow allas. I can see with top that mysql is being consulted while I'm waiting. I suspect it's because it's generating the "ka-ka ka-ke ke-ke ke-ki ki-ki ki-ki ki-ko ko-kr kr-la la-la la-la la-le li-li li-li li-li" overview lines.

For that domain it's not really usefull. The admins simply search.

How can I disable the overview line? Would it be an idea to make this configurable?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2978579&group_id=191583

[ postfixadmin-Patches-2943017 ] Dovecot SSHA support

[SourceForge.net <no...@so...>]

Patches item #2943017, was opened at 2010-01-31 03:20
Message generated for change (Comment added) made by dehalion
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2943017&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Dehalion (dehalion)
Assigned to: Nobody/Anonymous (nobody)
Summary: Dovecot SSHA support

Initial Comment:
Dovecot SSHA encryption is not supported by default because dovecotpw doesn't allow to give a salt for creating a password.

I found a PHP function written by chantra at http://coding.debuntu.org/php-how-calculate-ssha-value-string which verifies a given SSHA hash and a plaintext password. This function is used if the password in the database starts with {SSHA} and dovecot is used as encryption type.

----------------------------------------------------------------------

Comment By: Dehalion (dehalion)
Date: 2010-03-27 15:55

Message:
Sorry for the wrong diff format.
I hoped my comment would clarify which file is modified (since I only
touched one single file). I updated the patch file and hope everything is
fine now :D

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2010-03-24 13:48

Message:
Hi
thanks for taking the time to submit the patch - however, could you please
regenerate it? It doesn't include any file names, or context around the
changes, so I'm unsure as to where it should apply.

If possible could you just attach the output from e.g. 'diff -u
newfile.php oldfile.php' or something similar?

Thanks!

----------------------------------------------------------------------

Comment By: Dehalion (dehalion)
Date: 2010-01-31 23:42

Message:
I forgot:
affected files: only functions.inc.php
modified function pacrypt()
added function ssha_verify_password()

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2943017&group_id=191583

[ postfixadmin-Patches-2974928 ] Domain Level Quotas

[SourceForge.net <no...@so...>]

Patches item #2974928, was opened at 2010-03-22 23:14
Message generated for change (Comment added) made by 
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2974928&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: W. Rossmann ()
Assigned to: Nobody/Anonymous (nobody)
Summary: Domain Level Quotas

Initial Comment:
Enables domain-level quota management by modifing the check_quota function in functions.php to check against the current total quota for the domain. A third, optional argument $username has been added for the case of modifying a quota, the user's current quota is excluded from the total. Minor modification to edit-mailbox.php to pass the username in the third argument.

Notes:
- Currently provides no front-end modification to a domain-level quota information, domain quotas must be set in the database
- Patch created based on v2.3

----------------------------------------------------------------------

>Comment By: W. Rossmann ()
Date: 2010-03-25 18:57

Message:
The add/edit domain pages were simpler and faster to modify than I thought.
The unified patch below rolls in quota checking, display, and
addition/editing as well as the relevant additions to $CONF and english
language file.

This patch also rolls in a resolution to the edit-alias.php bug:
https://sourceforge.net/tracker/?func=detail&aid=2976010&group_id=191583&atid=937964

----------------------------------------------------------------------

Comment By: W. Rossmann ()
Date: 2010-03-25 18:02

Message:
added a patch to display domain quotas in super-admin and domain-admin
list-domain.php, line numbering in config.inc.php might be a bit squiffy.

also, list-domain.php does the legwork for gathering domain information
into the $domain_properties array, why does templates/overview_get.php do
it over again with get_domain_properties()?

----------------------------------------------------------------------

Comment By: W. Rossmann ()
Date: 2010-03-22 23:18

Message:
* also assumes 'domain.quota' field is in MB

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2974928&group_id=191583

[ postfixadmin-Patches-2974928 ] Domain Level Quotas

[SourceForge.net <no...@so...>]

Patches item #2974928, was opened at 2010-03-22 23:14
Message generated for change (Comment added) made by 
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2974928&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: W. Rossmann ()
Assigned to: Nobody/Anonymous (nobody)
Summary: Domain Level Quotas

Initial Comment:
Enables domain-level quota management by modifing the check_quota function in functions.php to check against the current total quota for the domain. A third, optional argument $username has been added for the case of modifying a quota, the user's current quota is excluded from the total. Minor modification to edit-mailbox.php to pass the username in the third argument.

Notes:
- Currently provides no front-end modification to a domain-level quota information, domain quotas must be set in the database
- Patch created based on v2.3

----------------------------------------------------------------------

>Comment By: W. Rossmann ()
Date: 2010-03-25 18:02

Message:
added a patch to display domain quotas in super-admin and domain-admin
list-domain.php, line numbering in config.inc.php might be a bit squiffy.

also, list-domain.php does the legwork for gathering domain information
into the $domain_properties array, why does templates/overview_get.php do
it over again with get_domain_properties()?

----------------------------------------------------------------------

Comment By: W. Rossmann ()
Date: 2010-03-22 23:18

Message:
* also assumes 'domain.quota' field is in MB

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2974928&group_id=191583

[ postfixadmin-Patches-2976213 ] maildir name hook

[SourceForge.net <no...@so...>]

Patches item #2976213, was opened at 2010-03-24 23:42
Message generated for change (Tracker Item Submitted) made by 
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2976213&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: W. Rossmann ()
Assigned to: Nobody/Anonymous (nobody)
Summary: maildir name hook

Initial Comment:
Regarding the hook to define a function to create a custom maildir:
https://sourceforge.net/projects/postfixadmin/forums/forum/676076/topic/3493439

I've gone ahead and done so. One directive added to $CONF, one function added to functions.inc.php, and a modification to create-mailbox.php to implement it.

Generated based on v2.3

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2976213&group_id=191583

[ postfixadmin-Bugs-2976010 ] edit-alias.php backwards in_array arguments

[SourceForge.net <no...@so...>]

Bugs item #2976010, was opened at 2010-03-24 16:41
Message generated for change (Tracker Item Submitted) made by 
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2976010&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: v 2.3
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: W. Rossmann ()
Assigned to: Nobody/Anonymous (nobody)
Summary: edit-alias.php backwards in_array arguments

Initial Comment:
144             if(in_array($orig_alias_list, $fAddress)) {

should be

144             if(in_array($fAddress, $orig_alias_list)) {

and seems to still be this way in the current SVN version. [r816, ln140]

Also, there seems to be a flaw in the logic of this file where if special_alias_control = NO the mailbox alias is removed, but is only restored if alias_control_admin = NO as well which essentially ~does~ let the domain admin control the default mailbox alias by virtue of it being removed if they do not add it back manually.

Lines relevant to the above are 73 and 142 in v2.3, 68 and 138 in SVN r816

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2976010&group_id=191583