[ postfixadmin-Bugs-3152571 ] Vacation dates not working

[SourceForge.net <no...@so...>]

Bugs item #3152571, was opened at 2011-01-06 20:15
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3152571&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: SVN (please specify revision!)
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Colin Viebrock (cviebrock)
Assigned to: Nobody/Anonymous (nobody)
Summary: Vacation dates not working

Initial Comment:
The SQL that checks to make sure the vacation is between the start and stop dates is only in one of 3 queries.  Here's the patch (against rev 757, but I see the fix isn't in 882 either) to add the SQL conditions to the other two queries.

I'm not sure if this is the most efficient solution, though.  Perhaps this logic shouldn't be in the queries at all, and instead maybe the find_real_address() should return the entire record, and have the date range checking done at the end of the script in the main program?

- Colin

----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2011-02-27 22:36

Message:
Thanks for the bugreport and your patch! 

I commited it to SVN r970 - and added a TODO note that we should use a
function instead of 3 copies of the same query ;-)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3152571&group_id=191583