Re: [Postfixadmin-devel] Regarding Bug #2835877
Brought to you by:
christian_boltz,
gingerdog
From: Stevan B. <st...@ba...> - 2009-10-20 20:25:12
|
On Tue, 20 Oct 2009 20:27:27 +0100 David Goodwin <da...@co...> wrote: > > I checked out trunk and see this here: > > ------------------- > > # Recipient has vacation > > if ($rv == 1) { > > $realemail = $email; > > $logger->debug("Found '\$email'\ has vacation active"); > > } else { > > my $vemail = $email; > > $vemail =~ s/\@/#/g; > > $logger->debug("Looking for alias records that \'$email\' resolves to with vacation turned on"); > > $query = qq{SELECT goto FROM alias WHERE address=? AND (goto LIKE ? OR goto LIKE ? OR goto LIKE ?)}; > > $stm = $dbh->prepare($query) or panic_prepare($query); > > $stm->execute($email,"$email,%","%,$email","%,$email,%") or panic_execute($query,"address='$email'"); > > $rv = $stm->rows; > > ------------------- > > > > This is not going to work. This part here: > > ------------------- > > $stm->execute($email,"$email,%","%,$email","%,$email,%") or panic_execute($query,"address='$email'"); > > ------------------- > > > > Is going to be executed as: > > ------------------- > > SELECT goto FROM alias WHERE address='da...@co...' AND (goto LIKE 'da...@co...,%' OR goto LIKE '%,da...@co...' OR goto LIKE '%,da...@co...,%') > > ------------------- > > > > Hi, > Hallo David, > The code above lives in a function called find_recipient() (or > something similar). BEFORE this is called we convert the SMTP > recipient (e.g. foo#bar@autoreply.whatever) to it's real email addres > (e.g. foo@bar). Hence I'm confused as to why you still insist it's > wrong. Can you please read the code which calls that function and > confirm I'm right - perhaps I've totally misread it? > I have attached the patch I would use to patch Postfix.Admin trunk for fixing that issue regarding alias lookups. I was so free to change the email addresses in the header to not be directly addressable. > Thanks > Kind Regards from Switzerland > David. > Stevan Bajic |