[ postfixadmin-Patches-2545787 ] Check if notified_at is older than created

[SourceForge.net <no...@so...>]

Patches item #2545787, was opened at 2009-01-29 15:56
Message generated for change (Comment added) made by gingerdog
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2545787&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: SVN (please specify revision!)
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Rag3Rac3r (rag3rac3r)
Assigned to: Nobody/Anonymous (nobody)
Summary: Check if notified_at is older than created

Initial Comment:
This patch really only applies under certain conditions, when PFAs php-script for some reason can't delete the entry from the vacation_notification table (for example if your running MySQL Replication to a off site email server, and you don't like to setup a master<->master replication in MySQL).

What it does is that it enables so vacation.pl takes into consideration that the vacation_notification table can contain outdated values (i.e. a user has changed his message and/or come back from vacation and gone on vacation again).

It creates a higher amount of sql queries as an conditional query is moved to be an needed sql query, so it should really be used when you only have to.
And it should also be combined with an shell script (perl, php, sh) to clean the vacation_notification table.

Patch applies to SVN rev. 535

My suggestion to maintainers is to place it into contrib, this should NOT go into the vacation.pl as it still only applies under very special circumstances.

----------------------------------------------------------------------

>Comment By: GingerDog (gingerdog)
Date: 2009-01-30 08:14

Message:
Thanks; I'll try and review it and add it to SVN shortly. (If I've not done
anything in a week, feel free to give me a kick)

----------------------------------------------------------------------

Comment By: Rag3Rac3r (rag3rac3r)
Date: 2009-01-29 23:45

Message:
Added a example cleanup script for the table in the database that both
cleans out active vacations where the notifcation was sent out last time
the user was on vacation and where the vacation is inactive and it in
normal cases would've been purged by the PFA webscripts.
Perl isn't my strong side, if it had been, the script would've been in
that ;)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2545787&group_id=191583