Menu
▾
▴
poptop-server — Main discussion group for poptop PPTP server
You can subscribe to this list here.
| 2002 |
Jan
|
Feb
|
Mar
(5) |
Apr
(11) |
May
(14) |
Jun
(24) |
Jul
(95) |
Aug
(57) |
Sep
(46) |
Oct
(117) |
Nov
(132) |
Dec
(206) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2003 |
Jan
(203) |
Feb
(210) |
Mar
(204) |
Apr
(155) |
May
(316) |
Jun
(297) |
Jul
(294) |
Aug
(207) |
Sep
(168) |
Oct
(109) |
Nov
(128) |
Dec
(185) |
| 2004 |
Jan
(220) |
Feb
(283) |
Mar
(222) |
Apr
(149) |
May
(112) |
Jun
(158) |
Jul
(134) |
Aug
(90) |
Sep
(170) |
Oct
(163) |
Nov
(65) |
Dec
(144) |
| 2005 |
Jan
(172) |
Feb
(178) |
Mar
(177) |
Apr
(148) |
May
(66) |
Jun
(156) |
Jul
(102) |
Aug
(137) |
Sep
(67) |
Oct
(55) |
Nov
(53) |
Dec
(54) |
| 2006 |
Jan
(63) |
Feb
(73) |
Mar
(93) |
Apr
(68) |
May
(48) |
Jun
(126) |
Jul
(62) |
Aug
(52) |
Sep
(51) |
Oct
(47) |
Nov
(50) |
Dec
(10) |
| 2007 |
Jan
(50) |
Feb
(47) |
Mar
(5) |
Apr
(57) |
May
(85) |
Jun
(35) |
Jul
(9) |
Aug
(19) |
Sep
(24) |
Oct
(53) |
Nov
(44) |
Dec
(28) |
| 2008 |
Jan
(26) |
Feb
(31) |
Mar
(21) |
Apr
(21) |
May
(31) |
Jun
(57) |
Jul
(31) |
Aug
(26) |
Sep
(35) |
Oct
(17) |
Nov
(25) |
Dec
(38) |
| 2009 |
Jan
(25) |
Feb
(31) |
Mar
(25) |
Apr
(25) |
May
(24) |
Jun
(24) |
Jul
(14) |
Aug
(9) |
Sep
(8) |
Oct
|
Nov
(44) |
Dec
(18) |
| 2010 |
Jan
(24) |
Feb
(17) |
Mar
(64) |
Apr
(11) |
May
(1) |
Jun
(25) |
Jul
(4) |
Aug
(3) |
Sep
(9) |
Oct
(19) |
Nov
(5) |
Dec
(2) |
| 2011 |
Jan
(5) |
Feb
(6) |
Mar
(14) |
Apr
(29) |
May
(3) |
Jun
(4) |
Jul
(2) |
Aug
(4) |
Sep
(12) |
Oct
(6) |
Nov
(7) |
Dec
|
| 2012 |
Jan
(4) |
Feb
(4) |
Mar
(1) |
Apr
(29) |
May
(10) |
Jun
(3) |
Jul
(25) |
Aug
(26) |
Sep
(2) |
Oct
(5) |
Nov
(5) |
Dec
|
| 2013 |
Jan
(37) |
Feb
(18) |
Mar
|
Apr
(15) |
May
(4) |
Jun
|
Jul
|
Aug
|
Sep
|
Oct
(23) |
Nov
(42) |
Dec
|
| 2014 |
Jan
|
Feb
(14) |
Mar
(7) |
Apr
|
May
(11) |
Jun
|
Jul
|
Aug
(2) |
Sep
|
Oct
(12) |
Nov
|
Dec
|
| 2015 |
Jan
|
Feb
(2) |
Mar
|
Apr
|
May
(3) |
Jun
|
Jul
|
Aug
|
Sep
|
Oct
(48) |
Nov
|
Dec
(4) |
| 2016 |
Jan
|
Feb
(1) |
Mar
|
Apr
|
May
(3) |
Jun
|
Jul
(8) |
Aug
|
Sep
|
Oct
|
Nov
(1) |
Dec
(1) |
| 2019 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(1) |
Oct
(2) |
Nov
|
Dec
|
| 2020 |
Jan
|
Feb
|
Mar
(3) |
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
(3) |
Nov
|
Dec
|
| 2023 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
(2) |
Dec
|
| 2024 |
Jan
|
Feb
|
Mar
|
Apr
|
May
(1) |
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: James C. <qu...@la...> - 2024-05-18 05:05:30
|
G'day,
pptpd 1.5.0 has been released. git tag pushed.
Please reply to the mailing list with your test results.
See:
https://sourceforge.net/projects/poptop/files/pptpd/pptpd-1.5.0/
https://github.com/quozl/pptpd
Checksums:
733be416d9388d48fb678a213c637503 pptpd-1.5.0.tar.gz
6a724284b1ce00ea23f7d7608d081843a10c8a8d87d951cb2ea86e70aa1b4e77 pptpd-1.5.0.tar.gz
|
|
From: James C. <qu...@la...> - 2023-11-27 10:46:57
|
Thanks, taken.
b77d92c ("Build fixes for ppp-2.5")
On Sun, Nov 26, 2023 at 01:59:58PM +0100, Christoph Biedl wrote:
> Hello,
>
> it seems pptpd needs some adjustment for pppd 2.5. The patch attached
> was submitted by Chris Boot, as part of Debian bug report #1056898
> <https://bugs.debian.org/1056898>. I guess this should go upstream, so
> please consider inclusion.
>
> All the best,
> Christoph
> Subject: Build fixes for ppp-2.5
> Author: Chris Boot <bo...@de...>
> Last-Update: 2023-11-26
>
> --- a/plugins/pptpd-logwtmp.c
> +++ b/plugins/pptpd-logwtmp.c
> @@ -12,9 +12,12 @@
> #include <unistd.h>
> #include <utmp.h>
> #include <string.h>
> +#include <linux/if.h>
> +#include <linux/limits.h>
> #include <pppd/pppd.h>
> +#include <pppd/options.h>
>
> -char pppd_version[] = VERSION;
> +char pppd_version[] = PPPD_VERSION;
>
> static char pptpd_original_ip[PATH_MAX+1];
> static bool pptpd_logwtmp_strip_domain = 0;
> @@ -28,7 +31,7 @@
> { NULL }
> };
>
> -static char *reduce(char *user)
> +static const char *reduce(const char *user)
> {
> char *sep;
> if (!pptpd_logwtmp_strip_domain) return user;
> @@ -42,8 +45,10 @@
>
> static void ip_up(void *opaque, int arg)
> {
> - char *user = reduce(peer_authname);
> - if (debug)
> + char ifname[IFNAMSIZ];
> + const char *user = reduce(ppp_peer_authname(NULL, 0));
> + ppp_get_ifname(ifname, sizeof(ifname));
> + if (debug_on())
> notice("pptpd-logwtmp.so ip-up %s %s %s", ifname, user,
> pptpd_original_ip);
> logwtmp(ifname, user, pptpd_original_ip);
> @@ -51,16 +56,18 @@
>
> static void ip_down(void *opaque, int arg)
> {
> - if (debug)
> + char ifname[IFNAMSIZ];
> + ppp_get_ifname(ifname, sizeof(ifname));
> + if (debug_on())
> notice("pptpd-logwtmp.so ip-down %s", ifname);
> logwtmp(ifname, "", "");
> }
>
> void plugin_init(void)
> {
> - add_options(options);
> - add_notifier(&ip_up_notifier, ip_up, NULL);
> - add_notifier(&ip_down_notifier, ip_down, NULL);
> - if (debug)
> + ppp_add_options(options);
> + ppp_add_notify(NF_IP_UP, ip_up, NULL);
> + ppp_add_notify(NF_IP_DOWN, ip_down, NULL);
> + if (debug_on())
> notice("pptpd-logwtmp: $Version$");
> }
> _______________________________________________
> Poptop-server mailing list
> Pop...@li...
> https://lists.sourceforge.net/lists/listinfo/poptop-server
|
|
From: Christoph B. <sou...@ma...> - 2023-11-26 13:25:04
|
Hello, it seems pptpd needs some adjustment for pppd 2.5. The patch attached was submitted by Chris Boot, as part of Debian bug report #1056898 <https://bugs.debian.org/1056898>. I guess this should go upstream, so please consider inclusion. All the best, Christoph |
|
From: Dahili N. <dah...@gm...> - 2020-10-09 13:07:48
|
Friends i have IPV6 /64 subnet witch is Start Range: 2a01:4f9:c010:1c0b:0:0:0:0 End Range: 2a01:4f9:c010:1c0b:ffff:ffff:ffff:ffff No. of host: 18446744073709551616 i love to offer ipv6 via poptop i seeking paid help |
|
From: mattias j. <mj...@mj...> - 2020-10-08 19:17:51
|
On windows Are it normal that the gateway are 0.0.0.0 Skickades från E-post<https://go.microsoft.com/fwlink/?LinkId=550986> för Windows 10 |
|
From: mattias <mjo...@gm...> - 2020-10-08 14:45:34
|
<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!-- /* Font Definitions */ @font-face {font-family:"Cambria Math"; panose-1:2 4 5 3 5 4 6 3 2 4;} @font-face {font-family:Calibri; panose-1:2 15 5 2 2 2 4 3 2 4;} /* Style Definitions */ p.MsoNormal, li.MsoNormal, div.MsoNormal {margin:0cm; font-size:11.0pt; font-family:"Calibri",sans-serif;} a:link, span.MsoHyperlink {mso-style-priority:99; color:blue; text-decoration:underline;} .MsoChpDefault {mso-style-type:export-only;} @page WordSection1 {size:612.0pt 792.0pt; margin:70.85pt 70.85pt 70.85pt 70.85pt;} div.WordSection1 {page:WordSection1;} --></style></head><body lang=SV link=blue vlink="#954F72" style='word-wrap:break-word'><div class=WordSection1><p class=MsoNormal>Are it normal that the gateway on the client are 0.0.0.0?</p><p class=MsoNormal>The ip from the server are correct</p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Skickades från <a href="https://go.microsoft.com/fwlink/?LinkId=550986">E-post</a> för Windows 10</p><p class=MsoNormal><o:p> </o:p></p></div></body></html> |
|
From: mattias <mjo...@gm...> - 2020-03-13 06:32:41
|
yes you run centos7 but i run centos 8 Den 2020-03-13 kl. 03:35, skrev Dahili Network: > yum install -y epel-release > > yum install -y pptpd > > rpm -qa |grep pptpd > pptpd-1.4.0-2.el7.x86_64 > > > > > > On 12.03.2020 20:51, mattias wrote: >> no match for pptpd >> >> Den 2020-03-12 kl. 18:34, skrev Dahili Network: >>> >>> yes >>> >>> >>> >>> >>> >>> >>> >>> On 12.03.2020 17:25, mattias wrote: >>>> any compatible centos8 rpm? >>>> >>>> >>>> >>>> _______________________________________________ >>>> Poptop-server mailing list >>>> Pop...@li... >>>> https://lists.sourceforge.net/lists/listinfo/poptop-server >> >> >> _______________________________________________ >> Poptop-server mailing list >> Pop...@li... >> https://lists.sourceforge.net/lists/listinfo/poptop-server |
|
From: mattias <mjo...@gm...> - 2020-03-12 17:51:39
|
no match for pptpd Den 2020-03-12 kl. 18:34, skrev Dahili Network: > > yes > > yum install -y pptpd > > > > > > On 12.03.2020 17:25, mattias wrote: >> any compatible centos8 rpm? >> >> >> >> _______________________________________________ >> Poptop-server mailing list >> Pop...@li... >> https://lists.sourceforge.net/lists/listinfo/poptop-server |
|
From: mattias <mjo...@gm...> - 2020-03-12 14:25:48
|
any compatible centos8 rpm? |
|
From: James C. <qu...@la...> - 2019-10-14 22:43:42
|
Thanks. Fixed in 3b7a80c3b63a9f9388991299f76c245bb900875e. On Mon, Oct 14, 2019 at 04:32:17PM +0000, mattias jonsson wrote: > seems not to work > > you can run configure > > but make gives errors > > > _______________________________________________ > Poptop-server mailing list > Pop...@li... > https://lists.sourceforge.net/lists/listinfo/poptop-server -- James Cameron http://quozl.netrek.org/ |
|
From: mattias j. <mj...@mj...> - 2019-10-14 20:06:08
|
seems not to work you can run configure but make gives errors |
|
From: Dahili N. <dah...@gm...> - 2019-09-04 09:56:15
|
dear developer friends my sourceforge developer id is oguzersoz i love to compile poptop with /8 subnet and need paid help may be better if we can create isolated groups for clients, not to create isolated users also may be better if we move chap-secrets in to mysql database like powerdns done i attached my ideal pptpd network diagram my watsapp +905548842814 my email dah...@gm... |
|
From: James C. <qu...@la...> - 2016-12-26 02:01:06
|
On Sat, Dec 24, 2016 at 11:17:18PM +0100, Christoph Biedl wrote:
> Unfortunately this has an unpleaseant side effect: Since the new
> pptpd instance has no knowlegde of the old one's children, it will
> happily allocate connection slots (by IP address) that are already
> in use. So the second client will not see any traffic.
Yes, but only when IP address allocation is controlled by pptpd.
Other IP address allocation methods are radius, chap-secrets (pppd),
and remote (ipcp-accept-remote). For this pptpd takes --delegate
option.
> The only way to solve this AFAICS was the old instance persists all
> the childrens' information so the new one will not allocate them
> while they are running. There might be some race conditions to
> consider as well. James (upstream) is reading this, if you can solve
> this by Jan 20th I'll be happy to include it for stretch. Afterwards
> it might be too late.
I've no plans to fix this by that date, but I'm interested in patches
to do so.
My preference is a /var/run/pptpd/ip directory containing a file for
each active connection, name equal to IP address, content is PID.
pptpmanager.c slot_* functions would maintain these files as a mirror
of struct slot *slots.
Here's a quick pseudo-code plan;
void slot_set_pid(int i, pid_t pid)
{
struct slot *slot = &slots[i];
// if pid is zero, {
// delete file,
// } else {
// create and write pid to file
// }
slot->pid = pid;
}
int slot_find_by_pid(pid_t pid)
{
int i;
for(i=0; i<slot_count; i++) {
struct slot *slot = &slots[i];
if (slot->pid == pid)
// if file exists, {
// read pid from file,
// if pid exists (kill with sig zero), {
// continue (skip slot),
// } else {
// unlink file,
// }
return i;
}
return -1;
}
--
James Cameron
http://quozl.netrek.org/
|
|
From: James C. <qu...@la...> - 2016-07-08 04:07:08
|
Thanks, pushed as d7b9552.
"git format-patch" style of mail is also welcome, and will save me a
few minutes. ;-)
On Fri, Jul 08, 2016 at 12:58:07AM +0200, Christoph Biedl wrote:
> Hello,
>
> it's easily possible to trigger a segfault in pptpctrl:
>
> # /usr/sbin/pptpctrl 0 0 1 /etc/ppp/pptpd-options 0 1
>
> This happened when triggering a bug in pptpmanager I am currently
> working on. The check for (argc < 7) isn't sufficient, my suggested
> fix adds a check to any GETARG_* invocation.
>
> Christoph
>
> --- a/pptpctrl.c
> +++ b/pptpctrl.c
> @@ -92,19 +92,29 @@ static void launch_pppd(char **pppaddrs, struct in_addr *inetaddrs);
> #define OUR_NB_MODE O_NDELAY
> #endif
>
> +void usage()
> +{
> + fprintf(stderr, "pptpctrl: insufficient arguments, see man pptpctrl\n");
> + exit(2);
> +}
> +
> /* read a command line argument, a flag alone */
> #define GETARG_INT(X) \
> + if (arg >= argc) usage() ; \
> X = atoi(argv[arg++])
>
> /* read a command line argument, a string alone */
> #define GETARG_STRING(X) \
> + if (arg >= argc) usage() ; \
> X = strdup(argv[arg++])
>
> /* read a command line argument, a presence flag followed by string */
> #define GETARG_VALUE(X) \
> - if(atoi(argv[arg++]) != 0) \
> + if (arg >= argc) usage() ; \
> + if(atoi(argv[arg++]) != 0) { \
> + if (arg >= argc) usage() ; \
> strlcpy(X, argv[arg++], sizeof(X)); \
> - else \
> + } else \
> *X = '\0'
>
> int main(int argc, char **argv)
> @@ -122,10 +132,8 @@ int main(int argc, char **argv)
> gargv = argv;
>
> /* fail if argument count invalid */
> - if (argc < 7) {
> - fprintf(stderr, "pptpctrl: insufficient arguments, see man pptpctrl\n");
> - exit(2);
> - }
> + if (argc < 7)
> + usage();
>
> /* open a connection to the syslog daemon */
> openlog("pptpd", LOG_PID, PPTP_FACILITY);
>
> ------------------------------------------------------------------------------
> Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
> Francisco, CA to explore cutting-edge tech and listen to tech luminaries
> present their vision of the future. This family event has something for
> everyone, including kids. Get more information and register today.
> http://sdm.link/attshape
> _______________________________________________
> Poptop-server mailing list
> Pop...@li...
> https://lists.sourceforge.net/lists/listinfo/poptop-server
--
James Cameron
http://quozl.netrek.org/
|
|
From: James C. <qu...@la...> - 2016-07-08 04:06:13
|
On Fri, Jul 08, 2016 at 12:51:31AM +0200, Christoph Biedl wrote: > James Cameron wrote... > > > My guess is padding that will be written to later by the forked > > process; what does it look like when running normally? See inststr.c > > and my_setproctitle in compat.c. > > That makes sense. > > > If so, a comment patch would be welcome. > > How about the following? Thanks, pushed as b839696. -- James Cameron http://quozl.netrek.org/ |
|
From: James C. <qu...@la...> - 2016-07-08 04:05:43
|
Thanks, pushed as 0c0ad67.
On Thu, Jul 07, 2016 at 10:49:47PM +0200, Christoph Biedl wrote:
> Hello,
>
> at the moment, pptpd will happily process lines like
>
> | remoteip 192.168.0.234-234,192.168.0.234,192.168.0.234
>
> and afterwards state "MGR: Maximum of 3 connections available". While
> technically true, I guess this is never by intention but will result
> in interesting behaviour. Can you please add a check for duplicate
> addresses? It's not urgent at all but avoids havoc if the
> administrator has a bad day.
>
> The patch below worked for me.
>
> Christoph
>
> --- a/pptpmanager.c
> +++ b/pptpmanager.c
> @@ -136,6 +136,13 @@ void slot_set_local(int i, char *ip)
> void slot_set_remote(int i, char *ip)
> {
> struct slot *slot = &slots[i];
> + int j;
> + for (j = 0; j < slot_count; j++) {
> + if (!slots[j].remote || strcmp(slots[j].remote, ip))
> + continue;
> + syslog(LOG_ERR, "MGR: Remote IP address %s in config file is a duplicate!", ip);
> + exit(1);
> + }
> if (slot->remote) free(slot->remote);
> slot->remote = strdup(ip);
> }
>
> ------------------------------------------------------------------------------
> Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
> Francisco, CA to explore cutting-edge tech and listen to tech luminaries
> present their vision of the future. This family event has something for
> everyone, including kids. Get more information and register today.
> http://sdm.link/attshape
> _______________________________________________
> Poptop-server mailing list
> Pop...@li...
> https://lists.sourceforge.net/lists/listinfo/poptop-server
--
James Cameron
http://quozl.netrek.org/
|
|
From: Christoph B. <sou...@ma...> - 2016-07-07 22:58:15
|
Hello,
it's easily possible to trigger a segfault in pptpctrl:
# /usr/sbin/pptpctrl 0 0 1 /etc/ppp/pptpd-options 0 1
This happened when triggering a bug in pptpmanager I am currently
working on. The check for (argc < 7) isn't sufficient, my suggested
fix adds a check to any GETARG_* invocation.
Christoph
--- a/pptpctrl.c
+++ b/pptpctrl.c
@@ -92,19 +92,29 @@ static void launch_pppd(char **pppaddrs, struct in_addr *inetaddrs);
#define OUR_NB_MODE O_NDELAY
#endif
+void usage()
+{
+ fprintf(stderr, "pptpctrl: insufficient arguments, see man pptpctrl\n");
+ exit(2);
+}
+
/* read a command line argument, a flag alone */
#define GETARG_INT(X) \
+ if (arg >= argc) usage() ; \
X = atoi(argv[arg++])
/* read a command line argument, a string alone */
#define GETARG_STRING(X) \
+ if (arg >= argc) usage() ; \
X = strdup(argv[arg++])
/* read a command line argument, a presence flag followed by string */
#define GETARG_VALUE(X) \
- if(atoi(argv[arg++]) != 0) \
+ if (arg >= argc) usage() ; \
+ if(atoi(argv[arg++]) != 0) { \
+ if (arg >= argc) usage() ; \
strlcpy(X, argv[arg++], sizeof(X)); \
- else \
+ } else \
*X = '\0'
int main(int argc, char **argv)
@@ -122,10 +132,8 @@ int main(int argc, char **argv)
gargv = argv;
/* fail if argument count invalid */
- if (argc < 7) {
- fprintf(stderr, "pptpctrl: insufficient arguments, see man pptpctrl\n");
- exit(2);
- }
+ if (argc < 7)
+ usage();
/* open a connection to the syslog daemon */
openlog("pptpd", LOG_PID, PPTP_FACILITY);
|
|
From: Christoph B. <sou...@ma...> - 2016-07-07 22:51:40
|
James Cameron wrote...
> My guess is padding that will be written to later by the forked
> process; what does it look like when running normally? See inststr.c
> and my_setproctitle in compat.c.
That makes sense.
> If so, a comment patch would be welcome.
How about the following?
Christoph
--- a/pptpmanager.c
+++ b/pptpmanager.c
@@ -483,7 +483,12 @@ static void connectCall(int clientSocket, int clientNumber)
* speed and option file on the command line.
*/
+#ifdef HAVE_SETPROCTITLE
+ ctrl_argv[pptpctrl_argc++] = PPTP_CTRL_BIN;
+#else
+ /* Add some padding so the forked process can change the title */
ctrl_argv[pptpctrl_argc++] = PPTP_CTRL_BIN " ";
+#endif
/* Pass socket as stdin */
if (clientSocket != 0) {
|
|
From: James C. <qu...@la...> - 2016-07-07 22:17:17
|
On Thu, Jul 07, 2016 at 11:49:50PM +0200, Christoph Biedl wrote: > Hello, > > while looking for some other issue, I came across the following line > in pptpmanager.c:486: > > | ctrl_argv[pptpctrl_argc++] = PPTP_CTRL_BIN " "; > > That existed since the initial commit, but what's the reason for > padding extra spaces after the program's path? My guess is padding that will be written to later by the forked process; what does it look like when running normally? See inststr.c and my_setproctitle in compat.c. If so, a comment patch would be welcome. > The only thing I can > think of was to hide further parameters from from "ps" output. That > was rather weird, though. > > Christoph > > ------------------------------------------------------------------------------ > Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San > Francisco, CA to explore cutting-edge tech and listen to tech luminaries > present their vision of the future. This family event has something for > everyone, including kids. Get more information and register today. > http://sdm.link/attshape > _______________________________________________ > Poptop-server mailing list > Pop...@li... > https://lists.sourceforge.net/lists/listinfo/poptop-server -- James Cameron http://quozl.netrek.org/ |
|
From: Christoph B. <sou...@ma...> - 2016-07-07 21:49:58
|
Hello,
while looking for some other issue, I came across the following line
in pptpmanager.c:486:
| ctrl_argv[pptpctrl_argc++] = PPTP_CTRL_BIN " ";
That existed since the initial commit, but what's the reason for
padding extra spaces after the program's path? The only thing I can
think of was to hide further parameters from from "ps" output. That
was rather weird, though.
Christoph
|
|
From: Christoph B. <sou...@ma...> - 2016-07-07 21:09:27
|
Hello,
at the moment, pptpd will happily process lines like
| remoteip 192.168.0.234-234,192.168.0.234,192.168.0.234
and afterwards state "MGR: Maximum of 3 connections available". While
technically true, I guess this is never by intention but will result
in interesting behaviour. Can you please add a check for duplicate
addresses? It's not urgent at all but avoids havoc if the
administrator has a bad day.
The patch below worked for me.
Christoph
--- a/pptpmanager.c
+++ b/pptpmanager.c
@@ -136,6 +136,13 @@ void slot_set_local(int i, char *ip)
void slot_set_remote(int i, char *ip)
{
struct slot *slot = &slots[i];
+ int j;
+ for (j = 0; j < slot_count; j++) {
+ if (!slots[j].remote || strcmp(slots[j].remote, ip))
+ continue;
+ syslog(LOG_ERR, "MGR: Remote IP address %s in config file is a duplicate!", ip);
+ exit(1);
+ }
if (slot->remote) free(slot->remote);
slot->remote = strdup(ip);
}
|
|
From: James C. <qu...@la...> - 2016-05-11 23:23:23
|
On Wed, May 11, 2016 at 12:33:17PM +0000, vemula balaji wrote: > I am using poptop pptp server. > [...] > > PPTP version is > pptpd -v > accel-pptpd v0.8.5 compiled for pppd-2.4.5, linux-3.2.54 accel-pptpd is not poptop. -- James Cameron http://quozl.netrek.org/ |
|
From: vemula b. <bal...@ya...> - 2016-05-11 13:06:48
|
poptop pptp server is assigning same client ip address with multiple PID's
ps axf | grep pppd 2141 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 115 4525 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 115 4879 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 115 4899 root 3224 S grep pppd 5119 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 115 5567 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 115 5951 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 115 6159 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 115 6315 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 115 6491 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 115 6753 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 115 6879 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 115 7231 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 115 7368 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 115 7734 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 115 7778 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 115 8493 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 11514517 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 11515420 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 11515883 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 11516246 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 11516575 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 11518735 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 11519122 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 11519525 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 11519888 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 11520317 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 11521614 root 3088 T cat /usr/sbin/pppd local file /etc/ppp/options.pptpd28392 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 11528722 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 11529035 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 11529662 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 11530097 root 6256 S /usr/sbin/pppd local file /etc/ppp/options.pptpd 115 Thanks,
V.Balaji
94402 45849
On Wednesday, 11 May 2016 6:03 PM, vemula balaji <bal...@ya...> wrote:
Hi,
I am using poptop pptp server. I am able to establish multiple pptp connections to the server from a single pptp client machine. (more than 30).Though i configured maximum connections as 25 only.
PPTP version ispptpd -vaccel-pptpd v0.8.5 compiled for pppd-2.4.5, linux-3.2.54
I am observing duplicate pptp connections on client as follows.
ppp27 Link encap:Point-to-Point Protocol inet addr:6.6.6.7 P-t-P:6.6.6.6 Mask:255.255.255.255 UP POINTOPOINT RUNNING NOARP MULTICAST MTU:1500 Metric:1 RX packets:4 errors:0 dropped:0 overruns:0 frame:0 TX packets:4 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:3 RX bytes:40 (40.0 B) TX bytes:46 (46.0 B)
ppp28 Link encap:Point-to-Point Protocol inet addr:6.6.6.7 P-t-P:6.6.6.6 Mask:255.255.255.255 UP POINTOPOINT RUNNING NOARP MULTICAST MTU:1500 Metric:1 RX packets:4 errors:0 dropped:0 overruns:0 frame:0 TX packets:4 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:3 RX bytes:40 (40.0 B) TX bytes:46 (46.0 B)
ppp29 Link encap:Point-to-Point Protocol inet addr:6.6.6.7 P-t-P:6.6.6.6 Mask:255.255.255.255 UP POINTOPOINT RUNNING NOARP MULTICAST MTU:1500 Metric:1 RX packets:4 errors:0 dropped:0 overruns:0 frame:0 TX packets:4 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:3 RX bytes:40 (40.0 B) TX bytes:46 (46.0 B)
ppp30 Link encap:Point-to-Point Protocol inet addr:6.6.6.7 P-t-P:6.6.6.6 Mask:255.255.255.255 UP POINTOPOINT RUNNING NOARP MULTICAST MTU:1500 Metric:1 RX packets:4 errors:0 dropped:0 overruns:0 frame:0 TX packets:4 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:3 RX bytes:40 (40.0 B) TX bytes:46 (46.0 B)
Please let me know if i have to make any changes to the configuration file.
Any pointers are helpful.
Thanks,
V.Balaji
|
|
From: vemula b. <bal...@ya...> - 2016-05-11 12:33:30
|
Hi, I am using poptop pptp server. I am able to establish multiple pptp connections to the server from a single pptp client machine. (more than 30).Though i configured maximum connections as 25 only. PPTP version ispptpd -vaccel-pptpd v0.8.5 compiled for pppd-2.4.5, linux-3.2.54 I am observing duplicate pptp connections on client as follows. ppp27 Link encap:Point-to-Point Protocol inet addr:6.6.6.7 P-t-P:6.6.6.6 Mask:255.255.255.255 UP POINTOPOINT RUNNING NOARP MULTICAST MTU:1500 Metric:1 RX packets:4 errors:0 dropped:0 overruns:0 frame:0 TX packets:4 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:3 RX bytes:40 (40.0 B) TX bytes:46 (46.0 B) ppp28 Link encap:Point-to-Point Protocol inet addr:6.6.6.7 P-t-P:6.6.6.6 Mask:255.255.255.255 UP POINTOPOINT RUNNING NOARP MULTICAST MTU:1500 Metric:1 RX packets:4 errors:0 dropped:0 overruns:0 frame:0 TX packets:4 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:3 RX bytes:40 (40.0 B) TX bytes:46 (46.0 B) ppp29 Link encap:Point-to-Point Protocol inet addr:6.6.6.7 P-t-P:6.6.6.6 Mask:255.255.255.255 UP POINTOPOINT RUNNING NOARP MULTICAST MTU:1500 Metric:1 RX packets:4 errors:0 dropped:0 overruns:0 frame:0 TX packets:4 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:3 RX bytes:40 (40.0 B) TX bytes:46 (46.0 B) ppp30 Link encap:Point-to-Point Protocol inet addr:6.6.6.7 P-t-P:6.6.6.6 Mask:255.255.255.255 UP POINTOPOINT RUNNING NOARP MULTICAST MTU:1500 Metric:1 RX packets:4 errors:0 dropped:0 overruns:0 frame:0 TX packets:4 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:3 RX bytes:40 (40.0 B) TX bytes:46 (46.0 B) Please let me know if i have to make any changes to the configuration file. Any pointers are helpful. Thanks, V.Balaji |
|
From: Christoph B. <sou...@ma...> - 2015-12-04 20:39:12
|
James Cameron wrote...
> But this change was merged already in 20bf1af on 2014-10-16.
Oy, and I even know the guy who submitted this.
Sorry for the noise, I took precautions this won't happen a third time.
Christoph
|
90 messages has been excluded from this view by a project administrator.
