#31 kernelmod.sh (0.8.4) does not work with 2.4.26 kernel

open
nobody
None
5
2012-09-17
2004-09-28
No

I am sorry if I offend anyone but I am totally
fustrated from chasing after trival bugs, doesn't
anyone actually test their work before checking it into
CVS? Anyone reading this should steer clear of
kernelmod-0.8.4 if you are using the 2.4 kernel. I
have used kernelmod-0.7.1 in the past and it worked
once a small change was made.

kernelmod.sh attempts to patch files using source in
kernelmod/src/bsd-mppe, this directory does not exist!
linux-default-bsd-mppe is the directory that does
exist. If I had wanted to use the OpenSSL code the
OpenSSL files are totally missing because openssl-mppe
directory is totally missing. If you had not indended
for someone to use openSSL then you should not allow
the option.

In kernelmod.sh there is a function setkernelver() that
contains the line:

VERSION=head -n 4 $KSOURCE/Makefile | grep VERSION | awk -F' = ' '{print $2}'

given the first 4 lines of the kernel Makefile:

VERSION = 2
PATCHLEVEL = 4
SUBLEVEL = 26
EXTRAVERSION = 0

what do you think the result of:

VERSION=head -n 4 $KSOURCE/Makefile | grep VERSION | awk -F' = ' '{print $2}'

is?

2? No, it is '2 0' because VERSION is in both VERSION
and EXTRAVERSION. The shell script ends up trashing
the Makefile and breaking the build. Thanks for making
me chase after two errors like that, don't you guys
actually test your work before you check it into CVS? I
can understand code problem with a patch, this was
simply sloppy.

And finally there is an actual code problem with the
patch, I will work through it myself as no one seems to
be home here:

Building module arcfour.o
Building module ppp_mppe_compress.o
ppp_mppe_compress.c:35: MPPE_MAX_KEY_LEN' undeclared here (not in a function) ppp_mppe_compress.c:36:MPPE_MAX_KEY_LEN' undeclared
here (not in a function)
ppp_mppe_compress.c: In function mppe_rekey': ppp_mppe_compress.c:135:MPPE_MAX_KEY_LEN' undeclared
(first use in this function)
ppp_mppe_compress.c:135: (Each undeclared identifier is
reported only once
ppp_mppe_compress.c:135: for each function it appears in.)
ppp_mppe_compress.c: In function mppe_alloc': ppp_mppe_compress.c:164:CILEN_MPPE' undeclared (first
use in this function)
ppp_mppe_compress.c:166: CI_MPPE' undeclared (first use in this function) ppp_mppe_compress.c: In functionmppe_init':
ppp_mppe_compress.c:213: CILEN_MPPE' undeclared (first use in this function) ppp_mppe_compress.c:214:CI_MPPE' undeclared (first
use in this function)
ppp_mppe_compress.c:217: warning: implicit declaration
of function MPPE_CI_TO_OPTS' ppp_mppe_compress.c:218:MPPE_OPT_128' undeclared
(first use in this function)
ppp_mppe_compress.c:220: MPPE_OPT_40' undeclared (first use in this function) ppp_mppe_compress.c:226:MPPE_OPT_STATEFUL' undeclared
(first use in this function)
ppp_mppe_compress.c: At top level:
ppp_mppe_compress.c:576: CI_MPPE' undeclared here (not in a function) ppp_mppe_compress.c:576: initializer element is not constant ppp_mppe_compress.c:576: (near initialization forppp_mppe.compress_proto')
Building module sha1.o
Building module ppp_mppe.o
/usr/bin/ld: cannot open ppp_mppe_compress.o: No such
file or directory

Discussion


Log in to post a comment.