[poe-commits] poe/t 30_filter_httpd.t,1.10,1.11
Brought to you by:
rcaputo
From: <rc...@us...> - 2004-05-26 03:57:45
|
Update of /cvsroot/poe/poe/t In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv29192/t Modified Files: 30_filter_httpd.t Log Message: Anonymous Coward reported a bug in the code that skips testing a broken HTTP::Request object. This commit should fix it. Index: 30_filter_httpd.t =================================================================== RCS file: /cvsroot/poe/poe/t/30_filter_httpd.t,v retrieving revision 1.10 retrieving revision 1.11 diff -C2 -d -r1.10 -r1.11 *** 30_filter_httpd.t 22 May 2004 05:16:59 -0000 1.10 --- 30_filter_httpd.t 26 May 2004 03:57:35 -0000 1.11 *************** *** 123,130 **** 'simple post: HTTP::Request object contains proper URI'); ! if ($^O eq "MSWin32" and $] < 5.008003) { ! skip("Please upgrade ActivePerl to pass this test."); ! } ! else { is($req->content, "I=like&tasty=pie\n", 'simple post: HTTP::Request object contains proper content'); --- 123,140 ---- 'simple post: HTTP::Request object contains proper URI'); ! # The HTTP::Request bundled with ActivePerl 5.6.1 causes a test ! # failure here. The one included in ActivePerl 5.8.3 works fine. ! # It was suggested by an anonymous bug reporter to test against ! # HTTP::Request's version rather than Perl's, so we're doing that ! # here. Theoretically we shouldn't get this far. The Makefile ! # magic should strongly suggest HTTP::Request 1.34. But people ! # install (or fail to) the darnedest things, so I thought it was ! # safe to check here rather than fail the test due to operator ! # error. ! SKIP: { ! my $required_http_request_version = 1.34; ! skip("simple post: Please upgrade HTTP::Request to $required_http_request_version or later", 1) ! if $^O eq "MSWin32" and $HTTP::Request::VERSION < $required_http_request_version; ! is($req->content, "I=like&tasty=pie\n", 'simple post: HTTP::Request object contains proper content'); |