[poe-commits] poe/POE/Resource Extrefs.pm,1.8,1.9
Brought to you by:
rcaputo
From: <rc...@us...> - 2003-11-22 05:05:14
|
Update of /cvsroot/poe/poe/POE/Resource In directory sc8-pr-cvs1:/tmp/cvs-serv23969/POE/Resource Modified Files: Extrefs.pm Log Message: Deferring deletion of %kr_extra_refs items caused inconsistencies in the results from _data_extref_count(). I noticed it when Client::HTTP's tests stopped exiting on their own. Tracked it back to Client::DNS, reproduced it there, and used its test suite to verify the error back home in POE::Resource::Extrefs. Whee! Oh, right. This commit backs out that prior "optimization". Index: Extrefs.pm =================================================================== RCS file: /cvsroot/poe/poe/POE/Resource/Extrefs.pm,v retrieving revision 1.8 retrieving revision 1.9 diff -C2 -d -r1.8 -r1.9 *** Extrefs.pm 21 Nov 2003 05:08:26 -0000 1.8 --- Extrefs.pm 22 Nov 2003 05:05:10 -0000 1.9 *************** *** 109,112 **** --- 109,114 ---- delete $kr_extra_refs{$session}->{$tag}; + delete $kr_extra_refs{$session} + unless scalar keys %{$kr_extra_refs{$session}}; $self->_data_ses_refcount_dec($session); } *************** *** 129,134 **** } } - - delete $kr_extra_refs{$session}; } --- 131,134 ---- |