Re: [png-mng-implement] libpng-1.2.23beta02 available

[Pierre P. <pie...@gm...>]

On 10/16/07, Glenn Randers-Pehrson <gl...@gm...> wrote:
> Libpng-1.2.23beta02 is available at
> ftp://ftp.simplesystems.org/pub/png-group/src/
> and at
> http://libpng.sf.net/
>
> Png_strncpy() and png_strcpy() are gone.
> New bug with $AN (should be $(AN) ) in Makefile.am is fixed.
>
> I took the macro definitions for png_strncpy() and png_strcpy() out
> of pngconf.h -- that does not disturb ABI compatibility, does it?  It
> would cause source incompatibility for anyone using them in applications,
> though.
>
> Glenn

got an "oops" in second chunk of pngset.c:
@@ -1040,9 +1040,10 @@
         png_unknown_chunkp to = np + info_ptr->unknown_chunks_num + i;
         png_unknown_chunkp from = unknowns + i;

-        png_strncpy((png_charp)to->name, (png_charp)from->name,
-          PNG_CHUNK_NAME_LENGTH);
-        to->name[PNG_CHUNK_NAME_LENGTH] = '\0';
+        png_memcpy((png_charp)to->name,
+                   (png_charp)from->name,
+                   png_sizeof(from->name));
+        to->name[png_sizeof(to->name)] = '\0';

         to->data = (png_bytep)png_malloc_warn(png_ptr, from->size);
         if (to->data == NULL)

==> last line should be or we write out (we may be saved by alignement
but this should be correct for next rel I guess :-)
+ to->name[png_sizeof(to->name)-1] = '\0';