[pmd-commits] [pmd/pmd] 628331: Avoid redundant method calls and improve codebase

[GitHub <no...@gi...>]

  Branch: refs/heads/pmd/5.4.x
  Home:   https://github.com/pmd/pmd
  Commit: 6283316e51d5e05fc3f02c969aadd26a78660a2e
      https://github.com/pmd/pmd/commit/6283316e51d5e05fc3f02c969aadd26a78660a2e
  Author: Juan Martín Sotuyo Dodero <jms...@mo...>
  Date:   2017-01-03 (Tue, 03 Jan 2017)

  Changed paths:
    M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/symboltable/ClassScope.java
    M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/symboltable/JavaNameOccurrence.java

  Log Message:
  -----------
  Avoid redundant method calls and improve codebase

 - Avoid making calls within for loops, specially costly ones
    such as `getQualifiedTypeNames`
 - Don't create lists when they are empty.
 - Create lists of proper size to avoid resizing / oversizing
 - I'm seeing a ~5% improvement. We are reaching the point were noise
    makes it hard to detect improvements. We should attack GC cycles soon.


  Commit: ba7a7a2f8d1bfde103e6fe0388a1575a4e4d4391
      https://github.com/pmd/pmd/commit/ba7a7a2f8d1bfde103e6fe0388a1575a4e4d4391
  Author: Andreas Dangel <ad...@us...>
  Date:   2017-01-03 (Tue, 03 Jan 2017)

  Changed paths:
    M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/symboltable/ClassScope.java
    M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/symboltable/JavaNameOccurrence.java

  Log Message:
  -----------
  Merge branch 'pr-162' into pmd/5.4.x
Closes #162 (rebased onto pmd/5.4.x)


Compare: https://github.com/pmd/pmd/compare/e5dbeb800b95...ba7a7a2f8d1b