#992 Class java.beans.Statement triggered in CloseResource rule

[Kenneth Ljunggren]

Using PMD 4.2.5

Having the following code below and including the ruleset/design.xml
The CloseResource rule incorrectly reports the Statement variable as a resource that should be closed.

:::java
import java.beans.Statement;
...
          Statement stmt = new Statement(vo, "set" + prop, new Object[] { vector });

           try {
             stmt.execute();
           } catch (Exception e) {
             throw new RuntimeException("Could not set property prop: " + prop + "of type:" + pd.getPropertyType(), e);
           }      

[Romain PELISSE]

Hi,

Thanks for the report. Would you mind checking if this is still happening with PMD 4.3 ? I think some tweaking on CloseResource was done.

[Kenneth Ljunggren]

Same result using PMD 4.3.

<pmd version="4.3" timestamp="2012-02-02T14:43:55.013">
...
<violation beginline="66" endline="66" begincolumn="27" endcolumn="30" rule="CloseResource" ruleset="Design Rules" package="common.utils" class="" method="setBoolean" variable="stmt" externalinfourl="http://pmd.sourceforge.net/rules/design.html#CloseResource" priority="3">Ensure that resources like this Statement object are closed after use</violation>
..</pmd>

[Romain PELISSE]

A quick and good fix, will probably be to use type resolution to assert that Statement is coming form an SQL related package. I'll try to look at that, but if you want, you can probably do this by yourself. Look into existing rulesets how type resolution is used, and modify PMD rule accordingly.

[Andreas Dangel]

• Description has changed:

Diff:

--- old
+++ new
@@ -3,6 +3,8 @@
 Having the following code below and including the ruleset/design.xml
 The CloseResource rule incorrectly reports the Statement variable as a resource that should be closed.

+~~~~~
+:::java
 import java.beans.Statement;
 ...
           Statement stmt = new Statement(vo, "set" + prop, new Object[] { vector });
@@ -12,3 +14,4 @@
            } catch (Exception e) {
              throw new RuntimeException("Could not set property prop: " + prop + "of type:" + pd.getPropertyType(), e);
            }      
+~~~~~