#707 DataflowAnomalyAnalysis false positive DD

[Miroslav Šulc]

I think this code should not cause DD warning as it is valid. Anyway I get warning on redefinition of 'val' value.

public void test(final boolean param) {
Integer val = null;
if (param) {
val = 1;
}
return val;
}

[Sven Jacob]

Logged In: YES
user_id=1565594
Originator: NO

In my opinion val is at first defined with the null reference. In the case that there should be no definition then you would get an ur-anomaly, because the variable may not be defined and is used in the return statement.

Dont know what would be better.

Sven.

[Miroslav Šulc]

Logged In: YES
user_id=1483986
Originator: YES

'val' must be set to null, otherwise the code would not compile (the DU you mentioned).

IMO there is no other way to write the code when dealing with complex code in the 'if' branch. Up to that, the DD is "valid" only in case 'param' is true.

So IMO the solution would be to update the rule so it checks whether the redefinition occurs within conditional statement (or maybe within the same level of code, be it top level in the method or a lower level like conditional statements) and if so then do not issue DD.