PMD / Issues / #1512 [java] Combine rules AvoidConstantsInInterface and ConstantsInInterface

#1512 [java] Combine rules AvoidConstantsInInterface and ConstantsInInterface

Milestone: PMD-5.6.0

Status: closed

Owner: Juan Sotuyo

Labels: java (55) java-design (7)

Module: PMD

Priority: 3-Major

Type: Bug

Affects version:

Ruleset / Rule: java-design

Updated: 2017-01-03

Created: 2016-08-12

Creator: Andreas Dangel

Private: No

With PMD 5.5.0, a new rule ConstantsInInterface has been added. However, there is already a very similar rule AvoidConstantsInterface. These two rules should be combined.

Once done, schedule for 5.7.0 an issue, to remove the old (deprecated) rule name, so that there is only one rule.

Discussion

Andreas Dangel - 2016-08-12

labels: --> java, java-design

Ruleset / Rule: --> java-design
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Description has changed:

Diff:

--- old
+++ new
@@ -1 +1,3 @@
 With PMD 5.5.0, a new rule [ConstantsInInterface](http://pmd.github.io/latest/pmd-java/rules/java/design.html#ConstantsInInterface) has been added. However, there is already a very similar rule [AvoidConstantsInterface](http://pmd.github.io/latest/pmd-java/rules/java/design.html#AvoidConstantsInterface). These two rules should be combined.
+
+Once done, schedule for 5.7.0 an issue, to remove the old (deprecated) rule name, so that there is only one rule.

Juan Sotuyo - 2016-12-08

Instead of deprecating it in 5.7.0, we may be able to unify these rules directly and use RuleSetFactoryCompatibility to support the old configuration.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Juan Sotuyo - 2016-12-08

assigned_to: Maraxus
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Juan Sotuyo - 2016-12-08

I'm taking this over and submitting a PR

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Juan Sotuyo - 2016-12-08

PR submitted: https://github.com/pmd/pmd/pull/156

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Andreas Dangel - 2017-01-03

status: open --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

[java] Combine rules AvoidConstantsInInterface and ConstantsInInterface

A source code analyzer

Milestone

Searches

Help

#1512 [java] Combine rules AvoidConstantsInInterface and ConstantsInInterface

Discussion