#1494 [java] SingularField: lombok.Data false positive

[Geniy00]

Should PMD take into accaunt using of lombok?

import lombok.Data;

@Data
public class MyClass {

    private String field1;

    public MyClass(String field1) {
        this.field1 = field1;
    }
}

MyClass.java:8: Perhaps 'field1' could be replaced by a local variable.

[Andreas Dangel]

See also [#1420].

[Andreas Dangel]

This bug will be fixed with PMD 5.4.3, 5.5.2, and later.

Commit: https://github.com/pmd/pmd/commit/0c75e5123cc1c3441c035ef45f62b220769fe9e7

[Satya Reddy]

import lombok.Getter;
import lombok.Setter;

@Getter
@Setter
public class Foo {
    private String id;
    public Foo(String id) {
        this.id = id;
    }
}

with PMD 5.7, I get following:

Private field 'id' could be made final; it is only initialized in the declaration or constructor.

The id could be later set using Setter method.

[Andreas Dangel]

See https://github.com/pmd/pmd/issues/410