#1456 [java] UnusedFormalParameter: should ignore overriding methods

In the next code segment, if UnusedFormalParameter.checkAll is true:

abstract class Base{
  abstract public int badMethod(int arg1, String arg2);
}

class Imp1 extends Base {
  @Override
  public int badMethod(int arg1, String arg2) {
    return arg2.length();
  }
}

class Imp2 extends Base {
  @Override
  public int badMethod(int arg1, String arg2) {
    return arg2.length() + arg1;
  }
}

Imp1.badMethod() is overriding Base.badMethod(), so arg1 should not be considered "unused".

[Andreas Dangel]

This bug will be fixed with PMD 5.3.7, 5.4.2 and 5.5.0.

Commit: https://github.com/pmd/pmd/commit/89ffb56e4e194d459a4de995a8ce70174e65e540

[Anonymous]

Thanks!