#1446 [java] JUnit4TestShouldUseBeforeAnnotation: False positive when TestNG is used

[Julien Herr]

I'm using pmd via SonarQube and JUnit4TestShouldUseBeforeAnnotation is triggered with the following code:

@BeforeMethod
public void setUp(Method m) {
  ...
}

@BeforeMethod from TestNG is equivalent to @Before from JUnit.

[Andreas Dangel]

This will be fixed with PMD 5.3.6 and later. If an import of testng is found, this rule won't trigger anymore.

Commit: https://github.com/pmd/pmd/commit/2a52757aa550731e82d400e727a00478d1a36af2

[Andreas Dangel]

Alternatively you can disable the JUnit rules, as you are using TestNG and not JUnit :) As the name of the rules indicate, they are supposed to be used with JUnit...

[Julien Herr]

This will be fixed with PMD 5.3.6 and later.

Great!

Alternatively you can disable the JUnit rules, as you are using TestNG and not JUnit :)

For sure! That's what I will do.

As the name of the rules indicate, they are supposed to be used with JUnit...

+1 but in this case the name should changed or TestNG should have its own rules.