#1443 [java] RedundantFieldInitializer: False positive for small floats

[David Burström]

False positive for -1.0 < f < 1.0, e.g.
public float myFloat = 0.1f

[David Burström]

How about

--- a/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/optimizations/RedundantFieldInitializerRule.java
+++ b/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/optimizations/RedundantFieldInitializerRule.java
@@ -100,7 +100,7 @@ public class RedundantFieldInitializerRule extends AbstractJavaRule {
                                     value = (int) literal.getImage().charAt(1);
                                 }

-                                if (value.longValue() == 0) {
+                                if (value.doubleValue() == 0) {
                                     addViolation(data, variableDeclarator);
                                 }
                             }

--- a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/optimizations/xml/RedundantFieldInitializer.xml
+++ b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/optimizations/xml/RedundantFieldInitializer.xml
@@ -1302,4 +1302,13 @@ public class SomeClass {
 }
         ]]></code>
     </test-code>
+    <test-code>
+        <description>#1443 RedundantFieldInitializer: False positive for small floats</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+public class SomeClass {
+    private float someNumber = 0.1f;
+}^M
+        ]]></code>
+    </test-code>
 </test-data>

[Andreas Dangel]

Thanks!
I've applied your patch - it will be included in PMD 5.3.6 and later.

Commit: https://github.com/pmd/pmd/commit/90b1f65ea20c4bbca7362ec79a90614ef8b60ec5