#1371 InsufficientStringBufferDeclaration not detected properly on StringBuffer

[Damian Techeira]

There is an inconsistent behaviour on InsufficientStringBufferDeclaration, which is not always reported.

The code below is a sample where there are 2 equally wrong uses of StringBuffer but only one is reported.

public class StringBufferTest {

    private static String TAG = "TAG";

        public void test() {

        // this line is not reported as InsufficientStringBufferDeclaration 
        final StringBuffer stringBuffer = new StringBuffer().append("agrego ").append("un ");
        stringBuffer.append("string ");
        Log.i(TAG, stringBuffer.toString());

        // this line is reported as InsufficientStringBufferDeclaration 
        final StringBuffer stringBuffer2 = new StringBuffer();
        stringBuffer2.append("agrego ");
        stringBuffer2.append("un ");
        stringBuffer2.append("string ");
        Log.i(TAG, stringBuffer2.toString());
    }
}

[Andreas Dangel]

This will be fixed with PMD 5.3.4.

Commit:

• pmd/5.3.x: https://github.com/pmd/pmd/commit/abe800dfa9a1d772e08b81a660f10601112dc643 and https://github.com/pmd/pmd/commit/c0c79e522f22b87d78070e7e221fa57eaf420e32
• master: https://github.com/pmd/pmd/commit/ef0c8c9d2714f01ab6f1578424a579e8bb077b6d and https://github.com/pmd/pmd/commit/b95433b059fa6b317822d40acd441ea6c40b1fe2

See also: https://github.com/pmd/pmd/pull/69