- Module: PMD --> Eclipse
The PMD eclipse context menu called "Clear Violation Reviews" will actually change the user's files and does not provide a warning that it will do so and as such is dangerous, especially to new users.
Issues are as follows
1) "Clear Violation Reviews" is very similar to "Clear Violations". Which one do I want? One of these clears the eclipse PMD markers and the other actually changes your files to remove the //NOPMD tags. Suggest renaming the menu item to "Remove //NOPMD Code Markers"
2) Both of the above menu items are located in a context menu and could easily be accidentally clicked on.
3) "Clear Violation Reviews" modifies your code (think about right clicking an entire project and choosing this option) without warning. I've never seen a static analysis do that and it was completely unexpected. Provide a dialog box that includes a warning and allows the user to cancel out the action.