#1353 False positive "Only One Return" with lambda

[Rei Angelus]

With java 8, when a method contains a lambda expression with a return, the return of the lambda is counted as a return of the method.

For example :
:::java
public Try<SearchHit[]> search(final String indexName, final SearchRequest searchRequest) {
final SearchHit[] empty = new SearchHit[0];
final Optional<SearchDefinition> searchDefinition = settingsService.getSearchDefinition(indexName);
return searchDefinition.<Try<SearchHit[]>>map(
i -> {
final List<Try<ProviderSearchHit[]>> res = i.getSearchMapping().stream()
.peek(m -> LOGGER.debug("Treating backend \"{}\"", m.getProviderRef()))
.map(m -> invokeAdapter(getProviderSearchService(m.getProviderRef()), m, searchRequest))
.collect(Collectors.toList());
return TryCollections.pull(res).map(l -> sortReturning(l.stream().collect(ArrayCollectors.arrayMerging(
SearchServiceImpl::toSearchHit,
SearchHit::getInternalId,
Function.identity(),
SearchServiceImpl::merge)).orElse(Collections.emptyList()), SearchServiceImpl.searchHitComparator()))
.map(list -> list.toArray(empty));
}).orElse(Try.success(empty));
}

One return for the lambda, one return for the method but false positive "Only One Return"

[Andreas Dangel]

Thanks for the bug report. It will be fixed with the next version (5.3.2).

Commit: https://github.com/pmd/pmd/commit/cae16d39d7bb8c1d3d2a0af0c735a9c093469c22