Menu

#1343 MethodNamingConventions for overrided methods

PMD-5.3.2
closed
None
PMD
3-Major
Bug
2015-05-15
2015-05-05
No

The rule MethodNamingConventions checks underscore in method name.
However, if the method overrides a superclass or an interface, it's impossible to change the name, particularly if the superclass or the interface belongs to another project or to an imported library.
=> Then, there are false positive, and this rule should check if its an @override or not ?

Discussion

  • Andreas Dangel

    Andreas Dangel - 2015-05-15
    • status: open --> closed
    • assigned_to: Andreas Dangel
    • Milestone: New Tickets --> PMD-5.3.2
     
  • Andreas Dangel

    Andreas Dangel - 2015-05-15

    Thanks for the bug report. That's a good suggestion.
    I've added a check for the @Override annotation, and in that case, the method is ignored.

    This will be fixed with 5.3.2.

    Commit: https://github.com/pmd/pmd/commit/3c316c20187ab76fa7536105969ee62b463d75e1

     

Log in to post a comment.