From: Alan W. I. <ir...@be...> - 2003-09-30 00:36:26
|
Hi Rafael: I have just built the documentation (with the plsetopt additions I just committed) and uploaded it to the website. Here are the commands I used: ./bootstrap.sh --date-version ./configure .... --enable-builddoc make cd doc/docbook/src make WWW_USER=airwin@ www-install In the old days that @ sign suffix on the user name was not necessary, and I was wondering why it was necessary now? Alan __________________________ Alan W. Irwin email: ir...@be... phone: 250-727-2902 Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the PLplot scientific plotting software package (plplot.org), the Yorick front-end to PLplot (yplot.sf.net), the Loads of Linux Links project (loll.sf.net), and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |
From: Rafael L. <lab...@ps...> - 2003-09-30 07:40:02
|
* Alan W. Irwin <ir...@be...> [2003-09-29 17:35]: > make WWW_USER=airwin@ www-install > > In the old days that @ sign suffix on the user name was not necessary, and > I was wondering why it was necessary now? Because the rsh command is defined like this in Makefile.am: RSH_COMMAND = $(RSH) $(WWW_USER)$(WWW_HOST) If it was defined with an "@" like this: RSH_COMMAND = $(RSH) $(WWW_USER)@$(WWW_HOST) Then the command would not work if WWW_USER is empty. BTW, an empty WW_USER is the default situation. If this really, really bug you, I may try to find a workaround solution for that, but I think that for now it is simpler to require the addition of the "@" sign. -- Rafael |
From: Alan W. I. <ir...@be...> - 2003-09-30 15:39:18
|
On 2003-09-30 09:37+0200 Rafael Laboissiere wrote: > Then the command would not work if WWW_USER is empty. BTW, an empty WW_USER > is the default situation. > > If this really, really bug you, I may try to find a workaround solution for > that, but I think that for now it is simpler to require the addition of the > "@" sign. Thanks for explaining why the change was made. I had assumed everybody would always have to specify WWW_USER regardless, but I forgot the case where local username and SF name are identical so that empty WWW_USER (without the @) would actually work. I think the best solution is to append @ to any non-empty WWW_USER. Do you mind if I have a go with that simple change? Alan __________________________ Alan W. Irwin email: ir...@be... phone: 250-727-2902 Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the PLplot scientific plotting software package (plplot.org), the Yorick front-end to PLplot (yplot.sf.net), the Loads of Linux Links project (loll.sf.net), and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |
From: Rafael L. <lab...@ps...> - 2003-09-30 16:10:11
|
* Alan W. Irwin <ir...@be...> [2003-09-30 08:38]: > Thanks for explaining why the change was made. I had assumed everybody > would always have to specify WWW_USER regardless, but I forgot the case > where local username and SF name are identical so that empty WWW_USER > (without the @) would actually work. I think the best solution is to append > @ to any non-empty WWW_USER. Do you mind if I have a go with that simple > change? I just looked at doc/docbook/docbook.m4 and I saw this: AC_ARG_WITH(www-user, AC_HELP_STRING([--with-www-user=NAME], [User name at WWW host]), [WWW_USER="$withval@"], [WWW_USER="]) AC_SUBST(WWW_USER) It seems that the @ sign is added when the --with-www-user option is used. However, from your previous message: * Alan W. Irwin <ir...@be...> [2003-09-29 17:35]: > make WWW_USER=airwin@ www-install > > In the old days that @ sign suffix on the user name was not necessary, and I > was wondering why it was necessary now? Setting the AC_SUBST variable WWW_USER from the configure call is different from setting the Makefile variable WWW_USER from the command line. At any rate, I do not mind if you implement the change. You must be careful, though, since the @ is added already by configure. -- Rafael |
From: Alan W. I. <ir...@be...> - 2003-09-30 18:59:21
|
On 2003-09-30 18:06+0200 Rafael Laboissiere wrote: > I just looked at doc/docbook/docbook.m4 and I saw this: > > AC_ARG_WITH(www-user, > AC_HELP_STRING([--with-www-user=NAME], [User name at WWW host]), > [WWW_USER="$withval@"], > [WWW_USER="]) > AC_SUBST(WWW_USER) > > It seems that the @ sign is added when the --with-www-user option is used. > [...]Setting the AC_SUBST variable WWW_USER from the configure call is different > from setting the Makefile variable WWW_USER from the command line. > > At any rate, I do not mind if you implement the change. You must be > careful, though, since the @ is added already by configure. Well, I was going to implement it by removing the above @ in docbook.m4 and using a Gnu make conditional to define WWW_USERAT as $(WWW_USER)@ only for non-empty $(WWW_USER). But it turns out that Gnu make conditionals completely confuse automake (it thinks the trailing endif corresponds to an automake conditional) so we cannot use them. So I have given up and will leave everything as is. Alan __________________________ Alan W. Irwin email: ir...@be... phone: 250-727-2902 Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the PLplot scientific plotting software package (plplot.org), the Yorick front-end to PLplot (yplot.sf.net), the Loads of Linux Links project (loll.sf.net), and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |
From: Rafael L. <lab...@ps...> - 2003-09-30 20:37:14
|
* Alan W. Irwin <ir...@be...> [2003-09-30 11:58]: > Well, I was going to implement it by removing the above @ in docbook.m4 and > using a Gnu make conditional to define WWW_USERAT as $(WWW_USER)@ only for > non-empty $(WWW_USER). But it turns out that Gnu make conditionals > completely confuse automake (it thinks the trailing endif corresponds to an > automake conditional) so we cannot use them. So I have given up and will > leave everything as is. You might try the following (not fully tested, but should work): WWW_USERAT = `if test "$(WWW_USER)" ; then echo $(WWW_USER)@ ; fi` or: WWW_USERAT = $(shell if test "$(WWW_USER)" ; then echo $(WWW_USER)@ ; fi) The second form is probably less portable, but we are already using the $(shell ...) construct elsewhere in doc/docbook/src/Makefile.am. -- Rafael |