Menu
▾
▴
plplot-devel
|
From: Peter W. <pet...@nt...> - 2015-11-30 19:39:50
|
I have done a plplot build using cmake with the 'deprecated' flag set
on. The mingw make comes with an error message:
C:\PlplotSource-5.11.1\src\plmap.c: In function 'drawmap':
C:\PlplotSource-5.11.1\src\plmap.c:530:25: error: 'appendresult'
undeclared (first use in this function)
appendresult += appendfltptr( &splitx, nsplitsections, bufx + i );
^
I do not get this error with the deprecated flag set off. It seems a
simple error to correct (merely initialise appendresult =0)
but I am loath to tamper with complex code which is not mine.
Best Wishes
--
Peter Williams
pet...@nt...
|
|
From: Alan W. I. <ir...@be...> - 2015-11-30 21:30:13
|
On 2015-11-30 19:39-0000 Peter Williams wrote: > I have done a plplot build using cmake with the 'deprecated' flag set > on. The mingw make comes with an error message: > > C:\PlplotSource-5.11.1\src\plmap.c: In function 'drawmap': > > C:\PlplotSource-5.11.1\src\plmap.c:530:25: error: 'appendresult' > undeclared (first use in this function) > appendresult += appendfltptr( &splitx, nsplitsections, bufx + i ); > ^ > I do not get this error with the deprecated flag set off. It seems a > simple error to correct (merely initialise appendresult =0) > but I am loath to tamper with complex code which is not mine. To Phil and Peter: I confirm this issue on Linux if I use the combination of cmake options -DPL_DEPRECATED=ON -DHAVE_SHAPELIB=OFF. As expected, this build issue does go away if the appendresult declaration and initialization is moved to where it will be compiled in general. However, that is not all the story, because if you also compile example 19 for that case and any device driver (I chose cairo), then there is a long series of warnings issued for that example when you run it, e.g., with examples/c/x19c -dev xcairo Those warning messages start with *** PLPLOT WARNING *** Could not find ss/ss64ne_Landform_Area.map file. That makes no sense. If -DHAVE_SHAPELIB=OFF why in the world should this example (or more likely the core library) be looking for shapelib files? I also tested the case where -DPL_DEPRECATED=OFF -DHAVE_SHAPELIB=OFF, and the code does the right thing there which is emit the following warning *** PLPLOT WARNING *** Use of the old plplot map file format is deprecated. It is recommended that the shapelib library be used to provide map support. @Phil: As original author of this code, would you please fix the -DPL_DEPRECATED=ON -DHAVE_SHAPELIB=OFF case so that the first pages of example 19 come out right (like they do now) using the deprecated way of doing things, but the last page should simply emit the same message as for the -DPL_DEPRECATED=OFF -DHAVE_SHAPELIB=OFF case, i.e., the last WARNING message above? Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |
|
From: Phil R. <p.d...@gm...> - 2015-12-01 09:47:08
|
Hi Alan I'll look at this today -----Original Message----- From: "Alan W. Irwin" <ir...@be...> Sent: 30/11/2015 21:30 To: "Phil Rosenberg" <p.d...@gm...>; "Peter Williams" <pet...@nt...> Cc: "PLplot development list" <plp...@li...> Subject: Re: [Plplot-devel] Plplot Source Error On 2015-11-30 19:39-0000 Peter Williams wrote: > I have done a plplot build using cmake with the 'deprecated' flag set > on. The mingw make comes with an error message: > > C:\PlplotSource-5.11.1\src\plmap.c: In function 'drawmap': > > C:\PlplotSource-5.11.1\src\plmap.c:530:25: error: 'appendresult' > undeclared (first use in this function) > appendresult += appendfltptr( &splitx, nsplitsections, bufx + i ); > ^ > I do not get this error with the deprecated flag set off. It seems a > simple error to correct (merely initialise appendresult =0) > but I am loath to tamper with complex code which is not mine. To Phil and Peter: I confirm this issue on Linux if I use the combination of cmake options -DPL_DEPRECATED=ON -DHAVE_SHAPELIB=OFF. As expected, this build issue does go away if the appendresult declaration and initialization is moved to where it will be compiled in general. However, that is not all the story, because if you also compile example 19 for that case and any device driver (I chose cairo), then there is a long series of warnings issued for that example when you run it, e.g., with examples/c/x19c -dev xcairo Those warning messages start with *** PLPLOT WARNING *** Could not find ss/ss64ne_Landform_Area.map file. That makes no sense. If -DHAVE_SHAPELIB=OFF why in the world should this example (or more likely the core library) be looking for shapelib files? I also tested the case where -DPL_DEPRECATED=OFF -DHAVE_SHAPELIB=OFF, and the code does the right thing there which is emit the following warning *** PLPLOT WARNING *** Use of the old plplot map file format is deprecated. It is recommended that the shapelib library be used to provide map support. @Phil: As original author of this code, would you please fix the -DPL_DEPRECATED=ON -DHAVE_SHAPELIB=OFF case so that the first pages of example 19 come out right (like they do now) using the deprecated way of doing things, but the last page should simply emit the same message as for the -DPL_DEPRECATED=OFF -DHAVE_SHAPELIB=OFF case, i.e., the last WARNING message above? Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |
|
From: Phil R. <p.d...@gm...> - 2015-12-10 12:36:42
|
Hi Alan Sorry this has taken me a while to look at. I just want to check what you think the behaviour should be id shapelib is off, deprecated is on and the user passes in a map name other than one of the ones we supply? The behaviour before we began using shapefiles was the same as it is now: If a file with that name existed then plplot attempted to read it, if not then plplot reported the warning you saw. I think that is still correct behaviour. What should probably happen is that the final page of the example should not be drawn unless shapelib support is on. To do this we need either a compile time or runtime check for whether plplot was built with shapelib support. Not wanting to touch the public API I guess a #define PL_USE_SHAPEFILES in plConfig.h is required. However I'm not sure how to do that. I tried adding set(PL_USE_SHAPEFILES, TRUE) In shapelib.cmake and #cmakedefine PL_USE_SHAPEFILES in plConfig.h.in, but this doesn't work. You might have to look at this to get it to work or give me some idea what I am doing wrong. I suspect that shapelib.cmake is not called until after plConfig.h is generated. If so then sorting that would be a significant change to the build system that is beyond my skill. Phil On 1 December 2015 at 09:46, Phil Rosenberg <p.d...@gm...> wrote: > Hi Alan I'll look at this today > ________________________________ > From: Alan W. Irwin > Sent: 30/11/2015 21:30 > To: Phil Rosenberg; Peter Williams > Cc: PLplot development list > Subject: Re: [Plplot-devel] Plplot Source Error > > On 2015-11-30 19:39-0000 Peter Williams wrote: > >> I have done a plplot build using cmake with the 'deprecated' flag set >> on. The mingw make comes with an error message: >> >> C:\PlplotSource-5.11.1\src\plmap.c: In function 'drawmap': >> >> C:\PlplotSource-5.11.1\src\plmap.c:530:25: error: 'appendresult' >> undeclared (first use in this function) >> appendresult += appendfltptr( &splitx, nsplitsections, bufx + i ); >> ^ >> I do not get this error with the deprecated flag set off. It seems a >> simple error to correct (merely initialise appendresult =0) >> but I am loath to tamper with complex code which is not mine. > > To Phil and Peter: > > I confirm this issue on Linux if I use the combination of cmake options > -DPL_DEPRECATED=ON -DHAVE_SHAPELIB=OFF. > > As expected, this build issue does go away if the appendresult declaration > and > initialization is moved to where it will be compiled in general. > However, that is not all the story, because if you also compile > example 19 for that case and any device driver (I chose cairo), then > there is a long series of warnings issued for that example when > you run it, e.g., with > > examples/c/x19c -dev xcairo > > Those warning messages start with > > *** PLPLOT WARNING *** > Could not find ss/ss64ne_Landform_Area.map file. > > That makes no sense. If -DHAVE_SHAPELIB=OFF why in the world > should this example (or more likely the core library) be looking for > shapelib files? I also tested the case where -DPL_DEPRECATED=OFF > -DHAVE_SHAPELIB=OFF, and the code does the right thing there > which is emit the following warning > > *** PLPLOT WARNING *** > Use of the old plplot map file format is deprecated. > It is recommended that the shapelib library be used to provide map > support. > > @Phil: As original author of this code, would you please fix the > -DPL_DEPRECATED=ON -DHAVE_SHAPELIB=OFF case so that the first pages of > example 19 come out right (like they do now) using the deprecated way > of doing things, but the last page should simply emit the same message > as for the -DPL_DEPRECATED=OFF -DHAVE_SHAPELIB=OFF case, i.e., the > last WARNING message above? > > Alan > __________________________ > Alan W. Irwin > > Astronomical research affiliation with Department of Physics and Astronomy, > University of Victoria (astrowww.phys.uvic.ca). > > Programming affiliations with the FreeEOS equation-of-state > implementation for stellar interiors (freeeos.sf.net); the Time > Ephemerides project (timeephem.sf.net); PLplot scientific plotting > software package (plplot.sf.net); the libLASi project > (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); > and the Linux Brochure Project (lbproject.sf.net). > __________________________ > > Linux-powered Science > __________________________ |
|
From: Phil R. <p.d...@gm...> - 2015-12-10 12:46:22
|
Alan I have pushed my work so far as it fixes the bug. The only side effect is that it stops the shapefile example building in x19. At least this way you can see my work and where I might be going wrong with the cmake stuff Phil On 10 December 2015 at 12:36, Phil Rosenberg <p.d...@gm...> wrote: > Hi Alan > Sorry this has taken me a while to look at. > > I just want to check what you think the behaviour should be id > shapelib is off, deprecated is on and the user passes in a map name > other than one of the ones we supply? The behaviour before we began > using shapefiles was the same as it is now: If a file with that name > existed then plplot attempted to read it, if not then plplot reported > the warning you saw. I think that is still correct behaviour. > What should probably happen is that the final page of the example > should not be drawn unless shapelib support is on. To do this we need > either a compile time or runtime check for whether plplot was built > with shapelib support. Not wanting to touch the public API I guess a > #define PL_USE_SHAPEFILES in plConfig.h is required. However I'm not > sure how to do that. I tried adding > > set(PL_USE_SHAPEFILES, TRUE) > > In shapelib.cmake and > > #cmakedefine PL_USE_SHAPEFILES > > in plConfig.h.in, but this doesn't work. You might have to look at > this to get it to work or give me some idea what I am doing wrong. I > suspect that shapelib.cmake is not called until after plConfig.h is > generated. If so then sorting that would be a significant change to > the build system that is beyond my skill. > > > Phil > > On 1 December 2015 at 09:46, Phil Rosenberg <p.d...@gm...> wrote: >> Hi Alan I'll look at this today >> ________________________________ >> From: Alan W. Irwin >> Sent: 30/11/2015 21:30 >> To: Phil Rosenberg; Peter Williams >> Cc: PLplot development list >> Subject: Re: [Plplot-devel] Plplot Source Error >> >> On 2015-11-30 19:39-0000 Peter Williams wrote: >> >>> I have done a plplot build using cmake with the 'deprecated' flag set >>> on. The mingw make comes with an error message: >>> >>> C:\PlplotSource-5.11.1\src\plmap.c: In function 'drawmap': >>> >>> C:\PlplotSource-5.11.1\src\plmap.c:530:25: error: 'appendresult' >>> undeclared (first use in this function) >>> appendresult += appendfltptr( &splitx, nsplitsections, bufx + i ); >>> ^ >>> I do not get this error with the deprecated flag set off. It seems a >>> simple error to correct (merely initialise appendresult =0) >>> but I am loath to tamper with complex code which is not mine. >> >> To Phil and Peter: >> >> I confirm this issue on Linux if I use the combination of cmake options >> -DPL_DEPRECATED=ON -DHAVE_SHAPELIB=OFF. >> >> As expected, this build issue does go away if the appendresult declaration >> and >> initialization is moved to where it will be compiled in general. >> However, that is not all the story, because if you also compile >> example 19 for that case and any device driver (I chose cairo), then >> there is a long series of warnings issued for that example when >> you run it, e.g., with >> >> examples/c/x19c -dev xcairo >> >> Those warning messages start with >> >> *** PLPLOT WARNING *** >> Could not find ss/ss64ne_Landform_Area.map file. >> >> That makes no sense. If -DHAVE_SHAPELIB=OFF why in the world >> should this example (or more likely the core library) be looking for >> shapelib files? I also tested the case where -DPL_DEPRECATED=OFF >> -DHAVE_SHAPELIB=OFF, and the code does the right thing there >> which is emit the following warning >> >> *** PLPLOT WARNING *** >> Use of the old plplot map file format is deprecated. >> It is recommended that the shapelib library be used to provide map >> support. >> >> @Phil: As original author of this code, would you please fix the >> -DPL_DEPRECATED=ON -DHAVE_SHAPELIB=OFF case so that the first pages of >> example 19 come out right (like they do now) using the deprecated way >> of doing things, but the last page should simply emit the same message >> as for the -DPL_DEPRECATED=OFF -DHAVE_SHAPELIB=OFF case, i.e., the >> last WARNING message above? >> >> Alan >> __________________________ >> Alan W. Irwin >> >> Astronomical research affiliation with Department of Physics and Astronomy, >> University of Victoria (astrowww.phys.uvic.ca). >> >> Programming affiliations with the FreeEOS equation-of-state >> implementation for stellar interiors (freeeos.sf.net); the Time >> Ephemerides project (timeephem.sf.net); PLplot scientific plotting >> software package (plplot.sf.net); the libLASi project >> (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); >> and the Linux Brochure Project (lbproject.sf.net). >> __________________________ >> >> Linux-powered Science >> __________________________ |
|
From: Alan W. I. <ir...@be...> - 2015-12-10 20:16:48
|
On 2015-12-10 12:36-0000 Phil Rosenberg wrote:
> Hi Alan
> Sorry this has taken me a while to look at.
>
> I just want to check what you think the behaviour should be id
> shapelib is off, deprecated is on and the user passes in a map name
> other than one of the ones we supply? The behaviour before we began
> using shapefiles was the same as it is now: If a file with that name
> existed then plplot attempted to read it, if not then plplot reported
> the warning you saw. I think that is still correct behaviour.
> What should probably happen is that the final page of the example
> should not be drawn unless shapelib support is on. To do this we need
> either a compile time or runtime check for whether plplot was built
> with shapelib support. Not wanting to touch the public API I guess a
> #define PL_USE_SHAPEFILES in plConfig.h is required. However I'm not
> sure how to do that. I tried adding
>
> set(PL_USE_SHAPEFILES, TRUE)
^
> In shapelib.cmake and
>
> #cmakedefine PL_USE_SHAPEFILES
>
> in plConfig.h.in, but this doesn't work.
The issue is the comma in the above set command. Commas are extremely
rare (if they exist at all) in CMake syntax. I don't know, but I
suspect the variable name you set was "PL_USE_SHAPEFILES," with
the above command.
I followed up by pushing that comma removal (as of commit 4970505) which
lead to
// Define if built with shapefile support
#define PL_USE_SHAPEFILES
being set in the configured include/plConfig.h in the build tree.
So all is well there, and here are the relevant results in the cache
for my (default) configuration:
software@raven> grep -E "SHAPE|DEPRECATED" CMakeCache.txt
HAVE_SHAPELIB:BOOL=ON
PL_DEPRECATED:BOOL=OFF
SHAPELIB_INCLUDE_DIR:PATH=/usr/include
SHAPELIB_LIBRARY:FILEPATH=/usr/lib/x86_64-linux-gnu/libshp.so
So that all seems fine, but for this combination I now get the result that
the last page of example 19 does not display any more.
Instead of looking at that issue alone, I suggest you systematically
look at example 19 results for all combinations of HAVE_SHAPELIB and
PL_DEPRECATED
1. -DHAVE_SHAPELIB=OFF, -DPL_DEPRECATED=OFF
2. -DHAVE_SHAPELIB=ON, -DPL_DEPRECATED=OFF
3. -DHAVE_SHAPELIB=OFF, -DPL_DEPRECATED=ON
4. -DHAVE_SHAPELIB=ON, -DPL_DEPRECATED=ON
For PL_DEPRECATED=OFF we should rely completely on the shapelib
approach, and for PL_DEPRECATED=ON we should rely completely on the
traditional non-shapelib approach. So following that philosophy we
should have the following behaviour for example 19:
Case 1 should not plot anything for any page and instead should
emit a warning for each page that shapelib is missing.
Case 2 (the above case I tested) should display all pages with no
warnings (the last page is missing in error for me).
Cases 3 and 4 should display all but the last page using the
deprecated approach, and for the last page should not plot anything
but give a warning message that shapelib and PL_DEPRECATED=OFF are
required for that page.
I hope this clarifies what is needed by example 19 in each of the 4 cases.
Alan
__________________________
Alan W. Irwin
Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).
Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__________________________
Linux-powered Science
__________________________
|
|
From: Phil R. <p.d...@gm...> - 2015-12-11 12:59:52
|
Hi Alan My latest commit has fixed the missing plot. Your option 3 will need some work. Currently shapelib is used if it is available regardless of the situation with PL_DEPECATED. Phil On 10 December 2015 at 20:16, Alan W. Irwin <ir...@be...> wrote: > On 2015-12-10 12:36-0000 Phil Rosenberg wrote: > >> Hi Alan >> Sorry this has taken me a while to look at. >> >> I just want to check what you think the behaviour should be id >> shapelib is off, deprecated is on and the user passes in a map name >> other than one of the ones we supply? The behaviour before we began >> using shapefiles was the same as it is now: If a file with that name >> existed then plplot attempted to read it, if not then plplot reported >> the warning you saw. I think that is still correct behaviour. >> What should probably happen is that the final page of the example >> should not be drawn unless shapelib support is on. To do this we need >> either a compile time or runtime check for whether plplot was built >> with shapelib support. Not wanting to touch the public API I guess a >> #define PL_USE_SHAPEFILES in plConfig.h is required. However I'm not >> sure how to do that. I tried adding >> >> set(PL_USE_SHAPEFILES, TRUE) > > ^ > >> In shapelib.cmake and >> >> #cmakedefine PL_USE_SHAPEFILES >> >> in plConfig.h.in, but this doesn't work. > > > The issue is the comma in the above set command. Commas are extremely > rare (if they exist at all) in CMake syntax. I don't know, but I > suspect the variable name you set was "PL_USE_SHAPEFILES," with > the above command. > > I followed up by pushing that comma removal (as of commit 4970505) which > lead to > > // Define if built with shapefile support > #define PL_USE_SHAPEFILES > > being set in the configured include/plConfig.h in the build tree. > > So all is well there, and here are the relevant results in the cache > for my (default) configuration: > > software@raven> grep -E "SHAPE|DEPRECATED" CMakeCache.txt > HAVE_SHAPELIB:BOOL=ON > PL_DEPRECATED:BOOL=OFF > SHAPELIB_INCLUDE_DIR:PATH=/usr/include > SHAPELIB_LIBRARY:FILEPATH=/usr/lib/x86_64-linux-gnu/libshp.so > > So that all seems fine, but for this combination I now get the result that > the last page of example 19 does not display any more. > > Instead of looking at that issue alone, I suggest you systematically > look at example 19 results for all combinations of HAVE_SHAPELIB and > PL_DEPRECATED > > 1. -DHAVE_SHAPELIB=OFF, -DPL_DEPRECATED=OFF > > 2. -DHAVE_SHAPELIB=ON, -DPL_DEPRECATED=OFF > > 3. -DHAVE_SHAPELIB=OFF, -DPL_DEPRECATED=ON > > 4. -DHAVE_SHAPELIB=ON, -DPL_DEPRECATED=ON > > For PL_DEPRECATED=OFF we should rely completely on the shapelib > approach, and for PL_DEPRECATED=ON we should rely completely on the > traditional non-shapelib approach. So following that philosophy we > should have the following behaviour for example 19: > > Case 1 should not plot anything for any page and instead should > emit a warning for each page that shapelib is missing. > > Case 2 (the above case I tested) should display all pages with no > warnings (the last page is missing in error for me). > > Cases 3 and 4 should display all but the last page using the > deprecated approach, and for the last page should not plot anything > but give a warning message that shapelib and PL_DEPRECATED=OFF are > required for that page. > > I hope this clarifies what is needed by example 19 in each of the 4 cases. > > > Alan > __________________________ > Alan W. Irwin > > Astronomical research affiliation with Department of Physics and Astronomy, > University of Victoria (astrowww.phys.uvic.ca). > > Programming affiliations with the FreeEOS equation-of-state > implementation for stellar interiors (freeeos.sf.net); the Time > Ephemerides project (timeephem.sf.net); PLplot scientific plotting > software package (plplot.sf.net); the libLASi project > (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); > and the Linux Brochure Project (lbproject.sf.net). > __________________________ > > Linux-powered Science > __________________________ |
|
From: Alan W. I. <ir...@be...> - 2015-12-11 22:12:31
|
On 2015-12-11 12:59-0000 Phil Rosenberg wrote: > Hi Alan > My latest commit has fixed the missing plot. Your option 3 will need > some work. Currently shapelib is used if it is available regardless of > the situation with PL_DEPECATED. Hi Phil: I am sorry, but what I said before was misleading and therefore lead you into the following language propagation issue: The current examples/c/x19.c has conditionally compiled code in it, e.g., #ifdef PL_USE_SHAPEFILES But that macro approach obviously only works for C and C+, and cannot be propagated to the rest of our supported languages. So instead of using macros in the examples, we need the core library to handle all of this. So to rephrase what I said, what we really need is the following: 1. -DHAVE_SHAPELIB=OFF, -DPL_DEPRECATED=OFF 2. -DHAVE_SHAPELIB=ON, -DPL_DEPRECATED=OFF 3. -DHAVE_SHAPELIB=OFF, -DPL_DEPRECATED=ON 4. -DHAVE_SHAPELIB=ON, -DPL_DEPRECATED=ON For PL_DEPRECATED=OFF _the libplplot C library_ should rely completely on the shapelib approach, and for PL_DEPRECATED=ON that library should rely completely on the traditional non-shapelib approach. So following that philosophy we should have the following results: Case 1: The library should emit a warning for _every_ plmap-related call that shapelib is missing and otherwise do nothing with those calls. So for this case example 19 will plot a box (generated by plenv) for every page plus generate warning messages, but the plotted pages will contain nothing else for all languages. Case 2: The library should proceed with all the shapelib logic for all plmap calls. Thus, the example 19 result will be complete for every page with no warnings for all languages. (From what you said, I think we have this result now, but I will wait to test it until you are done with your library changes and dropped the macro approach in examples/c/19c.c and examples/c++/x19c.cc). Cases 3 and 4: The library should proceed with the traditional approach for the plmap call, but for all the rest of the plmap-related calls that are only relevant to shapelib should emit a warning (e.g., "The shapelib form of plmap calls are not available when the PL_DEPRECATED macro is #defined). The example 19 results for this case for all languages should look fine for all but the last page, and that page should just contain a box generated by the plenv command and also generate a lot of warnings from the library. Sorry for the previous misleading communication. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |
|
From: Alan W. I. <ir...@be...> - 2016-01-09 05:04:35
|
On 2015-12-11 14:12-0800 Alan W. Irwin wrote: > On 2015-12-11 12:59-0000 Phil Rosenberg wrote: > >> Hi Alan >> My latest commit has fixed the missing plot. Your option 3 will need >> some work. Currently shapelib is used if it is available regardless of >> the situation with PL_DEPECATED. > > Hi Phil: > > I am sorry, but what I said before was misleading and therefore > lead you into the following language propagation issue: > > The current examples/c/x19.c has conditionally compiled code in it, > e.g., > > #ifdef PL_USE_SHAPEFILES > > But that macro approach obviously only works for C and C+, and cannot > be propagated to the rest of our supported languages. So instead > of using macros in the examples, we need the core library to > handle all of this. Hi Phil: I have decided to go ahead and fix this issue since it affects all platforms where shapelib is not available. The result is all warning messages are now emitted by the library rather than the examples, and example 19 results for all languages should be the same as the corresponding C results. For details please consult the commit message at <http://sourceforge.net/p/plplot/plplot/ci/aab6dd1adf692f7031643948dcb2d8ef7881cef1>. Actually, I ask everyone here to read that commit message carefully to make sure you are all willing to go along with the present new build-system design for the three configuration cases that are discussed. Also, this commit needs testing on platforms other than mine to make sure the results follow the new configuration design on all platforms. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X