Menu
▾
▴
plplot-devel
|
From: Orion P. <or...@co...> - 2015-10-07 03:00:48
|
On 10/06/2015 09:42 AM, Robert Maynard wrote: > I am proud to announce the first CMake 3.4 release candidate. This appears to have broken plplot's ada build on Fedora. Previous good (cmake 3.3.2): [ 22%] Building Ada object examples/ada/CMakeFiles/x00a.dir/x00a.o cd /builddir/build/BUILD/plplot-5.11.1/fedora/examples/ada && /usr/bin/gnatgcc -I/builddir/build/BUILD/plplot-5.11.1/fedora/examples/ada -I/builddir/build/BUILD/plplot-5.11.1/bindings/ada -c /builddir/build/BUILD/plplot-5.11.1/examples/ada/x00a.adb -o CMakeFiles/x00a.dir/x00a.o New bad: [ 22%] Building Ada object examples/ada/CMakeFiles/x00a.dir/x00a.o cd /builddir/build/BUILD/plplot-5.11.1/fedora/examples/ada && /usr/bin/gnatgcc -c /builddir/build/BUILD/plplot-5.11.1/examples/ada/x00a.adb -o CMakeFiles/x00a.dir/x00a.o x00a.adb:28:05: file "plplot_auxiliary.ads" not found x00a.adb:29:05: file "plplot_traditional.ads" not found examples/ada/CMakeFiles/x00a.dir/build.make:65: recipe for target 'examples/ada/CMakeFiles/x00a.dir/x00a.o' failed So we're now missing the -I include dir options. That's all I have for now, I'll try to take a closer look later. -- Orion Poplawski Technical Manager 303-415-9701 x222 NWRA/CoRA Division FAX: 303-415-9702 3380 Mitchell Lane or...@co... Boulder, CO 80301 http://www.cora.nwra.com |
|
From: Orion P. <or...@co...> - 2015-10-22 15:29:00
|
On 10/07/2015 10:45 AM, Orion Poplawski wrote: > On 10/06/2015 09:00 PM, Orion Poplawski wrote: >> On 10/06/2015 09:42 AM, Robert Maynard wrote: >>> I am proud to announce the first CMake 3.4 release candidate. >> >> This appears to have broken plplot's ada build on Fedora. Previous good (cmake >> 3.3.2): >> >> [ 22%] Building Ada object examples/ada/CMakeFiles/x00a.dir/x00a.o >> cd /builddir/build/BUILD/plplot-5.11.1/fedora/examples/ada && /usr/bin/gnatgcc >> -I/builddir/build/BUILD/plplot-5.11.1/fedora/examples/ada >> -I/builddir/build/BUILD/plplot-5.11.1/bindings/ada -c >> /builddir/build/BUILD/plplot-5.11.1/examples/ada/x00a.adb -o >> CMakeFiles/x00a.dir/x00a.o >> >> New bad: >> >> [ 22%] Building Ada object examples/ada/CMakeFiles/x00a.dir/x00a.o >> cd /builddir/build/BUILD/plplot-5.11.1/fedora/examples/ada && >> /usr/bin/gnatgcc -c >> /builddir/build/BUILD/plplot-5.11.1/examples/ada/x00a.adb -o >> CMakeFiles/x00a.dir/x00a.o >> x00a.adb:28:05: file "plplot_auxiliary.ads" not found >> x00a.adb:29:05: file "plplot_traditional.ads" not found >> examples/ada/CMakeFiles/x00a.dir/build.make:65: recipe for target >> 'examples/ada/CMakeFiles/x00a.dir/x00a.o' failed >> >> So we're now missing the -I include dir options. >> >> That's all I have for now, I'll try to take a closer look later. >> > > There also appears to be a similar issue with building Paraview where the > MPI_INLCUDE_PATH is no longer being passed to the compile line. > FYI - builds still fail with cmake 3.4.0-rc2. Have had time to look at it closer. plplot issue seems to be triggered by a change in Ada_FLAGS: -Ada_FLAGS = -I/home/orion/fedora/plplot/plplot-5.11.1/build-3.3.2/examples/ada -I/home/orion/fedora/plplot/plplot-5.11.1/bindings/ada +Ada_FLAGS = but plplot I believe has custom Ada cmake platform support. I am still concerned about possible regressions here. -- Orion Poplawski Technical Manager 303-415-9701 x222 NWRA, Boulder/CoRA Office FAX: 303-415-9702 3380 Mitchell Lane or...@nw... Boulder, CO 80301 http://www.nwra.com |
|
From: Phil R. <p.d...@gm...> - 2015-10-22 19:42:32
|
In the past I had problems with the Ada module. Even though I don't have Ada installed the find module corrupted some build parameters. Since then I have always built with Ada switched off as I could never find the cause. Perhaps the two issues are linked. Phil -----Original Message----- From: "Orion Poplawski" <or...@co...> Sent: 22/10/2015 16:29 To: "CMake Mailing List" <cm...@cm...>; "Plplot-devel mailing list" <plp...@li...> Subject: Re: [Plplot-devel] [CMake] [ANNOUNCE] CMake 3.4.0-rc1 is now ready! On 10/07/2015 10:45 AM, Orion Poplawski wrote: > On 10/06/2015 09:00 PM, Orion Poplawski wrote: >> On 10/06/2015 09:42 AM, Robert Maynard wrote: >>> I am proud to announce the first CMake 3.4 release candidate. >> >> This appears to have broken plplot's ada build on Fedora. Previous good (cmake >> 3.3.2): >> >> [ 22%] Building Ada object examples/ada/CMakeFiles/x00a.dir/x00a.o >> cd /builddir/build/BUILD/plplot-5.11.1/fedora/examples/ada && /usr/bin/gnatgcc >> -I/builddir/build/BUILD/plplot-5.11.1/fedora/examples/ada >> -I/builddir/build/BUILD/plplot-5.11.1/bindings/ada -c >> /builddir/build/BUILD/plplot-5.11.1/examples/ada/x00a.adb -o >> CMakeFiles/x00a.dir/x00a.o >> >> New bad: >> >> [ 22%] Building Ada object examples/ada/CMakeFiles/x00a.dir/x00a.o >> cd /builddir/build/BUILD/plplot-5.11.1/fedora/examples/ada && >> /usr/bin/gnatgcc -c >> /builddir/build/BUILD/plplot-5.11.1/examples/ada/x00a.adb -o >> CMakeFiles/x00a.dir/x00a.o >> x00a.adb:28:05: file "plplot_auxiliary.ads" not found >> x00a.adb:29:05: file "plplot_traditional.ads" not found >> examples/ada/CMakeFiles/x00a.dir/build.make:65: recipe for target >> 'examples/ada/CMakeFiles/x00a.dir/x00a.o' failed >> >> So we're now missing the -I include dir options. >> >> That's all I have for now, I'll try to take a closer look later. >> > > There also appears to be a similar issue with building Paraview where the > MPI_INLCUDE_PATH is no longer being passed to the compile line. > FYI - builds still fail with cmake 3.4.0-rc2. Have had time to look at it closer. plplot issue seems to be triggered by a change in Ada_FLAGS: -Ada_FLAGS = -I/home/orion/fedora/plplot/plplot-5.11.1/build-3.3.2/examples/ada -I/home/orion/fedora/plplot/plplot-5.11.1/bindings/ada +Ada_FLAGS = but plplot I believe has custom Ada cmake platform support. I am still concerned about possible regressions here. -- Orion Poplawski Technical Manager 303-415-9701 x222 NWRA, Boulder/CoRA Office FAX: 303-415-9702 3380 Mitchell Lane or...@nw... Boulder, CO 80301 http://www.nwra.com ------------------------------------------------------------------------------ _______________________________________________ Plplot-devel mailing list Plp...@li... https://lists.sourceforge.net/lists/listinfo/plplot-devel |
|
From: Orion P. <or...@co...> - 2015-10-31 01:59:53
Attachments:
plplot-cmake34.patch
|
On 10/22/2015 11:30 AM, Brad King wrote: > On 10/22/2015 11:28 AM, Orion Poplawski wrote: >>>> This appears to have broken plplot's ada build on Fedora. >> >> FYI - builds still fail with cmake 3.4.0-rc2. Have had time to look at it >> closer. plplot issue seems to be triggered by a change in Ada_FLAGS: >> >> -Ada_FLAGS = >> -I/home/orion/fedora/plplot/plplot-5.11.1/build-3.3.2/examples/ada >> -I/home/orion/fedora/plplot/plplot-5.11.1/bindings/ada >> +Ada_FLAGS = >> >> but plplot I believe has custom Ada cmake platform support. I am still >> concerned about possible regressions here. > > Plplot's Ada support uses CMake internal APIs so it is plplot's > responsibility to adapt to our changes: > > https://cmake.org/gitweb?p=cmake.git;a=blob;f=Modules/CMakeAddNewLanguage.txt;hb=v3.4.0-rc2 > Maintainers of external language support are responsible for porting > it to each version of CMake as upstream changes are made. > > Our 3.4.0-rc2 release notes point out a change likely causing this problem: > > https://cmake.org/gitweb?p=cmake.git;a=blob;f=Help/release/3.4.rst;hb=v3.4.0-rc2#l271 > * The internal "CMAKE_<LANG>_COMPILE_OBJECT" rule variable now > substitutes compiler include flags in a separate "<INCLUDES>" > placeholder instead of the main "<FLAGS>" placeholder. > > Where Plplot currently writes: > > SET(CMAKE_Ada_COMPILE_OBJECT > "<CMAKE_Ada_COMPILER> <FLAGS> -c <SOURCE> -o <OBJECT> > ") > > try: > > if(NOT CMAKE_VERSION VERSION_LESS 3.4) > set(CMAKE_Ada_COMPILE_OBJECT > "<CMAKE_Ada_COMPILER> <INCLUDES> <FLAGS> -c <SOURCE> -o <OBJECT>") > else() > set(CMAKE_Ada_COMPILE_OBJECT > "<CMAKE_Ada_COMPILER> <FLAGS> -c <SOURCE> -o <OBJECT>") > endif() > > -Brad > Ah, thank you very much. The attached patch fixes this. -- Orion Poplawski Technical Manager 303-415-9701 x222 NWRA/CoRA Division FAX: 303-415-9702 3380 Mitchell Lane or...@co... Boulder, CO 80301 http://www.cora.nwra.com |
|
From: Alan W. I. <ir...@be...> - 2015-10-31 17:10:35
|
On 2015-10-30 19:59-0600 Orion Poplawski wrote: > On 10/22/2015 11:30 AM, Brad King wrote: [...] >> Where Plplot currently writes: >> >> SET(CMAKE_Ada_COMPILE_OBJECT >> "<CMAKE_Ada_COMPILER> <FLAGS> -c <SOURCE> -o <OBJECT> >> ") >> >> try: >> >> if(NOT CMAKE_VERSION VERSION_LESS 3.4) >> set(CMAKE_Ada_COMPILE_OBJECT >> "<CMAKE_Ada_COMPILER> <INCLUDES> <FLAGS> -c <SOURCE> -o <OBJECT>") >> else() >> set(CMAKE_Ada_COMPILE_OBJECT >> "<CMAKE_Ada_COMPILER> <FLAGS> -c <SOURCE> -o <OBJECT>") >> endif() >> >> -Brad >> > > Ah, thank you very much. The attached patch fixes this. Hi Orion: Thanks for implementing Brad's suggestion to fix the PLplot Ada language support issue for CMake-3.4. To help give you PLplot git credit for your work, would you please put the patch in "git format-patch" form? I also notice substantial use of <FLAGS> in the PLplot D language support case. I assume your tests did not reveal any issues for D because you were not trying any D compiler flags, but I predict if you do that, you will encounter the same problem. For example, if you try export DFLAGS=-Iwhatever I assume that (harmless) compile flag will correctly propagate to the D compile step (as seen by the VERBOSE=1 option for make) for older versions of CMake but will not propagate correctly for CMake-3.4. Anyhow, I am virtually positive there is also a PLplot <FLAGS> D language support issue for CMake-3.4 so if you don't beat me to it, I plan (likely late next week because I am currently tied up with something else) to expose that issue with a test like the one I suggested above and also plan to fix the issue following Brad's suggestion. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |
|
From: Orion P. <or...@co...> - 2015-11-02 02:54:14
Attachments:
0001-Add-support-for-cmake-3.4-for-Ada.patch
|
On 10/31/2015 11:10 AM, Alan W. Irwin wrote: > Hi Orion: > > Thanks for implementing Brad's suggestion to fix the PLplot Ada > language support issue for CMake-3.4. To help give you PLplot git > credit for your work, would you please put the patch in "git > format-patch" form? Attached. > I also notice substantial use of <FLAGS> in the PLplot D language > support case. I assume your tests did not reveal any issues for D > because you were not trying any D compiler flags, but I predict if you > do that, you will encounter the same problem. For example, if you try > > export DFLAGS=-Iwhatever > > I assume that (harmless) compile flag will correctly propagate to the D > compile step (as seen > by the VERBOSE=1 option for make) for older versions of CMake but will > not propagate correctly for CMake-3.4. > > Anyhow, I am virtually positive there is also a PLplot <FLAGS> D > language support issue for CMake-3.4 so if you don't beat me to it, I > plan (likely late next week because I am currently tied up with > something else) to expose that issue with a test like the one I > suggested above and also plan to fix the issue following Brad's > suggestion. I don't enable D support on the Fedora package, so I haven't looked at this. -- Orion Poplawski Technical Manager 303-415-9701 x222 NWRA/CoRA Division FAX: 303-415-9702 3380 Mitchell Lane or...@co... Boulder, CO 80301 http://www.cora.nwra.com |
|
From: Alan W. I. <ir...@be...> - 2015-11-09 19:36:11
|
On 2015-11-01 19:54-0700 Orion Poplawski wrote: > On 10/31/2015 11:10 AM, Alan W. Irwin wrote: >> Hi Orion: >> >> Thanks for implementing Brad's suggestion to fix the PLplot Ada >> language support issue for CMake-3.4. To help give you PLplot git >> credit for your work, would you please put the patch in "git >> format-patch" form? > > Attached. Hi Orion: Tested (with cmake-3.3.2 and cmake-3.4.0-rc3) and applied (<http://sourceforge.net/p/plplot/plplot/ci/5722b1754e384b62a18e20dc45d41785c1b40cbb/>) with thanks! >> I also notice substantial use of <FLAGS> in the PLplot D language >> support case. [...] > I don't enable D support on the Fedora package, so I haven't looked at this. It turns out there are indeed similar D example build problems with CMake-3.4.0-rc3 so making the equivalent fix to PLplot's CMake language support for D is next on my agenda. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |
|
From: Alan W. I. <ir...@be...> - 2015-11-10 02:02:38
|
On 2015-10-22 13:30-0400 Brad King wrote: [...] > Plplot's Ada support uses CMake internal APIs so it is plplot's > responsibility to adapt to our changes: [...] > Where Plplot currently writes: > > SET(CMAKE_Ada_COMPILE_OBJECT > "<CMAKE_Ada_COMPILER> <FLAGS> -c <SOURCE> -o <OBJECT> > ") > > try: > > if(NOT CMAKE_VERSION VERSION_LESS 3.4) > set(CMAKE_Ada_COMPILE_OBJECT > "<CMAKE_Ada_COMPILER> <INCLUDES> <FLAGS> -c <SOURCE> -o <OBJECT>") > else() > set(CMAKE_Ada_COMPILE_OBJECT > "<CMAKE_Ada_COMPILER> <FLAGS> -c <SOURCE> -o <OBJECT>") > endif() To bring this thread to conclusion, Orion implemented Brad's idea for PLplot's Ada language support (see <http://sourceforge.net/p/plplot/plplot/ci/5722b1754e384b62a18e20dc45d41785c1b40cbb/>), and I just did the same thing for PLplot's D language support (see <http://sourceforge.net/p/plplot/plplot/ci/16fe6dcb1e5acc3284f265af366eccc1b2099bfc>) with good test results for Ada and D examples for both shared and static libraries and both CMake-3.3.2 and CMake-3.4.0-rc3. Thanks, Brad, for your essential help in solving these PLplot Ada and D issues caused by the internal changes in CMake's language support infrastructure for CMake-3.4. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |
|
From: Alan W. I. <ir...@be...> - 2015-10-07 08:31:10
|
On 2015-10-06 21:00-0600 Orion Poplawski wrote: > On 10/06/2015 09:42 AM, Robert Maynard wrote: >> I am proud to announce the first CMake 3.4 release candidate. > > This appears to have broken plplot's ada build on Fedora. Previous good > (cmake 3.3.2): > > [ 22%] Building Ada object examples/ada/CMakeFiles/x00a.dir/x00a.o > cd /builddir/build/BUILD/plplot-5.11.1/fedora/examples/ada && > /usr/bin/gnatgcc > -I/builddir/build/BUILD/plplot-5.11.1/fedora/examples/ada > -I/builddir/build/BUILD/plplot-5.11.1/bindings/ada -c > /builddir/build/BUILD/plplot-5.11.1/examples/ada/x00a.adb -o > CMakeFiles/x00a.dir/x00a.o > > New bad: > > [ 22%] Building Ada object examples/ada/CMakeFiles/x00a.dir/x00a.o > cd /builddir/build/BUILD/plplot-5.11.1/fedora/examples/ada && > /usr/bin/gnatgcc -c > /builddir/build/BUILD/plplot-5.11.1/examples/ada/x00a.adb -o > CMakeFiles/x00a.dir/x00a.o > x00a.adb:28:05: file "plplot_auxiliary.ads" not found > x00a.adb:29:05: file "plplot_traditional.ads" not found > examples/ada/CMakeFiles/x00a.dir/build.make:65: recipe for target > 'examples/ada/CMakeFiles/x00a.dir/x00a.o' failed > > So we're now missing the -I include dir options. > > That's all I have for now, I'll try to take a closer look later. Hi Orion: Thanks for your report of the above regression for the CMake 3.4 release candidate. To help make further progress with this regression, please provide the complete set of commands that build the Ada wrapper library and the Ada example rather than the above snippets. The requested information can be determined using cmake -DBUILD_TEST=ON .... make VERBOSE=1 x00a >& x00a.out Please execute those two commands for both cmake 3.3.2 and the 3.4 release candidate. Then attach compressed versions of the two x00a.out files to a post to the plplot-devel mailing list, and I will attempt to take it from there. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X