plplot-devel

[Plplot-devel] patch 31 which contains wincairo fixes

[Alan W. I. <ir...@be...>]

Hi Hazen:

A PLplot user has created a patch containing wincairo fixes (see
<http://sourceforge.net/p/plplot/patches/31/>).  As the originator of
the wincairo device could you please evaluate this 3-line change to
see whether we should apply it now to master so it will be included in
the planned 5.11.1 bugfix release?

Thanks in advance.

Alan
__________________________
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__________________________

Linux-powered Science
__________________________

Re: [Plplot-devel] patch 31 which contains wincairo fixes

[Hazen B. <hba...@ma...>]

On 07/04/2015 12:15 PM, Alan W. Irwin wrote:
> Hi Hazen:
>
> A PLplot user has created a patch containing wincairo fixes (see
> <http://sourceforge.net/p/plplot/patches/31/>).  As the originator of
> the wincairo device could you please evaluate this 3-line change to
> see whether we should apply it now to master so it will be included in
> the planned 5.11.1 bugfix release?

Hi Alan,

I think these changes are the right thing to do based on reading up on 
Microsoft's documentation and I would just go ahead and apply it. 
However since I no longer have a Windows development box I can't test 
it. The best test would be to make sure that it doesn't break 32 bit 
Windows.

-Hazen

Re: [Plplot-devel] patch 31 which contains wincairo fixes

[Greg J. <gv...@gm...>]

I have been using the calls
-    SetWindowLong( aStream->hwnd, GWL_USERDATA, (long) pls );
+    SetWindowLongPtr( aStream->hwnd, GWLP_USERDATA, (LONG_PTR) pls );

in both 32- and 64-bit compiled wincairo application for months, as well as
in wingcc.  They work.  AFAICT there's
no reason to maintain #ifdef _WIN64 conditionals as long as you go with
these calls.

I hadn't noticed the omission of <cairo-win32.h> except it now removes a
worrisome warning I got
in 64-bit compilation (the 32-bit comnpilation didn't need this, evidently).


On Sun, Jul 5, 2015 at 3:46 AM, Hazen Babcock <hba...@ma...> wrote:

> On 07/04/2015 12:15 PM, Alan W. Irwin wrote:
> > Hi Hazen:
> >
> > A PLplot user has created a patch containing wincairo fixes (see
> > <http://sourceforge.net/p/plplot/patches/31/>).  As the originator of
> > the wincairo device could you please evaluate this 3-line change to
> > see whether we should apply it now to master so it will be included in
> > the planned 5.11.1 bugfix release?
>
> Hi Alan,
>
> I think these changes are the right thing to do based on reading up on
> Microsoft's documentation and I would just go ahead and apply it.
> However since I no longer have a Windows development box I can't test
> it. The best test would be to make sure that it doesn't break 32 bit
> Windows.
>
> -Hazen
>
>
>
> ------------------------------------------------------------------------------
> Don't Limit Your Business. Reach for the Cloud.
> GigeNET's Cloud Solutions provide you with the tools and support that
> you need to offload your IT needs and focus on growing your business.
> Configured For All Businesses. Start Your Cloud Today.
> https://www.gigenetcloud.com/
> _______________________________________________
> Plplot-devel mailing list
> Plp...@li...
> https://lists.sourceforge.net/lists/listinfo/plplot-devel
>

Re: [Plplot-devel] patch 31 which contains wincairo fixes

[Hazen B. <hba...@ma...>]

On 07/06/2015 01:26 PM, Greg Jung wrote:
> I have been using the calls
> -    SetWindowLong( aStream->hwnd, GWL_USERDATA, (long) pls );
> +    SetWindowLongPtr( aStream->hwnd, GWLP_USERDATA, (LONG_PTR) pls );
>
> in both 32- and 64-bit compiled wincairo application for months, as well as
> in wingcc.  They work.  AFAICT there's
> no reason to maintain #ifdef _WIN64 conditionals as long as you go with
> these calls.
>
> I hadn't noticed the omission of <cairo-win32.h> except it now removes a
> worrisome warning I got
> in 64-bit compilation (the 32-bit comnpilation didn't need this, evidently).

Ok, I just pushed this so let me know if it causes any problems.

-Hazen