From: Andrew R. <and...@us...> - 2012-10-04 13:33:54
|
Hez, Thanks for your updates to the plcolorbar / pllegend support. Do you have any other plans for further changes? I was wondering whether we are approaching the point where we feel happy with the API for these functions. If so I would definitely like to see this being finalised for the next release. As part of this we could also enable the colorbar features in the C examples by default and start propagating them to other languages. This would be a nice new feature for a new release. I did notice that at least with the xwin driver the colorbar text extended beyond the window. We may need to tweak the size of the viewport to fix this. I'll check more generally with other drivers too. Cheers Andrew On Wed, Oct 03, 2012 at 01:22:15PM +0000, hez...@us... wrote: > Revision: 12235 > http://plplot.svn.sourceforge.net/plplot/?rev=12235&view=rev > Author: hezekiahcarty > Date: 2012-10-03 13:22:14 +0000 (Wed, 03 Oct 2012) > Log Message: > ----------- > Add support for multiple labels and axes to plcolorbar > > C examples 16 and 33 have been updated to match the API changes. > > Modified Paths: > -------------- > trunk/examples/c/x16c.c > trunk/examples/c/x33c.c > trunk/include/plplot.h > trunk/src/pllegend.c > |
From: Hezekiah M. C. <hez...@us...> - 2012-10-05 12:10:06
|
On Thu, Oct 4, 2012 at 9:33 AM, Andrew Ross <and...@us...> wrote: > > Hez, > > Thanks for your updates to the plcolorbar / pllegend support. Do you > have any other plans for further changes? I was wondering whether we > are approaching the point where we feel happy with the API for these > functions. If so I would definitely like to see this being finalised > for the next release. As part of this we could also enable the > colorbar features in the C examples by default and start propagating > them to other languages. This would be a nice new feature for a new > release. > > I did notice that at least with the xwin driver the colorbar text > extended beyond the window. We may need to tweak the size of the > viewport to fix this. I'll check more generally with other drivers > too. > Andrew, I am happy with the plcolorbar interface. With this latest commit and Alan's additions, it is flexible enough to support more than I had initially planned. The same goes for pllegend. I would prefer it if others could look at the new plcolorbar API and comment/ask questions to ensure nothing important is missing. Beyond that, I'm happy to call both functions' interfaces stable. There are still some bugs in plcolorbar. Bounding box handling with multiple labels and/or axes does not work properly. I don't think I am using Alan's bounding box update code properly when applying each label and axis. Fixing this would not require an interface change so the bug fixing could happen in parallel with bindings propagation and example updates. Hez |
From: Andrew R. <and...@us...> - 2012-10-22 21:20:27
|
On Fri, Oct 05, 2012 at 08:03:02AM -0400, Hezekiah M. Carty wrote: > On Thu, Oct 4, 2012 at 9:33 AM, Andrew Ross > <and...@us...> wrote: > > > > Hez, > > > > Thanks for your updates to the plcolorbar / pllegend support. Do you > > have any other plans for further changes? I was wondering whether we > > are approaching the point where we feel happy with the API for these > > functions. If so I would definitely like to see this being finalised > > for the next release. As part of this we could also enable the > > colorbar features in the C examples by default and start propagating > > them to other languages. This would be a nice new feature for a new > > release. > > > > I did notice that at least with the xwin driver the colorbar text > > extended beyond the window. We may need to tweak the size of the > > viewport to fix this. I'll check more generally with other drivers > > too. > > > > Andrew, > > I am happy with the plcolorbar interface. With this latest commit and > Alan's additions, it is flexible enough to support more than I had > initially planned. The same goes for pllegend. I would prefer it if > others could look at the new plcolorbar API and comment/ask questions > to ensure nothing important is missing. Beyond that, I'm happy to > call both functions' interfaces stable. > > There are still some bugs in plcolorbar. Bounding box handling with > multiple labels and/or axes does not work properly. I don't think I > am using Alan's bounding box update code properly when applying each > label and axis. Fixing this would not require an interface change so > the bug fixing could happen in parallel with bindings propagation and > example updates. > > Hez I've started the process of porting the colorbar support to other languages. As a first step I've enabled colorbar support by default in C example 16 so we can test and compare. I've implemented plcolorbar in the C++ bindings and updated the examples accordingly. If anyone wants to help in this, feel free. The swig generated bindings will need a little behind the scenes work first to deal with all the arrays. Andrew |
From: Hezekiah M. C. <hez...@us...> - 2012-10-24 17:31:15
|
On Mon, Oct 22, 2012 at 5:20 PM, Andrew Ross <and...@us...> wrote: > On Fri, Oct 05, 2012 at 08:03:02AM -0400, Hezekiah M. Carty wrote: >> On Thu, Oct 4, 2012 at 9:33 AM, Andrew Ross >> <and...@us...> wrote: >> > >> > Hez, >> > >> > Thanks for your updates to the plcolorbar / pllegend support. Do you >> > have any other plans for further changes? I was wondering whether we >> > are approaching the point where we feel happy with the API for these >> > functions. If so I would definitely like to see this being finalised >> > for the next release. As part of this we could also enable the >> > colorbar features in the C examples by default and start propagating >> > them to other languages. This would be a nice new feature for a new >> > release. >> > >> > I did notice that at least with the xwin driver the colorbar text >> > extended beyond the window. We may need to tweak the size of the >> > viewport to fix this. I'll check more generally with other drivers >> > too. >> > >> >> Andrew, >> >> I am happy with the plcolorbar interface. With this latest commit and >> Alan's additions, it is flexible enough to support more than I had >> initially planned. The same goes for pllegend. I would prefer it if >> others could look at the new plcolorbar API and comment/ask questions >> to ensure nothing important is missing. Beyond that, I'm happy to >> call both functions' interfaces stable. >> >> There are still some bugs in plcolorbar. Bounding box handling with >> multiple labels and/or axes does not work properly. I don't think I >> am using Alan's bounding box update code properly when applying each >> label and axis. Fixing this would not require an interface change so >> the bug fixing could happen in parallel with bindings propagation and >> example updates. >> >> Hez > > I've started the process of porting the colorbar support to other > languages. As a first step I've enabled colorbar support by default > in C example 16 so we can test and compare. > > I've implemented plcolorbar in the C++ bindings and updated the > examples accordingly. If anyone wants to help in this, feel free. The > swig generated bindings will need a little behind the scenes work > first to deal with all the arrays. > > Andrew Andrew, I found another change that I think we should make before completing the plcolorbar + example change propagation. The tick mark arguments are still restricted to single values but they should be made into arrays with one element each per axis. I hope to be able to make and commit these changes within the next day or two. If someone else beats me to it that's fine as well. Hez |
From: Andrew R. <and...@us...> - 2012-10-24 19:08:26
|
On Wed, Oct 24, 2012 at 01:30:44PM -0400, Hezekiah M. Carty wrote: > On Mon, Oct 22, 2012 at 5:20 PM, Andrew Ross > <and...@us...> wrote: > > On Fri, Oct 05, 2012 at 08:03:02AM -0400, Hezekiah M. Carty wrote: > >> On Thu, Oct 4, 2012 at 9:33 AM, Andrew Ross > >> <and...@us...> wrote: > >> > > >> > Hez, > >> > > >> > Thanks for your updates to the plcolorbar / pllegend support. Do you > >> > have any other plans for further changes? I was wondering whether we > >> > are approaching the point where we feel happy with the API for these > >> > functions. If so I would definitely like to see this being finalised > >> > for the next release. As part of this we could also enable the > >> > colorbar features in the C examples by default and start propagating > >> > them to other languages. This would be a nice new feature for a new > >> > release. > >> > > >> > I did notice that at least with the xwin driver the colorbar text > >> > extended beyond the window. We may need to tweak the size of the > >> > viewport to fix this. I'll check more generally with other drivers > >> > too. > >> > > >> > >> Andrew, > >> > >> I am happy with the plcolorbar interface. With this latest commit and > >> Alan's additions, it is flexible enough to support more than I had > >> initially planned. The same goes for pllegend. I would prefer it if > >> others could look at the new plcolorbar API and comment/ask questions > >> to ensure nothing important is missing. Beyond that, I'm happy to > >> call both functions' interfaces stable. > >> > >> There are still some bugs in plcolorbar. Bounding box handling with > >> multiple labels and/or axes does not work properly. I don't think I > >> am using Alan's bounding box update code properly when applying each > >> label and axis. Fixing this would not require an interface change so > >> the bug fixing could happen in parallel with bindings propagation and > >> example updates. > >> > >> Hez > > > > I've started the process of porting the colorbar support to other > > languages. As a first step I've enabled colorbar support by default > > in C example 16 so we can test and compare. > > > > I've implemented plcolorbar in the C++ bindings and updated the > > examples accordingly. If anyone wants to help in this, feel free. The > > swig generated bindings will need a little behind the scenes work > > first to deal with all the arrays. > > > > Andrew > > Andrew, > > I found another change that I think we should make before completing > the plcolorbar + example change propagation. The tick mark arguments > are still restricted to single values but they should be made into > arrays with one element each per axis. > > I hope to be able to make and commit these changes within the next day > or two. If someone else beats me to it that's fine as well. Hez, Thanks. I won't have much time over the next couple of days for plplot so I'll wait until you've made your changes before propagating further. One issue I did notice with example 33 (not yet enabled by default) is that the high caps don't appear to do anything. Low caps are fine. Can you confirm this? Andrew |
From: Andrew R. <and...@us...> - 2012-10-25 17:39:57
|
On Wed, Oct 24, 2012 at 08:08:16PM +0100, Andrew Ross wrote: > On Wed, Oct 24, 2012 at 01:30:44PM -0400, Hezekiah M. Carty wrote: > > > > Andrew, > > > > I found another change that I think we should make before completing > > the plcolorbar + example change propagation. The tick mark arguments > > are still restricted to single values but they should be made into > > arrays with one element each per axis. > > > > I hope to be able to make and commit these changes within the next day > > or two. If someone else beats me to it that's fine as well. > > Hez, > > Thanks. I won't have much time over the next couple of days for plplot so > I'll wait until you've made your changes before propagating further. > > One issue I did notice with example 33 (not yet enabled by default) is that > the high caps don't appear to do anything. Low caps are fine. Can you confirm > this? I've propagated your API changes to C++ and also fixed example 33 which was broken by the changes. Your patch hasn't fixed the high caps problem for me though. I'm not clear from the SVN comments whether it was supposed to? Andrew |
From: Hezekiah M. C. <hez...@us...> - 2012-10-25 19:57:05
|
On Thu, Oct 25, 2012 at 1:39 PM, Andrew Ross <and...@us...> wrote: > On Wed, Oct 24, 2012 at 08:08:16PM +0100, Andrew Ross wrote: >> On Wed, Oct 24, 2012 at 01:30:44PM -0400, Hezekiah M. Carty wrote: >> > >> > Andrew, >> > >> > I found another change that I think we should make before completing >> > the plcolorbar + example change propagation. The tick mark arguments >> > are still restricted to single values but they should be made into >> > arrays with one element each per axis. >> > >> > I hope to be able to make and commit these changes within the next day >> > or two. If someone else beats me to it that's fine as well. >> >> Hez, >> >> Thanks. I won't have much time over the next couple of days for plplot so >> I'll wait until you've made your changes before propagating further. >> >> One issue I did notice with example 33 (not yet enabled by default) is that >> the high caps don't appear to do anything. Low caps are fine. Can you confirm >> this? > > I've propagated your API changes to C++ and also fixed example 33 which > was broken by the changes. Your patch hasn't fixed the high caps problem > for me though. I'm not clear from the SVN comments whether it was > supposed to? > > Andrew Andrew, Thank you for propagating the changes and updating example 33. I've tested on a few different 64bit Linux systems and I don't have any issues with the low or high caps in example 33. Is the issue present on all pages of example 33 which should have high caps or only a subset of the pages? Do you have this issue with all of the display drivers? Hez |
From: Alan W. I. <ir...@be...> - 2012-10-25 20:08:24
|
On 2012-10-25 15:56-0400 Hezekiah M. Carty wrote: > On Thu, Oct 25, 2012 at 1:39 PM, Andrew Ross > <and...@us...> wrote: >> On Wed, Oct 24, 2012 at 08:08:16PM +0100, Andrew Ross wrote: >>> On Wed, Oct 24, 2012 at 01:30:44PM -0400, Hezekiah M. Carty wrote: >>>> >>>> Andrew, >>>> >>>> I found another change that I think we should make before completing >>>> the plcolorbar + example change propagation. The tick mark arguments >>>> are still restricted to single values but they should be made into >>>> arrays with one element each per axis. >>>> >>>> I hope to be able to make and commit these changes within the next day >>>> or two. If someone else beats me to it that's fine as well. >>> >>> Hez, >>> >>> Thanks. I won't have much time over the next couple of days for plplot so >>> I'll wait until you've made your changes before propagating further. >>> >>> One issue I did notice with example 33 (not yet enabled by default) is that >>> the high caps don't appear to do anything. Low caps are fine. Can you confirm >>> this? >> >> I've propagated your API changes to C++ and also fixed example 33 which >> was broken by the changes. Your patch hasn't fixed the high caps problem >> for me though. I'm not clear from the SVN comments whether it was >> supposed to? >> >> Andrew > > Andrew, > > Thank you for propagating the changes and updating example 33. > > I've tested on a few different 64bit Linux systems and I don't have > any issues with the low or high caps in example 33. Is the issue > present on all pages of example 33 which should have high caps or only > a subset of the pages? Do you have this issue with all of the display > drivers? Andrew, I don't think I have seen that issue here either. So I am looking forward to your reply to Hez's request for more information as well to help pin this down. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |
From: Andrew R. <and...@us...> - 2012-10-25 21:11:27
|
On Thu, Oct 25, 2012 at 01:08:16PM -0700, Alan Irwin wrote: > On 2012-10-25 15:56-0400 Hezekiah M. Carty wrote: > > > On Thu, Oct 25, 2012 at 1:39 PM, Andrew Ross > > <and...@us...> wrote: > >> On Wed, Oct 24, 2012 at 08:08:16PM +0100, Andrew Ross wrote: > >>> On Wed, Oct 24, 2012 at 01:30:44PM -0400, Hezekiah M. Carty wrote: > >>>> > >>>> Andrew, > >>>> > >>>> I found another change that I think we should make before completing > >>>> the plcolorbar + example change propagation. The tick mark arguments > >>>> are still restricted to single values but they should be made into > >>>> arrays with one element each per axis. > >>>> > >>>> I hope to be able to make and commit these changes within the next day > >>>> or two. If someone else beats me to it that's fine as well. > >>> > >>> Hez, > >>> > >>> Thanks. I won't have much time over the next couple of days for plplot so > >>> I'll wait until you've made your changes before propagating further. > >>> > >>> One issue I did notice with example 33 (not yet enabled by default) is that > >>> the high caps don't appear to do anything. Low caps are fine. Can you confirm > >>> this? > >> > >> I've propagated your API changes to C++ and also fixed example 33 which > >> was broken by the changes. Your patch hasn't fixed the high caps problem > >> for me though. I'm not clear from the SVN comments whether it was > >> supposed to? > >> > >> Andrew > > > > Andrew, > > > > Thank you for propagating the changes and updating example 33. > > > > I've tested on a few different 64bit Linux systems and I don't have > > any issues with the low or high caps in example 33. Is the issue > > present on all pages of example 33 which should have high caps or only > > a subset of the pages? Do you have this issue with all of the display > > drivers? > > Andrew, I don't think I have seen that issue here either. So I am > looking forward to your reply to Hez's request for more information as > well to help pin this down. OK. I think I've found the reason. I'd tested with the xwin and psc drivers. In both these cases the background colour for the colorbar boxes are black. This masks the black high caps. Trying with other drivers (e.g. qtwidget) and everything is fine. So the problem is with how the background colour of the colorbar box is assigned. This seems to be driver dependent in a non-obvious way. Andrew |
From: Hezekiah M. C. <hez...@us...> - 2012-10-25 21:33:32
|
On Thu, Oct 25, 2012 at 5:11 PM, Andrew Ross <and...@us...> wrote: > On Thu, Oct 25, 2012 at 01:08:16PM -0700, Alan Irwin wrote: >> On 2012-10-25 15:56-0400 Hezekiah M. Carty wrote: >> >> > On Thu, Oct 25, 2012 at 1:39 PM, Andrew Ross >> > <and...@us...> wrote: >> >> On Wed, Oct 24, 2012 at 08:08:16PM +0100, Andrew Ross wrote: >> >>> On Wed, Oct 24, 2012 at 01:30:44PM -0400, Hezekiah M. Carty wrote: >> >>>> >> >>>> Andrew, >> >>>> >> >>>> I found another change that I think we should make before completing >> >>>> the plcolorbar + example change propagation. The tick mark arguments >> >>>> are still restricted to single values but they should be made into >> >>>> arrays with one element each per axis. >> >>>> >> >>>> I hope to be able to make and commit these changes within the next day >> >>>> or two. If someone else beats me to it that's fine as well. >> >>> >> >>> Hez, >> >>> >> >>> Thanks. I won't have much time over the next couple of days for plplot so >> >>> I'll wait until you've made your changes before propagating further. >> >>> >> >>> One issue I did notice with example 33 (not yet enabled by default) is that >> >>> the high caps don't appear to do anything. Low caps are fine. Can you confirm >> >>> this? >> >> >> >> I've propagated your API changes to C++ and also fixed example 33 which >> >> was broken by the changes. Your patch hasn't fixed the high caps problem >> >> for me though. I'm not clear from the SVN comments whether it was >> >> supposed to? >> >> >> >> Andrew >> > >> > Andrew, >> > >> > Thank you for propagating the changes and updating example 33. >> > >> > I've tested on a few different 64bit Linux systems and I don't have >> > any issues with the low or high caps in example 33. Is the issue >> > present on all pages of example 33 which should have high caps or only >> > a subset of the pages? Do you have this issue with all of the display >> > drivers? >> >> Andrew, I don't think I have seen that issue here either. So I am >> looking forward to your reply to Hez's request for more information as >> well to help pin this down. > > OK. I think I've found the reason. I'd tested with the xwin and psc > drivers. In both these cases the background colour for the colorbar > boxes are black. This masks the black high caps. Trying with other > drivers (e.g. qtwidget) and everything is fine. So the problem is > with how the background colour of the colorbar box is assigned. This > seems to be driver dependent in a non-obvious way. > > Andrew Andrew, The background color in example 33 is transparent. The xwin and psc drivers don't support transparency while the Cairo and Qt devices do. I expect that is where the problem is coming from. Hez |
From: Andrew R. <and...@us...> - 2012-10-31 09:57:18
|
On Thu, Oct 25, 2012 at 05:26:25PM -0400, Hezekiah M. Carty wrote: > On Thu, Oct 25, 2012 at 5:11 PM, Andrew Ross > > > > OK. I think I've found the reason. I'd tested with the xwin and psc > > drivers. In both these cases the background colour for the colorbar > > boxes are black. This masks the black high caps. Trying with other > > drivers (e.g. qtwidget) and everything is fine. So the problem is > > with how the background colour of the colorbar box is assigned. This > > seems to be driver dependent in a non-obvious way. > > > > Andrew > > Andrew, > > The background color in example 33 is transparent. The xwin and psc > drivers don't support transparency while the Cairo and Qt devices do. > I expect that is where the problem is coming from. > > Hez Hez, That sounds likely. I'll see if I can find a way of setting up the example so that it still works ok even with drivers which don't support transparent backgrounds. Probably choosing a colourscale which doesn't use black would solve the problem. Thanks Andrew |
From: Hezekiah M. C. <hez...@us...> - 2012-10-31 19:00:27
|
On Wed, Oct 31, 2012 at 5:57 AM, Andrew Ross <and...@us...> wrote: > On Thu, Oct 25, 2012 at 05:26:25PM -0400, Hezekiah M. Carty wrote: >> On Thu, Oct 25, 2012 at 5:11 PM, Andrew Ross >> > >> > OK. I think I've found the reason. I'd tested with the xwin and psc >> > drivers. In both these cases the background colour for the colorbar >> > boxes are black. This masks the black high caps. Trying with other >> > drivers (e.g. qtwidget) and everything is fine. So the problem is >> > with how the background colour of the colorbar box is assigned. This >> > seems to be driver dependent in a non-obvious way. >> > >> > Andrew >> >> Andrew, >> >> The background color in example 33 is transparent. The xwin and psc >> drivers don't support transparency while the Cairo and Qt devices do. >> I expect that is where the problem is coming from. >> >> Hez > > Hez, > > That sounds likely. I'll see if I can find a way of setting up the > example so that it still works ok even with drivers which don't > support transparent backgrounds. Probably choosing a colourscale which > doesn't use black would solve the problem. > > Thanks > > Andrew Andrew, A different color scale should work just fine. Another option would be to enable outlines in an appropriate color for the colorbars. Then you would at least see an outline around the caps. I used the blue_yellow color scale because its minimum and maximum scale colors are distinct from the immediately adjacent colors on the scale. That is useful for testing and showing off the end caps. Hez |