plplot-devel — Technical discussion about PLplot development

Re: [Plplot-devel] version info, runalldemos.tcl, etc.

[Alan W. I. <ir...@be...>]

On Thu, 4 Jul 2002, Vince Darley wrote:

> On Thu, 4 Jul 2002, Alan W. Irwin wrote:

> > Interestingly, for this environment I get the same first-page skip bug if a
> > multi-page demo (such as 8) is plotted first.  Do you get that for your
> > non-plserver environment?  If not, that will be another clue for Maurice when
> > he attempts to figure out this long-standing bug.
>
> If I understand what you're saying, then no, I don't see that bug.  But
> I'm not 100% sure I know what you mean.

If example 8 (or any other multipage example) is the *first* button you
press then the first page of example 8 is skipped and you start with the
second page.  The remainder of the pages are accessible with CR.  If you
press example 8 (or any other multi-page example) a *second* time the
problem goes away, i.e., the first page is displayed properly and you have
access to the rest with CR.  Just to be clear here, the exact same symptoms
occur for tkdemos.tcl under plserver but not for tcldemos.tcl under pltcl.
So the common factor seems to be plserver.

>
> > One glitch in runAllDemos.tcl is the page button does
> > not work.  Here is the stack trace delivered by plserver
>
> Does hitting 'return' work?

Yes.

Alan

Re: [Plplot-devel] version info, runalldemos.tcl, etc.

[Vince D. <vi...@sa...>]

On Thu, 4 Jul 2002, Alan W. Irwin wrote:
> ./plserver
> source ../examples/tk/runAllDemos.tcl
> 
> is almost entirely working now.

Good!

> Interestingly, for this environment I get the same first-page skip bug if a
> multi-page demo (such as 8) is plotted first.  Do you get that for your
> non-plserver environment?  If not, that will be another clue for Maurice when
> he attempts to figure out this long-standing bug.

If I understand what you're saying, then no, I don't see that bug.  But
I'm not 100% sure I know what you mean.

> One glitch in runAllDemos.tcl is the page button does
> not work.  Here is the stack trace delivered by plserver

Does hitting 'return' work?

> % source ../examples/tk/runExtendedDemos.tcl
> invalid command name "Plplotwin"

The extended demo won't work.  Sorry for the misleading cvs msg.

> The other remaining issue I forgot to mention last time was the
> bindings/tcl/pltclgen perl script that won't work for you because of
> line-ending issues.  I assume that should be straightforward since perl has
> had to deal with these sorts of issues forever.  However, that will probably
> take somebody familiar with perl (Geoffrey?) to figure this out.

Indeed!

> Yes, the compile farm probably didn't have swig at all or swig-1.1 rather
> than the required swig-1.3. Of course you could have worked around that by
> the --disable-python configure option. The missing tk and tcl headers (which
> I assume is what the problem is) on the compile farm are the real
> showstoppers. But for unknown reasons SF have a long track record of
> excluding essential developer packages from their compile-farm machines.

I eventually found the disable-python flag, but there doesn't seem to be
any workaround for tcl/tk missing...

thanks!

Vince.

Re: [Plplot-devel] version info, runalldemos.tcl, etc.

[Alan W. I. <ir...@be...>]

On Thu, 4 Jul 2002, Vince Darley wrote:

> I've committed changes which should resolve all of these issues, I think.

Thanks very much for these efforts.

The new way of dealing with PLPLOT_VERSION works fine and will make my life
much easier at release time.

./plserver
source ../examples/tk/runAllDemos.tcl

is almost entirely working now.

Interestingly, for this environment I get the same first-page skip bug if a
multi-page demo (such as 8) is plotted first.  Do you get that for your
non-plserver environment?  If not, that will be another clue for Maurice when
he attempts to figure out this long-standing bug.

One glitch in runAllDemos.tcl is the page button does
not work.  Here is the stack trace delivered by plserver

bad option "nextpage":  must be closelink, cmd, configure, draw, gcmap0, gcmap1, info, openlink, orient, page, print, redraw, save, scmap0, scmap1, scol0, scol1, view, xscroll, or yscroll
    while executing
".p.plwin nextpage"
    invoked from within
".bnextpage invoke"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 [list $w invoke]"
    (procedure "tkButtonUp" line 7)
    invoked from within
"tkButtonUp .bnextpage
"
    (command bound to event)

Also the shell button does not work

invalid command name "console"
    while executing
"console show"
    invoked from within
".cshell invoke"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 [list $w invoke]"
    (procedure "tkButtonUp" line 7)
    invoked from within
"tkButtonUp .cshell
"
    (command bound to event)

Finally, as a wish list item it would be nice to have the plot window
completely separate from the buttons (or the buttons much smaller so the
plot window is not so crowded on the screen).

I also tried runExtendedDemos.tcl since your commit message said it was
changed to work under plserver.  However, it doesn't.

./plserver
% source ../examples/tk/runExtendedDemos.tcl
invalid command name "Plplotwin"

The other remaining issue I forgot to mention last time was the
bindings/tcl/pltclgen perl script that won't work for you because of
line-ending issues.  I assume that should be straightforward since perl has
had to deal with these sorts of issues forever.  However, that will probably
take somebody familiar with perl (Geoffrey?) to figure this out.

> The bit I'm not 100% clear on is whether RunAllDemos.tcl will work with
> plserver, since I don't have a plserver to test on (I tried to compile
> plplot on sourceforge's compile farm, but couldn't get it to find tcl, tk
> and got some python compile errors (couldn't find 'swig' I think)).

Thanks for trying the compile farm, but it is probably a no-hoper except for
testing the very innermost core of plplot with just the postscript driver.

Yes, the compile farm probably didn't have swig at all or swig-1.1 rather
than the required swig-1.3. Of course you could have worked around that by
the --disable-python configure option. The missing tk and tcl headers (which
I assume is what the problem is) on the compile farm are the real
showstoppers. But for unknown reasons SF have a long track record of
excluding essential developer packages from their compile-farm machines.

<rant on>

A year ago when I complained about tk, tcl, and X (!) headers being missing,
on the compile farm boxes, the SF support people claimed it would be too
much work to download and install them.  I got a similar response when I
noticed some of their essential packages were way out of date and therefore
vulnerable to security holes.  Their responses were complete nonsense of
course since their compile farm box was a Debian machine where the packages
were just an apt-get away from being installed or updated to the latest
version.

Personally, I have never been impressed with sourceforge "support".  I
certainly like all the tools they give us to play with such as the forums,
mailing lists, file release area, cvs, webcvs, etc., but if anything goes
wrong you are largely on your own, and God help you if you ever want
anything extra (such as Tcl/Tk headers on the compile farm boxes).
Fundamentally, I believe the problem is they hired most of their staff
during the Linux bubble, and they got some really lame support people as a
result who have always had the senority and who have always set a really bad
tone of coming up with excuse after excuse for inaction.

Because their support is so bad I don't see much long-term viability for
SourceForge even if they could overcome their monetary losses.  SourceForge
do provide a lot of nice toys so I am willing to stick with them until their
demise, however.

<rant off>

In my opinion, if you had access to a low-end PC that is otherwise not used
for much you would be much better off converting it to Linux using say
RedHat 7.3 (a distribution used heavily by our astrogroup) or Debian woody
(my preferred distribution). Then you are in complete control and can
download anything you need.

But if you have no access to a box you could convert to Linux, then I am
here to help....

Alan

[Plplot-devel] version info, runalldemos.tcl, etc.

[Vince D. <vi...@sa...>]

I've committed changes which should resolve all of these issues, I think.
The bit I'm not 100% clear on is whether RunAllDemos.tcl will work with
plserver, since I don't have a plserver to test on (I tried to compile
plplot on sourceforge's compile farm, but couldn't get it to find tcl, tk
and got some python compile errors (couldn't find 'swig' I think)).

cheers,

-- Vince

<http://www.santafe.edu/~vince>

[Plplot-devel] bug fix in plot3d

[Gary B. <gb...@cs...>]

Plot3d had a bug in its handling of an end condition. The problem was 
actually in plnxtvhi_draw and only happened when the view parameters 
were just right. I discovered it by spinning plots around. You can see 
what I changed in the CVS diff. It used to say

		} else if (j >= n) {
		    su1 = u[n - 1];
		    sv1 = v[n - 1];
		    su2 = u[n];
		    sv2 = -1;

which  got garbage past the end of the u vector. Now it says


		} else if (j >= n) {
		    su1 = u[n - 1];
		    sv1 = v[n - 1];
		    su2 = u[n - 1];
		    sv2 = -1;

gb

[Plplot-devel] 3D clipping added to PLplot

[Gary B. <gb...@cs...>]

The recent changes to plot3d, plsym, plline, plfill that Alan committed 
to CVS add clipping to the 3d bounding box to all (I think) of the 3d 
functions in PLplot. The goal of these changes was to prevent any of 
the 3d objects from drawing outside of the x/y/z limits specified in 
the plw3d call. The old code did NO 3d clipping and only partially 
clipped to the 2D window specified in the call to plwind. Now I believe 
both types of clipping are complete.

I needed these changes to make my interactive zoom interface work correctly.

gb

[Plplot-devel] Re: page control bug has been introduced by recent changes

[Alan W. I. <ir...@be...>]

On Thu, 4 Jul 2002, Vince Darley wrote:

> Hmm, I really don't see that I've modified any file which could have an
> effect on this demo at all.  The 'plframe' and 'xwin' driver is completely
> untouched... However, I'll take a look.  (My code uses a new tkwin driver
> which won't be used in your build).

You are completely correct and my apologies for blaming the bug on your
changes.  Because of what you said above, I rebuilt a 21 June version of the
code (long before any of your recent changes or Gary's), and the tkdemos.tcl
page control bug was there.  So this bug has been around for a while (and
perhaps even before plplot-5.1.0 since my test scripts don't test multipage
plots as the first example to be tried under plserver).

That leaves two outstanding issues from your recent CVS changes that I am
aware of.  These are (1) finishing off the version stuff (using strncpy to
get the first 3 characters of PLPLOT_VERSION), and (2) getting
runAllDemos.tcl to work for both of our environments.

Alan

[Plplot-devel] Re: page control bug has been introduced by recent changes

[Vince D. <vi...@sa...>]

Hmm, I really don't see that I've modified any file which could have an
effect on this demo at all.  The 'plframe' and 'xwin' driver is completely
untouched... However, I'll take a look.  (My code uses a new tkwin driver
which won't be used in your build).

-- Vince

<http://www.santafe.edu/~vince>


On Wed, 3 Jul 2002, Alan W. Irwin wrote:

> Vince,
> 
> The page control when running tkdemos.tcl under plserver, e.g.,
> 
> ./plserver
> source tkdemos.tcl
> 8
> 
> no longer works quite properly.
> 
> If you start with a multipage demo such as 8, the first page is skipped, and
> then the rest of the pages of the multipage example are available with page
> control using CR. The second time you run a multipage demo (or if you run
> any other demo first) the first page is available and not skipped over.
> 
> The problem does not occur when you run tcldemos.tcl under pltcl, e.g.,
> 
> ./pltcl -dev tk
> plinit
> source tcldemos.tcl
> 8
> 
> Alan
> 
> email: ir...@be...
> phone: 250-727-2902	FAX: 250-721-7715
> snail-mail:
> Dr. Alan W. Irwin
> Department of Physics and Astronomy,
> University of Victoria, P.O. Box 3055,
> Victoria, British Columbia, Canada, V8W 3P6
> __________________________
> 
> Linux-powered astrophysics
> __________________________
> 
> 
> 

[Plplot-devel] x19.tcl

[Alan W. I. <ir...@be...>]

x19.tcl is looking good, and I have changed both tcldemos.tcl and tkdemos.tcl
to run it.

It is nice to deliver positive news for a change....;-)

Alan

email: ir...@be...
phone: 250-727-2902	FAX: 250-721-7715
snail-mail:
Dr. Alan W. Irwin
Department of Physics and Astronomy,
University of Victoria, P.O. Box 3055,
Victoria, British Columbia, Canada, V8W 3P6
__________________________

Linux-powered astrophysics
__________________________

[Plplot-devel] page control bug has been introduced by recent changes

[Alan W. I. <ir...@be...>]

Vince,

The page control when running tkdemos.tcl under plserver, e.g.,

./plserver
source tkdemos.tcl
8

no longer works quite properly.

If you start with a multipage demo such as 8, the first page is skipped, and
then the rest of the pages of the multipage example are available with page
control using CR. The second time you run a multipage demo (or if you run
any other demo first) the first page is available and not skipped over.

The problem does not occur when you run tcldemos.tcl under pltcl, e.g.,

./pltcl -dev tk
plinit
source tcldemos.tcl
8

Alan

email: ir...@be...
phone: 250-727-2902	FAX: 250-721-7715
snail-mail:
Dr. Alan W. Irwin
Department of Physics and Astronomy,
University of Victoria, P.O. Box 3055,
Victoria, British Columbia, Canada, V8W 3P6
__________________________

Linux-powered astrophysics
__________________________

[Plplot-devel] runAllDemos.tcl

[Alan W. I. <ir...@be...>]

Vince, I cannot get runAllDemos.tcl to work under plserver.

Here is the error message when I click on demo1.

./plserver
% source ../examples/tk/runAllDemos.tcl
% plbox: Please set up window first, aborting operation

Other demos either give no response at all or assorted error messages.

In contrast

./plserver
% source ../examples/tk/tkdemos.tcl
% 1
% 2
% 3

etc.

works well.

Is there some change you can make to runAllDemos.tcl so it will work under
plserver without compromising what you want to do with it on your own
system?  Clicking on buttons is a little nicer than typing in
numbers.....;-)

Alan

email: ir...@be...
phone: 250-727-2902	FAX: 250-721-7715
snail-mail:
Dr. Alan W. Irwin
Department of Physics and Astronomy,
University of Victoria, P.O. Box 3055,
Victoria, British Columbia, Canada, V8W 3P6
__________________________

Linux-powered astrophysics
__________________________

Re: [Plplot-devel] x01.tcl, pladv

[Alan W. I. <ir...@be...>]

Vince, your instincts were completely right, but I don't see how you got the
correct solution from the documentation which is somewhat ambiguous....;-)

I looked at the code and also did some experiments with the python front end
which has exactly the same cross-talk problem. Ordinarily, plssub is called
before plinit (see plstart, etc.) But sometimes it must be called afterward
as in the present situation for the first and second examples (whether tcl
or python).  In the old days, plssub called plP_eop() and then plP_bop which
generated empty pages for some drivers before I commented out those calls.
plP_subpInit (called both by plssub and plinit) sets cursub to 0.  So when
the first or second examples are executed in isolation without the initial
pladv(0) before plssub(2,2) everything is fine.  However, if these examples
are called after another example as occurs both for the python and tcl
demos, then you have to finish the last page of the previous example by a
call to pladv(0).  This required extra pladv(0) (for both the first and
second examples in python and tcl) does not generate an extra blank page if
the examples are run in isolation (or first) because of special logic already
in place in pladv.

Thus, your fix was correct so I have reinstated that as well as the same fix
for the first python example.  As you state, the extra pladv(0) is already
in the second (tcl and python) example, but I also put some commentary in
there as to why.

Thanks for drawing my attention to this problem.

Alan

email: ir...@be...
phone: 250-727-2902	FAX: 250-721-7715
snail-mail:
Dr. Alan W. Irwin
Department of Physics and Astronomy,
University of Victoria, P.O. Box 3055,
Victoria, British Columbia, Canada, V8W 3P6
__________________________

Linux-powered astrophysics
__________________________

On Wed, 3 Jul 2002, Vince Darley wrote:

> My reading of the manual is that you _do_ need a pladv before plssub
> because there is no plenv.  The plenv after plssub refers to the subpage
> set up by plssub and is therefore (I would argue, but this may be
> nonsense!) nothing to do with the 'plenv' that the man page says you need.
>
> but this could be completely wrong ;-)
>
> -- Vince
>
> <http://www.santafe.edu/~vince>
>
>
> On Wed, 3 Jul 2002, Alan W. Irwin wrote:
>
> > Thanks for drawing that problem to my attention.  I confirm it here as well
> > with the sequence of commands:
> >
> > pltcl -dev xwin
> > plinit
> > source tcldemos.tcl
> > 2
> > 1
> >
> > However, inserting an extra pladv is only a superficial fix that will cause
> > problems elsewhere (IMO) because in fact x01.tcl does call pladv already (in
> > plot1 and plot2 indirectly via plenv and directly in plot3).
> >
> > I have now narrowed the problem down to plssub.  If you comment that out
> > the overwriting problem disappears.  So perhaps there is a deeper lying
> > bug in plssub that should be addressed.
> >
> > I will look deeper into this.
> >
> > Alan
> >
> > email: ir...@be...
> > phone: 250-727-2902	FAX: 250-721-7715
> > snail-mail:
> > Dr. Alan W. Irwin
> > Department of Physics and Astronomy,
> > University of Victoria, P.O. Box 3055,
> > Victoria, British Columbia, Canada, V8W 3P6
> > __________________________
> >
> > Linux-powered astrophysics
> > __________________________
> >
> > On Wed, 3 Jul 2002, Vince Darley wrote:
> >
> > > The first tcl demo, 'x01.tcl' has a problem if it is called after drawing
> > > a previous demo --- the four plots overwrite whatever was previously drawn
> > > rather than clearing the plot page first.
> > >
> > > My reading of the manual:
> > >
> > > Advances to the next subpage if sub=0, performing a page advance if there
> > > are no remaining subpages on the current page. If subwindowing isn't being
> > > used, pladv(0) will always advance the page. If sub>0, PLplot switches to
> > > the specified subpage. Note that this allows you to overwrite a plot on
> > > the specified subpage; if this is not what you intended, use pleop
> > > followed by plbop to first advance the page. This routine is called
> > > automatically (with sub=0) by plenv, but if plenv is not used, pladv must
> > > be called after initializing PLplot but before defining the viewport.
> > >
> > > suggests that '$w cmd pladv 0' (as used in x02.tcl, in fact) is the right
> > > fix to this problem.  (Since x01.tcl doesn't use plenv, "pladv must be
> > > called...").
> > >
> > > Is this right?
> > >
> > > -- Vince
> > >
> > > <http://www.santafe.edu/~vince>
> > >
> > >
> > >
> > >
> > >
> > > -------------------------------------------------------
> > > This sf.net email is sponsored by:ThinkGeek
> > > No, I will not fix your computer.
> > > http://thinkgeek.com/sf
> > > _______________________________________________
> > > Plplot-devel mailing list
> > > Plp...@li...
> > > https://lists.sourceforge.net/lists/listinfo/plplot-devel
> > >
> >
> >
>
>
>
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> No, I will not fix your computer.
> http://thinkgeek.com/sf
> _______________________________________________
> Plplot-devel mailing list
> Plp...@li...
> https://lists.sourceforge.net/lists/listinfo/plplot-devel
>

Re: [Plplot-devel] version info

[Alan W. I. <ir...@be...>]

I am not too proficient in C so this took me a while, but I believe the
standard C function strncpy will do what you want.  Here is a short example.


#include <stdio.h>
#include "plplot/plplotP.h"
main()

{
   char short_version[]="x.x";
   strncpy(short_version, PLPLOT_VERSION, 3);
   printf("%s\n",PLPLOT_VERSION);
   printf("%s\n",short_version);
}

The result of compiling and running this code was a printout of

5.1.0
5.1

Alan

email: ir...@be...
phone: 250-727-2902	FAX: 250-721-7715
snail-mail:
Dr. Alan W. Irwin
Department of Physics and Astronomy,
University of Victoria, P.O. Box 3055,
Victoria, British Columbia, Canada, V8W 3P6
__________________________

Linux-powered astrophysics
__________________________

On Wed, 3 Jul 2002, Vince Darley wrote:

> On Wed, 3 Jul 2002, Alan W. Irwin wrote:
> > PLPLOT_VERSION is already accessible from tclAPI.c via the plplot/plplotP.h
> > include which in turn includes plConfig.h.  Can you parse out the parts
> > you need to replace 5.1 and 5.1.0 wherever they occur in tclAPI.c?  That
> > would greatly simplify my life at release time.
>
> Ideally tclAPI.c needs both "5.1.0" and "5.1".  But plConfig.h only
> provides "5.1.0" (in PLPLOT_VERSION).  I don't know how to write a macro
> to extract the first bit of that string, and I certainly don't know
> anything about auto_conf.  Perhaps best is to change tclAPI.c so that we
> use "5.1.0" everywhere.
>
> I can easily do that, but extracting "5.1" if it is possible, would be
> nicer...
>
> Vince.
>
>
>
>
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> No, I will not fix your computer.
> http://thinkgeek.com/sf
> _______________________________________________
> Plplot-devel mailing list
> Plp...@li...
> https://lists.sourceforge.net/lists/listinfo/plplot-devel
>

[Plplot-devel] version info

[Vince D. <vi...@sa...>]

On Wed, 3 Jul 2002, Alan W. Irwin wrote:
> PLPLOT_VERSION is already accessible from tclAPI.c via the plplot/plplotP.h
> include which in turn includes plConfig.h.  Can you parse out the parts
> you need to replace 5.1 and 5.1.0 wherever they occur in tclAPI.c?  That
> would greatly simplify my life at release time.

Ideally tclAPI.c needs both "5.1.0" and "5.1".  But plConfig.h only
provides "5.1.0" (in PLPLOT_VERSION).  I don't know how to write a macro
to extract the first bit of that string, and I certainly don't know
anything about auto_conf.  Perhaps best is to change tclAPI.c so that we
use "5.1.0" everywhere.

I can easily do that, but extracting "5.1" if it is possible, would be
nicer...

Vince.

Re: [Plplot-devel] Re: libDir problems with finding plplot.tcl

[Alan W. I. <ir...@be...>]

Great.  That one-line fix solved the problem, and I have committed it.

Thanks very much!

Now on to the last issue that arises from this.  tclAPI.c has all sorts of
version information scattered throughout it now.  The definitive place to
find out about version information is plplot/cf/version.in.  On the Linux
side that is turned into PLPLOT_VERSION and automatically propagated to
plConfig.h via the magic of autoconf. I haven't paid attention to what
happens to the version on the windows side, but I think the windows guys
(Olof et al) simply edit plplot/sys/win32/msdev/makefile to change
PLPLOT_VERSION before each release.

PLPLOT_VERSION is already accessible from tclAPI.c via the plplot/plplotP.h
include which in turn includes plConfig.h.  Can you parse out the parts
you need to replace 5.1 and 5.1.0 wherever they occur in tclAPI.c?  That
would greatly simplify my life at release time.

Alan

email: ir...@be...
phone: 250-727-2902	FAX: 250-721-7715
snail-mail:
Dr. Alan W. Irwin
Department of Physics and Astronomy,
University of Victoria, P.O. Box 3055,
Victoria, British Columbia, Canada, V8W 3P6
__________________________

Linux-powered astrophysics
__________________________

On Wed, 3 Jul 2002, Vince Darley wrote:

> Ok, I think I see the problem.  It isn't anything to do with the 'libDir'
> changes, but rather to calling tcl_findLibrary twice.
>
> Use this:
>
>     if (Tcl_Eval(interp, initScript) != TCL_OK) {
> #ifdef PLPLOT_EXTENDED_SEARCH
> +	Tcl_UnsetVar(interp, "pllibrary", TCL_GLOBAL_ONLY);
> 	if (Tcl_Eval(interp, initScriptExtended) != TCL_OK) {
>
>
> (i.e. add the line with '+'), and all should work, I think...  I only
> rarely have access to a linux box (except perhaps through the sourceforge
> compile farm), so it isn't that easy for me to test these things.
>
> cheers,
>
> -- Vince
>
> <http://www.santafe.edu/~vince>
>
>
> On Wed, 3 Jul 2002, Alan W. Irwin wrote:
>
> > Vince,
> >
> > Sorry for another negative message, but it is part of my job to test your
> > changes to make sure all the details are right so that we present a polished
> > product for our next release.  I am certainly willing to continue the Linux
> > testing of your changes, but you might be able to eliminate a lot of these
> > little problems (and achieve a lot better turnaround than when two of us are
> > involved) if you tested your changes on a Linux box (which I understand you
> > have access to) before committing them.
> >
> > With your latest change I am still getting exactly the same error message
> > for the installed version:
> >
> > application-specific initialization failed: Can't find a usable plplot.tcl
> > in the following directories:
> >     /usr/plplot5.1/library
> >
> > As I have said before, I believe the problem is one of your libDir changes
> > below (perhaps even initializing it to NULL?) is severely limiting the
> > directories that are being searched. For your latest change, I noticed you
> > switched to the "5.1.0/tcl" style which worked for me in the past, but the
> > point is no amount of fiddling with initScript or initScriptExtended is
> > going to work if your libDir changes makes sure those lines are completely
> > ignored.  The error message above shows only one directory is being
> > searched.  That never happened to me before your libDir changes.  So I
> > suspect if you look carefully at everything you did with libDir, you will
> > find the reason why the directory search is now so limited.
> >
> > I am going to quote my previous post on this (especially the diff) to help
> > you get to the bottom of this.
> >
> > Alan
> >
> > On Tue, 2 Jul 2002, Alan W. Irwin wrote:
> >
> > > I didn't do anything particularly sophisticated.  3 versions ago (i.e., for
> > > version 1.32), this worked
> > > fine for install (but not for built version in plplot/tmp).
> > >
> > > static char initScript[] =
> > > "tcl_findLibrary plplot 5.1.0/tcl \"\" plplot.tcl PL_LIBRARY pllibrary";
> > >
> > > i.e., I just replaced 5.1 by 5.1.0/tcl for just this line in 1.32.  So I was
> > > essentially just doing what you are now doing with initScriptExtended, and I
> > > therefore think your current approach should work fine except for some
> > > additional changes you made to libDir.  Here is the diff I am talking about
> > > between version 1.32 and version 1.35.  I may have it wrong, but I think I
> > > understand the initScriptExtended stuff so by elimination I think it is the
> > > changed libDir stuff that is causing the trouble.
> > >
> > > Alan
> > >
> > > *******************
> > > Index: tclAPI.c
> > > ===================================================================
> > > RCS file: /cvsroot/plplot/plplot/bindings/tcl/tclAPI.c,v
> > > retrieving revision 1.32
> > > retrieving revision 1.35
> > > diff -u -3 -p -r1.32 -r1.35
> > > --- tclAPI.c	2 Jul 2002 11:30:36 -0000	1.32
> > > +++ tclAPI.c	2 Jul 2002 16:44:25 -0000	1.35
> > > @@ -1,4 +1,4 @@
> > > -/* $Id: tclAPI.c,v 1.32 2002/07/02 11:30:36 vincentdarley Exp $
> > > +/* $Id: tclAPI.c,v 1.35 2002/07/02 16:44:25 vincentdarley Exp $
> > >
> > >      Copyright 1994, 1995
> > >      Maurice LeBrun			mj...@di...
> > > @@ -313,6 +313,15 @@ loopbackCmd(ClientData clientData, Tcl_I
> > >  static char defaultLibraryDir[200] = PL_LIBRARY;
> > >  extern char* plplotLibDir;
> > >
> > > +#if (!defined(MAC_TCL) && !defined(__WIN32__))
> > > +/*
> > > + * Use an extended search for installations on Unix where we
> > > + * have very likely installed plplot so that plplot.tcl is
> > > + * in  /usr/local/plplot/lib/plplot5.1.0/tcl
> > > + */
> > > +#define PLPLOT_EXTENDED_SEARCH
> > > +#endif
> > > +
> > >  /*
> > >   * PlbasicInit
> > >   *
> > > @@ -326,7 +335,11 @@ PlbasicInit( Tcl_Interp *interp )
> > >  {
> > >      static char initScript[] =
> > >      "tcl_findLibrary plplot 5.1 \"\" plplot.tcl PL_LIBRARY pllibrary";
> > > -    char *libDir;
> > > +#ifdef PLPLOT_EXTENDED_SEARCH
> > > +    static char initScriptExtended[] =
> > > +    "tcl_findLibrary plplot 5.1.0 \"\" tcl/plplot.tcl PL_LIBRARY pllibrary";
> > > +#endif
> > > +    char *libDir = NULL;
> > >  #ifdef USE_TCL_STUBS
> > >      /*
> > >       * We hard-wire 8.1 here, rather than TCL_VERSION, TK_VERSION because
> > > @@ -359,16 +372,48 @@ PlbasicInit( Tcl_Interp *interp )
> > >  #endif
> > >
> > >      Tcl_SetVar(interp, "plversion", "5.1", TCL_GLOBAL_ONLY);
> > > -    if(Tcl_Eval(interp, initScript))
> > > +    if (Tcl_Eval(interp, initScript) != TCL_OK) {
> > > +#ifdef PLPLOT_EXTENDED_SEARCH
> > > +	if (Tcl_Eval(interp, initScriptExtended) != TCL_OK) {
> > > +	    /* Last chance, look in '.' */
> > > +	    Tcl_DString ds;
> > > +	    if (Tcl_Access("plplot.tcl", 0) != 0) {
> > > +		return TCL_ERROR;
> > > +	    }
> > > +	    if (Tcl_EvalFile(interp, "plplot.tcl") != TCL_OK) {
> > > +		return TCL_ERROR;
> > > +	    }
> > > +	    /* It is in the current directory */
> > > +	    libDir = Tcl_GetCwd(interp, &ds);
> > > +	    if (libDir == NULL) {
> > > +		return TCL_ERROR;
> > > +	    }
> > > +	    libDir = strdup(libDir);
> > > +	    Tcl_DStringFree(&ds);
> > > +	}
> > > +	/*
> > > +	 * Clear the result so the user isn't confused by an error
> > > +	 * message from the previous failed search
> > > +	 */
> > > +	Tcl_ResetResult(interp);
> > > +#else
> > >  	return TCL_ERROR;
> > > +#endif
> > > +    }
> > >
> > > -    libDir = Tcl_GetVar(interp, "pllibrary", TCL_GLOBAL_ONLY);
> > >      if (libDir == NULL) {
> > > -	Tcl_SetVar(interp, "pllibrary", defaultLibraryDir, TCL_GLOBAL_ONLY);
> > > +	libDir = Tcl_GetVar(interp, "pllibrary", TCL_GLOBAL_ONLY);
> > > +	if (libDir == NULL) {
> > > +	    /* I don't believe this path can ever be reached now */
> > > +	    Tcl_SetVar(interp, "pllibrary", defaultLibraryDir, TCL_GLOBAL_ONLY);
> > > +	    libDir = defaultLibraryDir;
> > > +	}
> > >      } else {
> > > -	/* Used by init code in plctrl.c */
> > > -	plplotLibDir = strdup(libDir);
> > > +	Tcl_SetVar(interp, "pllibrary", libDir, TCL_GLOBAL_ONLY);
> > >      }
> > > +
> > > +    /* Used by init code in plctrl.c */
> > > +    plplotLibDir = strdup(libDir);
> > >
> > >  #ifdef TCL_DIR
> > >      if (libDir == NULL) {
> > > *******************
> > >
> > >
> > >
> > > -------------------------------------------------------
> > > This sf.net email is sponsored by:ThinkGeek
> > > Welcome to geek heaven.
> > > http://thinkgeek.com/sf
> > > _______________________________________________
> > > Plplot-devel mailing list
> > > Plp...@li...
> > > https://lists.sourceforge.net/lists/listinfo/plplot-devel
> > >
> >
> >
>
>
>
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> No, I will not fix your computer.
> http://thinkgeek.com/sf
> _______________________________________________
> Plplot-devel mailing list
> Plp...@li...
> https://lists.sourceforge.net/lists/listinfo/plplot-devel
>

Re: [Plplot-devel] x01.tcl, pladv

[Vince D. <vi...@sa...>]

My reading of the manual is that you _do_ need a pladv before plssub
because there is no plenv.  The plenv after plssub refers to the subpage
set up by plssub and is therefore (I would argue, but this may be
nonsense!) nothing to do with the 'plenv' that the man page says you need.

but this could be completely wrong ;-)

-- Vince

<http://www.santafe.edu/~vince>


On Wed, 3 Jul 2002, Alan W. Irwin wrote:

> Thanks for drawing that problem to my attention.  I confirm it here as well
> with the sequence of commands:
> 
> pltcl -dev xwin
> plinit
> source tcldemos.tcl
> 2
> 1
> 
> However, inserting an extra pladv is only a superficial fix that will cause
> problems elsewhere (IMO) because in fact x01.tcl does call pladv already (in
> plot1 and plot2 indirectly via plenv and directly in plot3).
> 
> I have now narrowed the problem down to plssub.  If you comment that out
> the overwriting problem disappears.  So perhaps there is a deeper lying
> bug in plssub that should be addressed.
> 
> I will look deeper into this.
> 
> Alan
> 
> email: ir...@be...
> phone: 250-727-2902	FAX: 250-721-7715
> snail-mail:
> Dr. Alan W. Irwin
> Department of Physics and Astronomy,
> University of Victoria, P.O. Box 3055,
> Victoria, British Columbia, Canada, V8W 3P6
> __________________________
> 
> Linux-powered astrophysics
> __________________________
> 
> On Wed, 3 Jul 2002, Vince Darley wrote:
> 
> > The first tcl demo, 'x01.tcl' has a problem if it is called after drawing
> > a previous demo --- the four plots overwrite whatever was previously drawn
> > rather than clearing the plot page first.
> >
> > My reading of the manual:
> >
> > Advances to the next subpage if sub=0, performing a page advance if there
> > are no remaining subpages on the current page. If subwindowing isn't being
> > used, pladv(0) will always advance the page. If sub>0, PLplot switches to
> > the specified subpage. Note that this allows you to overwrite a plot on
> > the specified subpage; if this is not what you intended, use pleop
> > followed by plbop to first advance the page. This routine is called
> > automatically (with sub=0) by plenv, but if plenv is not used, pladv must
> > be called after initializing PLplot but before defining the viewport.
> >
> > suggests that '$w cmd pladv 0' (as used in x02.tcl, in fact) is the right
> > fix to this problem.  (Since x01.tcl doesn't use plenv, "pladv must be
> > called...").
> >
> > Is this right?
> >
> > -- Vince
> >
> > <http://www.santafe.edu/~vince>
> >
> >
> >
> >
> >
> > -------------------------------------------------------
> > This sf.net email is sponsored by:ThinkGeek
> > No, I will not fix your computer.
> > http://thinkgeek.com/sf
> > _______________________________________________
> > Plplot-devel mailing list
> > Plp...@li...
> > https://lists.sourceforge.net/lists/listinfo/plplot-devel
> >
> 
> 

Re: [Plplot-devel] x01.tcl, pladv

[Alan W. I. <ir...@be...>]

Thanks for drawing that problem to my attention.  I confirm it here as well
with the sequence of commands:

pltcl -dev xwin
plinit
source tcldemos.tcl
2
1

However, inserting an extra pladv is only a superficial fix that will cause
problems elsewhere (IMO) because in fact x01.tcl does call pladv already (in
plot1 and plot2 indirectly via plenv and directly in plot3).

I have now narrowed the problem down to plssub.  If you comment that out
the overwriting problem disappears.  So perhaps there is a deeper lying
bug in plssub that should be addressed.

I will look deeper into this.

Alan

email: ir...@be...
phone: 250-727-2902	FAX: 250-721-7715
snail-mail:
Dr. Alan W. Irwin
Department of Physics and Astronomy,
University of Victoria, P.O. Box 3055,
Victoria, British Columbia, Canada, V8W 3P6
__________________________

Linux-powered astrophysics
__________________________

On Wed, 3 Jul 2002, Vince Darley wrote:

> The first tcl demo, 'x01.tcl' has a problem if it is called after drawing
> a previous demo --- the four plots overwrite whatever was previously drawn
> rather than clearing the plot page first.
>
> My reading of the manual:
>
> Advances to the next subpage if sub=0, performing a page advance if there
> are no remaining subpages on the current page. If subwindowing isn't being
> used, pladv(0) will always advance the page. If sub>0, PLplot switches to
> the specified subpage. Note that this allows you to overwrite a plot on
> the specified subpage; if this is not what you intended, use pleop
> followed by plbop to first advance the page. This routine is called
> automatically (with sub=0) by plenv, but if plenv is not used, pladv must
> be called after initializing PLplot but before defining the viewport.
>
> suggests that '$w cmd pladv 0' (as used in x02.tcl, in fact) is the right
> fix to this problem.  (Since x01.tcl doesn't use plenv, "pladv must be
> called...").
>
> Is this right?
>
> -- Vince
>
> <http://www.santafe.edu/~vince>
>
>
>
>
>
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> No, I will not fix your computer.
> http://thinkgeek.com/sf
> _______________________________________________
> Plplot-devel mailing list
> Plp...@li...
> https://lists.sourceforge.net/lists/listinfo/plplot-devel
>

[Plplot-devel] Re: libDir problems with finding plplot.tcl

[Vince D. <vi...@sa...>]

Ok, I think I see the problem.  It isn't anything to do with the 'libDir'
changes, but rather to calling tcl_findLibrary twice.

Use this:

    if (Tcl_Eval(interp, initScript) != TCL_OK) {
#ifdef PLPLOT_EXTENDED_SEARCH
+	Tcl_UnsetVar(interp, "pllibrary", TCL_GLOBAL_ONLY);
	if (Tcl_Eval(interp, initScriptExtended) != TCL_OK) {


(i.e. add the line with '+'), and all should work, I think...  I only
rarely have access to a linux box (except perhaps through the sourceforge
compile farm), so it isn't that easy for me to test these things.

cheers,

-- Vince

<http://www.santafe.edu/~vince>


On Wed, 3 Jul 2002, Alan W. Irwin wrote:

> Vince,
> 
> Sorry for another negative message, but it is part of my job to test your
> changes to make sure all the details are right so that we present a polished
> product for our next release.  I am certainly willing to continue the Linux
> testing of your changes, but you might be able to eliminate a lot of these
> little problems (and achieve a lot better turnaround than when two of us are
> involved) if you tested your changes on a Linux box (which I understand you
> have access to) before committing them.
> 
> With your latest change I am still getting exactly the same error message
> for the installed version:
> 
> application-specific initialization failed: Can't find a usable plplot.tcl
> in the following directories:
>     /usr/plplot5.1/library
> 
> As I have said before, I believe the problem is one of your libDir changes
> below (perhaps even initializing it to NULL?) is severely limiting the
> directories that are being searched. For your latest change, I noticed you
> switched to the "5.1.0/tcl" style which worked for me in the past, but the
> point is no amount of fiddling with initScript or initScriptExtended is
> going to work if your libDir changes makes sure those lines are completely
> ignored.  The error message above shows only one directory is being
> searched.  That never happened to me before your libDir changes.  So I
> suspect if you look carefully at everything you did with libDir, you will
> find the reason why the directory search is now so limited.
> 
> I am going to quote my previous post on this (especially the diff) to help
> you get to the bottom of this.
> 
> Alan
> 
> On Tue, 2 Jul 2002, Alan W. Irwin wrote:
> 
> > I didn't do anything particularly sophisticated.  3 versions ago (i.e., for
> > version 1.32), this worked
> > fine for install (but not for built version in plplot/tmp).
> >
> > static char initScript[] =
> > "tcl_findLibrary plplot 5.1.0/tcl \"\" plplot.tcl PL_LIBRARY pllibrary";
> >
> > i.e., I just replaced 5.1 by 5.1.0/tcl for just this line in 1.32.  So I was
> > essentially just doing what you are now doing with initScriptExtended, and I
> > therefore think your current approach should work fine except for some
> > additional changes you made to libDir.  Here is the diff I am talking about
> > between version 1.32 and version 1.35.  I may have it wrong, but I think I
> > understand the initScriptExtended stuff so by elimination I think it is the
> > changed libDir stuff that is causing the trouble.
> >
> > Alan
> >
> > *******************
> > Index: tclAPI.c
> > ===================================================================
> > RCS file: /cvsroot/plplot/plplot/bindings/tcl/tclAPI.c,v
> > retrieving revision 1.32
> > retrieving revision 1.35
> > diff -u -3 -p -r1.32 -r1.35
> > --- tclAPI.c	2 Jul 2002 11:30:36 -0000	1.32
> > +++ tclAPI.c	2 Jul 2002 16:44:25 -0000	1.35
> > @@ -1,4 +1,4 @@
> > -/* $Id: tclAPI.c,v 1.32 2002/07/02 11:30:36 vincentdarley Exp $
> > +/* $Id: tclAPI.c,v 1.35 2002/07/02 16:44:25 vincentdarley Exp $
> >
> >      Copyright 1994, 1995
> >      Maurice LeBrun			mj...@di...
> > @@ -313,6 +313,15 @@ loopbackCmd(ClientData clientData, Tcl_I
> >  static char defaultLibraryDir[200] = PL_LIBRARY;
> >  extern char* plplotLibDir;
> >
> > +#if (!defined(MAC_TCL) && !defined(__WIN32__))
> > +/*
> > + * Use an extended search for installations on Unix where we
> > + * have very likely installed plplot so that plplot.tcl is
> > + * in  /usr/local/plplot/lib/plplot5.1.0/tcl
> > + */
> > +#define PLPLOT_EXTENDED_SEARCH
> > +#endif
> > +
> >  /*
> >   * PlbasicInit
> >   *
> > @@ -326,7 +335,11 @@ PlbasicInit( Tcl_Interp *interp )
> >  {
> >      static char initScript[] =
> >      "tcl_findLibrary plplot 5.1 \"\" plplot.tcl PL_LIBRARY pllibrary";
> > -    char *libDir;
> > +#ifdef PLPLOT_EXTENDED_SEARCH
> > +    static char initScriptExtended[] =
> > +    "tcl_findLibrary plplot 5.1.0 \"\" tcl/plplot.tcl PL_LIBRARY pllibrary";
> > +#endif
> > +    char *libDir = NULL;
> >  #ifdef USE_TCL_STUBS
> >      /*
> >       * We hard-wire 8.1 here, rather than TCL_VERSION, TK_VERSION because
> > @@ -359,16 +372,48 @@ PlbasicInit( Tcl_Interp *interp )
> >  #endif
> >
> >      Tcl_SetVar(interp, "plversion", "5.1", TCL_GLOBAL_ONLY);
> > -    if(Tcl_Eval(interp, initScript))
> > +    if (Tcl_Eval(interp, initScript) != TCL_OK) {
> > +#ifdef PLPLOT_EXTENDED_SEARCH
> > +	if (Tcl_Eval(interp, initScriptExtended) != TCL_OK) {
> > +	    /* Last chance, look in '.' */
> > +	    Tcl_DString ds;
> > +	    if (Tcl_Access("plplot.tcl", 0) != 0) {
> > +		return TCL_ERROR;
> > +	    }
> > +	    if (Tcl_EvalFile(interp, "plplot.tcl") != TCL_OK) {
> > +		return TCL_ERROR;
> > +	    }
> > +	    /* It is in the current directory */
> > +	    libDir = Tcl_GetCwd(interp, &ds);
> > +	    if (libDir == NULL) {
> > +		return TCL_ERROR;
> > +	    }
> > +	    libDir = strdup(libDir);
> > +	    Tcl_DStringFree(&ds);
> > +	}
> > +	/*
> > +	 * Clear the result so the user isn't confused by an error
> > +	 * message from the previous failed search
> > +	 */
> > +	Tcl_ResetResult(interp);
> > +#else
> >  	return TCL_ERROR;
> > +#endif
> > +    }
> >
> > -    libDir = Tcl_GetVar(interp, "pllibrary", TCL_GLOBAL_ONLY);
> >      if (libDir == NULL) {
> > -	Tcl_SetVar(interp, "pllibrary", defaultLibraryDir, TCL_GLOBAL_ONLY);
> > +	libDir = Tcl_GetVar(interp, "pllibrary", TCL_GLOBAL_ONLY);
> > +	if (libDir == NULL) {
> > +	    /* I don't believe this path can ever be reached now */
> > +	    Tcl_SetVar(interp, "pllibrary", defaultLibraryDir, TCL_GLOBAL_ONLY);
> > +	    libDir = defaultLibraryDir;
> > +	}
> >      } else {
> > -	/* Used by init code in plctrl.c */
> > -	plplotLibDir = strdup(libDir);
> > +	Tcl_SetVar(interp, "pllibrary", libDir, TCL_GLOBAL_ONLY);
> >      }
> > +
> > +    /* Used by init code in plctrl.c */
> > +    plplotLibDir = strdup(libDir);
> >
> >  #ifdef TCL_DIR
> >      if (libDir == NULL) {
> > *******************
> >
> >
> >
> > -------------------------------------------------------
> > This sf.net email is sponsored by:ThinkGeek
> > Welcome to geek heaven.
> > http://thinkgeek.com/sf
> > _______________________________________________
> > Plplot-devel mailing list
> > Plp...@li...
> > https://lists.sourceforge.net/lists/listinfo/plplot-devel
> >
> 
> 

[Plplot-devel] libDir problems with finding plplot.tcl

[Alan W. I. <ir...@be...>]

Vince,

Sorry for another negative message, but it is part of my job to test your
changes to make sure all the details are right so that we present a polished
product for our next release.  I am certainly willing to continue the Linux
testing of your changes, but you might be able to eliminate a lot of these
little problems (and achieve a lot better turnaround than when two of us are
involved) if you tested your changes on a Linux box (which I understand you
have access to) before committing them.

With your latest change I am still getting exactly the same error message
for the installed version:

application-specific initialization failed: Can't find a usable plplot.tcl
in the following directories:
    /usr/plplot5.1/library

As I have said before, I believe the problem is one of your libDir changes
below (perhaps even initializing it to NULL?) is severely limiting the
directories that are being searched. For your latest change, I noticed you
switched to the "5.1.0/tcl" style which worked for me in the past, but the
point is no amount of fiddling with initScript or initScriptExtended is
going to work if your libDir changes makes sure those lines are completely
ignored.  The error message above shows only one directory is being
searched.  That never happened to me before your libDir changes.  So I
suspect if you look carefully at everything you did with libDir, you will
find the reason why the directory search is now so limited.

I am going to quote my previous post on this (especially the diff) to help
you get to the bottom of this.

Alan

On Tue, 2 Jul 2002, Alan W. Irwin wrote:

> I didn't do anything particularly sophisticated.  3 versions ago (i.e., for
> version 1.32), this worked
> fine for install (but not for built version in plplot/tmp).
>
> static char initScript[] =
> "tcl_findLibrary plplot 5.1.0/tcl \"\" plplot.tcl PL_LIBRARY pllibrary";
>
> i.e., I just replaced 5.1 by 5.1.0/tcl for just this line in 1.32.  So I was
> essentially just doing what you are now doing with initScriptExtended, and I
> therefore think your current approach should work fine except for some
> additional changes you made to libDir.  Here is the diff I am talking about
> between version 1.32 and version 1.35.  I may have it wrong, but I think I
> understand the initScriptExtended stuff so by elimination I think it is the
> changed libDir stuff that is causing the trouble.
>
> Alan
>
> *******************
> Index: tclAPI.c
> ===================================================================
> RCS file: /cvsroot/plplot/plplot/bindings/tcl/tclAPI.c,v
> retrieving revision 1.32
> retrieving revision 1.35
> diff -u -3 -p -r1.32 -r1.35
> --- tclAPI.c	2 Jul 2002 11:30:36 -0000	1.32
> +++ tclAPI.c	2 Jul 2002 16:44:25 -0000	1.35
> @@ -1,4 +1,4 @@
> -/* $Id: tclAPI.c,v 1.32 2002/07/02 11:30:36 vincentdarley Exp $
> +/* $Id: tclAPI.c,v 1.35 2002/07/02 16:44:25 vincentdarley Exp $
>
>      Copyright 1994, 1995
>      Maurice LeBrun			mj...@di...
> @@ -313,6 +313,15 @@ loopbackCmd(ClientData clientData, Tcl_I
>  static char defaultLibraryDir[200] = PL_LIBRARY;
>  extern char* plplotLibDir;
>
> +#if (!defined(MAC_TCL) && !defined(__WIN32__))
> +/*
> + * Use an extended search for installations on Unix where we
> + * have very likely installed plplot so that plplot.tcl is
> + * in  /usr/local/plplot/lib/plplot5.1.0/tcl
> + */
> +#define PLPLOT_EXTENDED_SEARCH
> +#endif
> +
>  /*
>   * PlbasicInit
>   *
> @@ -326,7 +335,11 @@ PlbasicInit( Tcl_Interp *interp )
>  {
>      static char initScript[] =
>      "tcl_findLibrary plplot 5.1 \"\" plplot.tcl PL_LIBRARY pllibrary";
> -    char *libDir;
> +#ifdef PLPLOT_EXTENDED_SEARCH
> +    static char initScriptExtended[] =
> +    "tcl_findLibrary plplot 5.1.0 \"\" tcl/plplot.tcl PL_LIBRARY pllibrary";
> +#endif
> +    char *libDir = NULL;
>  #ifdef USE_TCL_STUBS
>      /*
>       * We hard-wire 8.1 here, rather than TCL_VERSION, TK_VERSION because
> @@ -359,16 +372,48 @@ PlbasicInit( Tcl_Interp *interp )
>  #endif
>
>      Tcl_SetVar(interp, "plversion", "5.1", TCL_GLOBAL_ONLY);
> -    if(Tcl_Eval(interp, initScript))
> +    if (Tcl_Eval(interp, initScript) != TCL_OK) {
> +#ifdef PLPLOT_EXTENDED_SEARCH
> +	if (Tcl_Eval(interp, initScriptExtended) != TCL_OK) {
> +	    /* Last chance, look in '.' */
> +	    Tcl_DString ds;
> +	    if (Tcl_Access("plplot.tcl", 0) != 0) {
> +		return TCL_ERROR;
> +	    }
> +	    if (Tcl_EvalFile(interp, "plplot.tcl") != TCL_OK) {
> +		return TCL_ERROR;
> +	    }
> +	    /* It is in the current directory */
> +	    libDir = Tcl_GetCwd(interp, &ds);
> +	    if (libDir == NULL) {
> +		return TCL_ERROR;
> +	    }
> +	    libDir = strdup(libDir);
> +	    Tcl_DStringFree(&ds);
> +	}
> +	/*
> +	 * Clear the result so the user isn't confused by an error
> +	 * message from the previous failed search
> +	 */
> +	Tcl_ResetResult(interp);
> +#else
>  	return TCL_ERROR;
> +#endif
> +    }
>
> -    libDir = Tcl_GetVar(interp, "pllibrary", TCL_GLOBAL_ONLY);
>      if (libDir == NULL) {
> -	Tcl_SetVar(interp, "pllibrary", defaultLibraryDir, TCL_GLOBAL_ONLY);
> +	libDir = Tcl_GetVar(interp, "pllibrary", TCL_GLOBAL_ONLY);
> +	if (libDir == NULL) {
> +	    /* I don't believe this path can ever be reached now */
> +	    Tcl_SetVar(interp, "pllibrary", defaultLibraryDir, TCL_GLOBAL_ONLY);
> +	    libDir = defaultLibraryDir;
> +	}
>      } else {
> -	/* Used by init code in plctrl.c */
> -	plplotLibDir = strdup(libDir);
> +	Tcl_SetVar(interp, "pllibrary", libDir, TCL_GLOBAL_ONLY);
>      }
> +
> +    /* Used by init code in plctrl.c */
> +    plplotLibDir = strdup(libDir);
>
>  #ifdef TCL_DIR
>      if (libDir == NULL) {
> *******************
>
>
>
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Welcome to geek heaven.
> http://thinkgeek.com/sf
> _______________________________________________
> Plplot-devel mailing list
> Plp...@li...
> https://lists.sourceforge.net/lists/listinfo/plplot-devel
>

[Plplot-devel] compiler warnings due to pdf.h changes

[Alan W. I. <ir...@be...>]

Vince,

Your recent change to pdf.h has generated the following gcc compiler warning
messages.

/usr/include/tcl8.3/tcl.h:376: warning: redefinition of Tcl_Channel'
plplot/pdf.h:39: warning: Tcl_Channel' previously declared here

I haven't followed this up in detail, but I presume some source code is
including pdf.h and tcl.h, and you have a nameclash between the two
typedefs. Since only one typedef is involved perhaps the simplest way to fix
this is to use a name that doesn't clash with the generic tcl.h typedef? Or
else dropt the TclChannel typedef and go through the source code and make
sure tcl.h is always included before pdf.h?

Alan

email: ir...@be...
phone: 250-727-2902	FAX: 250-721-7715
snail-mail:
Dr. Alan W. Irwin
Department of Physics and Astronomy,
University of Victoria, P.O. Box 3055,
Victoria, British Columbia, Canada, V8W 3P6
__________________________

Linux-powered astrophysics
__________________________

[Plplot-devel] x01.tcl, pladv

[Vince D. <vi...@sa...>]

The first tcl demo, 'x01.tcl' has a problem if it is called after drawing
a previous demo --- the four plots overwrite whatever was previously drawn
rather than clearing the plot page first.

My reading of the manual:

Advances to the next subpage if sub=0, performing a page advance if there
are no remaining subpages on the current page. If subwindowing isn't being
used, pladv(0) will always advance the page. If sub>0, PLplot switches to
the specified subpage. Note that this allows you to overwrite a plot on
the specified subpage; if this is not what you intended, use pleop
followed by plbop to first advance the page. This routine is called
automatically (with sub=0) by plenv, but if plenv is not used, pladv must
be called after initializing PLplot but before defining the viewport. 

suggests that '$w cmd pladv 0' (as used in x02.tcl, in fact) is the right
fix to this problem.  (Since x01.tcl doesn't use plenv, "pladv must be
called...").

Is this right?

-- Vince

<http://www.santafe.edu/~vince>

[Plplot-devel] x01.tcl

[Alan W. I. <ir...@be...>]

Vince, I have just reverted your one-line change in x01.tcl (which from the
log message I think you did by accident).  The pladv should not be there
since later on the routine calls plenv (which calls pladv itself).  This
extra page advance will not make a difference for some devices (I think),
but for others you will generate extra blank pages which I have worked very
hard to keep out of the examples.

If your device driver requires this extra pladv, then it is not consistent
with the rest of the devices and should be fixed.

Alan

email: ir...@be...
phone: 250-727-2902	FAX: 250-721-7715
snail-mail:
Dr. Alan W. Irwin
Department of Physics and Astronomy,
University of Victoria, P.O. Box 3055,
Victoria, British Columbia, Canada, V8W 3P6
__________________________

Linux-powered astrophysics
__________________________

Re: [Plplot-devel] tk driver

[Vince D. <vi...@sa...>]

The '*.map' files now checkout ok.  I've added 'x19.tcl' to the tcl/tk
demos which is like 'x19.c' and demonstrates the 'plmap' and 'plmeridians'
functions.

Does 'pltcl' now work for you in build & install?

Thanks!

-- Vince

<http://www.santafe.edu/~vince>

Re: [Plplot-devel] tk driver

[Alan W. I. <ir...@be...>]

On Wed, 3 Jul 2002, Vince Darley wrote:

> On Tue, 2 Jul 2002, Alan W. Irwin wrote:
> > Apparently the thing to do for binary files from a Unix/Linux system (windows
> > would be different!) is
> >
> > cd plplot/lib
> > cvs admin -kb *.fnt
> >
> > followed by
> >
> > cvs update -A *.fnt
>
> It appears we need to do the same thing for the '*.map' files...
> Unfortunately, since I'm on a windows box, I can't do it here, I think.
>

Yes, according to the documentation you would have to do something different
(involving the correct binary file obtained say from a tarball rather than
cvs) from windows. So it is a lot easier from Linux.

Anyhow, done!  Give it a try.

Alan

Re: [Plplot-devel] tk driver

[Vince D. <vi...@sa...>]

On Tue, 2 Jul 2002, Alan W. Irwin wrote:
> Apparently the thing to do for binary files from a Unix/Linux system (windows
> would be different!) is
> 
> cd plplot/lib
> cvs admin -kb *.fnt
> 
> followed by
> 
> cvs update -A *.fnt

It appears we need to do the same thing for the '*.map' files...
Unfortunately, since I'm on a windows box, I can't do it here, I think.

Vince.