plplot-devel — Technical discussion about PLplot development

Re: [Plplot-devel] legend and label using wxWidgets

[Pedro V. <ped...@sp...>]

ah, yes, that's right "Visual Studio 14" only  is for 32 bits

I did not try with 64 bits libs

On 2016-12-27 15:19, Laurent Berger wrote:
> No i think Visual Studio 14 is for 32 bits. Visual Studio 14 win 64
> is for 64 bits libs. I don't use 32 bits libs. All my project are for
> 64 bits platform. Have you checked x04 with 64 bits libs?
>
>
> Le 27/12/2016 à 21:11, Pedro Vicente a écrit :
>>>> "Visual Studio 14"
>>> Does it mean that you use 32 bits libs?
>>
>> No, it means to use Visual Studio 2015 ("Visual Studio 14" is the 
>> version number of Visual Studio 2015)
>>
>>
>>
>> On 2016-12-27 15:05, Laurent Berger wrote:
>>> Does it mean that you use 32 bits libs?
>>>
>>>
>>> Le 27/12/2016 à 21:00, Pedro Vicente a écrit :
>>>> "Visual Studio 14"
>>

-- 
Pedro Vicente
ped...@sp...
http://www.space-research.org/

Re: [Plplot-devel] legend and label using wxWidgets

[Laurent B. <lau...@un...>]

No i think Visual Studio 14 is for 32 bits. Visual Studio 14 win 64 is 
for 64 bits libs. I don't use 32 bits libs. All my project are for 64 
bits platform. Have you checked x04 with 64 bits libs?


Le 27/12/2016 à 21:11, Pedro Vicente a écrit :
>>> "Visual Studio 14"
>> Does it mean that you use 32 bits libs?
>
> No, it means to use Visual Studio 2015 ("Visual Studio 14" is the 
> version number of Visual Studio 2015)
>
>
>
> On 2016-12-27 15:05, Laurent Berger wrote:
>> Does it mean that you use 32 bits libs?
>>
>>
>> Le 27/12/2016 à 21:00, Pedro Vicente a écrit :
>>> "Visual Studio 14"
>

Re: [Plplot-devel] Using wxWidgets

[Pedro V. <ped...@sp...>]

Laurent

my mistake, the .gz file has a git patch.
Use the attached files to replace the ones you have in git master

-Pedro


On 2016-12-27 15:08, Pedro Vicente wrote:
> Hi Laurent
>
> I did some changes to the current master that will allow you to keep
> using this code
>
> wxPLplotwindow<wxFrame> *frame = new wxPLplotwindow<wxFrame>();
>
> would you mind giving it a try?
>
> do
>
> git clone of Plplot (in Windows I use Tortoise git)
> extract the attached .gz
> copy the 2 files
> wxPLplotwindow.h
> wxPLplotDemo.cpp
>
> to to their locations in the master (in bindings/wxwidgets and 
> examples/c++)
>
> and rebuild your application
>
> thanks
>
> -Pedro
>
>
>
>
>
> On 2016-12-27 10:27, Laurent Berger wrote:
>> Problem is my compiler said
>>
>> 3>c:userslaurent.pc-laurent-visidocumentsvisual studio
>> 2013wxopencvwxopencvmaincourbeplplot.h(55): error C2059: syntax 
>> error
>>
>> Now syntax error I need two days to change my code. It was like this
>> in previous version of plplot. I don't remember 5.xx.xx. I don't 
>> wan't
>> to go back in my code. I will use 5.11.1
>>
>>>> yes
>>>>
>>>> but for the current (5.11.1) release compared to the new
>>>> implemented
>>>> examples,
>>>> the effect is the same
>>>>
>>>> previously the way to start the demo was
>>>>
>>>> wxPLplotwindow<wxFrame> *frame = new wxPLplotwindow<wxFrame>();
>>>>
>>>> and now is
>>>>
>>>> wxPLplotwindow *frame = new wxPLplotwindow();
>>>>
>>>> and because wxPLplotwindow is a child of a wxFrame,
>>>> the visible effect is exactly the same, a frame window that shows
>>>> a
>>>> plot.
>>>>
>>>> -Pedro
>>
>> Le 27/12/2016 à 16:11, Pedro Vicente a écrit :
>>
>>> Laurent
>>>
>>>> I have installed last version of plplot and last patch (from
>>>> pedro).
>>>> Can
>>>> you confirm me that wxPLplotwindow is now a non template class?
>>>
>>> yes, that is correct.
>>>
>>> -Pedro
>>>
>>> On 2016-12-27 10:04, Laurent Berger wrote:
>>>
>>>> Hi,
>>>>
>>>> I have installed last version of plplot and last patch (from
>>>> pedro).
>>>> Can
>>>> you confirm me that wxPLplotwindow is now a non template class?
>>>>
>>>> thanks for yours answers
>>>>
>>>>
>>>
>> 
>> ------------------------------------------------------------------------------
>>>> Check out the vibrant tech community on one of the world's most
>>>> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>>>> _______________________________________________
>>>> Plplot-devel mailing list
>>>> Plp...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/plplot-devel
>
> --
> Pedro Vicente
> ped...@sp...
> http://www.space-research.org/

-- 
Pedro Vicente
ped...@sp...
http://www.space-research.org/

Re: [Plplot-devel] legend and label using wxWidgets

[Pedro V. <ped...@sp...>]

>> "Visual Studio 14"
> Does it mean that you use 32 bits libs?

No, it means to use Visual Studio 2015 ("Visual Studio 14" is the 
version number of Visual Studio 2015)



On 2016-12-27 15:05, Laurent Berger wrote:
> Does it mean that you use 32 bits libs?
>
>
> Le 27/12/2016 à 21:00, Pedro Vicente a écrit :
>> "Visual Studio 14"

-- 
Pedro Vicente
ped...@sp...
http://www.space-research.org/

Re: [Plplot-devel] Using wxWidgets

[Pedro V. <ped...@sp...>]

Hi Laurent

I did some changes to the current master that will allow you to keep 
using this code

wxPLplotwindow<wxFrame> *frame = new wxPLplotwindow<wxFrame>();

would you mind giving it a try?

do

git clone of Plplot (in Windows I use Tortoise git)
extract the attached .gz
copy the 2 files
wxPLplotwindow.h
wxPLplotDemo.cpp

to to their locations in the master (in bindings/wxwidgets and 
examples/c++)

and rebuild your application

thanks

-Pedro





On 2016-12-27 10:27, Laurent Berger wrote:
> Problem is my compiler said
>
> 3>c:userslaurent.pc-laurent-visidocumentsvisual studio
> 2013wxopencvwxopencvmaincourbeplplot.h(55): error C2059: syntax error
>
> Now syntax error I need two days to change my code. It was like this
> in previous version of plplot. I don't remember 5.xx.xx. I don't 
> wan't
> to go back in my code. I will use 5.11.1
>
>>> yes
>>>
>>> but for the current (5.11.1) release compared to the new
>>> implemented
>>> examples,
>>> the effect is the same
>>>
>>> previously the way to start the demo was
>>>
>>> wxPLplotwindow<wxFrame> *frame = new wxPLplotwindow<wxFrame>();
>>>
>>> and now is
>>>
>>> wxPLplotwindow *frame = new wxPLplotwindow();
>>>
>>> and because wxPLplotwindow is a child of a wxFrame,
>>> the visible effect is exactly the same, a frame window that shows
>>> a
>>> plot.
>>>
>>> -Pedro
>
> Le 27/12/2016 à 16:11, Pedro Vicente a écrit :
>
>> Laurent
>>
>>> I have installed last version of plplot and last patch (from
>>> pedro).
>>> Can
>>> you confirm me that wxPLplotwindow is now a non template class?
>>
>> yes, that is correct.
>>
>> -Pedro
>>
>> On 2016-12-27 10:04, Laurent Berger wrote:
>>
>>> Hi,
>>>
>>> I have installed last version of plplot and last patch (from
>>> pedro).
>>> Can
>>> you confirm me that wxPLplotwindow is now a non template class?
>>>
>>> thanks for yours answers
>>>
>>>
>>
> 
> ------------------------------------------------------------------------------
>>> Check out the vibrant tech community on one of the world's most
>>> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>>> _______________________________________________
>>> Plplot-devel mailing list
>>> Plp...@li...
>>> https://lists.sourceforge.net/lists/listinfo/plplot-devel

-- 
Pedro Vicente
ped...@sp...
http://www.space-research.org/

Re: [Plplot-devel] legend and label using wxWidgets

[Laurent B. <lau...@un...>]

Does it mean that you use 32 bits libs?


Le 27/12/2016 à 21:00, Pedro Vicente a écrit :
> "Visual Studio 14"

Re: [Plplot-devel] legend and label using wxWidgets

[Pedro V. <ped...@sp...>]

Hi Laurent

I tried the current plplot master and I do not get your image axis 
results.
my images are attached, the png is a copy of the wxWidgets window.
I used wxWidgets 3.1 and the cmake command below

suggestion:

try
cd build
rm -rf * (or rather, the Windows command that deletes everything, on 
the build folder)

and then

cmake ".." -G "Visual Studio 14" -DPL_DOUBLE:BOOL=ON 
-DBUILD_TEST:BOOL=ON -DCMAKE_CONFIGURATION_TYPES:STRING="Debug" 
-DCMAKE_BUILD_TYPE:STRING="Debug" -DBUILD_SHARED_LIBS:BOOL=OFF 
-DSTATIC_RUNTIME:BOOL=ON -DPLD_wxwidgets:BOOL=ON 
-DwxWidgets_ROOT_DIR:PATH=%WXWIN% 
-DwxWidgets_LIB_DIR:PATH=%WXWIN%\lib\vc_lib 
-DwxWidgets_CONFIGURATION=mswud -DENABLE_MIX_CXX=ON 
-DwxWidgets_EXCLUDE_COMMON_LIBRARIES:BOOL=OFF

I often have strange results when I don't delete the cmake cache

-Pedro


On 2016-12-27 05:29, Laurent Berger wrote:
> Thanks for your answer.
>
> I give you all command I done. I work on master (I made a copy on my
> previous folder). I build plplot in static using vs2015.
>
> When I run x04 example problem is still here. Example seems slower
> now. I think that I applyed patch because legend are good now but 
> axis
> labels are still wrong
>
> $ git log
>  commit 26bc4bf13aa41dff0e19345e982eca00a0458578
>  Author: Alan W. Irwin <ai...@us...> [1]
>  Date:   Sat Dec 24 14:32:48 2016 -0800
>
>      Apply spell checker to release notes
>
>  commit dd178fd84c8e67e6c26c6248dc428d8302a0b744
>  Author: Alan W. Irwin <ai...@us...> [2]
>  Date:   Sat Dec 24 14:04:09 2016 -0800
>
>      Update the release notes for 5.12.0
>
>      N.B. The ChangeLog consisting of all the commit messages for
> the ~400
>      commits that are included in this release has been reviewed to
> help
>      insure that these release notes mention all the major PLplot
>      developments that have occurred for this release.  So
> virtually all
>      sections of these release notes should be ready for release. 
> However,
>      my work on the large documentation update is still in progress
> so that
>      section of these release notes will likely require further
> revision.
>
>  commit 995e75e6086caaf04d65c307612b6edaa49f96bc
>  Author: Phil Rosenberg <p.d...@gm...> [3]
>  Date:   Tue Dec 20 13:33:43 2016 +0000
>
>  Laurent@PC-Laurent-Vision MINGW64 /g/lib/plplot (master)
>  $ git am <
> 
> /c/Users/Laurent.PC-LAURENT-VISI/Desktop/patch/0001-wxwidgets-binding         
> -fix-for-delayed-OnCreate-event.patch
>  Applying: wxwidgets binding: fix for delayed OnCreate event
>  .git/rebase-apply/patch:355: new blank line at EOF.
>  +
>  warning: 1 line adds whitespace errors.
>
>  Laurent@PC-Laurent-Vision MINGW64 /g/lib/plplot (master)
>  $ git am <
> 
> /c/Users/Laurent.PC-LAURENT-VISI/Desktop/patch/0002-Reintroduce-OnCre         
> ate-event.patch
>  Applying: Reintroduce OnCreate() event
>
>  Laurent@PC-Laurent-Vision MINGW64 /g/lib/plplot (master)
>
>
>
> Links:
> ------
> [1] mailto:ai...@us...
> [2] mailto:ai...@us...
> [3] mailto:p.d...@gm...

-- 
Pedro Vicente
ped...@sp...
http://www.space-research.org/

Re: [Plplot-devel] legend and label using wxWidgets

[Laurent B. <lau...@un...>]

If you watch this video 
(http://perso.univ-lemans.fr/~berger/wxOpenCV/Portail/StatHistoSection/co/sequence.html#segment_yGYlRm4SzOeWIyROCQv5uc1) 
you can see that labels are at right position I think it is plplot 
version august 2015

Re: [Plplot-devel] Infinite Yielding issue

[Pedro V. <ped...@sp...>]

@Alan, Phil


>However, there is something we could try, which is,
>keep the current way of wxPLplotwindow beging a template,
>and at the same time overriding the Create() function (with template).

ok, I implemented this, attached

this

1) will not break current template use
2) will fix the bug

Limitation:
template can only be used with wxFrame (or a class that implements 
Create() with the same
signature)

test demo and example 01 run OK in CentOS, output is below



14:42:47: Debug: wxPLplotwindow::wxPLplotwindow
14:42:47: Debug: wxPLplotwindow::Create()
14:42:47: Debug: wxPLplotwindow::CreateStream()
14:42:47: Debug: plD_init_wxwidgets(): enter
14:42:47: Debug: wxPLDevice(): enter
14:42:47: Debug: wxPLDevice(): gc done
14:42:47: Debug: wxPLDevice(): m_interactiveTextGcdc done
14:42:47: Debug: wxPLDevice(): SetDC done
14:42:47: Debug: wxPLDevice(): leave
14:42:47: Debug: plD_init_wxwidgets(): leave
14:42:47: Debug: frame->Create
14:42:47: Debug: Plot()
14:42:48: Debug: wxPLplotwindow::OnCreate
14:42:48: Debug: wxPLplotwindow::CreateStream()



On 2016-12-27 12:58, Alan W. Irwin wrote:
> On 2016-12-27 10:09-0500 Pedro Vicente wrote:
>
>> @Alan
>>
>>> Isn't that loss of functionality by definition a backwards
>>> incompatibility in the API for the plplotwxwidgets library?
>>
>> yes
>>
>> but for the current (5.11.1) release compared to the new implemented 
>> examples,
>> the effect is the same
>>
>> previously the way to start the demo was
>>
>> wxPLplotwindow<wxFrame> *frame = new wxPLplotwindow<wxFrame>();
>>
>> and now is
>>
>> wxPLplotwindow *frame = new wxPLplotwindow();
>>
>> and because wxPLplotwindow is a child of a wxFrame,
>> the visible effect is exactly the same, a frame window that shows a 
>> plot.
>
> @Pedro:
>
> Thanks for that clarification.  So if users stick with the old way of
> creating frame they will get a build error (which I assume is the
> reason why Laurent is now getting build errors with his own code that
> links to the plplotwxwidgets library).  I do not say that in a
> critical way since if the choices are unreliability on some platforms
> versus changing our API in a backwards-incompatible way, then we must
> take the latter choice.
>
> @Phil:
>
> Do you agree with Pedro there is no obvious way out of this choice? 
> If
> so, then so be it, but we do have to warn users in the release notes
> of this backwards-incompatible change.
>
> Alan
> __________________________
> Alan W. Irwin
>
> Astronomical research affiliation with Department of Physics and 
> Astronomy,
> University of Victoria (astrowww.phys.uvic.ca).
>
> Programming affiliations with the FreeEOS equation-of-state
> implementation for stellar interiors (freeeos.sf.net); the Time
> Ephemerides project (timeephem.sf.net); PLplot scientific plotting
> software package (plplot.sf.net); the libLASi project
> (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
> and the Linux Brochure Project (lbproject.sf.net).
> __________________________
>
> Linux-powered Science
> __________________________

-- 
Pedro Vicente
ped...@sp...
http://www.space-research.org/

Re: [Plplot-devel] Infinite Yielding issue

[Pedro V. <ped...@sp...>]

@Alan

> So if users stick with the old way of
> creating frame they will get a build error

yes

However, there is something we could try, which is,
keep the current way of wxPLplotwindow beging a template,
and at the same time overriding the Create() function (with template).

this could mean that the template would only work for wxFrame, like
now

wxPLplotwindow<wxFrame> *frame = new wxPLplotwindow<wxFrame>();

but that would not break current applications

I'll try that later today

-Pedro


On 2016-12-27 12:58, Alan W. Irwin wrote:
> On 2016-12-27 10:09-0500 Pedro Vicente wrote:
>
>> @Alan
>>
>>> Isn't that loss of functionality by definition a backwards
>>> incompatibility in the API for the plplotwxwidgets library?
>>
>> yes
>>
>> but for the current (5.11.1) release compared to the new implemented 
>> examples,
>> the effect is the same
>>
>> previously the way to start the demo was
>>
>> wxPLplotwindow<wxFrame> *frame = new wxPLplotwindow<wxFrame>();
>>
>> and now is
>>
>> wxPLplotwindow *frame = new wxPLplotwindow();
>>
>> and because wxPLplotwindow is a child of a wxFrame,
>> the visible effect is exactly the same, a frame window that shows a 
>> plot.
>
> @Pedro:
>
> Thanks for that clarification.  So if users stick with the old way of
> creating frame they will get a build error (which I assume is the
> reason why Laurent is now getting build errors with his own code that
> links to the plplotwxwidgets library).  I do not say that in a
> critical way since if the choices are unreliability on some platforms
> versus changing our API in a backwards-incompatible way, then we must
> take the latter choice.
>
> @Phil:
>
> Do you agree with Pedro there is no obvious way out of this choice? 
> If
> so, then so be it, but we do have to warn users in the release notes
> of this backwards-incompatible change.
>
> Alan
> __________________________
> Alan W. Irwin
>
> Astronomical research affiliation with Department of Physics and 
> Astronomy,
> University of Victoria (astrowww.phys.uvic.ca).
>
> Programming affiliations with the FreeEOS equation-of-state
> implementation for stellar interiors (freeeos.sf.net); the Time
> Ephemerides project (timeephem.sf.net); PLplot scientific plotting
> software package (plplot.sf.net); the libLASi project
> (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
> and the Linux Brochure Project (lbproject.sf.net).
> __________________________
>
> Linux-powered Science
> __________________________

-- 
Pedro Vicente
ped...@sp...
http://www.space-research.org/

Re: [Plplot-devel] legend and label using wxWidgets

[Alan W. I. <ir...@be...>]

On 2016-12-27 11:29+0100 Laurent Berger wrote:

> Thanks for your answer.
>
> I give you all command I done. I work on master (I made a copy on my previous 
> folder). I build plplot in static using vs2015.
>
> When I run x04 example problem is still here. Example seems slower now. I 
> think that I applyed patch because legend are good now but axis labels are 
> still wrong
>
>
>
> $ git log
> commit 26bc4bf13aa41dff0e19345e982eca00a0458578
> Author: Alan W. Irwin <ai...@us...>
> Date:   Sat Dec 24 14:32:48 2016 -0800
>
>    Apply spell checker to release notes
>
> commit dd178fd84c8e67e6c26c6248dc428d8302a0b744
> Author: Alan W. Irwin <ai...@us...>
> Date:   Sat Dec 24 14:04:09 2016 -0800
>
>    Update the release notes for 5.12.0
>
>    N.B. The ChangeLog consisting of all the commit messages for the ~400
>    commits that are included in this release has been reviewed to help
>    insure that these release notes mention all the major PLplot
>    developments that have occurred for this release.  So virtually all
>    sections of these release notes should be ready for release. However,
>    my work on the large documentation update is still in progress so that
>    section of these release notes will likely require further revision.
>
> commit 995e75e6086caaf04d65c307612b6edaa49f96bc
> Author: Phil Rosenberg <p.d...@gm...>
> Date:   Tue Dec 20 13:33:43 2016 +0000
>
>
> Laurent@PC-Laurent-Vision MINGW64 /g/lib/plplot (master)
> $ git am < 
> /c/Users/Laurent.PC-LAURENT-VISI/Desktop/patch/0001-wxwidgets-binding 
> -fix-for-delayed-OnCreate-event.patch
> Applying: wxwidgets binding: fix for delayed OnCreate event
> .git/rebase-apply/patch:355: new blank line at EOF.
> +
> warning: 1 line adds whitespace errors.
>
> Laurent@PC-Laurent-Vision MINGW64 /g/lib/plplot (master)
> $ git am < 
> /c/Users/Laurent.PC-LAURENT-VISI/Desktop/patch/0002-Reintroduce-OnCre 
> ate-event.patch
> Applying: Reintroduce OnCreate() event
>
> Laurent@PC-Laurent-Vision MINGW64 /g/lib/plplot (master)
>

Hi Laurent:

It looks to me that your application of Pedro's commits on top of the
lastest master version is correct.  And the screenshot you attached
does indeed show some severe text issues for your vs2015 case which I cannot
recreate here at all on Linux.  Is it possible you have a stale build?
That is, do you get the same problem starting with the cmake command
in an initially empty build tree?

If it turns out a completely fresh configure and build still shows
the issue, then someone with access to Windows here will have to
take over and attempt to replicate what is potentially a
release-critical issue.

Alan
__________________________
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__________________________

Linux-powered Science
__________________________

Re: [Plplot-devel] Infinite Yielding issue

[Alan W. I. <ir...@be...>]

On 2016-12-27 10:09-0500 Pedro Vicente wrote:

> @Alan
>
>> Isn't that loss of functionality by definition a backwards
>> incompatibility in the API for the plplotwxwidgets library?
>
> yes
>
> but for the current (5.11.1) release compared to the new implemented 
> examples,
> the effect is the same
>
> previously the way to start the demo was
>
> wxPLplotwindow<wxFrame> *frame = new wxPLplotwindow<wxFrame>();
>
> and now is
>
> wxPLplotwindow *frame = new wxPLplotwindow();
>
> and because wxPLplotwindow is a child of a wxFrame,
> the visible effect is exactly the same, a frame window that shows a plot.

@Pedro:

Thanks for that clarification.  So if users stick with the old way of
creating frame they will get a build error (which I assume is the
reason why Laurent is now getting build errors with his own code that
links to the plplotwxwidgets library).  I do not say that in a
critical way since if the choices are unreliability on some platforms
versus changing our API in a backwards-incompatible way, then we must
take the latter choice.

@Phil:

Do you agree with Pedro there is no obvious way out of this choice? If
so, then so be it, but we do have to warn users in the release notes
of this backwards-incompatible change.

Alan
__________________________
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__________________________

Linux-powered Science
__________________________

Re: [Plplot-devel] Using wxWidgets

[Laurent B. <lau...@un...>]

Problem is my compiler said

3>c:\users\laurent.pc-laurent-visi\documents\visual studio 
2013\wxopencv\wxopencvmain\courbeplplot.h(55): error C2059: syntax error

Now syntax error I need two days to change my code. It was like this in 
previous version of plplot. I don't remember 5.xx.xx. I don't wan't to 
go back in my code. I will use 5.11.1

        yes

        but for the current (5.11.1) release compared to the new implemented
        examples,
        the effect is the same

        previously the way to start the demo was

        wxPLplotwindow<wxFrame> *frame = new wxPLplotwindow<wxFrame>();

        and now is

        wxPLplotwindow *frame = new wxPLplotwindow();

        and because wxPLplotwindow is a child of a wxFrame,
        the visible effect is exactly the same, a frame window that shows a
        plot.

        -Pedro


Le 27/12/2016 à 16:11, Pedro Vicente a écrit :
> Laurent
>
>> I have installed last version of plplot and last patch (from pedro).
>> Can
>> you confirm me that wxPLplotwindow is now a non template  class?
> yes, that is correct.
>
> -Pedro
>
>
> On 2016-12-27 10:04, Laurent Berger wrote:
>> Hi,
>>
>> I have installed last version of plplot and last patch (from pedro).
>> Can
>> you confirm me that wxPLplotwindow is now a non template  class?
>>
>> thanks for yours answers
>>
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>> _______________________________________________
>> Plplot-devel mailing list
>> Plp...@li...
>> https://lists.sourceforge.net/lists/listinfo/plplot-devel

Re: [Plplot-devel] Uusing wxWidgets

[Pedro V. <ped...@sp...>]

Laurent

> I have installed last version of plplot and last patch (from pedro). 
> Can
> you confirm me that wxPLplotwindow is now a non template  class?

yes, that is correct.

-Pedro


On 2016-12-27 10:04, Laurent Berger wrote:
> Hi,
>
> I have installed last version of plplot and last patch (from pedro). 
> Can
> you confirm me that wxPLplotwindow is now a non template  class?
>
> thanks for yours answers
>
>
>
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> Plplot-devel mailing list
> Plp...@li...
> https://lists.sourceforge.net/lists/listinfo/plplot-devel

-- 
Pedro Vicente
ped...@sp...
http://www.space-research.org/

Re: [Plplot-devel] Infinite Yielding issue

[Pedro V. <ped...@sp...>]

@Alan

> Isn't that loss of functionality by definition a backwards
> incompatibility in the API for the plplotwxwidgets library?

yes

but for the current (5.11.1) release compared to the new implemented 
examples,
the effect is the same

previously the way to start the demo was

wxPLplotwindow<wxFrame> *frame = new wxPLplotwindow<wxFrame>();

and now is

wxPLplotwindow *frame = new wxPLplotwindow();

and because wxPLplotwindow is a child of a wxFrame,
the visible effect is exactly the same, a frame window that shows a 
plot.

-Pedro



On 2016-12-27 02:12, Alan W. Irwin wrote:
> On 2016-12-26 21:30-0500 Pedro Vicente wrote:
>
>> @Alan, Phil
>>
>>> Now that we have such a widely tested solution, would you be 
>>> willing
>>> to write a short summary paragraph concerning the changes in the
>>> plplotwxwidgets library API?
>>
>> here it goes. The API really has no visible changes, but has a loss 
>> of functionality
>> (use of templates, i.e, ability to do plots other than in wxFrame 
>> windows)
>
> @Phil and Pedro:
>
> Isn't that loss of functionality by definition a backwards
> incompatibility in the API for the plplotwxwidgets library?  If Phil
> and you confirm that interpretation, I will need to warn about
> that in the release notes.
>
> Important questions below for Phil.
>
>>
>> "Fixed a bug that happened in test_wxPLplotDemo for  some Linux 
>> configurations.
>> The effect of the bug was a segmentation fault, due to the fact that 
>> an invalid
>> plot stream pointer was used. The cause of the stream pointer being 
>> invalid
>> is that the frame window did not initialize in a timely manner. This 
>> behaviour is a
>> wxWidgets feature that can or cannot happen in GTK/X11 window 
>> systems.
>> The solution for test_wxPLplotDemo was to initialize the stream in 
>> the function
>> Create(), which is done immediatley, instead of doing it on the 
>> function OnCreate(),
>> that is called later and executed at an indeterminated time. Note: 
>> the possiblility and request of creating
>> the stream in OnCreate() is still present, because this is a feature 
>> of the driver needed elsewhere.
>> A side effect of creating the new function Create() for the class 
>> wxPLplotwindow,
>> is that the class cannot be a template. At this time the class is 
>> descendant from
>> wxFrame, so only wxFrame windows can be created."
>>
>>
>>> To help you figure out what to say, here is how to discover the
>>> changes since plplot-5.11.1 in the library API and our demo that 
>>> links
>>> with that library:
>>> git diff --ignore-all-space plplot-5.11.1 bindings/wxwidgets/*.h
>>
>>
>> I did not got back in time this way, because all the other changes 
>> were made by Phil.
>>
>> Basically what I did was start with the current master of 
>> wxPLplotwindow and
>>
>> 1) override a function Create()
>> 2) do an auxilirary function CreateStream() that contains the code 
>> that was previously in
>> OnCreate(). This function is both called by Create() and OnCreate(). 
>> A boolean
>> flag assures that is only executed 1 time.
>> 3) Moved the event trigering that was previously on the 
>> wxPLplotwindow constructor
>> by ::Connect() calls
>> to a static event table
>>
>> This change 3) was not really needed, it was just to reflect the 
>> current way of handling events
>>
>> http://docs.wxwidgets.org/3.1/overview_events.html
>>
>> either by the static event table or by ::Bind()
>>
>>
>> feel free to change anything in the description.
>
> @ Pedro:
>
> Thanks for the above description of what you did.
>
> @Phil:
>
> I need your answers to the following questions.
>
> 1. Can you spot any release-critical issues with Pedro's present
>    two-commit fix (i.e., any trouble you can forsee for our Unix
>    and/or Windows users if we release with this)?
>
> 2. Are there any essential short-term changes you want to make to his
>    approach for this release?  (Essential here means release-critical
>    as used in question 1.)
>
> 3. Are there any long-term (post-release) changes you want to make to
>    his approach?
>
> Your answers to these questions are release critical so I would
> appreciate your timely response to them.
>
> Alan
> __________________________
> Alan W. Irwin
>
> Astronomical research affiliation with Department of Physics and 
> Astronomy,
> University of Victoria (astrowww.phys.uvic.ca).
>
> Programming affiliations with the FreeEOS equation-of-state
> implementation for stellar interiors (freeeos.sf.net); the Time
> Ephemerides project (timeephem.sf.net); PLplot scientific plotting
> software package (plplot.sf.net); the libLASi project
> (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
> and the Linux Brochure Project (lbproject.sf.net).
> __________________________
>
> Linux-powered Science
> __________________________

-- 
Pedro Vicente
ped...@sp...
http://www.space-research.org/

[Plplot-devel] Uusing wxWidgets

[Laurent B. <lau...@un...>]

Hi,

I have installed last version of plplot and last patch (from pedro). Can 
you confirm me that wxPLplotwindow is now a non template  class?

thanks for yours answers

Re: [Plplot-devel] legend and label using wxWidgets

[Laurent B. <lau...@un...>]

Thanks for your answer.

I give you all command I done. I work on master (I made a copy on my 
previous folder). I build plplot in static using vs2015.

When I run x04 example problem is still here. Example seems slower now. 
I think that I applyed patch because legend are good now but axis labels 
are still wrong



$ git log
commit 26bc4bf13aa41dff0e19345e982eca00a0458578
Author: Alan W. Irwin <ai...@us...>
Date:   Sat Dec 24 14:32:48 2016 -0800

     Apply spell checker to release notes

commit dd178fd84c8e67e6c26c6248dc428d8302a0b744
Author: Alan W. Irwin <ai...@us...>
Date:   Sat Dec 24 14:04:09 2016 -0800

     Update the release notes for 5.12.0

     N.B. The ChangeLog consisting of all the commit messages for the ~400
     commits that are included in this release has been reviewed to help
     insure that these release notes mention all the major PLplot
     developments that have occurred for this release.  So virtually all
     sections of these release notes should be ready for release. However,
     my work on the large documentation update is still in progress so that
     section of these release notes will likely require further revision.

commit 995e75e6086caaf04d65c307612b6edaa49f96bc
Author: Phil Rosenberg <p.d...@gm...>
Date:   Tue Dec 20 13:33:43 2016 +0000


Laurent@PC-Laurent-Vision MINGW64 /g/lib/plplot (master)
$ git am < 
/c/Users/Laurent.PC-LAURENT-VISI/Desktop/patch/0001-wxwidgets-binding 
-fix-for-delayed-OnCreate-event.patch
Applying: wxwidgets binding: fix for delayed OnCreate event
.git/rebase-apply/patch:355: new blank line at EOF.
+
warning: 1 line adds whitespace errors.

Laurent@PC-Laurent-Vision MINGW64 /g/lib/plplot (master)
$ git am < 
/c/Users/Laurent.PC-LAURENT-VISI/Desktop/patch/0002-Reintroduce-OnCre 
ate-event.patch
Applying: Reintroduce OnCreate() event

Laurent@PC-Laurent-Vision MINGW64 /g/lib/plplot (master)

Re: [Plplot-devel] Infinite Yielding issue

[Alan W. I. <ir...@be...>]

On 2016-12-26 21:30-0500 Pedro Vicente wrote:

> @Alan, Phil
>
>> Now that we have such a widely tested solution, would you be willing
>> to write a short summary paragraph concerning the changes in the
>> plplotwxwidgets library API?
>
> here it goes. The API really has no visible changes, but has a loss of 
> functionality
> (use of templates, i.e, ability to do plots other than in wxFrame windows)

@Phil and Pedro:

Isn't that loss of functionality by definition a backwards
incompatibility in the API for the plplotwxwidgets library?  If Phil
and you confirm that interpretation, I will need to warn about
that in the release notes.

Important questions below for Phil.

>
> "Fixed a bug that happened in test_wxPLplotDemo for  some Linux 
> configurations.
> The effect of the bug was a segmentation fault, due to the fact that an 
> invalid
> plot stream pointer was used. The cause of the stream pointer being invalid
> is that the frame window did not initialize in a timely manner. This 
> behaviour is a
> wxWidgets feature that can or cannot happen in GTK/X11 window systems.
> The solution for test_wxPLplotDemo was to initialize the stream in the 
> function
> Create(), which is done immediatley, instead of doing it on the function 
> OnCreate(),
> that is called later and executed at an indeterminated time. Note: the 
> possiblility and request of creating
> the stream in OnCreate() is still present, because this is a feature of the 
> driver needed elsewhere.
> A side effect of creating the new function Create() for the class 
> wxPLplotwindow,
> is that the class cannot be a template. At this time the class is descendant 
> from
> wxFrame, so only wxFrame windows can be created."
>
>
>> To help you figure out what to say, here is how to discover the
>> changes since plplot-5.11.1 in the library API and our demo that links
>> with that library:
>> 
>> git diff --ignore-all-space plplot-5.11.1 bindings/wxwidgets/*.h
>
>
> I did not got back in time this way, because all the other changes were made 
> by Phil.
>
> Basically what I did was start with the current master of wxPLplotwindow and
>
> 1) override a function Create()
> 2) do an auxilirary function CreateStream() that contains the code that was 
> previously in
> OnCreate(). This function is both called by Create() and OnCreate(). A 
> boolean
> flag assures that is only executed 1 time.
> 3) Moved the event trigering that was previously on the wxPLplotwindow 
> constructor
> by ::Connect() calls
> to a static event table
>
> This change 3) was not really needed, it was just to reflect the current way 
> of handling events
>
> http://docs.wxwidgets.org/3.1/overview_events.html
>
> either by the static event table or by ::Bind()
>
>
> feel free to change anything in the description.

@ Pedro:

Thanks for the above description of what you did.

@Phil:

I need your answers to the following questions.

1. Can you spot any release-critical issues with Pedro's present
    two-commit fix (i.e., any trouble you can forsee for our Unix
    and/or Windows users if we release with this)?

2. Are there any essential short-term changes you want to make to his
    approach for this release?  (Essential here means release-critical
    as used in question 1.)

3. Are there any long-term (post-release) changes you want to make to
    his approach?

Your answers to these questions are release critical so I would
appreciate your timely response to them.

Alan
__________________________
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__________________________

Linux-powered Science
__________________________

Re: [Plplot-devel] Infinite Yielding issue

[Pedro V. <ped...@sp...>]

@Alan, Phil

> Now that we have such a widely tested solution, would you be willing
> to write a short summary paragraph concerning the changes in the
> plplotwxwidgets library API?

here it goes. The API really has no visible changes, but has a loss of 
functionality
(use of templates, i.e, ability to do plots other than in wxFrame windows)

"Fixed a bug that happened in test_wxPLplotDemo for  some Linux 
configurations.
 The effect of the bug was a segmentation fault, due to the fact that an 
invalid
plot stream pointer was used. The cause of the stream pointer being invalid
is that the frame window did not initialize in a timely manner. This 
behaviour is a
wxWidgets feature that can or cannot happen in GTK/X11 window systems.
The solution for test_wxPLplotDemo was to initialize the stream in the 
function
Create(), which is done immediatley, instead of doing it on the function 
OnCreate(),
that is called later and executed at an indeterminated time. Note: the 
possiblility and request of creating
the stream in OnCreate() is still present, because this is a feature of the 
driver needed elsewhere.
A side effect of creating the new function Create() for the class 
wxPLplotwindow,
is that the class cannot be a template. At this time the class is descendant 
from
wxFrame, so only wxFrame windows can be created."


> To help you figure out what to say, here is how to discover the
> changes since plplot-5.11.1 in the library API and our demo that links
> with that library:
>
> git diff --ignore-all-space plplot-5.11.1 bindings/wxwidgets/*.h


I did not got back in time this way, because all the other changes were made 
by Phil.

Basically what I did was start with the current master of wxPLplotwindow and

1) override a function Create()
2) do an auxilirary function CreateStream() that contains the code that was 
previously in
OnCreate(). This function is both called by Create() and OnCreate(). A 
boolean
flag assures that is only executed 1 time.
3) Moved the event trigering that was previously on the wxPLplotwindow 
constructor
by ::Connect() calls
to a static event table

This change 3) was not really needed, it was just to reflect the current way 
of handling events

http://docs.wxwidgets.org/3.1/overview_events.html

either by the static event table or by ::Bind()


feel free to change anything in the description.
I did not mention the new debug print option of wxWidgets in cmake,
because you implemented that feature, but that should be mentioned also.


-Pedro






----- Original Message ----- 
From: "Alan W. Irwin" <ir...@be...>
To: "Pedro Vicente" <ped...@sp...>
Cc: "Phil Rosenberg" <p.d...@gm...>; "PLplot development list" 
<Plp...@li...>
Sent: Monday, December 26, 2016 5:09 PM
Subject: Re: [Plplot-devel] Infinite Yielding issue


> On 2016-12-24 20:24-0500 Pedro Vicente wrote:
>
>> Hi Alan
>>
>>> Then collect those two files in a tarball using
>>> tar zcf wxwidgets_experimental_commits2.tar.gz 00*
>>
>> I did the git am as explained, and
>> wxwidgets_experimental_commits2.tar.gz
>> is attached
>>
>> examples/c/x01c -dev wxwidgets
>> and
>> test_wxPLplotDemo
>>
>> run with no problems on all my tests
>>
>
> Hi Pedro:
>
> Thanks very much for that compiler warning fix and big testing effort
> on a Windows platform and 4 Linux platforms for this latest iteration
> of your two-commit fix.
>
> I tested this latest version here in the same way I did the previous
> iteration, and all was well.
>
> Now that we have such a widely tested solution, would you be willing
> to write a short summary paragraph concerning the changes in the
> plplotwxwidgets library API?  I cannot write such a summary myself
> because I don't know the correct C++ terminology to use.
>
> That summary would likely help Phil make up his mind about whether we
> will adopt your latest iteration of the fix or try something else.
> However, please write that paragraph with a somewhat larger audience in 
> mind
> than just Phil.  Because if he decides to go with your fix, then I
> will want to include your summary paragraph in our release notes to
> aid those (like you and Greg Jung) who are developing their own
> applications and libraries that link with the plplotwxwidgets library
> and who will therefore have to change those applications and libraries
> to be compatible with our changes.  So the summary should answer the
> question what is the minimum that an outside developer need to know about 
> the
> the changes to the plplotwxwidgets library API?
>
> To help you figure out what to say, here is how to discover the
> changes since plplot-5.11.1 in the library API and our demo that links
> with that library:
>
> git diff --ignore-all-space plplot-5.11.1 bindings/wxwidgets/*.h
>
> git diff --ignore-all-space plplot-5.11.1 examples/c++/wxPLplotDemo.cpp
>
> Obviously, the extra include to allow for the possibility of debugging
> output in bindings/wxwidgets/wxPLplotstream.h is not an API change,
> but it looks like there have been substantial backwards-incompatible
> changes in the plplotwxwidgets library API as indicated by
> the changes in bindings/wxwidgets/wxPLplotwindow.h.
>
> Those API changes appear also to be confirmed by that second git diff
> result above (although some of those changes were an addition of a
> locate mode and nothing to do with API changes so your summary doesn't
> need to mention that locate mode addition).
>
> Alan
> __________________________
> Alan W. Irwin
>
> Astronomical research affiliation with Department of Physics and 
> Astronomy,
> University of Victoria (astrowww.phys.uvic.ca).
>
> Programming affiliations with the FreeEOS equation-of-state
> implementation for stellar interiors (freeeos.sf.net); the Time
> Ephemerides project (timeephem.sf.net); PLplot scientific plotting
> software package (plplot.sf.net); the libLASi project
> (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
> and the Linux Brochure Project (lbproject.sf.net).
> __________________________
>
> Linux-powered Science
> __________________________
> 

Re: [Plplot-devel] legend and label using wxWidgets

[Alan W. I. <ir...@be...>]

On 2016-12-26 15:18+0100 Laurent Berger wrote:

> Hi,
>
> I think that something is weird in wxWidgets driver. When i want to draw a 
> legend or label yaxis text legend is wrong and label for x-axis on right too.
>
> I have attached png and svg file generated using x04c example (updated from 
> git 10 december 2016)

Hi Laurent:

Thanks for your report, and indeed that x04.png screenshot of your -dev
wxwidgets result has obvious text orientation issues.

However, that result is for our 2016-12-10 version, and Phil had
a commit called

Fixed problem with rotated wxWidgets text

on 2016-12-13 which likely addresses the gross text orientation issues
you were seeing.  Furthermore, since that fix, there have been many more
wxwidgets-related fixes to deal with a release-critical bug (things
happening in the wrong order) that showed up on some Linux boxes.

We are still in the process of evaluating the latest version of our
fix, but it works fine for Pedro on a Windows platform and 4 Linux
platforms. It also works fine for me here on Debian Jessie, and a
final decision concerning this fix will be made when Phil gets back in
touch (probably tomorrow) after his Christmas break.

For the most recent version of this fix, I have looked carefully at
the results for example 4, and they are the same as
<http://plplot.sourceforge.net/examples.php?demo=04> except for a tiny
(1/20th to 1/10th of a character height) vertical character
misalignment issue which has been with us for quite a while with our
wxwidgets-related components.

Would you be willing to help us out with testing this most recent
version of this fix?

Here is how you do that.

(1) Look at Pedro's most recent post to PLplot-devel and copy that
tarball (called wxwidgets_experimental_commits2.tar.gz) to a local
directory.

(2) Unpack that tarball ==>
0001-wxwidgets-binding-fix-for-delayed-OnCreate-event.patch
0002-Reintroduce-OnCreate-event.patch

(3) Create a local topic branch from _the latest_ updated version
of our git master branch following the directions in
README.developers.

(4) Go to the top-level directory of that source tree and apply the
two commits above, using, e.g.,

git am < $DIR/0001-wxwidgets-binding-fix-for-delayed-OnCreate-event.patch
git am < $DIR/0002-Reintroduce-OnCreate-event.patch

where $DIR is the directory location where you have unpacked those two
patches.

The above is exactly just what I did here.  I followed up by configuring
the PLplot build with cmake using an initially empty build tree;
building the x04c, wxwidgets,
and wxPLViewer targets; and then running

examplex/c/x04c -dev wxwidgets

To generate the good results I reported above.

Please repeat this cookbook (especially starting with a fresh build
using an initially empty build tree) and report the results here
_whether they are good or bad_.  (Good strengthens the argument our
present fix is probably OK, bad means there is likely more work to do
with that fix.) Also please include in your good or bad report a
complete identification of your wxwidgets platform, i.e., your
operating system, wxwidgets version number, and gtk+ version number
(not relevant on bare Windows, but relevant on most other platforms
because typically wxwidgets is built on top of gtk+ for those other
platforms).  And if your report is bad, then a screenshot like you
just sent for the December 10th version is useful as well.

Thanks in advance for your help testing the latest version of our
wxwidgets fix in the above way.  And, of course, please ask additional
questions here if some part of the above directions is not clear
to you.

Alan
__________________________
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__________________________

Linux-powered Science
__________________________

Re: [Plplot-devel] Infinite Yielding issue

[Alan W. I. <ir...@be...>]

On 2016-12-24 20:24-0500 Pedro Vicente wrote:

> Hi Alan
>
>> Then collect those two files in a tarball using
>> tar zcf wxwidgets_experimental_commits2.tar.gz 00*
>
> I did the git am as explained, and
> wxwidgets_experimental_commits2.tar.gz
> is attached
>
> examples/c/x01c -dev wxwidgets
> and
> test_wxPLplotDemo
>
> run with no problems on all my tests
>

Hi Pedro:

Thanks very much for that compiler warning fix and big testing effort
on a Windows platform and 4 Linux platforms for this latest iteration
of your two-commit fix.

I tested this latest version here in the same way I did the previous
iteration, and all was well.

Now that we have such a widely tested solution, would you be willing
to write a short summary paragraph concerning the changes in the
plplotwxwidgets library API?  I cannot write such a summary myself
because I don't know the correct C++ terminology to use.

That summary would likely help Phil make up his mind about whether we
will adopt your latest iteration of the fix or try something else.
However, please write that paragraph with a somewhat larger audience in mind
than just Phil.  Because if he decides to go with your fix, then I
will want to include your summary paragraph in our release notes to
aid those (like you and Greg Jung) who are developing their own
applications and libraries that link with the plplotwxwidgets library
and who will therefore have to change those applications and libraries
to be compatible with our changes.  So the summary should answer the
question what is the minimum that an outside developer need to know about the
the changes to the plplotwxwidgets library API?

To help you figure out what to say, here is how to discover the
changes since plplot-5.11.1 in the library API and our demo that links
with that library:

git diff --ignore-all-space plplot-5.11.1 bindings/wxwidgets/*.h

git diff --ignore-all-space plplot-5.11.1 examples/c++/wxPLplotDemo.cpp

Obviously, the extra include to allow for the possibility of debugging
output in bindings/wxwidgets/wxPLplotstream.h is not an API change,
but it looks like there have been substantial backwards-incompatible
changes in the plplotwxwidgets library API as indicated by
the changes in bindings/wxwidgets/wxPLplotwindow.h.

Those API changes appear also to be confirmed by that second git diff
result above (although some of those changes were an addition of a
locate mode and nothing to do with API changes so your summary doesn't
need to mention that locate mode addition).

Alan
__________________________
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__________________________

Linux-powered Science
__________________________

[Plplot-devel] legend and label using wxWidgets

[Laurent B. <lau...@un...>]

Hi,

I think that something is weird in wxWidgets driver. When i want to draw 
a legend or label yaxis text legend is wrong and label for x-axis on 
right too.

I have attached png and svg file generated using x04c example (updated 
from git 10 december 2016)

Thanks for your help

Re: [Plplot-devel] Infinite Yielding issue

[Pedro V. <ped...@sp...>]

Hi Alan

> Then collect those two files in a tarball using
>tar zcf wxwidgets_experimental_commits2.tar.gz 00*

I did the git am as explained, and
wxwidgets_experimental_commits2.tar.gz
is attached

examples/c/x01c -dev wxwidgets
and
test_wxPLplotDemo

run with no problems on all my tests

> Half an hour ago it was the start of Christmas Eve day for me, and
> that happened several hours ago for you and quite a while ago for
> Phil.  So Merry Christmas and Happy New Year! to both of you and everybody 
> else on this
> list.

Merry Christmas and Happy New Year as well to everyone

-Pedro


----- Original Message ----- 
From: "Alan W. Irwin" <ir...@be...>
To: "Pedro Vicente" <ped...@sp...>
Cc: "Phil Rosenberg" <p.d...@gm...>; "PLplot development list" 
<Plp...@li...>
Sent: Saturday, December 24, 2016 3:42 AM
Subject: Re: [Plplot-devel] Infinite Yielding issue


> On 2016-12-24 01:13-0500 Pedro Vicente wrote:
>
>> Hi Alan
>>
>> some more upbeat news about the example error , it's gone :-)
>
> It's gone here too.  :-)
>
> So thanks very much Pedro for this early Christmas present!
>
> [...]
>> I also removed this "PLDLLIMPEXP_WX"
>>
>> class PLDLLIMPEXP_WX wxPLplotwindow : public wxFrame
>
> That change causes a build issue on Linux if you are using
>
> export CXXFLAGS="-O3 -fvisibility=hidden -Wuninitialized"
> export CFLAGS="-O3 -fvisibility=hidden -Wuninitialized"
> export FFLAGS="-O3 -Wuninitialized -Wunused"
>
> which I highly recommend on Linux to check for symbol visibility
> issues on that platform (and to partially check for visibility
> issues on Windows as well, but in this case it sounds like it
> was not needed, but it should do no harm on that platform.)
>
> So I had to amend your present (second) commit to put it back.
>
>> I searched  in all the source code and could not find this symbol ?
>
> The unix find command is good for such tasks:
>
> software@raven> find . -type f |grep -v .git |xargs grep PLDLLIMPEXP_WX
> ./bindings/wxwidgets/wxPLplot_nanosec.h.in:PLDLLIMPEXP_WX void
> ./bindings/wxwidgets/wxPLplotwindow.h:class PLDLLIMPEXP_WX wxPLplotwindow 
> : public wxFrame
> ./bindings/wxwidgets/wxPLplotstream.h:class PLDLLIMPEXP_WX wxPLplotstream 
> : public plstream
> ./bindings/wxwidgets/deprecated_wxPLplotwindow.h:class PLDLLIMPEXP_WX 
> wxPLplotwindow : public wxWindow
> ./bindings/wxwidgets/deprecated_wxPLplotstream.h.in:class PLDLLIMPEXP_WX 
> wxPLplotstream : public plstream
> ./include/pldll.h.in:  #define PLDLLIMPEXP_WX    PLDLLEXPORT
> ./include/pldll.h.in:  #define PLDLLIMPEXP_WX_DATA( type )    PLDLLEXPORT 
> type
> ./include/pldll.h.in:  #define PLDLLIMPEXP_WX    PLDLLIMPORT
> ./include/pldll.h.in:  #define PLDLLIMPEXP_WX_DATA( type )    PLDLLIMPORT 
> type
>
> Just in case you are curious about find, the above command says get me
> all the names of all the files in the source tree, drop all the .git
> ones (i.e., drop the git repository to focus on just files in the working 
> directory),
> then search all those remaining files for PLDLLIMPEXP_WX.  The result
> was 9 hits (9 lines somewhere in our source tree files that refer to
> PLDLLIMPEXP_WX).
>
> From these results, you can see that the way I use that macro in
> wxPLplotwindow.h has also been used for a long time in
> wxPLplotstream.h, deprecated_wxPLplotwindow.h, and
> deprecated_wxPLplotstream.h.in.  Also, that macro is defined in
> include/pldll.h.in (which as you will discover has some complicated
> preprocessing logic).
>
> N.B. Use of such *IMPEXP* macros is an integral part of our symbol 
> visibility support.
>
>> let me know if something on my patch is not clear
>
> I slightly amended the commit message on your first (modified) commit
> to indicate this complete fix would be in two commits, amended the
> second (present) commit to put back PLDLLIMPEXP_WX again, greatly
> expanded the commit message of that second commit using your own 
> description
> that you made in your post describing that commit, filled in a Tested
> by: place-holding section for you that you should later fill out with
> all the platforms you tested these two commits on, and finally added
> my own Tested by: section.
>
> Would you also look at one compiler warning I got because of the above
> -Wuninitialized option?  Here was that complete warning:
>
> /home/software/plplot/HEAD/plplot.git/bindings/wxwidgets/wxPLplotwindow.cpp: 
> In member function ‘void wxPLplotwindow::setUseGraphicsContext(bool)’:
> /home/software/plplot/HEAD/plplot.git/bindings/wxwidgets/wxPLplotwindow.cpp:326:33: 
> warning: ‘drawDc’ may be used uninitialized in this function 
> [-Wmaybe-uninitialized]
>          m_stream.SetDC( drawDc );
>
> A lot of the time such warnings are spurious so you have to quiet them
> by initializing something that shouldn't really need it.  But
> sometimes they really do point to a serious problem with something
> that is uninitialized because of bad code logic.
>
> Anyhow, please _amend_ (i.e., do not make a 3rd commit) your second
> commit to either quiet this warning if it is spurious or deal with the
> bad code logic if that turns out to be the issue, test these two
> commits thoroughly on all your platforms including Windows, and fill
> in the commit message Tested by: section of the second commit with
> that platform list.
>
> Quick directions again for amending the last commit on a topic branch.
>
> If a file is changed (i.e., you fixed the above warning).  Then stage
> that changed file with "git add" and get that change into your last
> commit by using "git commit --amend".  If there are no file changes,
> then simply use "git commit --amend" to modify the commit message of
> the last commit.  Note amending a commit is very useful if you
> have second thoughts about some aspect of it, want to update the
> commit message or whatever.  But the --amend option only works
> on the _last_ commit so make it a very strong habit to review your
> last commit completely to make sure it is good before you make another
> commit because that second commit makes it impossible to amend
> the first.  (I used such care this time to amend the first commit
> before applying your second commit and amending it.)
>
> Also, once a commit is published (i.e., pushed to our SF server), then
> it should never be amended or changed in any way, i.e., further
> changes have to be made using further commits rather than modifying an
> existing commit.  The reason for that "fundamental courtesy" rule is
> someone could clone the SF git repository, and branch a new topic
> branch off of any commit they desire, but if you subsequently modify
> that particular _public_ branch commit in any way, they get completely
> screwed.
>
> I have attached a tarball containing your two commits (both of which
> have been revised by me for this iteration as discussed above).  Apply
> them both in numerical order to a new topic branch using "git am".  If
> you get tired of running git am twice by hand in the correct order,
> then use "git help am" to figure out how to do that with just one "git
> am" command.
>
> Then generate another iteration consisting of the first
> (unchanged by you this time) commit, and the second commit that you revise
> as above using
>
> git format-patch -2
>
> Then collect those two files in a tarball using
>
> tar zcf wxwidgets_experimental_commits2.tar.gz 00*
>
> and attach that result to a post to this list for Phil to look at
> to make sure he understands and approves of the changes in these
> two commits.
>
> Half an hour ago it was the start of Christmas Eve day for me, and
> that happened several hours ago for you and quite a while ago for
> Phil.  So Merry Christmas and Happy New Year! to both of you and everybody 
> else on this
> list.
>
> I will likely check my e-mail again in ~12 hours and again on
> Christmas, and the 26th but I will totally understand if I don't here
> anything from you until the 27th.  However, by early on that date, I
> hope you will have prepared the two commits as specified above
> including testing on all your platforms. And I hope we can get in
> touch with Phil on that date to get his recommendation for what to do
> with regard to those two revised commits and the release.
>
> But right now I feel fairly confident about your two commits because
> there exist at least two platforms where they appear to work.  But
> hopefully you will have considerably expanded that number of "good"
> platforms by the 27th!
>
> Alan
> __________________________
> Alan W. Irwin
>
> Astronomical research affiliation with Department of Physics and 
> Astronomy,
> University of Victoria (astrowww.phys.uvic.ca).
>
> Programming affiliations with the FreeEOS equation-of-state
> implementation for stellar interiors (freeeos.sf.net); the Time
> Ephemerides project (timeephem.sf.net); PLplot scientific plotting
> software package (plplot.sf.net); the libLASi project
> (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
> and the Linux Brochure Project (lbproject.sf.net).
> __________________________
>
> Linux-powered Science
> __________________________ 

[Plplot-devel] A large update to the release notes has just been completed

[Alan W. I. <ir...@be...>]

I have just (commit 26bc4bf) completed a large update to our release
notes (README.release) based on reading through all the ~400 commit
messages for this release.  From my perspective these notes are
ready for our release except for the one section on my large
documentation upgrade which is still work in progress.

Please review these notes carefully in case I made any obvious errors
when summarizing the major developments for this release.  Especially,
please make sure my description of your work is present and correct
because it will be too late to complain about that after the release.
:-)

Alan
__________________________
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__________________________

Linux-powered Science
__________________________

Re: [Plplot-devel] Linux testing

[Alan W. I. <ir...@be...>]

On 2016-12-24 14:06-0000 p.d...@gm... wrote:

> Hi Pedro
>
> I hadn't realised you were accessing your machines remotely. I assumed that the VMs were local. Although I was accessing mu ubuntu remotely to, but using the cygwin x server. I'm not sure if the ubuntu bash on windows using xming counts as remote. Maybe this is the cause of the differences.
> However we should try to work with this somehow.

To Phil and Pedro:

Just for the record, virtually all of my results I reported were run
using an X-terminal (a zero-cost [someone threw it away in my
direction], low-power computer whose disk drive is now a USB stick)
for display, keyboard, and mouse, with the application running on a
comparatively more powerful remote computer (my wife's computer
"raven" in the same office, the 9-year old 2.4GHz box I have referred
to before). However, a couple of times I shifted to her computer and
keyboard so I was running the app and displaying on the same computer,
but that never made any noticable difference in the results.

<Semi-rant> So the classical X "network neutrality" appears to still
be working at least on Debian Jessie, although the way X has been
moving (toward Wayland, etc.) on Linux, that extremely useful network
neutrality will just be a low-priority afterthought in the future.  I
blame this bad trend on the X developers never touching or seeing
low-power boxes of any kind.  :-) </Semi-rant>

Alan
__________________________
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__________________________

Linux-powered Science
__________________________