Re: [Plplot-devel] Re: [Plplot-cvs] CVS update notice (plplot/src)

[<jc...@fe...>]

On Thursday 09 October 2003 23:19, Rafael Laboissiere wrote:
|  * Joao Cardoso <jc...@us...> [2003-10-09 14:00]:
|  > Update of /cvsroot/plplot/plplot/src
|  > In directory sc8-pr-cvs1:/tmp/cvs-serv22829/src
|  >
|  > Modified Files:
|  > 	plcore.c plctrl.c
|  > Log Message:
|  > If the current directory is in the build tree, change files search order
|  > so as to load them locally.
|  >
|  > [...]
|
|  I am very pleased that you finally cvs committed this code. 
| Congratulations for avoiding the use of a global variable (a liked the
| static variables in plInBuildTree).
|
|  However, I am just wondering:
|
|  * Joao Cardoso <jc...@us...> [2003-10-09 14:02]:
|  > Update of /cvsroot/plplot/plplot/include
|  > In directory sc8-pr-cvs1:/tmp/cvs-serv23141/include
|  >
|  > Modified Files:
|  > 	plConfig.h.in
|  > Log Message:
|  > Create and set BUILD_DIR.
|
|  Is it really necessary to have the #define BUILD_DIR in plConfig.h?

I followed the other *_DIR receipt. Feel free to make with it "The Right 
Thing".
And yes, config.h is include by plConfig.h, I should have checked that myself.

Joao

PS:

I forgot to tell in the cvs commit message that no environment variables are 
honored while in the build tree. If we are running plplot in the build tree 
we don't want to be fooled by any other instalation. That's the purpose of a 
build tree.

| Remember that this file is included in user's programs and I do not see the
| interest of having BUILD_DIR defined in this case.  At any rate, #define
| BUILD_DIR is already included in config.h, thanks to the call to
| AC_DEFINE_UNQUOTED in configure.ac.
|
|  By the way, I think that the same arguments would apply for other
| #define's included in plConfig.h ( LIB_DIR, DATA_DIR, BIN_DIR, and
| TCL_DIR).
|
|  Does anybody object to removing these #define's from plConfig.h.in?