From: Rafael L. <lab...@ps...> - 2003-03-28 08:45:24
|
* Alan W. Irwin <ir...@be...> [2003-03-27 20:37]: > Rafael, the gnu make pattern rules you put into > > c++/Makefile.examples.in f77/Makefile.examples.in > c/Makefile.examples.in tk/Makefile.examples.in Huh? I only changed c/Makefile.examples.in. I have never touched the other three. > should be changed to something that works on all Unix platforms. These > rules stopped me from running make in the examples subdirectories for > netbsd. I will fix c/Makefile.examples.in, replacing the pattern rule by an old fashioned suffix rule, which should work in all platforms. If this work, then I will change the other three Makefile.examples.in. > ************* > > Another octave issue. Without another change I just committed, the octave > documentation cannot be built. The problem is that top_srcdir = ../.., so > it only works if you stay in bindings/perl. So the fragment > > ( cd plplot_octave_txt ; \ > $(PERL) $(top_srcdir)/doc/docbook/bin/api2text.pl \ > $(top_srcdir)/docbook/src/plplotdoc.xml.in \ > $(top_srcdir)/doc/docbook/src/api.xml ) \ > > had to be replaced by > > ( cd plplot_octave_txt ; \ > $(PERL) ../../../doc/docbook/bin/api2text.pl \ > ../../../doc/docbook/src/plplotdoc.xml.in \ > ../../../doc/docbook/src/api.xml ) \ > > I think it is better to be specific here rather than using something like > ../$(top_srcdir) since we don't know whether top_srcdir will remain > relative forever. From the autoconf documentation, top_builddir is always guaranteed to be relative, while abs_top_builddir is the absolute path. I am pretty sure that this will be the case forever (the Autoconf maintainers will be killed if they introduced this backwards incompatibility...). Okay, you fixed something that was broken, but a potential maintainance burden was introduced. I am going to change "../../.." to "../$(top_srcdir)" to make things better. I am not going to use abs_top_buildir, because it is not automatically AC_SUBSTituted by Automake (but we could do it manually, if we wish). > Rafael, your new way of doing things works great for your tarball, but I > don't have access to that from cvs. Can you make your libltdl changes > available as a patch to cvs and also make sure your patch gets into the > upstream version so that we won't have to apply this patch forever? I do not quite understand your request. Which cvs are you talking about? How can we apply a patch on a file that is installed automatically and locally by libtoolize in bootstrap.sh? -- Rafael |