[Plplot-devel] Build failure with Python 3.13

[Orion P. <or...@nw...>]

Fedora rawhide has updated to Python 3.13b2 - plplot fails to build with:

[ 48%] Linking C executable x15c
cd 
/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/examples/c 
&& /usr/bin/cmake -E cmake_link_script CMakeFiles/x15c.dir/link.txt 
--verbose=1
/usr/bin/gcc -fPIC -O2 -flto=auto -ffat-lto-objects -fexceptions -g 
-grecord-gcc-switches -pipe -Wall -Werror=format-security 
-Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS 
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong 
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 
-mbranch-protection=standard -fasynchronous-unwind-tables 
-fstack-clash-protection -fno-omit-frame-pointer 
-mno-omit-leaf-frame-pointer -Wl,-z,relro -Wl,--as-needed 
-Wl,-z,pack-relative-relocs -Wl,-z,now 
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld 
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -Wl,--build-id=sha1 
-specs=/usr/lib/rpm/redhat/redhat-package-notes  -Wl,--no-warn-execstack 
-shared  -o mem.so CMakeFiles/mem.dir/mem.c.o 
-Wl,-rpath,/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/src:/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/lib/csa:/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/lib/nn:/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/lib/qsastime: 
../src/libplplot.so.17.0.0 -lm 
-Wl,-rpath-link,/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/lib/csa:/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/lib/nn:/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/lib/qsastime 

/usr/bin/gcc -O2 -flto=auto -ffat-lto-objects -fexceptions -g 
-grecord-gcc-switches -pipe -Wall -Werror=format-security 
-Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS 
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong 
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 
-mbranch-protection=standard -fasynchronous-unwind-tables 
-fstack-clash-protection -fno-omit-frame-pointer 
-mno-omit-leaf-frame-pointer -Wl,-z,relro -Wl,--as-needed 
-Wl,-z,pack-relative-relocs -Wl,-z,now 
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld 
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -Wl,--build-id=sha1 
-specs=/usr/lib/rpm/redhat/redhat-package-notes  -Wl,--no-warn-execstack 
CMakeFiles/x11c.dir/x11c.c.o -o x11c 
-Wl,-rpath,/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/src:/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/lib/csa:/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/lib/nn:/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/lib/qsastime 
../../src/libplplot.so.17.0.0 -lm 
-Wl,-rpath-link,/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/lib/csa:/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/lib/nn:/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/lib/qsastime 

/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/bindings/python/plplotcPYTHON_wrap.c: 
In function ‘do_pltr_callback’:
/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/bindings/python/plplotcPYTHON_wrap.c:4060:22: 
error: implicit declaration of function ‘PyEval_CallObject’; did you 
mean ‘PyObject_CallObject’? [-Wimplicit-function-declaration]
  4060 |             result = PyEval_CallObject( python_pltr, arglist );
       |                      ^~~~~~~~~~~~~~~~~
       |                      PyObject_CallObject
/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/bindings/python/plplotcPYTHON_wrap.c:4060:20: 
error: assignment to ‘PyObject *’ {aka ‘struct _object *’} from ‘int’ 
makes pointer from integer without a cast [-Wint-conversion]
  4060 |             result = PyEval_CallObject( python_pltr, arglist );
       |                    ^
[ 48%] Linking C executable x17c
/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/bindings/python/plplotcPYTHON_wrap.c: 
In function ‘do_f2eval_callback’:
/usr/bin/gcc -O2 -flto=auto -ffat-lto-objects -fexceptions -g 
-grecord-gcc-switches -pipe -Wall -Werror=format-security 
-Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS 
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong 
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 
-mbranch-protection=standard -fasynchronous-unwind-tables 
-fstack-clash-protection -fno-omit-frame-pointer 
-mno-omit-leaf-frame-pointer -Wl,-z,relro -Wl,--as-needed 
-Wl,-z,pack-relative-relocs -Wl,-z,now 
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld 
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -Wl,--build-id=sha1 
-specs=/usr/lib/rpm/redhat/redhat-package-notes  -Wl,--no-warn-execstack 
CMakeFiles/x15c.dir/x15c.c.o -o x15c 
-Wl,-rpath,/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/src:/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/lib/csa:/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/lib/nn:/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/lib/qsastime 
../../src/libplplot.so.17.0.0 -lm 
-Wl,-rpath-link,/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/lib/csa:/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/lib/nn:/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/lib/qsastime 

/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/bindings/python/plplotcPYTHON_wrap.c:4109:20: 
error: assignment to ‘PyObject *’ {aka ‘struct _object *’} from ‘int’ 
makes pointer from integer without a cast [-Wint-conversion]
  4109 |             result = PyEval_CallObject( python_f2eval, arglist );
       |                    ^
cd 
/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/examples/c 
&& /usr/bin/cmake -E cmake_link_script CMakeFiles/x17c.dir/link.txt 
--verbose=1
/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/bindings/python/plplotcPYTHON_wrap.c: 
In function ‘do_label_callback’:
/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/drivers/cairo.c: 
In function ‘plD_eop_xcairo’:
/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/bindings/python/plplotcPYTHON_wrap.c:4153:20: 
error: assignment to ‘PyObject *’ {aka ‘struct _object *’} from ‘int’ 
makes pointer from integer without a cast [-Wint-conversion]
  4153 |             result = PyEval_CallObject( python_label, arglist );
       |                    ^
/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/drivers/cairo.c:2088:14: 
warning: variable ‘aStream’ set but not used [-Wunused-but-set-variable]
  2088 |     PLCairo *aStream;
       |              ^~~~~~~
/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/bindings/python/plplotcPYTHON_wrap.c: 
In function ‘do_ct_callback’:
/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/bindings/python/plplotcPYTHON_wrap.c:4210:20: 
error: assignment to ‘PyObject *’ {aka ‘struct _object *’} from ‘int’ 
makes pointer from integer without a cast [-Wint-conversion]
  4210 |             result = PyEval_CallObject( python_ct, arglist );
       |                    ^
/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/bindings/python/plplotcPYTHON_wrap.c: 
In function ‘do_mapform_callback’:
[ 48%] Linking C executable pltek
/builddir/build/BUILD/plplot-5.15.0-build/plplot-5.15.0/redhat-linux-build/bindings/python/plplotcPYTHON_wrap.c:4251:20: 
error: assignment to ‘PyObject *’ {aka ‘struct _object *’} from ‘int’ 
makes pointer from integer without a cast [-Wint-conversion]
  4251 |             result = PyEval_CallObject( python_mapform, arglist );

According to https://docs.python.org/3.13/whatsnew/3.13.html:

Remove PyEval_CallObject(), PyEval_CallObjectWithKeywords(): use 
PyObject_CallNoArgs() or PyObject_Call() instead.
Warning: PyObject_Call() positional arguments must be a tuple and must 
not be NULL,
keyword arguments must be a dict or NULL, whereas removed functions 
checked arguments type and accepted NULL positional and keyword arguments.
To replace PyEval_CallObjectWithKeywords(func, NULL, kwargs) with 
PyObject_Call(),
pass an empty tuple as positional arguments using PyTuple_New(0).



-- 
Orion Poplawski
he/him/his  - surely the least important thing about me
IT Systems Manager                         720-772-5637
NWRA, Boulder/CoRA Office             FAX: 303-415-9702
3380 Mitchell Lane                       or...@nw...
Boulder, CO 80301                 https://www.nwra.com/