From: Alan W. I. <ir...@be...> - 2002-07-02 16:30:34
|
On Tue, 2 Jul 2002, Vince Darley wrote: > >>> > Under Linux/Unix whatever line-ending style is in cvs is checked out that > way and not converted and similarly on check-in. I wasn't sure what > happened > on windows, but I noticed in the past that some of the files in the > windows > area were a horrible mixture of the two styles so I made the decision to > convert them to a consistent (windows) style. > > I notice on all your many recent check-ins that you are using a Linux line > ending style. I really appreciate that for the core parts, but you don't > need to extend that to sys/win-tk/ if it is an extra burden for you there. > >>> > > No extra burden at all. In fact it would be a burden (and a bad idea, I > _think_) to do differently. > > All the text files (including all of those ones which you see as '\n') > have \r\n on my machine, so when I checked everything in, I didn't have to > do anything special at all, because cvs converted that to \n on the fly. You are the first on the plplot core team to actually have CVS access from windows. (Andrew Roach could never find a CVS client for his DOS system so he just used the Linux SF client at shell1.sf.net.) so the line-ending results are most interesting. I agree, just go ahead with what you are doing now. > > The only problems arise because: > > (i) processing of files (e.g. by perl) assumes a particular line-ending > style. (I would call this a bug in the perl script) > (ii) files aren't binary when they should be (e.g. lib/*.fnt) > > Anyway, these are the lessons I've picked up from developing Tcl, which I > think should also apply to plplot, but also feel free to ignore them if > they seem wrong. The most important one is (ii) because plplot will 100% > guaranteed segfault at the moment, which isn't very helpful! Agreed. I don't have the expertise to fix either of these issues, but hopefully others here will be able to give you some quick help. Alan |