[Plplot-devel] Sequence numbers (was Remove the deprecated sections in drivers.h and plcore.h?)

[Alan W. I. <ir...@be...>]

Thanks, Geoffrey, for your quick reply.  I will resolve this by documenting
well enough so I feel comfortable removing those code blocks.

I have been attempting to document what is going on with the drivers, and in
fact I have found a mess with the sequence numbers.  The driver code values
are discordant with configure.in. For example, configure.in says the null
device is 42 while null.c says it is 41, and vice versa for pstex.  I have
found a fair number of other cases as well.  Obviously things are working
okay right now, but there may be some subtle errors from this discordance
between configure.in numbers and the drivers/*.c numbers.  Therefore, I have
decided to make configure.in the definitive source of these numbers and
change the drivers/*.c values appropriately.  Hope this is the right thing
to do since I don't have deep understanding of how the sequence numbers are
actually used.

Alan

email: ir...@be...
phone: 250-727-2902	FAX: 250-721-7715
snail-mail:
Dr. Alan W. Irwin
Department of Physics and Astronomy,
University of Victoria, P.O. Box 3055,
Victoria, British Columbia, Canada, V8W 3P6
__________________________

Linux-powered astrophysics
__________________________

On Fri, 18 Jan 2002, Geoffrey Furnish wrote:

> This is the only message I can promise to generate before Monday.
>
> The issue to which you refer, has a recent origin in the sense that
> the "authoritative source in cf/configure.in" only appeared recently,
> in the timeframe of the dyndrv work.  Before that, plcore.h and
> drivers.h is where the stuff was authoritatively stored.
>
> I don't myself view this as a particularly significant issue for a
> release, since /users/ of the library can be oblivious to such
> things.  Functionality matters for a release, style is of secondary
> importance.
>
> Clearly we want this cleaned up.  I left it in (the header files) as a
> record, since we have to keep refering back to it from time to time.
> Maybe the transition is mostly complete by now, I don't know.  But for
> sure, there needs to be a clear, and documented procedure for adding a
> driver, which covers all the points.  If such exists, then I'm for
> eliminating all the junk code.  But if not, then lets don't prune the
> code before the production of suitable documentation.
>
> I haven't reviewed the documentation lately, so do not actually know
> where we stand on that.
>
> I'll /try/ to read email this weekend in case anyone follows up to this,
> but can't promise to respond before Monday.
>
> Alan W. Irwin writes:
>  > This is mostly directed to Geoffrey.
>  >
>  > When I was trying to understand the cgm driver a while back, I noticed the
>  > huge
>  >
>  > #if 0
>  >
>  > #endif
>  >
>  > blocks in include/drivers.h and include/plcore.h.
>  >
>  > Any objection to me just completely removing these code blocks?  In the latter
>  > case (at least) some of the drivers are missing so I got the device number
>  > wrong for cgm the first time I tried it.  The definitive source of device
>  > numbers is actually cf/configure.in so to have it also (sorta) in plcore.h
>  > is not good.
>  >
>  > Geoffrey, if this is a no-brainer, I would appreciate an immediate response
>  > so I can get on with things.  If you need more time to think about this, I
>  > will try to remember not to take any action on this until late tomorrow.
>  >
>  > Alan
>  >
>  > email: ir...@be...
>  > phone: 250-727-2902	FAX: 250-721-7715
>  > snail-mail:
>  > Dr. Alan W. Irwin
>  > Department of Physics and Astronomy,
>  > University of Victoria, P.O. Box 3055,
>  > Victoria, British Columbia, Canada, V8W 3P6
>  > __________________________
>  >
>  > Linux-powered astrophysics
>  > __________________________
>  >
>  >
>  > _______________________________________________
>  > Plplot-devel mailing list
>  > Plp...@li...
>  > https://lists.sourceforge.net/lists/listinfo/plplot-devel
>
> _______________________________________________
> Plplot-devel mailing list
> Plp...@li...
> https://lists.sourceforge.net/lists/listinfo/plplot-devel
>