From: Alan W. I. <Ala...@gm...> - 2019-09-13 07:09:12
|
On 2019-09-12 17:59+0100 Phil Rosenberg wrote: > Hi Alan > I think I have found a problem with test-drv-info. I think it is > unaware of the CMake flag CMAKE_DEBUG_POSTFIX. I've started using > -DCMAKE_DEBUG_POSTFIX=d as part of my cmake commands to add d to the > end of all debug libraries. But this causes test-drv-info to report: > Could not open the driver module <module> > If I go onto the command line ant try running test-drv-info myself, > adding d to the module name, I get > Could not read symbol plD_DEVICE_INFO_<module>d in driver module <module>d > > Is it possible to pull the postfix into the test-drv-info source? It > would simply need concatenating at line 76 of test-drv-info.c Hi Phil: I have no objection to such a change so long as it is completely general (any postfix string of any length that the user has specified for any possible CMAKE_BUILD_TYPE). For example, it should work (to take an absurd example) if the user specifies -DCMAKE_BUILD_TYPE=Release -DCMAKE_RELEASE_POSTFIX="_my_release_version_of_this_library" and also, of course, the case that interests you -DCMAKE_BUILD_TYPE=Debug -DCMAKE_DEBUG_POSTFIX="d" Please try the following change on line 176 of drivers/CMakeList.txt where CMake does the necessary concatanation: - "${WRITEABLE_TARGET}" ${SOURCE_ROOT_NAME} + "${WRITEABLE_TARGET}" ${SOURCE_ROOT_NAME}"${CMAKE_${CMAKE_BUILD_TYPE}_POSTFIX}" If that works for the two CMAKE_BUILD_TYPES and corresponding CMAKE...POSTFIX variables above, please go ahead and commit that change. Alan __________________________ Alan W. Irwin Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |