Re: [Plplot-devel] [EXTERNAL] Re: Patch for PLPLOT

[Alan W. I. <Ala...@gm...>]

On 2019-06-13 16:31-0000 Daniel Eliason wrote:

> Hi Alan,
>
> Unfortunately I made mistakes in the commit messages of the patches - here they are again, but I edited the messages.  The correct messages mention the "acc" parameter, and that artifacts appear when the "acc" parameter is set false.

Hi Daniel:

I am Ccing the plplot-devel list because other PLplot developers there may
be interested in these changes.

I have pushed (see
<https://sourceforge.net/p/plplot/plplot/ci/9394d4358f9dc385d38e052311adfd5b557625f5/>
and
<https://sourceforge.net/p/plplot/plplot/ci/7cd47798470a816c083d4c706f3c2ff23272aff4/>)
your two commits, and these two changes will become part of the next
release of PLplot (currently planned in early December this year).

I left the first commit (memcpy to memmove) exactly as it was because
it is obviously a good change in general.  However, it might interest
you to know that this commit did not change results here at all (with
or without a local change to make acc true both places in example
17). From this evidence on my platform (and also a hint in the man
page that some platforms do this) I believe that memcpy is implemented
on Debian as an alias of memmove, but from your results (as given by
your spectacularly bad screenshots of example 17 results without your
changes) that is obviously not the case for CentOS.

I have modified your second ("commentary and style") commit as follows:

* Styled your commit with our standard script.  The net effect of this
   modification was to move to our desired "//" form of commentary.

* Removed three of your changes where either it was obvious to me the
   the effect of your change would be to actually change the result or
   where I was not sure what the effect would be.  The motivation for
   dropping those changes is I discovered that the effect of your
   unmodified commit changed results here, but that issue (for what
   purports to be a style and commentary change) disappeared when I
   dropped your 3 problematic changes.

Please test the git master tip version from the SF git server yourself
now, and if it turns out you actually need one or more of your 3
dropped changes, we can add another commit to that effect with an
explanation why that further change is necessary.  And if you have any
other desired change you would like to make to PLplot, please contact
me again directly (or ideally on the plplot-devel mailing list for the
reason given above).

Best wishes,

Alan

__________________________
Alan W. Irwin

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.org); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__________________________

Linux-powered Science
__________________________