Re: [Plplot-devel] Command-line parsing improvements for both C and Fortran

[Arjen M. <Arj...@de...>]

Hi Alan,



> -----Original Message-----
> From: Alan W. Irwin [mailto:ir...@be...]
>
> This commit completes my parsing API changes in bindings/fortran/*.f90 and my
> changes to examples/fortran/x01f.f90 to test all of these parsing API's.  I would
> appreciate your review of my implementation.
> Furthermore, I would appreciate you following the parsing testing advice in
> README.release section 2.7.2 to discover which parts of this API work for gfortran
> with version > 4.9.2 (e.g., for your Cygwin and MinGW-w64/MSYS2 platforms) as
> well as the ifort compiler you have access to (and possibly the nagfor compiler you
> have arranged access to in the past).
>
> By the way, I am not sure of the correct terminology for character arrays that have
> both length and size allocated.  I refer to them above as "dynamic length and size",
> but I have also seen the term "deferred-length" used for character strings with
> allocated length.
>
Unless I am mistaken the official term is deferred-length.

I have not yet tested this with my compilers, but I have reviewed the implementation. I have very few comments about it:

-        It is a pity that we cannot disambiguate on the deferred/assumed length alone, but that is an issue of the language rules (the type of "assumed-length character string" simply encompasses the type of "deferred-length character string". Elaborate workaround might be possible, using classes/derived types, but that is not worth the trouble I think).

-        If we decide at some point that we need to keep the various implementations, then perhaps we could "layer" the versions:

o   The deferred-length variant can call the assumed-length + allocated size variant

o   This can in turn call the fixed size variant

It would reduce the amount of code, by a small amount of source lines. But again, that may not be worth our while.

I should have time to test the implementation tomorrow. Maybe that will bring out more comments ;).

Regards,

Arjen

DISCLAIMER: This message is intended exclusively for the addressee(s) and may contain confidential and privileged information. If you are not the intended recipient please notify the sender immediately and destroy this message. Unauthorized use, disclosure or copying of this message is strictly prohibited. The foundation 'Stichting Deltares', which has its seat at Delft, The Netherlands, Commercial Registration Number 41146461, is not liable in any way whatsoever for consequences and/or damages resulting from the improper, incomplete and untimely dispatch, receipt and/or content of this e-mail.