Re: [Plplot-devel] [plplot:bugs] #189 Using WIN32 Macro instead of _WIN32 (NOW FIXED)

[Arjen M. <Arj...@de...>]

Hi Alan,



> -----Original Message-----
> From: Alan W. Irwin [mailto:ir...@be...]
> Sent: Wednesday, October 11, 2017 4:18 AM
...

>
> @Those here with access to Windows:
>
> Accordingly I have now replaced use of the WIN32 and __WIN32__ macros with
> the _WIN32 macro throughout our C and C++ source code (commit 14ecc4b).  This
> is an intrusive change so I would appreciate tests of it on all Windows compilers
> and Windows platforms (e.g., MSVC, Cygwin, and MinGW-w64/MSYS2) accessible
> to you.
>
I have tested the new code on Cygwin 64 bits, MinGW-w64/MSYS2 (also 64 bits) and Windows/MSVC (also 64 bits) and found that all is working fine. I stress the 64-bits aspect, because the macros originated on 32-bits systems and were propagated to 64-bits. Perhaps we should include the 32-bits variant of the above platforms in the testing too.

Regards,

Arjen

DISCLAIMER: This message is intended exclusively for the addressee(s) and may contain confidential and privileged information. If you are not the intended recipient please notify the sender immediately and destroy this message. Unauthorized use, disclosure or copying of this message is strictly prohibited. The foundation 'Stichting Deltares', which has its seat at Delft, The Netherlands, Commercial Registration Number 41146461, is not liable in any way whatsoever for consequences and/or damages resulting from the improper, incomplete and untimely dispatch, receipt and/or content of this e-mail.