From: Mark de W. <m.d...@da...> - 2017-09-29 11:19:38
|
Hi Phil, On 28.9.17 22:31, Phil Rosenberg wrote: > I have just fixed the map plots. Apologies that this has taken > sooooooo long. The changes have just been pushed to the development > version and have been checked on my windows machine. Note that you > were correct also about there being an issue with using plmapfill. It > turned out that the type specified in the shapefile was overriding the > render type specified by the user. Thanks for the fixes. I just tested with HEAD and the polygon code no longer crashes. Next I wanted to test with a map with lines and no fill. Unfortunately plmapline also draws filled polygons. I did this test with the same shapefiles [1] as the original test. I assume it is caused by the code: src/plmap.c:324 if ( shapetype == SHPT_NULL ) { shapetype = fileShapeType; } The attached patch lets plmapline draw lines instead of filled polygons. I tested HEAD+patch and the coastal lines no longer disappear, so that issue is also fixed. I will do more testing next week, thanks again for the fixes. [1] http://www.naturalearthdata.com/http//www.naturalearthdata.com/download/50m/cultural/ne_50m_admin_0_countries_lakes.zip Regards, Mark de Wever |