Menu
▾
▴
Re: [Plplot-devel] PLplot Fortran bindings
|
From: Wadud M. <wad...@na...> - 2016-05-10 09:21:00
|
Hi Arjen,
Your suggestion has worked with the NAG Fortran compiler:
subroutine interface_plfcont( lookup, grid, nx, ny, kx, lx, ky, ly, clevel, nlevel, transform, data ) &
bind(c,name='plfcont')
import :: c_ptr
import :: private_plint, private_plflt, PLcGrid
[ ... ]
subroutine transform( x, y, tx, ty, data ) bind(c)
import :: private_plflt, PLcGrid
implicit none
This has removed the error. I will look into the sample code to see how the NAG Fortran compiler responds to it.
Thanks,
Wadud.
From: Arjen Markus [mailto:Arj...@de...]
Sent: 09 May 2016 18:23
To: Arjen Markus <Arj...@de...>; Wadud Miah <wad...@na...>; Alan W. Irwin <ir...@be...>
Cc: plp...@li...
Subject: RE: [Plplot-devel] PLplot Fortran bindings
Hi Wadud,
Looking at the code, I deduce that your compiler takes all the names available to the directly encompassing scope, interface_plfcont, rather than the encompassing module. Regardless of whether that is correct behaviour, I think the fix is to add PLcGrid to the imports for interface_plfcont.
Could you try that? If it works, I will apply the patch to the repository. I will try and concoct a small example so that I can post it on the comp.lang.fortran newsgroup for further advice. Quite possibly this is an edge case that needs to be sorted out. When I have such a small example, I will send it to you, so that you can check that the NAG compiler indeed doesn't like it.
Regards,
Arjen
From: Arjen Markus [mailto:Arj...@de...]
Sent: Monday, May 09, 2016 7:10 PM
To: Wadud Miah; Alan W. Irwin
Cc: plp...@li...<mailto:plp...@li...>
Subject: Re: [Plplot-devel] PLplot Fortran bindings
Hi Wadud,
I will have a closer look at it. I have never had the opportunity to use your compiler, so maybe we have been "lucky" sofar.
Regards,
Arjen
From: Wadud Miah [mailto:wad...@na...]
Sent: Monday, May 09, 2016 5:10 PM
To: Arjen Markus; Alan W. Irwin
Cc: plp...@li...<mailto:plp...@li...>
Subject: RE: [Plplot-devel] PLplot Fortran bindings
Hi Arjen,
The NAG Fortran compiler has picked up a compilation error which I am struggling to understand:
Error: /home/wadud/builds/plplot-plplot/bindings/f95/included_plplot_real_interfaces.f90, line 1112: Cannot IMPORT PLCGRID because it does not exist in the host INTERFACE_PLFCONT
detected at ,@PLCGRID
Going to the offending line in the code shown in boldface:
subroutine transform( x, y, tx, ty, data ) bind(c)
import :: private_plflt, PLcGrid
implicit none
real(kind=private_plflt), value, intent(in) :: x, y
real(kind=private_plflt), intent(out) :: tx, ty
type(PLcGrid), intent(in) :: data
end subroutine transform
It is not complaining about importing private_plflt but is complaining about importing PLcGrid and I do not understand how the compiler should know it should get this type definition from plplot_small_modules.f90 even though this works with other compilers, e.g. gfortran. I don't really know if this is significant, but at least I would like to make sense of it.
Best regards,
Wadud.
From: Arjen Markus [mailto:Arj...@de...]
Sent: 09 May 2016 14:15
To: Wadud Miah <wad...@na...<mailto:wad...@na...>>; Alan W. Irwin <ir...@be...<mailto:ir...@be...>>
Cc: plp...@li...<mailto:plp...@li...>
Subject: RE: [Plplot-devel] PLplot Fortran bindings
Hi Wadud,
That is right. The last argument, plplot-plplot, is actually the name of the directory that will contain the source code and auxiliary data files. You will get an up-to-date repository that way.
Regards,
Arjen
From: Wadud Miah [mailto:wad...@na...]
Sent: Monday, May 09, 2016 3:05 PM
To: Arjen Markus; Alan W. Irwin
Cc: plp...@li...<mailto:plp...@li...>
Subject: RE: [Plplot-devel] PLplot Fortran bindings
Hi Arjen,
Apologies for this question as I am not very familiar with Git, but what is the Git command I use to clone PLplot which has the corrections? Is it just:
git clone git://git.code.sf.net/p/plplot/plplot plplot-plplot
Regards,
Wadud.
From: Arjen Markus [mailto:Arj...@de...]
Sent: 28 April 2016 11:20
To: Wadud Miah <wad...@na...<mailto:wad...@na...>>; Alan W. Irwin <ir...@be...<mailto:ir...@be...>>
Cc: plp...@li...<mailto:plp...@li...>
Subject: RE: [Plplot-devel] PLplot Fortran bindings
Hi Wadud,
The changes should be there now - I introduced ISO_C_BINDING's C_INT32_T kind to solve the portability issue. On the platforms I have available that works fine. See https://sourceforge.net/p/plplot/plplot/ci/f00ee2a0fb0293e118a359d6e6312b30804b3420/
Regards,
Arjen
From: Wadud Miah [mailto:wad...@na...]
Sent: Thursday, April 28, 2016 12:17 PM
To: Arjen Markus; Alan W. Irwin
Cc: plp...@li...<mailto:plp...@li...>
Subject: RE: [Plplot-devel] PLplot Fortran bindings
Hi Arjen/Alan,
I will build PLplot for Git late next week as I will busy the next few days. Let me know once you have made all the relevant changes for me to test with the NAG Fortran compiler.
I am actually running a workshop in the UK called "Fortran Modernisation Workshop" which covers PLplot:
http://www.nag.co.uk/market/training/fortran-modernisation-workshop
I've found PLplot the best visualisation libraries for Fortran 90 which I would like to thank you for :-)
Best regards,
Wadud.
From: Arjen Markus [mailto:Arj...@de...]
Sent: Thursday, April 28, 2016 9:55 AM
To: Alan W. Irwin <ir...@be...<mailto:ir...@be...>>
Cc: Wadud Miah <wad...@na...<mailto:wad...@na...>>; plp...@li...<mailto:plp...@li...>
Subject: RE: [Plplot-devel] PLplot Fortran bindings
Hi Alan,
I made the small change I suggested and the results for Cygwin and MinGW64 look fine - see the attached files. The only platform I still need to test on is bare Windows (not as nicely packaged as the other two, unfortunately). When that turns out to be fine as well, I will do the commit.
Regards,
Arjen
> -----Original Message-----
> From: Alan W. Irwin [mailto:ir...@be...]
> Sent: Thursday, April 28, 2016 9:32 AM
> To: Arjen Markus
> Cc: Wadud Miah; plp...@li...<mailto:plp...@li...>
> Subject: RE: [Plplot-devel] PLplot Fortran bindings
>
> On 2016-04-28 06:35-0000 Arjen Markus wrote:
>
> > Hi Alan, Wadud,
> >
> >> -----Original Message-----
> >> From: Alan W. Irwin [mailto:ir...@be...]
> >> Sent: Wednesday, April 27, 2016 11:22 PM
> >> To: Wadud Miah
> >> Cc: Arjen Markus; plp...@li...<mailto:plp...@li...>
> >> Subject: RE: [Plplot-devel] PLplot Fortran bindings
> >>
> >> To Wadud and Arjen:
> >>
> >> @Arjen:
> >> Since you have been unable to answer my quick question in a timely
> >> manner concerning adopting selected_int_kind(9) rather than 4 for
> >> private_plint, private_plbool, and private_plunicode, I have decided
> >> to just go ahead with that change (commit 3442bac).
> >>
>
> > Yesterday was a national holiday here, so I paid little attention to
> my inbox :). However, considering the portability of these two types, why don't we
> use C_INT32_T from ISO_C_BINDING? This maps to C's int32_t type (for the
> companion C compiler to be precise). Essentially the same thing, except if the
> platform does not have 32 bits integers, I'd say, but it conveys the one-to-one
> relation between the Fortran and C side.
>
> > This does not rely on the Fortran 2008 standard, only on the Fortran
> 2003 standard and we require that for the new binding anyway.
>
> That argument sounds reasonable to me, but you are the expert here. So please
> implement this further change yourself.
>
> >> @Arjen: Could you follow up with similar test results for the latest
> >> git master tip for both your Cygwin and MinGW-w64/MSYS2 platforms?
> >> That wiki table documents your previous (good) Cygwin Fortran result.
> >> Previously you also sent me your good MinGW-w64/MSYS2 platform
> >> results for Fortran, but I was holding off on posting that result to
> >> our wiki because that report also revealed a MinGW-w64/MSYS2
> >> installation update issue that requires you to reinstall the
> >> MinGW-w64/MSYS2 platform to get access to the much more
> convenient/reliable updating available for the latest version of that platform.
> >>
> > Will do. I should have time today to do that. That testing should cover the other
> issue (the temporary files) as well.
>
> I look forward to those comprehensive test results on both platforms.
> You can constrain those tests to just test the Fortran, C, and the ps device driver
> components of PLplot (with the script arguments I have indicated) for speed
> because even that limited result should thoroughly test creating temporary files.
>
> I recommend you make that further change you outlined above before these
> constrained comprehensive tests so you can summarize these tests in the Tested
> by: paragraph in the commit message. Once I see that commit from you, I plan to
> follow up by redoing my own constrained Fortran comprehensive test (since it only
> takes 7 minutes).
>
> Alan
> __________________________
> Alan W. Irwin
>
> Astronomical research affiliation with Department of Physics and Astronomy,
> University of Victoria (astrowww.phys.uvic.ca).
>
> Programming affiliations with the FreeEOS equation-of-state implementation for
> stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net);
> PLplot scientific plotting software package (plplot.sf.net); the libLASi project
> (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux
> Brochure Project (lbproject.sf.net).
> __________________________
>
> Linux-powered Science
> __________________________
DISCLAIMER: This message is intended exclusively for the addressee(s) and may contain confidential and privileged information. If you are not the intended recipient please notify the sender immediately and destroy this message. Unauthorized use, disclosure or copying of this message is strictly prohibited. The foundation 'Stichting Deltares', which has its seat at Delft, The Netherlands, Commercial Registration Number 41146461, is not liable in any way whatsoever for consequences and/or damages resulting from the improper, incomplete and untimely dispatch, receipt and/or content of this e-mail.
________________________________________________________________________
This e-mail has been scanned for all viruses by Star.
________________________________________________________________________
________________________________
The Numerical Algorithms Group Ltd is a company registered in England and Wales with company number 1249803. The registered office is:
Wilkinson House, Jordan Hill Road, Oxford OX2 8DR, United Kingdom.
This e-mail has been scanned for all viruses by Microsoft Office 365.
________________________________
DISCLAIMER: This message is intended exclusively for the addressee(s) and may contain confidential and privileged information. If you are not the intended recipient please notify the sender immediately and destroy this message. Unauthorized use, disclosure or copying of this message is strictly prohibited. The foundation 'Stichting Deltares', which has its seat at Delft, The Netherlands, Commercial Registration Number 41146461, is not liable in any way whatsoever for consequences and/or damages resulting from the improper, incomplete and untimely dispatch, receipt and/or content of this e-mail.
________________________________________________________________________
This e-mail has been scanned for all viruses by Star.
________________________________________________________________________
________________________________
The Numerical Algorithms Group Ltd is a company registered in England and Wales with company number 1249803. The registered office is:
Wilkinson House, Jordan Hill Road, Oxford OX2 8DR, United Kingdom.
This e-mail has been scanned for all viruses by Microsoft Office 365.
________________________________
DISCLAIMER: This message is intended exclusively for the addressee(s) and may contain confidential and privileged information. If you are not the intended recipient please notify the sender immediately and destroy this message. Unauthorized use, disclosure or copying of this message is strictly prohibited. The foundation 'Stichting Deltares', which has its seat at Delft, The Netherlands, Commercial Registration Number 41146461, is not liable in any way whatsoever for consequences and/or damages resulting from the improper, incomplete and untimely dispatch, receipt and/or content of this e-mail.
________________________________________________________________________
This e-mail has been scanned for all viruses by Star.
________________________________________________________________________
________________________________
The Numerical Algorithms Group Ltd is a company registered in England and Wales with company number 1249803. The registered office is:
Wilkinson House, Jordan Hill Road, Oxford OX2 8DR, United Kingdom.
This e-mail has been scanned for all viruses by Microsoft Office 365.
________________________________
DISCLAIMER: This message is intended exclusively for the addressee(s) and may contain confidential and privileged information. If you are not the intended recipient please notify the sender immediately and destroy this message. Unauthorized use, disclosure or copying of this message is strictly prohibited. The foundation 'Stichting Deltares', which has its seat at Delft, The Netherlands, Commercial Registration Number 41146461, is not liable in any way whatsoever for consequences and/or damages resulting from the improper, incomplete and untimely dispatch, receipt and/or content of this e-mail.
DISCLAIMER: This message is intended exclusively for the addressee(s) and may contain confidential and privileged information. If you are not the intended recipient please notify the sender immediately and destroy this message. Unauthorized use, disclosure or copying of this message is strictly prohibited. The foundation 'Stichting Deltares', which has its seat at Delft, The Netherlands, Commercial Registration Number 41146461, is not liable in any way whatsoever for consequences and/or damages resulting from the improper, incomplete and untimely dispatch, receipt and/or content of this e-mail.
________________________________________________________________________
This e-mail has been scanned for all viruses by Star.
________________________________________________________________________
________________________________
The Numerical Algorithms Group Ltd is a company registered in England and Wales with company number 1249803. The registered office is:
Wilkinson House, Jordan Hill Road, Oxford OX2 8DR, United Kingdom.
This e-mail has been scanned for all viruses by Microsoft Office 365.
________________________________
|
